Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

203 lines
7.4 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using BenchmarkDotNet.Attributes;
using Opc.Ua.Bindings;
using Opc.Ua.Tests;
namespace Opc.Ua.Core.Encoders.Tests
{
/// <summary>
/// Common code for encoder/decoder benchmarks.
/// </summary>
public class EncoderBenchmarks
{
public const int StreamBufferSize = 4096;
public const int DataValueCount = 10;
public EncoderBenchmarks()
{
m_nodeId = new NodeId((uint)UnsecureRandom.Shared.Next(50000));
var list = new List<int>();
for (int i = 0; i < DataValueCount; i++)
{
list.Add(UnsecureRandom.Shared.Next());
}
m_list = list.ToArrayOf();
var values = new List<DataValue>();
var now = new DateTime(2024, 03, 01, 06, 05, 59, DateTimeKind.Utc);
now += TimeSpan.FromTicks(456789);
for (int i = 0; i < DataValueCount; i++)
{
values.Add(
new DataValue(
new Variant((UnsecureRandom.Shared.NextDouble() - 0.5) * 1000.0),
UnsecureRandom.Shared.NextDouble() > 0.1 ? StatusCodes.Good : StatusCodes.BadDataLost,
now,
now));
}
m_values = values.ToArrayOf();
}
[Params(64, 1024)]
public int PayLoadSize { get; set; } = 64;
protected void TestEncoding(IEncoder encoder)
{
DateTime now = DateTime.UtcNow;
int payLoadSize = PayLoadSize;
encoder.WriteInt32("PayloadSize", payLoadSize);
while (payLoadSize-- > 0)
{
encoder.WriteBoolean("Boolean", true);
encoder.WriteByte("Byte", 123);
encoder.WriteUInt16("UInt16", 1234);
encoder.WriteUInt32("UInt32", 123456);
encoder.WriteUInt64("UInt64", 1234566890);
encoder.WriteSByte("Int8", -123);
encoder.WriteInt16("Int16", -1234);
encoder.WriteInt32("Int32", -123456);
encoder.WriteInt64("Int64", -1234566890);
encoder.WriteFloat("Float", 123.456f);
encoder.WriteDouble("Double", 123456.789);
encoder.WriteDateTime("DateTime", now);
encoder.WriteString("String", "The quick brown fox jumps over the lazy dog.");
encoder.WriteNodeId("NodeId", m_nodeId);
encoder.WriteNodeId("ExpandedNodeId", m_nodeId);
encoder.WriteInt32Array("Array", m_list);
encoder.WriteDataValueArray("DataValues", m_values);
}
}
protected void TestDecoding(IDecoder decoder)
{
int payLoadSize = decoder.ReadInt32("PayloadSize");
while (payLoadSize-- > 0)
{
_ = decoder.ReadBoolean("Boolean");
_ = decoder.ReadByte("Byte");
_ = decoder.ReadUInt16("UInt16");
_ = decoder.ReadUInt32("UInt32");
_ = decoder.ReadUInt64("UInt64");
_ = decoder.ReadSByte("Int8");
_ = decoder.ReadInt16("Int16");
_ = decoder.ReadInt32("Int32");
_ = decoder.ReadInt64("Int64");
_ = decoder.ReadFloat("Float");
_ = decoder.ReadDouble("Double");
_ = decoder.ReadDateTime("DateTime");
_ = decoder.ReadString("String");
_ = decoder.ReadNodeId("NodeId");
_ = decoder.ReadNodeId("ExpandedNodeId");
_ = decoder.ReadInt32Array("Array");
_ = decoder.ReadDataValueArray("DataValues");
}
}
public virtual void OneTimeSetUp()
{
// for validating benchmark tests
m_telemetry = NUnitTelemetryContext.Create();
m_context = ServiceMessageContext.Create(m_telemetry);
m_bufferManager = new BufferManager(
nameof(BinaryEncoder),
StreamBufferSize,
m_telemetry);
}
public virtual void OneTimeTearDown()
{
m_context = null!;
m_telemetry = null!;
m_bufferManager = null!;
}
/// <summary>
/// Set up some variables for benchmarks.
/// </summary>
public virtual void GlobalSetup()
{
// for validating benchmark tests
m_telemetry = NUnitTelemetryContext.Create();
m_context = ServiceMessageContext.Create(m_telemetry);
m_bufferManager = new BufferManager(
nameof(BinaryEncoder),
StreamBufferSize,
m_telemetry);
}
/// <summary>
/// Tear down benchmark variables.
/// </summary>
public virtual void GlobalCleanup()
{
m_context = null!;
m_telemetry = null!;
m_bufferManager = null!;
}
protected NodeId m_nodeId = new(1234);
protected ArrayOf<int> m_list;
protected ArrayOf<DataValue> m_values;
protected ITelemetryContext m_telemetry = null!;
protected IServiceMessageContext m_context = null!;
protected BufferManager m_bufferManager = null!;
}
#if NET6_0_OR_GREATER
/// <summary>
/// Helper class to test ArraySegmentStream without Span support.
/// </summary>
public class ArraySegmentStreamNoSpan : ArraySegmentStream
{
public ArraySegmentStreamNoSpan(BufferManager bufferManager)
: base(bufferManager)
{
}
public ArraySegmentStreamNoSpan(BufferCollection buffers)
: base(buffers)
{
}
public override int Read(Span<byte> buffer)
{
return ReadMemoryStream(buffer);
}
public override void Write(ReadOnlySpan<byte> buffer)
{
WriteMemoryStream(buffer);
}
}
#endif
}