Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

192 lines
7.1 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Security.Cryptography;
namespace Opc.Ua.Core.TestFramework
{
/// <summary>
/// An <see cref="ECDsa"/> implementation that signs and verifies correctly
/// but refuses to surrender private key material, mirroring a key held in
/// a TPM, an HSM, a PKCS#11 token or a remote key management service.
/// </summary>
/// <remarks>
/// See <see cref="NonExportableRsa"/> for the rationale. Only
/// <see cref="ExportParameters"/> needs to reject the request: the base
/// class funnels <c>ExportECPrivateKey</c>, <c>ExportPkcs8PrivateKey</c>
/// and their encrypted variants through it.
/// </remarks>
public sealed class NonExportableECDsa : ECDsa
{
/// <summary>
/// Initializes a new instance wrapping a freshly generated software key.
/// </summary>
/// <param name="curve">
/// The named curve used to generate the key.
/// </param>
public NonExportableECDsa(ECCurve curve)
: this(Create(curve), ownsKey: true)
{
}
/// <summary>
/// Initializes a new instance that delegates operations to an existing key.
/// </summary>
/// <param name="key">
/// The key that performs the actual cryptographic operations.
/// </param>
/// <param name="ownsKey">
/// <c>true</c> if disposing this instance should also dispose
/// <paramref name="key"/>; otherwise <c>false</c>.
/// </param>
public NonExportableECDsa(ECDsa key, bool ownsKey = false)
{
m_key = key ?? throw new ArgumentNullException(nameof(key));
m_ownsKey = ownsKey;
KeySizeValue = key.KeySize;
LegalKeySizesValue = [new KeySizes(256, 384, 128), new KeySizes(521, 521, 0)];
}
/// <summary>
/// Gets the number of times an export of the private key was attempted.
/// </summary>
/// <remarks>
/// Tests use this to assert that a code path never reaches for private
/// key material, rather than merely tolerating the failure.
/// </remarks>
public int PrivateKeyExportAttempts => m_privateKeyExportAttempts;
/// <inheritdoc/>
public override string KeyExchangeAlgorithm => m_key.KeyExchangeAlgorithm!;
/// <inheritdoc/>
public override string SignatureAlgorithm => m_key.SignatureAlgorithm;
/// <inheritdoc/>
/// <exception cref="CryptographicException">
/// Thrown when <paramref name="includePrivateParameters"/> is <c>true</c>,
/// because the private key is not extractable.
/// </exception>
public override ECParameters ExportParameters(bool includePrivateParameters)
{
if (includePrivateParameters)
{
m_privateKeyExportAttempts++;
throw new CryptographicException(
"The private key is not exportable because it is held in hardware.");
}
return m_key.ExportParameters(false);
}
/// <inheritdoc/>
/// <exception cref="CryptographicException">
/// Thrown when <paramref name="includePrivateParameters"/> is <c>true</c>,
/// because the private key is not extractable.
/// </exception>
public override ECParameters ExportExplicitParameters(bool includePrivateParameters)
{
if (includePrivateParameters)
{
m_privateKeyExportAttempts++;
throw new CryptographicException(
"The private key is not exportable because it is held in hardware.");
}
return m_key.ExportExplicitParameters(false);
}
/// <inheritdoc/>
/// <exception cref="NotSupportedException">
/// Always thrown; key material cannot be injected into hardware this way.
/// </exception>
public override void ImportParameters(ECParameters parameters)
{
throw new NotSupportedException(
"Key material cannot be imported into a hardware protected key.");
}
/// <inheritdoc/>
/// <exception cref="NotSupportedException">
/// Always thrown; hardware keys are generated in the device.
/// </exception>
public override void GenerateKey(ECCurve curve)
{
throw new NotSupportedException(
"A hardware protected key must be generated inside the device.");
}
/// <inheritdoc/>
public override byte[] SignHash(byte[] hash)
{
return m_key.SignHash(hash);
}
/// <inheritdoc/>
public override bool VerifyHash(byte[] hash, byte[] signature)
{
return m_key.VerifyHash(hash, signature);
}
/// <inheritdoc/>
protected override byte[] HashData(
byte[] data,
int offset,
int count,
HashAlgorithmName hashAlgorithm)
{
return NonExportableKeyHash.Compute(data, offset, count, hashAlgorithm);
}
/// <inheritdoc/>
protected override byte[] HashData(
System.IO.Stream data,
HashAlgorithmName hashAlgorithm)
{
return NonExportableKeyHash.Compute(data, hashAlgorithm);
}
/// <inheritdoc/>
protected override void Dispose(bool disposing)
{
if (disposing && m_ownsKey)
{
m_key.Dispose();
}
base.Dispose(disposing);
}
private readonly ECDsa m_key;
private readonly bool m_ownsKey;
private int m_privateKeyExportAttempts;
}
}