mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-27 21:55:54 +08:00
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
218 lines
8.1 KiB
C#
218 lines
8.1 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System.Threading.Tasks;
|
|
using NUnit.Framework;
|
|
|
|
namespace Opc.Ua.Core.Tests.Security.Secrets
|
|
{
|
|
/// <summary>
|
|
/// Tests for <see cref="InMemorySecretStore"/> and
|
|
/// <see cref="SecretRegistry"/>.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Secrets")]
|
|
[Parallelizable]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
public class SecretStoreTests
|
|
{
|
|
[Test]
|
|
public void TryGetReturnsNullForUnknownSecret()
|
|
{
|
|
var store = new InMemorySecretStore();
|
|
var id = new SecretIdentifier("missing", InMemorySecretStore.DefaultStoreType);
|
|
|
|
ISecret? secret = store.TryGet(id);
|
|
|
|
Assert.That(secret, Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public async Task SetAsyncStoresAndTryGetReturnsCopyOfBytes()
|
|
{
|
|
var store = new InMemorySecretStore();
|
|
var id = new SecretIdentifier("password", InMemorySecretStore.DefaultStoreType);
|
|
byte[] expected = [0x01, 0x02, 0x03, 0x04];
|
|
|
|
await store.SetAsync(id, expected).ConfigureAwait(false);
|
|
|
|
using ISecret secret = store.TryGet(id)!;
|
|
Assert.That(secret, Is.Not.Null);
|
|
Assert.That(secret.Bytes.ToArray(), Is.EqualTo(expected));
|
|
}
|
|
|
|
[Test]
|
|
public async Task GetAsyncCompletesSynchronouslyOnHit()
|
|
{
|
|
var store = new InMemorySecretStore();
|
|
var id = new SecretIdentifier("password", InMemorySecretStore.DefaultStoreType);
|
|
await store.SetAsync(id, new byte[] { 0xAB }).ConfigureAwait(false);
|
|
|
|
// CA2012: deliberately storing then accessing .Result on a ValueTask after asserting
|
|
// IsCompletedSuccessfully — that is the exact behaviour this test verifies.
|
|
#pragma warning disable CA2012
|
|
ValueTask<ISecret?> task = store.GetAsync(id);
|
|
|
|
Assert.That(task.IsCompletedSuccessfully, Is.True,
|
|
"InMemorySecretStore.GetAsync must complete sync on cache hit.");
|
|
using ISecret secret = task.Result!;
|
|
#pragma warning restore CA2012
|
|
Assert.That(secret!.Bytes[0], Is.EqualTo((byte)0xAB));
|
|
}
|
|
|
|
[Test]
|
|
public async Task RemoveAsyncReturnsFalseWhenAbsent()
|
|
{
|
|
var store = new InMemorySecretStore();
|
|
var id = new SecretIdentifier("missing", InMemorySecretStore.DefaultStoreType);
|
|
|
|
bool removed = await store.RemoveAsync(id).ConfigureAwait(false);
|
|
|
|
Assert.That(removed, Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public async Task RemoveAsyncReturnsTrueWhenPresent()
|
|
{
|
|
var store = new InMemorySecretStore();
|
|
var id = new SecretIdentifier("password", InMemorySecretStore.DefaultStoreType);
|
|
await store.SetAsync(id, new byte[] { 0xAB }).ConfigureAwait(false);
|
|
|
|
bool removed = await store.RemoveAsync(id).ConfigureAwait(false);
|
|
|
|
Assert.That(removed, Is.True);
|
|
Assert.That(store.TryGet(id), Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public async Task SetAsyncReplacesExistingEntry()
|
|
{
|
|
var store = new InMemorySecretStore();
|
|
var id = new SecretIdentifier("password", InMemorySecretStore.DefaultStoreType);
|
|
await store.SetAsync(id, new byte[] { 0xAA }).ConfigureAwait(false);
|
|
await store.SetAsync(id, new byte[] { 0xBB }).ConfigureAwait(false);
|
|
|
|
using ISecret secret = store.TryGet(id)!;
|
|
|
|
Assert.That(secret!.Bytes[0], Is.EqualTo((byte)0xBB),
|
|
"SetAsync on an existing entry must replace it.");
|
|
}
|
|
|
|
[Test]
|
|
public async Task SetAsyncCopiesIncomingBytesSoMutatingOriginalDoesNotAffectStore()
|
|
{
|
|
var store = new InMemorySecretStore();
|
|
var id = new SecretIdentifier("password", InMemorySecretStore.DefaultStoreType);
|
|
byte[] source = [0x01, 0x02, 0x03];
|
|
await store.SetAsync(id, source).ConfigureAwait(false);
|
|
|
|
// Mutate the source after Set; the store must hold its own copy.
|
|
source[0] = 0xFF;
|
|
|
|
using ISecret secret = store.TryGet(id)!;
|
|
Assert.That(secret!.Bytes[0], Is.EqualTo((byte)0x01),
|
|
"InMemorySecretStore must copy the incoming bytes on Set.");
|
|
}
|
|
|
|
[Test]
|
|
public void TryGetThrowsArgumentNullExceptionForNullIdentifier()
|
|
{
|
|
var store = new InMemorySecretStore();
|
|
|
|
Assert.That(() => store.TryGet(null!), Throws.ArgumentNullException);
|
|
}
|
|
|
|
[Test]
|
|
public void RegistryDispatchesToStoreByStoreType()
|
|
{
|
|
var inMem = new InMemorySecretStore("Custom");
|
|
var registry = new SecretRegistry(inMem);
|
|
var id = new SecretIdentifier("k", "Custom");
|
|
byte[] bytes = [0x42];
|
|
inMem.SetAsync(id, bytes).AsTask().Wait();
|
|
|
|
using ISecret secret = registry.TryGet(id)!;
|
|
|
|
Assert.That(secret, Is.Not.Null);
|
|
Assert.That(secret.Bytes[0], Is.EqualTo((byte)0x42));
|
|
}
|
|
|
|
[Test]
|
|
public void RegistryReturnsNullWhenStoreTypeNotRegistered()
|
|
{
|
|
var registry = new SecretRegistry();
|
|
var id = new SecretIdentifier("k", "DoesNotExist");
|
|
|
|
Assert.That(registry.TryGet(id), Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public async Task RegistryGetAsyncReturnsNullWhenStoreTypeNotRegisteredAsync()
|
|
{
|
|
var registry = new SecretRegistry();
|
|
var id = new SecretIdentifier("k", "DoesNotExist");
|
|
|
|
ISecret? secret = await registry.GetAsync(id).ConfigureAwait(false);
|
|
|
|
Assert.That(secret, Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public async Task RegistryRegisterStoreReplacesByStoreTypeAsync()
|
|
{
|
|
var first = new InMemorySecretStore("X");
|
|
var second = new InMemorySecretStore("X");
|
|
var id = new SecretIdentifier("k", "X");
|
|
await first.SetAsync(id, new byte[] { 0xAA }).ConfigureAwait(false);
|
|
await second.SetAsync(id, new byte[] { 0xBB }).ConfigureAwait(false);
|
|
|
|
var registry = new SecretRegistry();
|
|
registry.RegisterStore(first);
|
|
registry.RegisterStore(second);
|
|
|
|
using ISecret secret = registry.TryGet(id)!;
|
|
|
|
Assert.That(secret!.Bytes[0], Is.EqualTo((byte)0xBB),
|
|
"RegisterStore with same StoreType must replace the previous registration.");
|
|
}
|
|
|
|
[Test]
|
|
public void IdentifierIsValueEqual()
|
|
{
|
|
var a = new SecretIdentifier("k", "X", "path");
|
|
var b = new SecretIdentifier("k", "X", "path");
|
|
|
|
Assert.That(a, Is.EqualTo(b));
|
|
Assert.That(a.GetHashCode(), Is.EqualTo(b.GetHashCode()));
|
|
}
|
|
}
|
|
}
|