mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-18 22:55:08 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
334 lines
13 KiB
C#
334 lines
13 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.IO;
|
|
using System.Text;
|
|
using System.Xml;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Security;
|
|
using Opc.Ua.Tests;
|
|
using SecurityNs = Opc.Ua.Security;
|
|
|
|
namespace Opc.Ua.Core.Tests.Stack.Configuration
|
|
{
|
|
[TestFixture]
|
|
[Category("Configuration")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
[Parallelizable]
|
|
public class SecurityConfigurationManagerTests
|
|
{
|
|
private ITelemetryContext m_telemetry;
|
|
private string m_tempDir;
|
|
|
|
[OneTimeSetUp]
|
|
public void OneTimeSetUp()
|
|
{
|
|
m_telemetry = NUnitTelemetryContext.Create();
|
|
m_tempDir = Path.Combine(
|
|
Path.GetTempPath(),
|
|
"OpcUaTestSecurityConfigMgr_" + Guid.NewGuid().ToString("N"));
|
|
Directory.CreateDirectory(m_tempDir);
|
|
}
|
|
|
|
[OneTimeTearDown]
|
|
public void OneTimeTearDown()
|
|
{
|
|
try
|
|
{
|
|
if (Directory.Exists(m_tempDir))
|
|
{
|
|
Directory.Delete(m_tempDir, true);
|
|
}
|
|
}
|
|
catch
|
|
{
|
|
// best effort cleanup
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void ReadConfigurationNullThrows()
|
|
{
|
|
var manager = new SecurityConfigurationManager(m_telemetry);
|
|
Assert.Throws<ArgumentNullException>(() => manager.ReadConfiguration(null!));
|
|
}
|
|
|
|
[Test]
|
|
public void ReadConfigurationFileNotFoundThrows()
|
|
{
|
|
var manager = new SecurityConfigurationManager(m_telemetry);
|
|
Assert.Throws<ServiceResultException>(
|
|
() => manager.ReadConfiguration(
|
|
Path.Combine(m_tempDir, "nonexistent.config")));
|
|
}
|
|
|
|
[Test]
|
|
public void WriteConfigurationNullConfigThrows()
|
|
{
|
|
var manager = new SecurityConfigurationManager(m_telemetry);
|
|
Assert.Throws<ArgumentNullException>(
|
|
() => manager.WriteConfiguration("somefile.config", null!));
|
|
}
|
|
|
|
[Test]
|
|
public void WriteConfigurationFileNotFoundThrows()
|
|
{
|
|
var manager = new SecurityConfigurationManager(m_telemetry);
|
|
var app = new SecuredApplication { ApplicationName = "Test" };
|
|
Assert.Throws<ServiceResultException>(
|
|
() => manager.WriteConfiguration(
|
|
Path.Combine(m_tempDir, "nonexistent.config"), app));
|
|
}
|
|
|
|
[Test]
|
|
public void WriteConfigurationEmptyPathThrows()
|
|
{
|
|
var manager = new SecurityConfigurationManager(m_telemetry);
|
|
var app = new SecuredApplication { ApplicationName = "Test" };
|
|
Assert.Throws<ServiceResultException>(
|
|
() => manager.WriteConfiguration(string.Empty, app));
|
|
}
|
|
|
|
[Test]
|
|
public void ReadConfigurationSecuredApplicationXml()
|
|
{
|
|
string configPath = Path.Combine(m_tempDir, "secured_app.config");
|
|
WriteSecuredApplicationConfigFile(configPath);
|
|
|
|
var manager = new SecurityConfigurationManager(m_telemetry);
|
|
SecuredApplication result = manager.ReadConfiguration(configPath);
|
|
|
|
Assert.That(result, Is.Not.Null);
|
|
Assert.That(result.ApplicationName, Is.EqualTo("TestSecuredApp"));
|
|
Assert.That(result.ApplicationUri, Is.EqualTo("urn:test:securedapp"));
|
|
Assert.That(result.ConfigurationFile, Is.EqualTo(configPath));
|
|
}
|
|
|
|
[Test]
|
|
public void ReadConfigurationAppConfigXml()
|
|
{
|
|
string configPath = Path.Combine(m_tempDir, "appconfig.config");
|
|
WriteApplicationConfigFile(configPath);
|
|
|
|
var manager = new SecurityConfigurationManager(m_telemetry);
|
|
SecuredApplication result = manager.ReadConfiguration(configPath);
|
|
|
|
Assert.That(result, Is.Not.Null);
|
|
Assert.That(result.ApplicationName, Is.EqualTo("TestAppConfig"));
|
|
Assert.That(result.ApplicationUri, Is.EqualTo("urn:test:appconfig"));
|
|
}
|
|
|
|
[Test]
|
|
public void ReadAndWriteSecuredApplicationRoundTrip()
|
|
{
|
|
string configPath = Path.Combine(m_tempDir, "roundtrip_secured.config");
|
|
WriteSecuredApplicationConfigFile(configPath);
|
|
|
|
var manager = new SecurityConfigurationManager(m_telemetry);
|
|
SecuredApplication original = manager.ReadConfiguration(configPath);
|
|
|
|
original.ApplicationName = "ModifiedName";
|
|
|
|
manager.WriteConfiguration(configPath, original);
|
|
|
|
SecuredApplication reloaded = manager.ReadConfiguration(configPath);
|
|
Assert.That(reloaded.ApplicationName, Is.EqualTo("ModifiedName"));
|
|
}
|
|
|
|
[Test]
|
|
public void ReadAndWriteAppConfigRoundTrip()
|
|
{
|
|
string configPath = Path.Combine(m_tempDir, "roundtrip_appconfig.config");
|
|
WriteApplicationConfigFile(configPath);
|
|
|
|
var manager = new SecurityConfigurationManager(m_telemetry);
|
|
SecuredApplication original = manager.ReadConfiguration(configPath);
|
|
|
|
original.ApplicationName = "UpdatedAppName";
|
|
|
|
manager.WriteConfiguration(configPath, original);
|
|
|
|
SecuredApplication reloaded = manager.ReadConfiguration(configPath);
|
|
Assert.That(reloaded.ApplicationName, Is.EqualTo("UpdatedAppName"));
|
|
}
|
|
|
|
[Test]
|
|
public void ReadConfigurationExePathLooksForConfig()
|
|
{
|
|
string uniqueName = "testapp_" + Guid.NewGuid().ToString("N")[..8];
|
|
string exePath = Path.Combine(m_tempDir, uniqueName + ".exe");
|
|
string configFileName = uniqueName + ".Config.xml";
|
|
string configInCwd = Path.Combine(Directory.GetCurrentDirectory(), configFileName);
|
|
|
|
File.WriteAllText(exePath, "dummy exe content");
|
|
WriteSecuredApplicationConfigFile(configInCwd);
|
|
|
|
try
|
|
{
|
|
var manager = new SecurityConfigurationManager(m_telemetry);
|
|
SecuredApplication result = manager.ReadConfiguration(exePath);
|
|
|
|
Assert.That(result, Is.Not.Null);
|
|
Assert.That(result.ApplicationName, Is.EqualTo("TestSecuredApp"));
|
|
Assert.That(result.ExecutableFile, Is.EqualTo(exePath));
|
|
}
|
|
finally
|
|
{
|
|
try
|
|
{
|
|
File.Delete(configInCwd);
|
|
}
|
|
catch
|
|
{
|
|
}
|
|
}
|
|
}
|
|
|
|
private void WriteSecuredApplicationConfigFile(string path)
|
|
{
|
|
using IDisposable scope = AmbientMessageContext.SetScopedContext(m_telemetry);
|
|
IServiceMessageContext ctx = AmbientMessageContext.CurrentContext ??
|
|
ServiceMessageContext.CreateEmpty(m_telemetry);
|
|
|
|
var app = new SecuredApplication
|
|
{
|
|
ApplicationName = "TestSecuredApp",
|
|
ApplicationUri = "urn:test:securedapp",
|
|
ApplicationType = SecurityNs.ApplicationType.Server_0,
|
|
LastExportTime = DateTime.UtcNow,
|
|
ApplicationCertificate = new SecurityNs.CertificateIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "%LocalApplicationData%/OPC/certs",
|
|
SubjectName = "CN=TestSecuredApp"
|
|
},
|
|
TrustedCertificateStore = new SecurityNs.CertificateStoreIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "%LocalApplicationData%/OPC/trusted"
|
|
},
|
|
IssuerCertificateStore = new SecurityNs.CertificateStoreIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "%LocalApplicationData%/OPC/issuers"
|
|
},
|
|
RejectedCertificatesStore = new SecurityNs.CertificateStoreIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "%LocalApplicationData%/OPC/rejected"
|
|
}
|
|
};
|
|
|
|
using var ms = new MemoryStream();
|
|
var settings = new XmlWriterSettings
|
|
{
|
|
Encoding = Encoding.UTF8,
|
|
Indent = true
|
|
};
|
|
using (var writer = XmlWriter.Create(ms, settings))
|
|
{
|
|
using var encoder = new XmlEncoder(
|
|
typeof(SecuredApplication), writer, ctx);
|
|
SecuredApplicationEncoding.EncodeContents(encoder, app);
|
|
encoder.Close();
|
|
}
|
|
|
|
File.WriteAllBytes(path, ms.ToArray());
|
|
}
|
|
|
|
private void WriteApplicationConfigFile(string path)
|
|
{
|
|
using IDisposable scope = AmbientMessageContext.SetScopedContext(m_telemetry);
|
|
IServiceMessageContext ctx = AmbientMessageContext.CurrentContext ??
|
|
ServiceMessageContext.CreateEmpty(m_telemetry);
|
|
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = "TestAppConfig",
|
|
ApplicationUri = "urn:test:appconfig",
|
|
ApplicationType = ApplicationType.Server,
|
|
SecurityConfiguration = new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "%LocalApplicationData%/OPC/certs",
|
|
SubjectName = "CN=TestAppConfig"
|
|
},
|
|
TrustedPeerCertificates = new CertificateTrustList
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "%LocalApplicationData%/OPC/trusted"
|
|
},
|
|
TrustedIssuerCertificates = new CertificateTrustList
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "%LocalApplicationData%/OPC/issuers"
|
|
},
|
|
RejectedCertificateStore = new CertificateStoreIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "%LocalApplicationData%/OPC/rejected"
|
|
}
|
|
},
|
|
ServerConfiguration = new ServerConfiguration
|
|
{
|
|
BaseAddresses = ["opc.tcp://localhost:4840"],
|
|
SecurityPolicies = new List<ServerSecurityPolicy>
|
|
{
|
|
new() {
|
|
SecurityPolicyUri = SecurityPolicies.Basic256Sha256,
|
|
SecurityMode = MessageSecurityMode.SignAndEncrypt
|
|
}
|
|
}.ToArrayOf()
|
|
}
|
|
};
|
|
|
|
using var ms = new MemoryStream();
|
|
var settings = new XmlWriterSettings
|
|
{
|
|
Encoding = Encoding.UTF8,
|
|
Indent = true
|
|
};
|
|
using (var writer = XmlWriter.Create(ms, settings))
|
|
{
|
|
using var encoder = new XmlEncoder(
|
|
typeof(ApplicationConfiguration), writer, ctx);
|
|
config.Encode(encoder);
|
|
encoder.Close();
|
|
}
|
|
|
|
File.WriteAllBytes(path, ms.ToArray());
|
|
}
|
|
}
|
|
}
|