Files
UA-.NETStandard/tests/Opc.Ua.Gds.Tests/ServerConfigurationPushTestClient.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

276 lines
11 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.IO;
using System.Text;
using System.Threading.Tasks;
using Microsoft.Extensions.Logging;
using Opc.Ua.Configuration;
using Opc.Ua.Gds.Client;
using Opc.Ua.Security.Certificates;
namespace Opc.Ua.Gds.Tests
{
public sealed class ServerConfigurationPushTestClient : IDisposable
{
public ServerPushConfigurationClient PushClient { get; private set; } = null!;
public static bool AutoAccept { get; set; }
public ServerConfigurationPushTestClient(bool autoAccept, ITelemetryContext telemetry)
{
AutoAccept = autoAccept;
m_telemetry = telemetry;
m_logger = telemetry.CreateLogger<ServerConfigurationPushTestClient>();
}
public IUserIdentity AppUser { get; private set; } = null!;
public IUserIdentity SysAdminUser { get; private set; } = null!;
public string TempStorePath { get; private set; } = null!;
public ApplicationConfiguration Config { get; private set; } = null!;
public string EndpointUrl { get; private set; } = null!;
public void Dispose()
{
PushClient?.Dispose();
m_application?.DisposeAsync().AsTask().GetAwaiter().GetResult();
m_application = null!;
}
public async Task LoadClientConfigurationAsync(int port = -1)
{
ApplicationInstance.MessageDlg = new ApplicationMessageDlg(m_logger);
await DisconnectClientAsync().ConfigureAwait(false);
if (m_application != null)
{
await m_application.DisposeAsync().ConfigureAwait(false);
m_application = null!;
}
m_application = new ApplicationInstance(m_telemetry)
{
ApplicationName = "Server Configuration Push Test Client",
ApplicationType = ApplicationType.Client,
ConfigSectionName = "Opc.Ua.ServerConfigurationPushTestClient"
};
#if USE_FILE_CONFIG
// load the application configuration.
Config = await m_application.LoadApplicationConfigurationAsync(false)
.ConfigureAwait(false);
#else
string root = Path.Combine(Path.GetTempPath(), "OPC");
string pkiRoot = Path.Combine(root, "pki");
var clientConfig = new ServerConfigurationPushTestClientConfiguration
{
ServerUrl = "opc.tcp://localhost:58810/GlobalDiscoveryTestServer",
AppUserName = string.Empty,
AppPassword = string.Empty,
SysAdminUserName = "sysadmin",
SysAdminPassword = "demo",
TempStorePath = Path.Combine(pkiRoot, "temp")
};
var transportQuotas = new TransportQuotas
{
OperationTimeout = 120000,
MaxStringLength = 1048576,
MaxByteStringLength = 1048576,
MaxArrayLength = 65535,
MaxMessageSize = 4194304,
MaxBufferSize = 65535,
ChannelLifetime = 300000,
SecurityTokenLifetime = 3600000
};
ArrayOf<CertificateIdentifier> applicationCerts =
ApplicationConfigurationBuilder.CreateDefaultApplicationCertificates(
"CN=Server Configuration Push Test Client, O=OPC Foundation",
CertificateStoreType.Directory,
pkiRoot);
// build the application configuration.
Config = await m_application
.Build(
"urn:localhost:opcfoundation.org:ServerConfigurationPushTestClient",
"http://opcfoundation.org/UA/ServerConfigurationPushTestClient")
.SetTransportQuotas(transportQuotas)
.AsClient()
.AddSecurityConfiguration(applicationCerts, pkiRoot, pkiRoot)
.SetAutoAcceptUntrustedCertificates(true)
.SetRejectSHA1SignedCertificates(false)
.SetRejectUnknownRevocationStatus(true)
.SetMinimumCertificateKeySize(1024)
.AddExtension(null, clientConfig)
.CreateAsync()
.ConfigureAwait(false);
#endif
// check the application certificate.
bool haveAppCertificate = await m_application
.CheckApplicationInstanceCertificatesAsync(true)
.ConfigureAwait(false);
if (!haveAppCertificate)
{
throw new InvalidOperationException("Application instance certificate invalid!");
}
Config.CertificateManager?.AcceptError = AcceptCertificate;
ServerConfigurationPushTestClientConfiguration clientConfiguration =
m_application.ApplicationConfiguration!
.ParseExtension<ServerConfigurationPushTestClientConfiguration>()!;
PushClient = new ServerPushConfigurationClient(m_application.ApplicationConfiguration);
EndpointUrl = TestUtils.PatchOnlyGDSEndpointUrlPort(
clientConfiguration!.ServerUrl,
port);
if (string.IsNullOrEmpty(clientConfiguration.AppUserName))
{
AppUser = new UserIdentity();
}
else
{
AppUser = new UserIdentity(
clientConfiguration.AppUserName,
Encoding.UTF8.GetBytes(clientConfiguration.AppPassword));
}
SysAdminUser = new UserIdentity(
clientConfiguration.SysAdminUserName,
Encoding.UTF8.GetBytes(clientConfiguration.SysAdminPassword));
TempStorePath = clientConfiguration.TempStorePath;
}
public async Task DisconnectClientAsync()
{
m_logger.LogInformation("Disconnect Session. Waiting for exit...");
if (PushClient != null)
{
ServerPushConfigurationClient pushClient = PushClient;
PushClient = null!;
try
{
await pushClient.DisconnectAsync().ConfigureAwait(false);
}
finally
{
await pushClient.DisposeAsync().ConfigureAwait(false);
}
}
}
private bool AcceptCertificate(Certificate certificate, ServiceResult error)
{
if (error.StatusCode == StatusCodes.BadCertificateUntrusted)
{
if (AutoAccept)
{
if (m_logger.IsEnabled(LogLevel.Information))
{
m_logger.LogInformation("Accepted Certificate: {Subject}", certificate.Subject);
}
return true;
}
if (m_logger.IsEnabled(LogLevel.Information))
{
m_logger.LogInformation("Rejected Certificate: {Subject}", certificate.Subject);
}
}
return false;
}
/// <summary>
/// Sets the PushClient's endpoint by SecurityPolicy URI and optional MessageSecurityMode.
/// </summary>
/// <exception cref="ArgumentException"></exception>
/// <exception cref="InvalidOperationException"></exception>
public async Task ConnectAsync(
string securityPolicyUri,
MessageSecurityMode securityMode = MessageSecurityMode.SignAndEncrypt)
{
if (Config == null)
{
throw new InvalidOperationException("Client configuration must be loaded before setting endpoint.");
}
await PushClient.DisconnectAsync().ConfigureAwait(false);
var endpointConfiguration = EndpointConfiguration.Create(Config);
using DiscoveryClient discoveryClient = await DiscoveryClient.CreateAsync(
new Uri(EndpointUrl),
endpointConfiguration,
m_telemetry).ConfigureAwait(false);
ArrayOf<EndpointDescription> endpoints =
await discoveryClient.GetEndpointsAsync(default).ConfigureAwait(false);
await discoveryClient.CloseAsync().ConfigureAwait(false);
EndpointDescription? selectedEndpoint = null;
foreach (EndpointDescription ep in endpoints)
{
if (ep.SecurityPolicyUri == securityPolicyUri && ep.SecurityMode == securityMode)
{
selectedEndpoint = ep;
break;
}
}
if (selectedEndpoint == null)
{
throw new ArgumentException(
$"No endpoint found for SecurityPolicyUri '{securityPolicyUri}' and SecurityMode '{securityMode}'.");
}
PushClient.Endpoint = new ConfiguredEndpoint(null, selectedEndpoint, endpointConfiguration);
await PushClient.ConnectAsync().ConfigureAwait(false);
}
private ApplicationInstance m_application = null!;
private readonly ITelemetryContext m_telemetry;
private readonly ILogger m_logger;
}
/// <summary>
/// Stores the configuration the data access node manager.
/// </summary>
[DataType(Namespace = Ua.Namespaces.OpcUaConfig)]
public partial class ServerConfigurationPushTestClientConfiguration
{
[DataTypeField(Order = 1)]
public string ServerUrl { get; set; } = null!;
[DataTypeField(Order = 2)]
public string AppUserName { get; set; } = null!;
[DataTypeField(Order = 3)]
public string AppPassword { get; set; } = null!;
[DataTypeField(Order = 4)]
public string SysAdminUserName { get; set; } = null!;
[DataTypeField(Order = 5)]
public string SysAdminPassword { get; set; } = null!;
[DataTypeField(Order = 6)]
public string TempStorePath { get; set; } = null!;
}
}