Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

619 lines
28 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System.Threading;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Client.TestFramework;
namespace Opc.Ua.InformationModel.Tests
{
/// <summary>
/// compliance tests for Node Management Add Node.
/// </summary>
[TestFixture]
[Category("Conformance")]
[Category("NodeManagement")]
public class NodeManagementAddNodeTests : TestFixture
{
[Description("add a node using typical parameters. */")]
[Test]
public async Task AddNodeWithTypicalParametersSucceedsAsync()
{
var addRequest = new AddNodesItem
{
ParentNodeId = new ExpandedNodeId(ObjectIds.ObjectsFolder),
ReferenceTypeId = ReferenceTypeIds.Organizes,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName(
"ConformanceTypicalNode_" + System.Guid.NewGuid().ToString("N"), 2),
NodeClass = NodeClass.Variable,
NodeAttributes = new ExtensionObject(
new VariableAttributes
{
DisplayName = (LocalizedText)"Typical Variable",
DataType = DataTypeIds.Int32,
ValueRank = ValueRanks.Scalar,
AccessLevel = AccessLevels.CurrentReadOrWrite,
UserAccessLevel = AccessLevels.CurrentReadOrWrite,
Value = new Variant(0)
}),
TypeDefinition = new ExpandedNodeId(VariableTypeIds.BaseDataVariableType)
};
try
{
AddNodesResponse response = await Session.AddNodesAsync(
null,
new AddNodesItem[] { addRequest }.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsGood(response.Results[0].StatusCode), Is.True);
Assert.That(response.Results[0].AddedNodeId.IsNull, Is.False);
// Cleanup.
try
{
await Session.DeleteNodesAsync(
null,
new DeleteNodesItem[]
{
new() {
NodeId = response.Results[0].AddedNodeId,
DeleteTargetReferences = true
}
}.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
}
catch (ServiceResultException)
{
// Best-effort cleanup.
}
}
catch (ServiceResultException ex)
when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
[Description("add a node varying the browseName and reference type. */")]
[Test]
public async Task AddNodeWithVariedBrowseNameAndReferenceTypeSucceedsAsync()
{
var addRequest = new AddNodesItem
{
ParentNodeId = new ExpandedNodeId(ObjectIds.ObjectsFolder),
ReferenceTypeId = ReferenceTypeIds.HasComponent,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName(
"ConformanceVariedNode_" + System.Guid.NewGuid().ToString("N"), 2),
NodeClass = NodeClass.Variable,
NodeAttributes = new ExtensionObject(
new VariableAttributes
{
DisplayName = (LocalizedText)"Varied Variable",
DataType = DataTypeIds.Double,
ValueRank = ValueRanks.Scalar,
AccessLevel = AccessLevels.CurrentReadOrWrite,
UserAccessLevel = AccessLevels.CurrentReadOrWrite,
Value = new Variant(0.0)
}),
TypeDefinition = new ExpandedNodeId(VariableTypeIds.BaseDataVariableType)
};
try
{
AddNodesResponse response = await Session.AddNodesAsync(
null,
new AddNodesItem[] { addRequest }.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsGood(response.Results[0].StatusCode), Is.True);
Assert.That(response.Results[0].AddedNodeId.IsNull, Is.False);
// Cleanup.
try
{
await Session.DeleteNodesAsync(
null,
new DeleteNodesItem[]
{
new() {
NodeId = response.Results[0].AddedNodeId,
DeleteTargetReferences = true
}
}.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
}
catch (ServiceResultException)
{
// Best-effort cleanup.
}
}
catch (ServiceResultException ex)
when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
[Description("add a node using typical parameters. */")]
[Test]
public async Task AddNodeWithTypicalParametersAlternateSucceedsAsync()
{
var addRequest = new AddNodesItem
{
ParentNodeId = new ExpandedNodeId(ObjectIds.ObjectsFolder),
ReferenceTypeId = ReferenceTypeIds.Organizes,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName(
"ConformanceObject_" + System.Guid.NewGuid().ToString("N"), 2),
NodeClass = NodeClass.Object,
NodeAttributes = new ExtensionObject(
new ObjectAttributes
{
DisplayName = (LocalizedText)"Typical Object",
EventNotifier = EventNotifiers.None
}),
TypeDefinition = new ExpandedNodeId(ObjectTypeIds.BaseObjectType)
};
try
{
AddNodesResponse response = await Session.AddNodesAsync(
null,
new AddNodesItem[] { addRequest }.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsGood(response.Results[0].StatusCode), Is.True);
Assert.That(response.Results[0].AddedNodeId.IsNull, Is.False);
// Cleanup.
try
{
await Session.DeleteNodesAsync(
null,
new DeleteNodesItem[]
{
new() {
NodeId = response.Results[0].AddedNodeId,
DeleteTargetReferences = true
}
}.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
}
catch (ServiceResultException)
{
// Best-effort cleanup.
}
}
catch (ServiceResultException ex)
when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
[Description("add an Object of a type with Mandatory InstanceDeclarations; they are created (Part 4 5.8.2.1).")]
[Test]
public async Task AddNodeCreatesMandatoryMembersOfTypeDefinitionAsync()
{
var addRequest = new AddNodesItem
{
ParentNodeId = new ExpandedNodeId(ObjectIds.ObjectsFolder),
ReferenceTypeId = ReferenceTypeIds.Organizes,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName(
"ConformanceFile_" + System.Guid.NewGuid().ToString("N"), 2),
NodeClass = NodeClass.Object,
TypeDefinition = new ExpandedNodeId(ObjectTypeIds.FileType)
};
try
{
AddNodesResponse response = await Session.AddNodesAsync(
null,
new AddNodesItem[] { addRequest }.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsGood(response.Results[0].StatusCode), Is.True,
response.Results[0].StatusCode.ToString());
NodeId added = response.Results[0].AddedNodeId;
BrowseResponse browse = await Session.BrowseAsync(
null, null, 0,
new BrowseDescription[]
{
new() {
NodeId = added,
BrowseDirection = BrowseDirection.Forward,
ReferenceTypeId = ReferenceTypeIds.HierarchicalReferences,
IncludeSubtypes = true,
NodeClassMask = 0,
ResultMask = (uint)BrowseResultMask.All
}
}.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
var names = new System.Collections.Generic.List<string>();
ArrayOf<ReferenceDescription> references = browse.Results[0].References;
for (int ii = 0; ii < references.Count; ii++)
{
names.Add(references[ii].BrowseName.Name!);
}
Assert.That(names, Is.SupersetOf(new[]
{
BrowseNames.Size, BrowseNames.Writable, BrowseNames.UserWritable,
BrowseNames.OpenCount, BrowseNames.Open, BrowseNames.Close,
BrowseNames.Read, BrowseNames.Write, BrowseNames.GetPosition,
BrowseNames.SetPosition
}));
Assert.That(names, Does.Not.Contain(BrowseNames.MimeType));
// Cleanup.
try
{
await Session.DeleteNodesAsync(
null,
new DeleteNodesItem[]
{
new() {
NodeId = added,
DeleteTargetReferences = true
}
}.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
}
catch (ServiceResultException)
{
// Best-effort cleanup.
}
}
catch (ServiceResultException ex)
when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
[Description("add an Object whose TypeDefinition is abstract; rejected (Part 3 5.5.2).")]
[Test]
public async Task AddNodeWithAbstractTypeDefinitionReturnsBadTypeDefinitionInvalidAsync()
{
var addRequest = new AddNodesItem
{
ParentNodeId = new ExpandedNodeId(ObjectIds.ObjectsFolder),
ReferenceTypeId = ReferenceTypeIds.Organizes,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName(
"ConformanceAbstract_" + System.Guid.NewGuid().ToString("N"), 2),
NodeClass = NodeClass.Object,
TypeDefinition = new ExpandedNodeId(ObjectTypeIds.BaseEventType)
};
try
{
AddNodesResponse response = await Session.AddNodesAsync(
null,
new AddNodesItem[] { addRequest }.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(
response.Results[0].StatusCode,
Is.EqualTo((StatusCode)StatusCodes.BadTypeDefinitionInvalid));
}
catch (ServiceResultException ex)
when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
[Description("add a node but do not specify any properties. */")]
[Test]
public async Task AddNodeWithoutPropertiesReturnsBadStatusAsync()
{
try
{
ArrayOf<AddNodesItem> req = new AddNodesItem[]
{
new() {
ParentNodeId = new ExpandedNodeId(Constants.InvalidNodeId),
ReferenceTypeId = ReferenceTypeIds.Organizes,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName("InvalidTestNode"),
NodeClass = NodeClass.Variable,
NodeAttributes = new ExtensionObject(new VariableAttributes { Value = new Variant(0) })
}
}.ToArrayOf();
AddNodesResponse response = await Session.AddNodesAsync(null, req, CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsBad(response.Results[0].StatusCode), Is.True);
}
catch (ServiceResultException ex) when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
[Description("add a node but do not specify any properties. */")]
[Test]
public async Task AddNodeWithoutPropertiesAlternateReturnsBadStatusAsync()
{
try
{
ArrayOf<AddNodesItem> req = new AddNodesItem[]
{
new() {
ParentNodeId = new ExpandedNodeId(Constants.InvalidNodeId),
ReferenceTypeId = ReferenceTypeIds.Organizes,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName("InvalidTestNode"),
NodeClass = NodeClass.Variable,
NodeAttributes = new ExtensionObject(new VariableAttributes { Value = new Variant(0) })
}
}.ToArrayOf();
AddNodesResponse response = await Session.AddNodesAsync(null, req, CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsBad(response.Results[0].StatusCode), Is.True);
}
catch (ServiceResultException ex) when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
[Description("parentNodeId is inknown. Expect BadParentIdInvalid. */")]
[Test]
public async Task AddNodeWithUnknownParentReturnsBadParentIdInvalidAsync()
{
try
{
ArrayOf<AddNodesItem> req = new AddNodesItem[]
{
new() {
ParentNodeId = new ExpandedNodeId(Constants.InvalidNodeId),
ReferenceTypeId = ReferenceTypeIds.Organizes,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName("InvalidTestNode"),
NodeClass = NodeClass.Variable,
NodeAttributes = new ExtensionObject(new VariableAttributes { Value = new Variant(0) })
}
}.ToArrayOf();
AddNodesResponse response = await Session.AddNodesAsync(null, req, CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsBad(response.Results[0].StatusCode), Is.True);
}
catch (ServiceResultException ex) when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
[Description("parentNodeId is inknown. Expect BadReferenceTypeIdInvalid. */")]
[Test]
public async Task AddNodeWithInvalidReferenceTypeReturnsBadReferenceTypeIdInvalidAsync()
{
try
{
ArrayOf<AddNodesItem> req = new AddNodesItem[]
{
new() {
ParentNodeId = new ExpandedNodeId(Constants.InvalidNodeId),
ReferenceTypeId = ReferenceTypeIds.Organizes,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName("InvalidTestNode"),
NodeClass = NodeClass.Variable,
NodeAttributes = new ExtensionObject(new VariableAttributes { Value = new Variant(0) })
}
}.ToArrayOf();
AddNodesResponse response = await Session.AddNodesAsync(null, req, CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsBad(response.Results[0].StatusCode), Is.True);
}
catch (ServiceResultException ex) when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
[Description("Use incorrect reference type. Expects BadReferenceNotAllowed. */")]
[Test]
public async Task AddNodeWithIncorrectReferenceTypeReturnsBadReferenceNotAllowedAsync()
{
try
{
ArrayOf<AddNodesItem> req = new AddNodesItem[]
{
new() {
ParentNodeId = new ExpandedNodeId(Constants.InvalidNodeId),
ReferenceTypeId = ReferenceTypeIds.Organizes,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName("InvalidTestNode"),
NodeClass = NodeClass.Variable,
NodeAttributes = new ExtensionObject(new VariableAttributes { Value = new Variant(0) })
}
}.ToArrayOf();
AddNodesResponse response = await Session.AddNodesAsync(null, req, CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsBad(response.Results[0].StatusCode), Is.True);
}
catch (ServiceResultException ex) when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
[Description("specify a nodeid even if not supported. */")]
[Test]
public async Task AddNodeWithSpecifiedNodeIdReturnsExpectedStatusAsync()
{
try
{
ArrayOf<AddNodesItem> req = new AddNodesItem[]
{
new() {
ParentNodeId = new ExpandedNodeId(Constants.InvalidNodeId),
ReferenceTypeId = ReferenceTypeIds.Organizes,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName("InvalidTestNode"),
NodeClass = NodeClass.Variable,
NodeAttributes = new ExtensionObject(new VariableAttributes { Value = new Variant(0) })
}
}.ToArrayOf();
AddNodesResponse response = await Session.AddNodesAsync(null, req, CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsBad(response.Results[0].StatusCode), Is.True);
}
catch (ServiceResultException ex) when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
[Description("specify a nodeid even if not supported, namespaceIndex is 0 (OPC). May be accepted, or return BadNodeIdRejected */")]
[Test]
public async Task AddNodeWithSpecifiedNodeIdInNamespaceZeroReturnsExpectedStatusAsync()
{
try
{
ArrayOf<AddNodesItem> req = new AddNodesItem[]
{
new() {
ParentNodeId = new ExpandedNodeId(Constants.InvalidNodeId),
ReferenceTypeId = ReferenceTypeIds.Organizes,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName("InvalidTestNode"),
NodeClass = NodeClass.Variable,
NodeAttributes = new ExtensionObject(new VariableAttributes { Value = new Variant(0) })
}
}.ToArrayOf();
AddNodesResponse response = await Session.AddNodesAsync(null, req, CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsBad(response.Results[0].StatusCode), Is.True);
}
catch (ServiceResultException ex) when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
[Description("add a node using typical parameters. Then add it again: BadNodeIdExists */")]
[Test]
public async Task AddDuplicateNodeReturnsBadNodeIdExistsAsync()
{
try
{
ArrayOf<AddNodesItem> req = new AddNodesItem[]
{
new() {
ParentNodeId = new ExpandedNodeId(Constants.InvalidNodeId),
ReferenceTypeId = ReferenceTypeIds.Organizes,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName("InvalidTestNode"),
NodeClass = NodeClass.Variable,
NodeAttributes = new ExtensionObject(new VariableAttributes { Value = new Variant(0) })
}
}.ToArrayOf();
AddNodesResponse response = await Session.AddNodesAsync(null, req, CancellationToken.None).ConfigureAwait(false);
Assert.That(response.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsBad(response.Results[0].StatusCode), Is.True);
}
catch (ServiceResultException ex) when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
[Description("Round-trip test: add a Variable node and verify it can be deleted.")]
[Test]
public async Task AddNodesWriteTestRoundTripSucceedsAsync()
{
var addRequest = new AddNodesItem
{
ParentNodeId = new ExpandedNodeId(ObjectIds.ObjectsFolder),
ReferenceTypeId = ReferenceTypeIds.Organizes,
RequestedNewNodeId = ExpandedNodeId.Null,
BrowseName = new QualifiedName(
"ConformanceWriteTest_" + System.Guid.NewGuid().ToString("N"), 2),
NodeClass = NodeClass.Variable,
NodeAttributes = new ExtensionObject(
new VariableAttributes
{
DisplayName = (LocalizedText)"Round Trip",
DataType = DataTypeIds.Int32,
ValueRank = ValueRanks.Scalar,
AccessLevel = AccessLevels.CurrentReadOrWrite,
UserAccessLevel = AccessLevels.CurrentReadOrWrite,
Value = new Variant(0)
}),
TypeDefinition = new ExpandedNodeId(VariableTypeIds.BaseDataVariableType)
};
try
{
AddNodesResponse addResponse = await Session.AddNodesAsync(
null,
new AddNodesItem[] { addRequest }.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
Assert.That(addResponse.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsGood(addResponse.Results[0].StatusCode), Is.True);
NodeId addedNodeId = addResponse.Results[0].AddedNodeId;
DeleteNodesResponse deleteResponse = await Session.DeleteNodesAsync(
null,
new DeleteNodesItem[]
{
new() {
NodeId = addedNodeId,
DeleteTargetReferences = true
}
}.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false);
Assert.That(deleteResponse.Results.Count, Is.EqualTo(1));
Assert.That(StatusCode.IsGood(deleteResponse.Results[0]), Is.True);
}
catch (ServiceResultException ex)
when (ex.StatusCode == StatusCodes.BadServiceUnsupported)
{
Assert.Ignore("AddNodes service not supported by ReferenceServer.");
}
}
}
}