mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-16 21:02:51 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
135 lines
5.5 KiB
C#
135 lines
5.5 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.IO;
|
|
using System.Text.Json;
|
|
using NUnit.Framework;
|
|
|
|
namespace Opc.Ua.Interop.Tests
|
|
{
|
|
/// <summary>
|
|
/// Known defects of a peer's stack, read from "expected-differences.json"
|
|
/// next to the peer: { "<check or test name>": { "reason": "...",
|
|
/// "issue": "<upstream link>" } }. A listed failure is reported as
|
|
/// inconclusive with its reason instead of failing the 2.0 tests; a
|
|
/// listed check that passes is reported with a warning so the list is
|
|
/// pruned once the stack is fixed.
|
|
/// </summary>
|
|
public static class ExpectedDifferences
|
|
{
|
|
public const string FileName = "expected-differences.json";
|
|
|
|
private static readonly Lazy<Dictionary<string, string>> s_differences = new(Load);
|
|
|
|
/// <summary>
|
|
/// The reason a check or test is expected to fail with this peer, or
|
|
/// null when it is expected to pass.
|
|
/// </summary>
|
|
public static string Reason(string name)
|
|
{
|
|
if (s_differences.Value.TryGetValue(name, out string? reason))
|
|
{
|
|
return reason;
|
|
}
|
|
// A key ending with '*' lists every test whose name starts with
|
|
// the rest, e.g. all checks of one security configuration.
|
|
foreach (KeyValuePair<string, string> entry in s_differences.Value)
|
|
{
|
|
if (entry.Key.EndsWith('*') &&
|
|
name.StartsWith(entry.Key.Substring(0, entry.Key.Length - 1), StringComparison.Ordinal))
|
|
{
|
|
return entry.Value;
|
|
}
|
|
}
|
|
return null!;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Ends a test whose check failed as expected, or warns when a listed
|
|
/// check passed.
|
|
/// </summary>
|
|
public static void Apply(string name, bool passed, string failure)
|
|
{
|
|
string reason = Reason(name);
|
|
if (reason == null)
|
|
{
|
|
return;
|
|
}
|
|
if (passed)
|
|
{
|
|
Assert.Warn($"'{name}' is listed in {FileName} ({reason}) but passed; remove the entry.");
|
|
return;
|
|
}
|
|
Assert.Inconclusive($"Expected difference of this peer: {reason}{Environment.NewLine}{failure}");
|
|
}
|
|
|
|
/// <summary>
|
|
/// The reason a test of this stack against the peer is expected to
|
|
/// fail, looked up by "Fixture.Test" (e.g.
|
|
/// "LegacyServerInteropTests.ConnectWithWrongPasswordIsRejected").
|
|
/// </summary>
|
|
public static string ReasonForTest(string fixture, string testName)
|
|
{
|
|
return Reason(fixture + "." + testName);
|
|
}
|
|
|
|
private static Dictionary<string, string> Load()
|
|
{
|
|
var differences = new Dictionary<string, string>(StringComparer.Ordinal);
|
|
// Next to the peer, or up to two levels up for peers run from a
|
|
// build output folder (milo/target/milo-peer.jar,
|
|
// async-opcua/target/release/async-opcua-peer).
|
|
string folder = LegacyPeerProcess.PeerDirectory;
|
|
string file = Path.Combine(folder, FileName);
|
|
for (int level = 0; level < 2 && !File.Exists(file) && Path.GetDirectoryName(folder) != null; level++)
|
|
{
|
|
folder = Path.GetDirectoryName(folder)!;
|
|
file = Path.Combine(folder!, FileName);
|
|
}
|
|
if (!File.Exists(file))
|
|
{
|
|
return differences;
|
|
}
|
|
using var document = JsonDocument.Parse(File.ReadAllText(file));
|
|
foreach (JsonProperty entry in document.RootElement.EnumerateObject())
|
|
{
|
|
string reason = (entry.Value.TryGetProperty("reason", out JsonElement r) ? r.GetString() : string.Empty)!;
|
|
if (entry.Value.TryGetProperty("issue", out JsonElement issue))
|
|
{
|
|
reason += " (" + issue.GetString() + ")";
|
|
}
|
|
differences[entry.Name] = reason!;
|
|
}
|
|
return differences;
|
|
}
|
|
}
|
|
}
|