Files
Marc Schier 0374e19121 Add MachineTool, WMTP, GMS and CranesHoists companions (#4765)
# Description

_Describe the changes here to communicate to the maintainers why they
should accept this pull request. By default - this will become the
Commit message after merging and thus define history._

Add provider-backed MachineTool, bundled WMTP, GMS and CranesHoists
companions using the existing Machinery/MachineVision fluent, DI and
typed-client approach. **The PR is open/non-draft by user choice.
Current head `ecc4a7d6ca3e8004cf28ab54da605da302d026bf` is mergeable and
has 108 successful checks, six intentionally skipped checks, zero
failures and zero pending checks. All five primary workflows completed
successfully at that exact head.**

| Family | Released specification/model | Packaging |
| --- | --- | --- |
| MachineTool | OPC 40501-1, 1.02.0 | Model, Server, Client and MCP;
normal root versions |
| WMTP | OPC 40505, 1.0.0 | Bundled in MachineTool; distinct CLR/wire
namespace and independent WMTP-only hosting |
| GMS | OPC 40210 reference 1.0.1, normative model 1.0.0 | Model,
Server, Client and MCP; normal root versions |
| CranesHoists | OPC 40020-1, 1.00 | Model, Server, Client and MCP; all
four plus Debug variants forced preview |

There are **12 new packable projects**. No separate WMTP
package/profile/guide, root version bump, tag, release or package
publication is included. Mandatory instance structure is the default;
selected optional features require explicit providers. The
implementation reuses Machinery results/jobs/files/ProcessValues and
Robotics topology, including retained MachineTool Production, defined
GMS jobs/parts, modern ISA95/Machinery jobs, shared-owner hosting and
isolated instances alongside MachineVision.

Runtime and integration fixes preserve raw quality/timestamps, coherent
acquisition, namespace ownership, accepted-configuration state,
borrowed-resource lifetime, session/node/file cleanup, terminal-value
publication, event propagation and endpoint-aware capability
publication. Firmware/licence transfer means provider acceptance, not
installation/activation. Cancellation does not silently abort another
caller's operation. The later upstream MCP expansion is integrated
without losing either family set or its default-off privileged/live
execution policy.

### Conformance and scope

Canonical model inputs are pinned to UA-Nodeset revision
`96a08945425d0295edb3607d2a38f6841ef44046`.

**GMS upstream exception:** [Annex
A.1](https://reference.opcfoundation.org/specs/OPC-40210/annex-a) makes
the released NodeSet normative, but §12.3.2.7 requires undefined
`GMS_ProductionStatisticsType`. Inherited statistics and defined
jobs/parts are implemented without inventing a standard type/NodeId; the
complete GMS Production facet is withheld.

The requirement ledger records **102 positively evidenced CU rows, 96
directly negative-tested rows and six explicit negative-evidence
limitations**. All 648 test-class/name/TRX links were independently
resolved to passing cases. The six limitations concern Stacklight,
retained legacy PowerOnDuration, Machinery PowerOnDuration, WorkingUnit,
Obligation and MaintenanceMode. They are not claims that every
invalid-input or hardware-control behavior was tested. The undefined GMS
requirement is outside the 102 defined CUs. No external certification
claim is made.

Retained baseline complete-assembly line coverage, with generated code
retained and no source exclusions:

| Family | Model | Server | Client |
| --- | ---: | ---: | ---: |
| MachineTool/WMTP | 83.80% | 91.98% | 84.74% |
| GMS | 95.51% | 90.63% | 88.38% |
| CranesHoists | 92.76% | 94.45% | 92.24% |

These nine measurements predate the later focused review fixes and
merges; they are not relabelled as new `ecc4a7d6c` percentages. The
current head's separate CI code-coverage check succeeded. No new
exclusions or threshold relaxations were introduced.

## Related Issues

- Fixes
[#4764](https://github.com/OPCFoundation/UA-.NETStandard/issues/4764),
the implementation/design and acceptance tracker.

## Checklist

_Put an `x` in the boxes that apply. You can complete these step by step
after opening the PR._

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [ ] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [x] I have addressed **all** PR feedback received.
2026-10-15 15:15:46 +02:00

188 lines
9.9 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Threading;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Client;
using Opc.Ua.Client.TestFramework;
using Opc.Ua.MachineTool.Client;
using Opc.Ua.MachineTool.Server;
using Opc.Ua.Tests;
namespace Opc.Ua.MachineTool.Tests
{
/// <summary>
/// Exercises explicit tool observations through the public builder and an actual opc.tcp session.
/// </summary>
[TestFixture]
[Category("MachineTool")]
[Category("Integration")]
[NonParallelizable]
public sealed class MachineToolEquipmentTests
{
/// <summary>
/// Tool identification, the standard BaseObject location and Number-valued life retain wire fidelity.
/// </summary>
[Test]
public async Task ToolInventoryPreservesIdentifiersLocationAndIntegralLifeOverTcpAsync()
{
await using var fixture = new MachineToolRuntimeFixture();
await fixture.StartAsync().ConfigureAwait(false);
MachineToolSnapshot initial = Example();
var provider = new InMemoryMachineToolProvider(initial);
await using MachineToolRuntime<MachineToolState> runtime = await fixture.Context.AddMachineTool("Tools")
.WithProvider(provider)
.WithEquipment(new MachineToolEquipmentOptions
{
Features = MachineToolFeatures.Tools | MachineToolFeatures.ToolLife
})
.WithIdentification(identity =>
{
identity.Manufacturer = new LocalizedText("Equipment test");
identity.SerialNumber = "Tools-1";
identity.ProductInstanceUri = "urn:equipment-tests:tools";
}).BuildAsync().ConfigureAwait(false);
ToolListState list = runtime.Equipment.State.Tools!;
var tool = (ToolState)list.FindChild(fixture.Context.Context,
new QualifiedName("T1", fixture.Context.InstanceNamespaceIndex))!;
Assert.That(tool, Is.Not.Null);
Assert.That(tool.Identifier!.Value, Is.EqualTo("GLOBAL-123"));
Assert.That(tool.Location!.TypeDefinitionId, Is.EqualTo(Opc.Ua.ObjectTypeIds.BaseObjectType));
ushort mt = (ushort)fixture.Context.Context.NamespaceUris.GetIndex(Namespaces.MachineTool);
var place = (BaseVariableState)tool.Location.FindChild(
fixture.Context.Context, new QualifiedName(BrowseNames.PlaceNumber, mt))!;
Assert.That(place.WrappedValue.TryGetValue(out ushort position), Is.True);
Assert.That(position, Is.EqualTo(65535));
Assert.That(tool.ControlIdentifier2, Is.Null);
Assert.That(tool.LastUsage, Is.Null);
Assert.That(tool.PlannedForOperating, Is.Null);
var life = (ToolLifeState)tool.ToolLife!.FindChild(fixture.Context.Context,
new QualifiedName("Parts", fixture.Context.InstanceNamespaceIndex))!;
await using var client = new ClientFixture(NUnitTelemetryContext.Create());
await client.LoadClientConfigurationAsync(fixture.Root, "EquipmentClient").ConfigureAwait(false);
using ISession session = await client.ConnectAsync(fixture.Endpoint, SecurityPolicies.None)
.ConfigureAwait(false);
DataValue value = await session.ReadValueAsync(life.NodeId).ConfigureAwait(false);
Assert.That(value.WrappedValue.TryGetValue(out ulong count), Is.True);
Assert.That(count, Is.EqualTo(18_446_744_073_709_551_610ul));
Assert.That(value.StatusCode, Is.EqualTo(StatusCodes.UncertainLastUsableValue));
Assert.That(value.SourceTimestamp, Is.EqualTo(initial.Equipment!.Tools[0].Life[0].Value.SourceTimestamp));
Assert.That(life.DataType, Is.EqualTo(Opc.Ua.DataTypeIds.Number));
Assert.That(life.Indication!.Value, Is.EqualTo(ToolLifeIndication.NumberOfParts));
Assert.That(life.IsCountingUp!.Value, Is.True);
Assert.That(life.EngineeringUnits!.BrowseName, Is.EqualTo(new QualifiedName("EngineeringUnits", mt)));
Assert.That(life.WarningValue!.WrappedValue.TryGetValue(out ulong warning), Is.True);
Assert.That(warning, Is.EqualTo(18_446_744_073_709_551_611ul));
WriteResponse write = await session.WriteAsync(null,
[new WriteValue { NodeId = life.NodeId, AttributeId = Attributes.Value, Value = new DataValue(1ul) }],
CancellationToken.None).ConfigureAwait(false);
Assert.That(write.Results[0], Is.EqualTo(StatusCodes.BadNotWritable));
await using var facade = new MachineToolClient(session, NUnitTelemetryContext.Create());
MachineToolEquipmentReadSnapshot inventory = await facade.ReadEquipmentAsync(runtime.NodeId)
.ConfigureAwait(false);
Assert.That(inventory.Tools.Count, Is.EqualTo(1));
Assert.That(inventory.Tools[0].NodeId, Is.EqualTo(tool.NodeId));
Assert.That(inventory.Tools[0].LocationNodeId, Is.EqualTo(tool.Location.NodeId));
Assert.That(inventory.Tools[0].ControlIdentifier2.IsNull, Is.True);
Assert.That(inventory.Tools[0].LastUsage.IsNull, Is.True);
Assert.That(inventory.Tools[0].Life[0].Value.WrappedValue, Is.EqualTo(value.WrappedValue));
Assert.That(inventory.Tools[0].Life[0].Value.SourceTimestamp, Is.EqualTo(value.SourceTimestamp));
Assert.That(inventory.Tools[0].Life[0].Value.StatusCode, Is.EqualTo(value.StatusCode));
await session.CloseAsync(CancellationToken.None).ConfigureAwait(false);
}
/// <summary>
/// Supplies independently known UInt64 values above Double's integral precision.
/// </summary>
internal static MachineToolSnapshot Example()
{
var sample = new MachineToolSampleInfo(
new DateTime(2026, 9, 1, 2, 3, 4, DateTimeKind.Utc), StatusCodes.UncertainLastUsableValue);
return new MachineToolSnapshot
{
Equipment = new MachineToolEquipmentObservation
{
Tools =
[
new MachineToolTool
{
Key = "T1",
Identifier = "GLOBAL-123",
Name = "Drill",
Location = new MachineToolLocation("Magazine", ushort.MaxValue),
Control = new MachineToolToolControl(7, ToolManagement.NumberBased, false,
ToolLocked.CapabilityUnavailable),
Sample = sample,
Life =
[
new MachineToolToolLife
{
Name = "Parts",
Value = Sample(Variant.From(18_446_744_073_709_551_610ul), sample),
StartValue = Sample(Variant.From(0ul), sample),
WarningValue = Sample(Variant.From(18_446_744_073_709_551_611ul), sample),
LimitValue = Sample(Variant.From(ulong.MaxValue), sample),
Indication = ToolLifeIndication.NumberOfParts,
EngineeringUnits = Unit(0x433632, "1", "one"),
IsCountingUp = true,
Sample = sample
}
]
}
]
}
};
}
/// <summary>
/// Creates an explicit sample without converting its numerical representation.
/// </summary>
internal static DataValue Sample(Variant value, MachineToolSampleInfo sample)
{
return new DataValue(value, sample.StatusCode, sample.SourceTimestamp);
}
/// <summary>
/// Supplies the UNECE unit identity independently of the runtime's validation.
/// </summary>
internal static EUInformation Unit(int code, string symbol, string description)
{
return new EUInformation
{
NamespaceUri = "http://www.opcfoundation.org/UA/units/un/cefact",
UnitId = code,
DisplayName = new LocalizedText(symbol),
Description = new LocalizedText(description)
};
}
}
}