Files
UA-.NETStandard/tests/Opc.Ua.MachineTool.Tests/MachineToolNotificationFactoryTests.cs
Marc Schier 0374e19121 Add MachineTool, WMTP, GMS and CranesHoists companions (#4765)
# Description

_Describe the changes here to communicate to the maintainers why they
should accept this pull request. By default - this will become the
Commit message after merging and thus define history._

Add provider-backed MachineTool, bundled WMTP, GMS and CranesHoists
companions using the existing Machinery/MachineVision fluent, DI and
typed-client approach. **The PR is open/non-draft by user choice.
Current head `ecc4a7d6ca3e8004cf28ab54da605da302d026bf` is mergeable and
has 108 successful checks, six intentionally skipped checks, zero
failures and zero pending checks. All five primary workflows completed
successfully at that exact head.**

| Family | Released specification/model | Packaging |
| --- | --- | --- |
| MachineTool | OPC 40501-1, 1.02.0 | Model, Server, Client and MCP;
normal root versions |
| WMTP | OPC 40505, 1.0.0 | Bundled in MachineTool; distinct CLR/wire
namespace and independent WMTP-only hosting |
| GMS | OPC 40210 reference 1.0.1, normative model 1.0.0 | Model,
Server, Client and MCP; normal root versions |
| CranesHoists | OPC 40020-1, 1.00 | Model, Server, Client and MCP; all
four plus Debug variants forced preview |

There are **12 new packable projects**. No separate WMTP
package/profile/guide, root version bump, tag, release or package
publication is included. Mandatory instance structure is the default;
selected optional features require explicit providers. The
implementation reuses Machinery results/jobs/files/ProcessValues and
Robotics topology, including retained MachineTool Production, defined
GMS jobs/parts, modern ISA95/Machinery jobs, shared-owner hosting and
isolated instances alongside MachineVision.

Runtime and integration fixes preserve raw quality/timestamps, coherent
acquisition, namespace ownership, accepted-configuration state,
borrowed-resource lifetime, session/node/file cleanup, terminal-value
publication, event propagation and endpoint-aware capability
publication. Firmware/licence transfer means provider acceptance, not
installation/activation. Cancellation does not silently abort another
caller's operation. The later upstream MCP expansion is integrated
without losing either family set or its default-off privileged/live
execution policy.

### Conformance and scope

Canonical model inputs are pinned to UA-Nodeset revision
`96a08945425d0295edb3607d2a38f6841ef44046`.

**GMS upstream exception:** [Annex
A.1](https://reference.opcfoundation.org/specs/OPC-40210/annex-a) makes
the released NodeSet normative, but §12.3.2.7 requires undefined
`GMS_ProductionStatisticsType`. Inherited statistics and defined
jobs/parts are implemented without inventing a standard type/NodeId; the
complete GMS Production facet is withheld.

The requirement ledger records **102 positively evidenced CU rows, 96
directly negative-tested rows and six explicit negative-evidence
limitations**. All 648 test-class/name/TRX links were independently
resolved to passing cases. The six limitations concern Stacklight,
retained legacy PowerOnDuration, Machinery PowerOnDuration, WorkingUnit,
Obligation and MaintenanceMode. They are not claims that every
invalid-input or hardware-control behavior was tested. The undefined GMS
requirement is outside the 102 defined CUs. No external certification
claim is made.

Retained baseline complete-assembly line coverage, with generated code
retained and no source exclusions:

| Family | Model | Server | Client |
| --- | ---: | ---: | ---: |
| MachineTool/WMTP | 83.80% | 91.98% | 84.74% |
| GMS | 95.51% | 90.63% | 88.38% |
| CranesHoists | 92.76% | 94.45% | 92.24% |

These nine measurements predate the later focused review fixes and
merges; they are not relabelled as new `ecc4a7d6c` percentages. The
current head's separate CI code-coverage check succeeded. No new
exclusions or threshold relaxations were introduced.

## Related Issues

- Fixes
[#4764](https://github.com/OPCFoundation/UA-.NETStandard/issues/4764),
the implementation/design and acceptance tracker.

## Checklist

_Put an `x` in the boxes that apply. You can complete these step by step
after opening the PR._

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [ ] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [x] I have addressed **all** PR feedback received.
2026-10-15 15:15:46 +02:00

198 lines
9.9 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.MachineTool.Server;
namespace Opc.Ua.MachineTool.Tests
{
/// <summary>
/// Verifies typed vendor alert factories, rollback and bounded accepted-publication retries.
/// </summary>
[TestFixture]
[NonParallelizable]
[Category("MachineTool")]
public sealed class MachineToolNotificationFactoryTests
{
/// <summary>
/// Vendor types retain their IDs and generated states; a later factory failure publishes no prefix.
/// </summary>
[Test]
public async Task VendorFactoriesStageAtomicallyAndPreserveTypeIdentityAsync()
{
await using var fixture = new MachineToolRuntimeFixture();
await fixture.StartAsync().ConfigureAwait(false);
var type = new BaseObjectTypeState
{
NodeId = new NodeId(Guid.NewGuid(), fixture.Context.InstanceNamespaceIndex),
BrowseName = new QualifiedName("VendorAlert", fixture.Context.InstanceNamespaceIndex),
DisplayName = new LocalizedText("Vendor alert"),
SuperTypeId = ExpandedNodeId.ToNodeId(ObjectTypeIds.AlertType, fixture.Context.Context.NamespaceUris),
IsAbstract = false,
IsPartOfTypeHierarchy = true
};
await fixture.Context.Manager.AddPredefinedNodeAsync(type).ConfigureAwait(false);
MachineToolAlert alert = MachineToolNotificationValidationTests.Alert();
var provider = new MachineToolNotificationTests.NotificationProvider(
new MachineToolNotificationSnapshot { Alerts = [alert] });
bool fail = true;
var created = new List<AlertState>();
var options = new MachineToolNotificationOptions
{
Provider = provider,
CreateAlertAsync = (context, parent, name, ct) =>
{
ct.ThrowIfCancellationRequested();
if (name.Name == "Third" && fail)
{
throw new ArgumentException("Factory failed.");
}
AlertState state = context.CreateInstanceOfAlertType(parent, name);
state.TypeDefinitionId = type.NodeId;
created.Add(state);
return new ValueTask<AlertState>(state);
}
};
await using MachineToolRuntime<MachineToolState> runtime =
await Builder(fixture, options).BuildAsync().ConfigureAwait(false);
Assert.That(runtime.Notifications!.TryGetAlert(alert.Key, out AlertState? original), Is.True);
Assert.That(original, Is.SameAs(created[0]));
Assert.That(original!.TypeDefinitionId, Is.EqualTo(type.NodeId));
provider.Snapshot = new MachineToolNotificationSnapshot
{
Revision = 1,
Alerts = [alert with { Severity = 800 }, alert with { Key = "Second" }, alert with { Key = "Third" }]
};
Assert.ThrowsAsync<ArgumentException>(async () =>
await runtime.RefreshNotificationsAsync().ConfigureAwait(false));
Assert.That(original.Severity!.Value, Is.EqualTo(500));
Assert.That(runtime.Notifications.TryGetAlert("Second", out _), Is.False);
Assert.That(fixture.Context.Manager.FindPredefinedNode(created[1].NodeId), Is.Null);
fail = false;
await runtime.RefreshNotificationsAsync().ConfigureAwait(false);
Assert.That(runtime.Notifications.TryGetAlert("Third", out AlertState? third), Is.True);
Assert.That(third!.TypeDefinitionId, Is.EqualTo(type.NodeId));
Assert.That(original.Severity.Value, Is.EqualTo(800));
Assert.That(runtime.Notifications.TryGetAlert("Absent", out _), Is.False);
Assert.Throws<ArgumentNullException>(() => runtime.Notifications.TryGetAlert(null!, out _));
}
/// <summary>
/// A failed sink retains the accepted EventId; the next update retries without creating a new identity.
/// </summary>
[Test]
public async Task PublicationRetryPreservesAcceptedMessageIdentityAsync()
{
await using var fixture = new MachineToolRuntimeFixture();
await fixture.StartAsync().ConfigureAwait(false);
var provider = new MachineToolNotificationTests.NotificationProvider(new MachineToolNotificationSnapshot());
await using MachineToolRuntime<MachineToolState> runtime =
await MachineToolNotificationTests.BuildAsync(fixture, provider).ConfigureAwait(false);
ByteString firstId = default;
ByteString retryId = default;
bool fail = true;
NodeStateReportEventAsyncHandler? previous = runtime.State.OnReportEventAsync;
runtime.State.OnReportEventAsync = async (context, node, value, ct) =>
{
if (value is NotificationEventState message)
{
if (fail)
{
firstId = message.EventId!.Value;
throw new InvalidOperationException("Sink rejected publication.");
}
retryId = message.EventId!.Value;
}
if (previous != null)
{
await previous(context, node, value, ct).ConfigureAwait(false);
}
};
provider.Snapshot = new MachineToolNotificationSnapshot
{
Revision = 1,
Messages = [MachineToolNotificationValidationTests.Message(1)]
};
Assert.ThrowsAsync<InvalidOperationException>(async () =>
await runtime.RefreshNotificationsAsync().ConfigureAwait(false));
Assert.That(runtime.Notifications!.Observation!.Revision, Is.EqualTo(1));
fail = false;
provider.Snapshot = new MachineToolNotificationSnapshot { Revision = 1 };
await runtime.RefreshNotificationsAsync().ConfigureAwait(false);
Assert.That(firstId.IsEmpty, Is.False);
Assert.That(retryId, Is.EqualTo(firstId));
runtime.State.OnReportEventAsync = previous;
}
/// <summary>
/// A factory cannot borrow an already-published condition from another machine.
/// </summary>
[Test]
public async Task BorrowedFactoryConditionIsRejectedWithoutDeletingItsOwnerAsync()
{
await using var fixture = new MachineToolRuntimeFixture();
await fixture.StartAsync().ConfigureAwait(false);
MachineToolAlert alert = MachineToolNotificationValidationTests.Alert();
var provider = new MachineToolNotificationTests.NotificationProvider(
new MachineToolNotificationSnapshot { Alerts = [alert] });
await using MachineToolRuntime<MachineToolState> first =
await MachineToolNotificationTests.BuildAsync(fixture, provider, "Owner").ConfigureAwait(false);
Assert.That(first.Notifications!.TryGetAlert(alert.Key, out AlertState? existing), Is.True);
var options = new MachineToolNotificationOptions
{
Provider = provider,
CreateAlertAsync = (_, _, _, _) => new ValueTask<AlertState>(existing!)
};
Assert.ThrowsAsync<ServiceResultException>(async () =>
await Builder(fixture, options).BuildAsync().ConfigureAwait(false));
Assert.That(fixture.Context.Manager.FindPredefinedNode(existing!.NodeId), Is.SameAs(existing));
Assert.That(existing.ActiveState!.Id!.Value, Is.True);
}
/// <summary>
/// Selects a factory on the normal public builder without replacing any shared registration.
/// </summary>
private static MachineToolBuilder<MachineToolState> Builder(
MachineToolRuntimeFixture fixture, MachineToolNotificationOptions options)
{
return fixture.Context.AddMachineTool("Factory")
.WithProvider(new InMemoryMachineToolProvider(new MachineToolSnapshot()))
.WithIdentification(identity =>
{
identity.Manufacturer = new LocalizedText("Factory test");
identity.SerialNumber = "Factory";
identity.ProductInstanceUri = "urn:notifications:factory";
}).WithNotifications(options);
}
}
}