Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

274 lines
10 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using NUnit.Framework;
using Opc.Ua.Redundancy.Server;
using Opc.Ua.Tests;
namespace Opc.Ua.Server.Tests.Redundancy
{
/// <summary>
/// Unit tests for <see cref="NodeStateSerializer"/>.
/// </summary>
[TestFixture]
[Category("Distributed")]
[Parallelizable(ParallelScope.All)]
public class NodeStateSerializerTests
{
private const ushort NamespaceIndex = 1;
private SystemContext m_context = null!;
[OneTimeSetUp]
public void OneTimeSetUp()
{
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
var messageContext = ServiceMessageContext.CreateEmpty(telemetry);
messageContext.NamespaceUris.GetIndexOrAppend("urn:test:serializer");
m_context = new SystemContext(telemetry)
{
NamespaceUris = messageContext.NamespaceUris,
ServerUris = messageContext.ServerUris,
EncodeableFactory = messageContext.Factory
};
}
[Test]
public void ObjectRoundTripsAsBaseObjectState()
{
var original = new BaseObjectState(null)
{
NodeId = new NodeId("obj", NamespaceIndex),
BrowseName = new QualifiedName("Obj", NamespaceIndex),
DisplayName = new LocalizedText("Obj")
};
ByteString payload = NodeStateSerializer.Serialize(m_context, original);
NodeState restored = NodeStateSerializer.Deserialize(m_context, payload);
Assert.That(restored, Is.InstanceOf<BaseObjectState>());
Assert.That(restored.NodeClass, Is.EqualTo(NodeClass.Object));
Assert.That(restored.BrowseName, Is.EqualTo(original.BrowseName));
}
[Test]
public void VariableRoundTripsWithValue()
{
var original = new BaseDataVariableState(null)
{
NodeId = new NodeId("var", NamespaceIndex),
BrowseName = new QualifiedName("Var", NamespaceIndex),
DisplayName = new LocalizedText("Var"),
DataType = DataTypeIds.Double,
ValueRank = ValueRanks.Scalar,
Value = new Variant(2.5)
};
ByteString payload = NodeStateSerializer.Serialize(m_context, original);
NodeState restored = NodeStateSerializer.Deserialize(m_context, payload);
Assert.That(restored, Is.InstanceOf<BaseDataVariableState>());
Assert.That(restored.NodeClass, Is.EqualTo(NodeClass.Variable));
var variable = (BaseDataVariableState)restored;
Assert.That(variable.Value, Is.EqualTo(new Variant(2.5)));
Assert.That(variable.DataType, Is.EqualTo(DataTypeIds.Double));
}
[Test]
public void MethodRoundTripsAsMethodState()
{
var original = new MethodState(null)
{
NodeId = new NodeId("m", NamespaceIndex),
BrowseName = new QualifiedName("DoIt", NamespaceIndex),
DisplayName = new LocalizedText("DoIt"),
Executable = true,
UserExecutable = true
};
ByteString payload = NodeStateSerializer.Serialize(m_context, original);
NodeState restored = NodeStateSerializer.Deserialize(m_context, payload);
Assert.That(restored, Is.InstanceOf<MethodState>());
Assert.That(((MethodState)restored).Executable, Is.True);
}
[Test]
public void DeserializeTooShortPayloadThrows()
{
var tooShort = ByteString.From(new byte[] { 1, 2 });
Assert.That(
() => NodeStateSerializer.Deserialize(m_context, tooShort),
Throws.TypeOf<ServiceResultException>());
}
[Test]
public void SerializeThrowsOnNullContext()
{
var node = new BaseObjectState(null);
Assert.That(
() => NodeStateSerializer.Serialize(null!, node),
Throws.ArgumentNullException);
}
[Test]
public void SerializeThrowsOnNullNode()
{
Assert.That(
() => NodeStateSerializer.Serialize(m_context, null!),
Throws.ArgumentNullException);
}
[Test]
public void DeserializeThrowsOnNullContext()
{
var node = new BaseObjectState(null)
{
NodeId = new NodeId("obj", NamespaceIndex),
BrowseName = new QualifiedName("Obj", NamespaceIndex)
};
ByteString payload = NodeStateSerializer.Serialize(m_context, node);
Assert.That(
() => NodeStateSerializer.Deserialize(null!, payload),
Throws.ArgumentNullException);
}
[Test]
public void ViewRoundTripsAsViewState()
{
var original = new ViewState
{
NodeId = new NodeId("view", NamespaceIndex),
BrowseName = new QualifiedName("View", NamespaceIndex),
DisplayName = new LocalizedText("View"),
ContainsNoLoops = true
};
NodeState restored = RoundTrip(original);
Assert.That(restored, Is.InstanceOf<ViewState>());
Assert.That(restored.NodeClass, Is.EqualTo(NodeClass.View));
Assert.That(((ViewState)restored).ContainsNoLoops, Is.True);
}
[Test]
public void ObjectTypeRoundTripsAsBaseObjectTypeState()
{
var original = new BaseObjectTypeState
{
NodeId = new NodeId("otype", NamespaceIndex),
BrowseName = new QualifiedName("OType", NamespaceIndex),
DisplayName = new LocalizedText("OType"),
IsAbstract = true
};
NodeState restored = RoundTrip(original);
Assert.That(restored, Is.InstanceOf<BaseObjectTypeState>());
Assert.That(restored.NodeClass, Is.EqualTo(NodeClass.ObjectType));
Assert.That(((BaseObjectTypeState)restored).IsAbstract, Is.True);
}
[Test]
public void VariableTypeRoundTripsAsBaseDataVariableTypeState()
{
var original = new BaseDataVariableTypeState
{
NodeId = new NodeId("vtype", NamespaceIndex),
BrowseName = new QualifiedName("VType", NamespaceIndex),
DisplayName = new LocalizedText("VType"),
DataType = DataTypeIds.Int32,
ValueRank = ValueRanks.Scalar
};
NodeState restored = RoundTrip(original);
Assert.That(restored, Is.InstanceOf<BaseDataVariableTypeState>());
Assert.That(restored.NodeClass, Is.EqualTo(NodeClass.VariableType));
Assert.That(((BaseDataVariableTypeState)restored).DataType, Is.EqualTo(DataTypeIds.Int32));
}
[Test]
public void ReferenceTypeRoundTripsAsReferenceTypeState()
{
var original = new ReferenceTypeState
{
NodeId = new NodeId("rtype", NamespaceIndex),
BrowseName = new QualifiedName("RType", NamespaceIndex),
DisplayName = new LocalizedText("RType"),
InverseName = new LocalizedText("RTypeInverse"),
Symmetric = false
};
NodeState restored = RoundTrip(original);
Assert.That(restored, Is.InstanceOf<ReferenceTypeState>());
Assert.That(restored.NodeClass, Is.EqualTo(NodeClass.ReferenceType));
Assert.That(((ReferenceTypeState)restored).InverseName, Is.EqualTo(original.InverseName));
}
[Test]
public void DataTypeRoundTripsAsDataTypeState()
{
var original = new DataTypeState
{
NodeId = new NodeId("dtype", NamespaceIndex),
BrowseName = new QualifiedName("DType", NamespaceIndex),
DisplayName = new LocalizedText("DType"),
IsAbstract = true
};
NodeState restored = RoundTrip(original);
Assert.That(restored, Is.InstanceOf<DataTypeState>());
Assert.That(restored.NodeClass, Is.EqualTo(NodeClass.DataType));
Assert.That(((DataTypeState)restored).IsAbstract, Is.True);
}
[Test]
public void DeserializeUnknownNodeClassThrows()
{
// A framed payload whose header is a NodeClass value the reconstructor does not support.
var payload = ByteString.From(new byte[] { 3, 0, 0, 0 });
Assert.That(
() => NodeStateSerializer.Deserialize(m_context, payload),
Throws.TypeOf<ServiceResultException>());
}
private NodeState RoundTrip(NodeState original)
{
ByteString payload = NodeStateSerializer.Serialize(m_context, original);
return NodeStateSerializer.Deserialize(m_context, payload);
}
}
}