mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-17 05:11:13 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
207 lines
9.3 KiB
C#
207 lines
9.3 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Security.Certificates;
|
|
using Opc.Ua.Server.TestFramework;
|
|
|
|
namespace Opc.Ua.Server.Tests
|
|
{
|
|
/// <summary>
|
|
/// Verifies the client nonce sent with CreateSession on a None channel
|
|
/// reaches the session, so an enhanced user token signature over it verifies.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Session")]
|
|
public sealed class CreateSessionNoneChannelNonceTests
|
|
{
|
|
/// <summary>
|
|
/// A client signs an X509 user token for an enhanced token policy on a
|
|
/// None channel over ServerNonce | Hash(ServerCertificate) | ClientNonce.
|
|
/// StandardServer used to drop the client nonce on a None channel, so the
|
|
/// server verified over an empty nonce and every activation failed.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task EnhancedCertificateUserTokenOnNoneChannelVerifiesThroughCreateSessionAsync()
|
|
{
|
|
SecurityPolicyInfo? policy = SecurityPolicies.Default.GetInfo(SecurityPolicies.RSA_DH_AesGcm);
|
|
if (policy == null)
|
|
{
|
|
Assert.Ignore("The RSA_DH_AesGcm security policy is not supported on this platform.");
|
|
}
|
|
|
|
var fixture = new ServerFixture<StandardServer>(telemetry => new StandardServer(telemetry))
|
|
{
|
|
SecurityNone = true
|
|
};
|
|
try
|
|
{
|
|
StandardServer server = await fixture.StartAsync().ConfigureAwait(false);
|
|
EndpointDescription endpoint = server.GetEndpoints().Find(
|
|
candidate => candidate.SecurityPolicyUri == SecurityPolicies.None);
|
|
Assert.That(endpoint, Is.Not.Null);
|
|
endpoint = (EndpointDescription)endpoint.Clone();
|
|
endpoint.UserIdentityTokens =
|
|
[
|
|
new UserTokenPolicy
|
|
{
|
|
PolicyId = "certificate",
|
|
TokenType = UserTokenType.Certificate,
|
|
SecurityPolicyUri = SecurityPolicies.RSA_DH_AesGcm
|
|
}
|
|
];
|
|
var channel = new SecureChannelContext(
|
|
"none-nonce", endpoint, RequestEncoding.Binary, null, null);
|
|
ByteString clientNonce = Nonce.CreateRandomNonceData(32).ToByteString();
|
|
|
|
CreateSessionResponse response = await server.CreateSessionAsync(
|
|
channel, new RequestHeader(), null, null, null, "none-nonce",
|
|
clientNonce, default, 60000, 0, RequestLifetime.None).ConfigureAwait(false);
|
|
|
|
ISession session = server.CurrentInstance.SessionManager.GetSessions()[0];
|
|
Assert.That(session.ClientNonce, Is.EqualTo(clientNonce));
|
|
|
|
using CertificateCollection serverChain = Utils.ParseCertificateChainBlob(
|
|
response.ServerCertificate, server.CurrentInstance.Telemetry);
|
|
using Certificate userCertificate = CertificateBuilder.Create("CN=None Channel User")
|
|
.SetRSAKeySize(2048)
|
|
.CreateForRSA();
|
|
byte[] dataToSign = policy.GetUserTokenSignatureData(
|
|
null,
|
|
response.ServerNonce.ToArray(),
|
|
serverChain[0].RawData,
|
|
null,
|
|
userCertificate.RawData,
|
|
null,
|
|
clientNonce.ToArray(),
|
|
MessageSecurityMode.None);
|
|
SignatureData userSignature = await SecurityPolicies.Default.CreateSignatureDataAsync(
|
|
policy,
|
|
userCertificate,
|
|
dataToSign,
|
|
CancellationToken.None).ConfigureAwait(false);
|
|
var identity = new ExtensionObject(new X509IdentityToken
|
|
{
|
|
PolicyId = "certificate",
|
|
CertificateData = userCertificate.RawData.ToByteString()
|
|
});
|
|
using var context = new OperationContext(
|
|
new RequestHeader(),
|
|
channel,
|
|
RequestType.ActivateSession,
|
|
RequestLifetime.None);
|
|
|
|
(IUserIdentityTokenHandler? token, UserTokenPolicy? selected) =
|
|
await session.ValidateBeforeActivateAsync(
|
|
context, new SignatureData(), identity, userSignature, CancellationToken.None)
|
|
.ConfigureAwait(false);
|
|
|
|
Assert.That(token.TokenType, Is.EqualTo(UserTokenType.Certificate));
|
|
Assert.That(selected!.PolicyId, Is.EqualTo("certificate"));
|
|
}
|
|
finally
|
|
{
|
|
await fixture.StopAsync().ConfigureAwait(false);
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Part 4 5.7.2.3 (Table 16): a client nonce longer than 128 bytes is
|
|
/// rejected with Bad_NonceInvalid on every channel, including None,
|
|
/// instead of being dropped silently.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task OversizedClientNonceOnNoneChannelIsRejectedAsync()
|
|
{
|
|
var fixture = new ServerFixture<StandardServer>(telemetry => new StandardServer(telemetry))
|
|
{
|
|
SecurityNone = true
|
|
};
|
|
try
|
|
{
|
|
StandardServer server = await fixture.StartAsync().ConfigureAwait(false);
|
|
var channel = new SecureChannelContext(
|
|
"none-nonce-oversized", GetNoneEndpoint(server), RequestEncoding.Binary, null, null);
|
|
ByteString clientNonce = Nonce.CreateRandomNonceData(129).ToByteString();
|
|
|
|
ServiceResultException ex = Assert.ThrowsAsync<ServiceResultException>(
|
|
async () => await server.CreateSessionAsync(
|
|
channel, new RequestHeader(), null, null, null, "none-nonce-oversized",
|
|
clientNonce, default, 60000, 0, RequestLifetime.None).ConfigureAwait(false));
|
|
Assert.That(ex.StatusCode, Is.EqualTo(StatusCodes.BadNonceInvalid));
|
|
Assert.That(server.CurrentInstance.SessionManager.GetSessions(), Is.Empty);
|
|
}
|
|
finally
|
|
{
|
|
await fixture.StopAsync().ConfigureAwait(false);
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// A None channel does not require a client nonce: an empty one is
|
|
/// still accepted.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task EmptyClientNonceOnNoneChannelIsAcceptedAsync()
|
|
{
|
|
var fixture = new ServerFixture<StandardServer>(telemetry => new StandardServer(telemetry))
|
|
{
|
|
SecurityNone = true
|
|
};
|
|
try
|
|
{
|
|
StandardServer server = await fixture.StartAsync().ConfigureAwait(false);
|
|
var channel = new SecureChannelContext(
|
|
"none-nonce-empty", GetNoneEndpoint(server), RequestEncoding.Binary, null, null);
|
|
|
|
CreateSessionResponse response = await server.CreateSessionAsync(
|
|
channel, new RequestHeader(), null, null, null, "none-nonce-empty",
|
|
default, default, 60000, 0, RequestLifetime.None).ConfigureAwait(false);
|
|
|
|
Assert.That(response.SessionId.IsNull, Is.False);
|
|
Assert.That(server.CurrentInstance.SessionManager.GetSessions(), Has.Count.EqualTo(1));
|
|
}
|
|
finally
|
|
{
|
|
await fixture.StopAsync().ConfigureAwait(false);
|
|
}
|
|
}
|
|
|
|
private static EndpointDescription GetNoneEndpoint(StandardServer server)
|
|
{
|
|
EndpointDescription endpoint = server.GetEndpoints().Find(
|
|
candidate => candidate.SecurityPolicyUri == SecurityPolicies.None);
|
|
Assert.That(endpoint, Is.Not.Null);
|
|
return endpoint;
|
|
}
|
|
}
|
|
}
|