mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-28 22:55:49 +08:00
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
223 lines
9.1 KiB
C#
223 lines
9.1 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Server.Fluent;
|
|
|
|
#pragma warning disable CA2000
|
|
|
|
namespace Opc.Ua.Server.Tests.Fluent
|
|
{
|
|
/// <summary>
|
|
/// Tests for <see cref="EngineeringUnitsBuilderExtensions"/> — the
|
|
/// fluent <c>WithEngineeringUnits</c> / <c>WithEURange</c> /
|
|
/// <c>WithUnits</c> helpers on <see cref="IVariableBuilder{TValue}"/>.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Fluent")]
|
|
public class EngineeringUnitsBuilderExtensionsTests
|
|
{
|
|
private const ushort kNs = 2;
|
|
|
|
private static SystemContext CreateContext()
|
|
{
|
|
var ns = new NamespaceTable();
|
|
ns.Append(Ua.Namespaces.OpcUa);
|
|
return new SystemContext(telemetry: null!)
|
|
{
|
|
NamespaceUris = ns
|
|
};
|
|
}
|
|
|
|
private static (NodeManagerBuilder Builder, BaseObjectState Root,
|
|
AnalogItemState<double> AnalogVar, BaseDataVariableState NonAnalogVar)
|
|
CreateBuilderWithAnalog()
|
|
{
|
|
SystemContext ctx = CreateContext();
|
|
|
|
var root = new BaseObjectState(parent: null)
|
|
{
|
|
NodeId = new NodeId("Root", kNs),
|
|
BrowseName = new QualifiedName("Root", kNs),
|
|
DisplayName = new LocalizedText("Root")
|
|
};
|
|
|
|
var analog = AnalogItemState<double>.With<VariantBuilder>(root);
|
|
analog.NodeId = new NodeId("Root.Temp", kNs);
|
|
analog.BrowseName = new QualifiedName("Temp", kNs);
|
|
analog.DisplayName = new LocalizedText("Temp");
|
|
analog.DataType = DataTypeIds.Double;
|
|
analog.ValueRank = ValueRanks.Scalar;
|
|
root.AddChild(analog);
|
|
|
|
var nonAnalog = new BaseDataVariableState(root)
|
|
{
|
|
NodeId = new NodeId("Root.PlainVar", kNs),
|
|
BrowseName = new QualifiedName("PlainVar", kNs),
|
|
DisplayName = new LocalizedText("PlainVar"),
|
|
DataType = DataTypeIds.Int32,
|
|
ValueRank = ValueRanks.Scalar
|
|
};
|
|
root.AddChild(nonAnalog);
|
|
|
|
var roots = new Dictionary<QualifiedName, NodeState> { [root.BrowseName] = root };
|
|
var byId = new Dictionary<NodeId, NodeState>
|
|
{
|
|
[root.NodeId] = root,
|
|
[analog.NodeId] = analog,
|
|
[nonAnalog.NodeId] = nonAnalog
|
|
};
|
|
|
|
var builder = new NodeManagerBuilder(
|
|
ctx,
|
|
nodeManager: FluentTestNodeManager.Create(kNs),
|
|
defaultNamespaceIndex: kNs,
|
|
rootResolver: q => roots.TryGetValue(q, out NodeState? n) ? n! : null!,
|
|
nodeIdResolver: id => byId.TryGetValue(id, out NodeState? n) ? n! : null!,
|
|
typeIdResolver: _ => []);
|
|
|
|
return (builder, root, analog, nonAnalog);
|
|
}
|
|
|
|
[Test]
|
|
public void WithEngineeringUnitsSetsValueOnAnalogVariable()
|
|
{
|
|
(NodeManagerBuilder b, _, AnalogItemState<double> analog, _) = CreateBuilderWithAnalog();
|
|
IVariableBuilder<double> vb = b.Variable<double>(new NodeId("Root.Temp", kNs));
|
|
|
|
var units = new EUInformation("K", "Kelvin", "http://www.opcfoundation.org/UA/units/un/cefact");
|
|
IVariableBuilder<double> chain = vb.WithEngineeringUnits(units);
|
|
|
|
Assert.That(chain, Is.SameAs(vb), "Builder is returned for chaining.");
|
|
Assert.That(analog.EngineeringUnits, Is.Not.Null,
|
|
"EngineeringUnits property must be created on demand.");
|
|
Assert.That(analog.EngineeringUnits!.Value, Is.SameAs(units));
|
|
}
|
|
|
|
[Test]
|
|
public void WithEURangeSetsRangeOnAnalogVariable()
|
|
{
|
|
(NodeManagerBuilder b, _, AnalogItemState<double> analog, _) = CreateBuilderWithAnalog();
|
|
IVariableBuilder<double> vb = b.Variable<double>(new NodeId("Root.Temp", kNs));
|
|
|
|
vb.WithEURange(min: 233.15, max: 473.15);
|
|
|
|
Assert.That(analog.EURange, Is.Not.Null);
|
|
Assert.That(analog.EURange!.Value, Is.Not.Null);
|
|
Assert.That(analog.EURange.Value.Low, Is.EqualTo(233.15));
|
|
Assert.That(analog.EURange.Value.High, Is.EqualTo(473.15));
|
|
}
|
|
|
|
[Test]
|
|
public void WithUnitsAppliesBoth()
|
|
{
|
|
(NodeManagerBuilder b, _, AnalogItemState<double> analog, _) = CreateBuilderWithAnalog();
|
|
IVariableBuilder<double> vb = b.Variable<double>(new NodeId("Root.Temp", kNs));
|
|
|
|
var units = new EUInformation("Pa", "Pascal", "ns");
|
|
vb.WithUnits(units, min: 0, max: 1_000_000);
|
|
|
|
Assert.That(analog.EngineeringUnits!.Value, Is.SameAs(units));
|
|
Assert.That(analog.EURange!.Value.Low, Is.Zero);
|
|
Assert.That(analog.EURange.Value.High, Is.EqualTo(1_000_000));
|
|
}
|
|
|
|
[Test]
|
|
public void WithEngineeringUnitsOnNonAnalogThrowsBadTypeMismatch()
|
|
{
|
|
(NodeManagerBuilder b, _, _, _) = CreateBuilderWithAnalog();
|
|
IVariableBuilder<int> vb = b.Variable<int>(new NodeId("Root.PlainVar", kNs));
|
|
|
|
var units = new EUInformation("K", "Kelvin", "ns");
|
|
ServiceResultException ex = Assert.Throws<ServiceResultException>(
|
|
() => vb.WithEngineeringUnits(units));
|
|
Assert.That(ex!.StatusCode, Is.EqualTo((uint)StatusCodes.BadTypeMismatch));
|
|
}
|
|
|
|
[Test]
|
|
public void WithEURangeOnNonAnalogThrowsBadTypeMismatch()
|
|
{
|
|
(NodeManagerBuilder b, _, _, _) = CreateBuilderWithAnalog();
|
|
IVariableBuilder<int> vb = b.Variable<int>(new NodeId("Root.PlainVar", kNs));
|
|
|
|
ServiceResultException ex = Assert.Throws<ServiceResultException>(
|
|
() => vb.WithEURange(0, 100));
|
|
Assert.That(ex!.StatusCode, Is.EqualTo((uint)StatusCodes.BadTypeMismatch));
|
|
}
|
|
|
|
[Test]
|
|
public void WithEURangeMinGreaterThanMaxThrowsArgumentException()
|
|
{
|
|
(NodeManagerBuilder b, _, _, _) = CreateBuilderWithAnalog();
|
|
IVariableBuilder<double> vb = b.Variable<double>(new NodeId("Root.Temp", kNs));
|
|
|
|
Assert.Throws<ArgumentException>(() => vb.WithEURange(min: 100, max: 0));
|
|
}
|
|
|
|
[Test]
|
|
public void WithEngineeringUnitsNullUnitsThrowsArgumentNullException()
|
|
{
|
|
(NodeManagerBuilder b, _, _, _) = CreateBuilderWithAnalog();
|
|
IVariableBuilder<double> vb = b.Variable<double>(new NodeId("Root.Temp", kNs));
|
|
|
|
Assert.Throws<ArgumentNullException>(
|
|
() => vb.WithEngineeringUnits(null!));
|
|
}
|
|
|
|
[Test]
|
|
public void WithEngineeringUnitsOnNullBuilderThrowsArgumentNullException()
|
|
{
|
|
IVariableBuilder<double> vb = null!;
|
|
var units = new EUInformation("K", "Kelvin", "ns");
|
|
Assert.Throws<ArgumentNullException>(() => vb.WithEngineeringUnits(units));
|
|
}
|
|
|
|
[Test]
|
|
public void WithEngineeringUnitsCalledTwiceReusesProperty()
|
|
{
|
|
(NodeManagerBuilder b, _, AnalogItemState<double> analog, _) = CreateBuilderWithAnalog();
|
|
IVariableBuilder<double> vb = b.Variable<double>(new NodeId("Root.Temp", kNs));
|
|
|
|
var unitsA = new EUInformation("K", "Kelvin", "ns");
|
|
var unitsB = new EUInformation("Pa", "Pascal", "ns");
|
|
|
|
vb.WithEngineeringUnits(unitsA);
|
|
PropertyState<EUInformation>? first = analog.EngineeringUnits;
|
|
vb.WithEngineeringUnits(unitsB);
|
|
|
|
Assert.That(analog.EngineeringUnits, Is.SameAs(first),
|
|
"EngineeringUnits property must not be replaced on a second call.");
|
|
Assert.That(analog.EngineeringUnits!.Value, Is.SameAs(unitsB));
|
|
}
|
|
}
|
|
}
|