mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-19 07:02:16 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
224 lines
9.1 KiB
C#
224 lines
9.1 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System.Collections.Generic;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
|
|
namespace Opc.Ua.Server.Tests.NodeManager
|
|
{
|
|
/// <summary>
|
|
/// Verifies that deleting a sampling-group monitored item does not release a component-cache
|
|
/// reference that the item never took.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("NodeManager")]
|
|
[Category("SamplingGroup")]
|
|
public sealed class SamplingGroupComponentCacheRegressionTests
|
|
{
|
|
/// <summary>
|
|
/// Verifies the synchronous node manager keeps a foreign cache reference after a delete.
|
|
/// </summary>
|
|
[Test]
|
|
public void DeletingSampledItemKeepsForeignComponentCacheReference()
|
|
{
|
|
Mock<IServerInternal> server = DeterministicServerMock.Create(out MonitoredItemQueueFactory queues);
|
|
using (queues)
|
|
using (var manager = new SyncHooks(server.Object))
|
|
{
|
|
manager.HoldCacheReference();
|
|
IMonitoredItem item = manager.Create();
|
|
Assert.That(item, Is.Not.Null);
|
|
|
|
manager.Delete(item);
|
|
|
|
Assert.That(manager.CachedNode, Is.Not.Null, "the delete released a reference it never took");
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies the asynchronous node manager keeps a foreign cache reference after a delete.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task DeletingSampledItemKeepsForeignComponentCacheReferenceAsync()
|
|
{
|
|
Mock<IServerInternal> server = DeterministicServerMock.Create(out MonitoredItemQueueFactory queues);
|
|
using (queues)
|
|
using (var manager = new AsyncHooks(server.Object))
|
|
{
|
|
await manager.InitializeAsync().ConfigureAwait(false);
|
|
manager.HoldCacheReference();
|
|
IMonitoredItem item = await manager.CreateAsync().ConfigureAwait(false);
|
|
Assert.That(item, Is.Not.Null);
|
|
|
|
await manager.DeleteAsync(item).ConfigureAwait(false);
|
|
|
|
Assert.That(manager.CachedNode, Is.Not.Null, "the delete released a reference it never took");
|
|
}
|
|
}
|
|
|
|
private static OperationContext NewContext(RequestType requestType)
|
|
{
|
|
return new OperationContext(new RequestHeader(), null, requestType, RequestLifetime.None);
|
|
}
|
|
|
|
private static MonitoredItemCreateRequest NewRequest(NodeId nodeId)
|
|
{
|
|
return new MonitoredItemCreateRequest
|
|
{
|
|
ItemToMonitor = new ReadValueId { NodeId = nodeId, AttributeId = Attributes.Value },
|
|
MonitoringMode = MonitoringMode.Disabled,
|
|
RequestedParameters = new MonitoringParameters
|
|
{
|
|
SamplingInterval = 1000,
|
|
QueueSize = 1,
|
|
DiscardOldest = true
|
|
}
|
|
};
|
|
}
|
|
|
|
private static BaseDataVariableState NewVariable(ushort namespaceIndex)
|
|
{
|
|
return new BaseDataVariableState(null)
|
|
{
|
|
NodeId = new NodeId(1, namespaceIndex),
|
|
DataType = DataTypeIds.Int32,
|
|
Value = 1,
|
|
AccessLevel = AccessLevels.CurrentRead,
|
|
UserAccessLevel = AccessLevels.CurrentRead
|
|
};
|
|
}
|
|
|
|
private sealed class SyncHooks : CustomNodeManager2
|
|
{
|
|
public SyncHooks(IServerInternal server)
|
|
: base(
|
|
server,
|
|
new ApplicationConfiguration { ServerConfiguration = new ServerConfiguration() },
|
|
true,
|
|
NullLogger.Instance,
|
|
"urn:tests:sampling-cache-sync")
|
|
{
|
|
m_node = NewVariable(NamespaceIndex);
|
|
AddPredefinedNode(SystemContext, m_node);
|
|
}
|
|
|
|
public NodeState CachedNode => LookupNodeInComponentCache(SystemContext, Handle())!;
|
|
|
|
public void HoldCacheReference()
|
|
{
|
|
AddNodeToComponentCache(SystemContext, Handle(), m_node);
|
|
}
|
|
|
|
public IMonitoredItem Create()
|
|
{
|
|
using OperationContext context = NewContext(RequestType.CreateMonitoredItems);
|
|
var errors = new List<ServiceResult> { null! };
|
|
var filterErrors = new List<MonitoringFilterResult> { null! };
|
|
var items = new List<IMonitoredItem> { null! };
|
|
CreateMonitoredItems(
|
|
context, 1, 1000, TimestampsToReturn.Both, [NewRequest(m_node.NodeId)],
|
|
errors, filterErrors, items, false, new MonitoredItemIdFactory());
|
|
return (ServiceResult.IsGood(errors[0]) ? items[0] : null)!;
|
|
}
|
|
|
|
public void Delete(IMonitoredItem item)
|
|
{
|
|
using OperationContext context = NewContext(RequestType.DeleteMonitoredItems);
|
|
var errors = new List<ServiceResult> { null! };
|
|
DeleteMonitoredItems(context, [item], new List<bool> { false }, errors);
|
|
Assert.That(ServiceResult.IsGood(errors[0]), Is.True);
|
|
}
|
|
|
|
private NodeHandle Handle()
|
|
{
|
|
return new NodeHandle { NodeId = m_node.NodeId, Node = m_node, Validated = true };
|
|
}
|
|
|
|
private readonly BaseDataVariableState m_node;
|
|
}
|
|
|
|
private sealed class AsyncHooks : AsyncCustomNodeManager
|
|
{
|
|
public AsyncHooks(IServerInternal server)
|
|
: base(
|
|
server,
|
|
new ApplicationConfiguration { ServerConfiguration = new ServerConfiguration() },
|
|
true,
|
|
NullLogger.Instance,
|
|
"urn:tests:sampling-cache-async")
|
|
{
|
|
m_node = NewVariable(NamespaceIndex);
|
|
}
|
|
|
|
public NodeState CachedNode => LookupNodeInComponentCache(SystemContext, Handle())!;
|
|
|
|
public ValueTask InitializeAsync()
|
|
{
|
|
return AddPredefinedNodeAsync(SystemContext, m_node);
|
|
}
|
|
|
|
public void HoldCacheReference()
|
|
{
|
|
AddNodeToComponentCache(SystemContext, Handle(), m_node);
|
|
}
|
|
|
|
public async Task<IMonitoredItem> CreateAsync()
|
|
{
|
|
using OperationContext context = NewContext(RequestType.CreateMonitoredItems);
|
|
var errors = new List<ServiceResult> { null! };
|
|
var filterErrors = new List<MonitoringFilterResult> { null! };
|
|
var items = new List<IMonitoredItem> { null! };
|
|
await CreateMonitoredItemsAsync(
|
|
context, 1, 1000, TimestampsToReturn.Both, [NewRequest(m_node.NodeId)],
|
|
errors, filterErrors, items, false, new MonitoredItemIdFactory()).ConfigureAwait(false);
|
|
return (ServiceResult.IsGood(errors[0]) ? items[0] : null)!;
|
|
}
|
|
|
|
public async Task DeleteAsync(IMonitoredItem item)
|
|
{
|
|
using OperationContext context = NewContext(RequestType.DeleteMonitoredItems);
|
|
var errors = new List<ServiceResult> { null! };
|
|
await DeleteMonitoredItemsAsync(context, [item], new List<bool> { false }, errors)
|
|
.ConfigureAwait(false);
|
|
Assert.That(ServiceResult.IsGood(errors[0]), Is.True);
|
|
}
|
|
|
|
private NodeHandle Handle()
|
|
{
|
|
return new NodeHandle { NodeId = m_node.NodeId, Node = m_node, Validated = true };
|
|
}
|
|
|
|
private readonly BaseDataVariableState m_node;
|
|
}
|
|
}
|
|
}
|