mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-19 07:02:16 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
290 lines
10 KiB
C#
290 lines
10 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Server.Tests
|
|
{
|
|
/// <summary>
|
|
/// Additional coverage-oriented tests for <see cref="SessionManager"/> targeting
|
|
/// constructor guards, session lookup, event accessors, event raising and
|
|
/// lockout maintenance that are not exercised by the higher-level fixtures.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Session")]
|
|
[Parallelizable]
|
|
public class SessionManagerCoverageTests
|
|
{
|
|
private Mock<IServerInternal> m_serverMock = null!;
|
|
private ITelemetryContext m_telemetry = null!;
|
|
private ApplicationConfiguration m_config = null!;
|
|
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
m_telemetry = NUnitTelemetryContext.Create();
|
|
m_serverMock = new Mock<IServerInternal>();
|
|
m_serverMock.Setup(s => s.Telemetry).Returns(m_telemetry);
|
|
m_serverMock.Setup(s => s.NamespaceUris).Returns(new NamespaceTable());
|
|
|
|
m_config = new ApplicationConfiguration
|
|
{
|
|
ServerConfiguration = new ServerConfiguration
|
|
{
|
|
MinSessionTimeout = 1000,
|
|
MaxSessionTimeout = 3_600_000,
|
|
MaxSessionCount = 100,
|
|
MaxRequestAge = 60_000,
|
|
MaxBrowseContinuationPoints = 10,
|
|
MaxHistoryContinuationPoints = 10
|
|
}
|
|
};
|
|
}
|
|
|
|
private CoverageSessionManager CreateManager()
|
|
{
|
|
return new CoverageSessionManager(m_serverMock.Object, m_config);
|
|
}
|
|
|
|
[Test]
|
|
public void ConstructorWithNullConfigurationThrows()
|
|
{
|
|
Assert.That(
|
|
() => new SessionManager(m_serverMock.Object, null!),
|
|
Throws.TypeOf<ArgumentNullException>());
|
|
}
|
|
|
|
[Test]
|
|
public void ConstructorWithNullServerThrows()
|
|
{
|
|
Assert.That(
|
|
() => new SessionManager(null!, m_config),
|
|
Throws.TypeOf<ArgumentNullException>());
|
|
}
|
|
|
|
[Test]
|
|
public void GetSessionWithUnknownTokenReturnsNull()
|
|
{
|
|
using CoverageSessionManager manager = CreateManager();
|
|
|
|
ISession? session = manager.GetSession(new NodeId(Guid.NewGuid()));
|
|
|
|
Assert.That(session, Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void GetSessionsWhenEmptyReturnsEmptyList()
|
|
{
|
|
using CoverageSessionManager manager = CreateManager();
|
|
|
|
Assert.That(manager.GetSessions(), Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public void RaiseSessionDiagnosticsChangedEventWithNullSessionThrows()
|
|
{
|
|
using CoverageSessionManager manager = CreateManager();
|
|
|
|
Assert.That(
|
|
() => manager.RaiseSessionDiagnosticsChangedEvent(null!),
|
|
Throws.TypeOf<ArgumentNullException>());
|
|
}
|
|
|
|
[Test]
|
|
public void ClearAuthenticationLockoutsDoesNotThrow()
|
|
{
|
|
using CoverageSessionManager manager = CreateManager();
|
|
|
|
Assert.That(manager.ClearAuthenticationLockouts, Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ValidateSessionLessRequestEventCanBeSubscribedAndRemoved()
|
|
{
|
|
using CoverageSessionManager manager = CreateManager();
|
|
static void Handler(object? sender, ValidateSessionLessRequestEventArgs e)
|
|
{
|
|
}
|
|
|
|
Assert.That(
|
|
() =>
|
|
{
|
|
manager.ValidateSessionLessRequest += Handler;
|
|
manager.ValidateSessionLessRequest -= Handler;
|
|
},
|
|
Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void ImpersonateUserEventCanBeSubscribedAndRemoved()
|
|
{
|
|
using CoverageSessionManager manager = CreateManager();
|
|
static void Handler(ISession session, ImpersonateEventArgs e)
|
|
{
|
|
}
|
|
|
|
#pragma warning disable CS0618 // Type or member is obsolete
|
|
Assert.That(
|
|
() =>
|
|
{
|
|
manager.ImpersonateUser += Handler;
|
|
manager.ImpersonateUser -= Handler;
|
|
},
|
|
Throws.Nothing);
|
|
#pragma warning restore CS0618
|
|
}
|
|
|
|
[TestCase(SessionEventReason.Created)]
|
|
[TestCase(SessionEventReason.Activated)]
|
|
[TestCase(SessionEventReason.Closing)]
|
|
[TestCase(SessionEventReason.DiagnosticsChanged)]
|
|
[TestCase(SessionEventReason.ChannelKeepAlive)]
|
|
public void SubscribedEventHandlerIsInvokedOnMatchingReason(SessionEventReason reason)
|
|
{
|
|
using CoverageSessionManager manager = CreateManager();
|
|
var session = new Mock<ISession>();
|
|
|
|
ISession? received = null;
|
|
SessionEventReason? receivedReason = null;
|
|
void Handler(ISession s, SessionEventReason r)
|
|
{
|
|
received = s;
|
|
receivedReason = r;
|
|
}
|
|
|
|
manager.Subscribe(reason, Handler);
|
|
manager.PublicRaiseSessionEvent(session.Object, reason);
|
|
|
|
Assert.That(received, Is.SameAs(session.Object));
|
|
Assert.That(receivedReason, Is.EqualTo(reason));
|
|
|
|
// Unsubscribing must stop further callbacks.
|
|
received = null;
|
|
manager.Unsubscribe(reason, Handler);
|
|
manager.PublicRaiseSessionEvent(session.Object, reason);
|
|
Assert.That(received, Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void RaiseSessionEventSwallowsHandlerException()
|
|
{
|
|
using CoverageSessionManager manager = CreateManager();
|
|
var session = new Mock<ISession>();
|
|
|
|
manager.SessionDiagnosticsChanged += (_, _) => throw new InvalidOperationException("boom");
|
|
|
|
Assert.That(
|
|
() => manager.RaiseSessionDiagnosticsChangedEvent(session.Object),
|
|
Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void RaiseSessionEventWithImpersonatingReasonDoesNotThrow()
|
|
{
|
|
using CoverageSessionManager manager = CreateManager();
|
|
var session = new Mock<ISession>();
|
|
|
|
Assert.That(
|
|
() => manager.PublicRaiseSessionEvent(session.Object, SessionEventReason.Impersonating),
|
|
Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public void RaiseSessionEventWithUnknownReasonThrows()
|
|
{
|
|
using CoverageSessionManager manager = CreateManager();
|
|
var session = new Mock<ISession>();
|
|
|
|
Assert.That(
|
|
() => manager.PublicRaiseSessionEvent(session.Object, (SessionEventReason)999),
|
|
Throws.TypeOf<ServiceResultException>());
|
|
}
|
|
|
|
private sealed class CoverageSessionManager : SessionManager
|
|
{
|
|
public CoverageSessionManager(IServerInternal server, ApplicationConfiguration config)
|
|
: base(server, config)
|
|
{
|
|
}
|
|
|
|
public void PublicRaiseSessionEvent(ISession session, SessionEventReason reason)
|
|
{
|
|
RaiseSessionEvent(session, reason);
|
|
}
|
|
|
|
public void Subscribe(SessionEventReason reason, SessionEventHandler handler)
|
|
{
|
|
switch (reason)
|
|
{
|
|
case SessionEventReason.Created:
|
|
SessionCreated += handler;
|
|
break;
|
|
case SessionEventReason.Activated:
|
|
SessionActivated += handler;
|
|
break;
|
|
case SessionEventReason.Closing:
|
|
SessionClosing += handler;
|
|
break;
|
|
case SessionEventReason.DiagnosticsChanged:
|
|
SessionDiagnosticsChanged += handler;
|
|
break;
|
|
case SessionEventReason.ChannelKeepAlive:
|
|
SessionChannelKeepAlive += handler;
|
|
break;
|
|
}
|
|
}
|
|
|
|
public void Unsubscribe(SessionEventReason reason, SessionEventHandler handler)
|
|
{
|
|
switch (reason)
|
|
{
|
|
case SessionEventReason.Created:
|
|
SessionCreated -= handler;
|
|
break;
|
|
case SessionEventReason.Activated:
|
|
SessionActivated -= handler;
|
|
break;
|
|
case SessionEventReason.Closing:
|
|
SessionClosing -= handler;
|
|
break;
|
|
case SessionEventReason.DiagnosticsChanged:
|
|
SessionDiagnosticsChanged -= handler;
|
|
break;
|
|
case SessionEventReason.ChannelKeepAlive:
|
|
SessionChannelKeepAlive -= handler;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|