mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-18 06:31:35 +08:00
442889cba5
# Description
This PR fixes a bug audit of the source generation projects
(`tools/Opc.Ua.SourceGeneration*`: model loading, NodeSet import, all
emitters, the Roslyn hosts and packaging). It also fixes a max-effort
code review of those fixes, and a check of every spec-relevant change
against the OPC UA 1.05 text.
- **Scope:** about 85 audit findings, 48 review findings and 32
spec-grounding items were addressed. Each fix has a regression test that
fails without it.
- **Wire change:** it includes one deliberate, stack-wide wire change:
**structure-field matrices now follow OPC 10000-6 5.2.5 Table 28**.
Most changes are internal correctness fixes. The sections below list
every change a user can observe: wire formats, generated code and API,
generated address-space content, diagnostics and runtime behaviour.
## Behaviour / user-facing changes
### Wire format (encoders)
- **Binary inline matrices** (OPC 10000-6 5.2.5 Table 28).
- **Layout:** a multi-dimensional *structure field* is encoded as
`Int32[] Dimensions`, then the values **without a length prefix**, with
at least 2 dimensions.
- **Empty and null:** any dimension <= 0 means no values follow, and a
null matrix is `-1`. An empty matrix is written as `[0,0]`.
- **Compatibility:** this is **not compatible with earlier builds of
this SDK** for matrix fields. It applies to generated types,
`[DataType]` types, `Structure`, client ComplexTypes and
`WriteEncodeableMatrix`.
- **Unchanged:** Variant matrices (5.2.2.16) keep their old encoding.
- **Declared rank decides matrix vs array.** A 1-D `MatrixOf<T>` in an
array field or a Variable value is written as an array again.
Matrix-declared fields go through the new public
`EncoderExtensions.WriteInlineMatrixValue`, which generated code also
uses. A non-empty 1-D value in a matrix field throws `BadEncodingError`.
- **Decoder hardening:**
- Before allocating, the decoder bounds all matrix dimensions against
overflow, `MaxArrayLength` and the remaining message length.
- The decoder rejects:
- a matrix with fewer than 2 dimensions;
- a populated matrix whose rank differs from the field's declared rank;
- a union SwitchField greater than the number of fields;
- an EncodingMask with unassigned bits set.
- **Encoder `MaxArrayLength`:** the encoder enforces `MaxArrayLength`
for inline matrices, as it already did for arrays.
- **XML structure fields** (5.3.1, 5.3.4, 5.3.5).
- **Fields:** `Structure` and client ComplexTypes write fields like
typed fields (`<A>1</A>`, array elements directly) instead of a Variant
body.
- **Matrix fields:** `Dimensions` and `Elements` go directly inside the
field element, with no `<Matrix>` wrapper.
- **Empty matrices:** written as nil, because XML dimensions must be
greater than 0.
- **Compatibility:** decoders still accept the old shapes.
- **Enum fixes:** enum array elements with value 0 are no longer
dropped, and enum array element names are fixed.
- **Other encoding fixes:**
- A null `DiagnosticInfo` structure field writes `0x00` instead of
nothing.
- A null scalar field in a runtime `Structure` is written as its default
instead of zero bytes, which used to shift every following field.
- A Variant holding an empty matrix encodes as an empty array instead of
throwing.
- `Variant.Copy` keeps the matrix identity of null and empty matrices.
- **NodeSet export and the DataContract surrogate** write Variable
values with the Variant rules again. A null or empty `MatrixOf` variable
no longer produces invalid XML or unreadable NodeSets.
- **`JsonEncoder.CanOmitFields`** is `true` only for Compact encoding.
Verbose and RawData JSON include default-valued fields.
### `[DataType]` source-generated types
- **Default-value handling** (OPC 10000-6 5.4.1, Table 1).
- **Encode:** a field is omitted only when its value *and* its declared
default are the type's default (0, false, null). Fields with a
non-default initializer or constructor default, and empty strings, are
always written, so configuration files get slightly larger.
- **JSON decode:** a field missing from JSON decodes to the type
default.
- **XML decode:** a field missing from XML keeps its declared default,
which older configuration files rely on.
- **Why:** this fixes silent round-trip loss, for example
`SamplingInterval = 0` read back as `-1`.
- **Nested `[DataType]` types:** they are now generated inside their
containing types. Without an explicit id, their default TypeId and
XmlName are qualified (e.g. `s=Outer.Foo`); **wire identity change** for
nested types. Colliding activator names get a `_2` suffix.
- **Activators:** they are `internal` when the type, or any containing
type, is not public (was CS0060).
- **Matrix properties:**
- `MatrixOf<T>` properties use the inline matrix encoding.
- Matrices of non-sealed structures, or with
`StructureHandling.ExtensionObject`, are written as ExtensionObjects.
- Their published ValueRank is 2, because the rank can't be known from
`MatrixOf<T>`.
- **Published StructureDefinitions:**
- They include base-class fields.
- Nullable properties are no longer marked optional.
- Inline structure fields name their concrete type.
- **`[Flags]` enums:** they are published as plain enumerations with
their member values, which matches how they are encoded.
- **Other generated code:**
- `Clone` deep-copies arrays and matrices of structures, Variants,
ExtensionObjects and DataValues.
- `IsEqual` and `GetHashCode` are consistent: EncodingMask, active union
member and NaN handling agree.
- Pooled `Reuse()` restores the freshly constructed state through the
new `protected virtual ResetForReuse()`, and returns an instance to its
runtime type's pool.
- **Enum capture:** enum member values are captured culture-invariantly.
Negative values were lost on cultures that use U+2212 as the minus sign.
### Model-driven generator: generated code, API and file names
- **Removed API:** generated `*_Placeholder` proxy accessors (e.g.
`PowerTrainTypeClient.GetMotorIdentifier_PlaceholderAsync`) and fluent
`X_Placeholder()` accessors are removed; they could never resolve
anything.
- Proxy accessors now look children up by BrowseName with the right
namespace.
- `RoboticsClient` finds motors and gears by type and drives via
`IsDrivenBy`. Its topology snapshots used to be empty.
- **Renamed files:** generated files for a bound `[NodeManager]` are now
named `{Namespace}.{Class}.NodeManager.g.cs` (also `.Factory` and
`.FluentBuilders`).
- **Generated NodeState code:**
- Attributes are set through `baseState`/`nodeState` locals, so children
named like base attributes (e.g. `DataType`, `EventNotifier`) compile.
- Children that hide base members are declared `public new`, using names
reflected from the runtime.
- `global::` qualification is used throughout.
- **Proxies and fluent builders:** a proxy whose supertype is excluded
(e.g. Draft) derives from the nearest emitted ancestor. Fluent wrappers
and NodeState factories fall back the same way; they used to fail with
CS0246.
- **Derived structures:**
- The optional-field `EncodingMask` continues across inheritance.
- A derived structure over a base type from another model no longer
relies on `base.ResetForReuse`.
- **Default values:**
- NodeId, QualifiedName and ExpandedNodeId defaults resolve by namespace
URI (`context.NamespaceUris.GetIndexOrAppend`) and server URI.
- StatusCode, negative enum, `double`/`float` (shortest round-trip
literal) and escaped string defaults now compile.
- **Event records:**
- Vendor event records have `Decoder.GetStandardFields(NamespaceTable)`,
and their browse paths use the model's namespace.
- A field whose namespace is unknown to the session no longer matches a
namespace-0 field.
- Companion `StandardFields` is `[Obsolete]`.
- Vendor simple subtypes such as `Percent : Double` map to their
built-in type.
- **Other fixes:**
- `MethodState.CallAsync` passes the real `objectId` to synchronous
`OnCallMethod2` handlers; it used to pass `NodeId.Null`.
- Enumeration fields with an explicit `Identifier` keep it, instead of
taking a trailing `_<digits>`.
- Explicit NumericIds are no longer reused by automatic numbering.
- Dependencies are loaded in topological order.
### Generated address-space content
- **Arguments:**
- Methods without arguments no longer get empty
`InputArguments`/`OutputArguments` properties (OPC 10000-3 5.7).
- About 2,660 automatically assigned namespace-0 NodeIds of 15000 and
above shift. Every NodeId in `StandardTypes.csv` is unchanged.
- **Permissions:** type nodes and method declarations on types now carry
the model's `RolePermissions`/`AccessRestrictions`.
- **Restored nodes:** NodeSet import keeps nodes that were silently
dropped before:
- `NamespaceMetadata` objects and the NodeSet's own TypeDictionary
variables;
- ISA95 placeholders linked only non-hierarchically;
- instances whose parent is in another namespace.
- **Import details:**
- ValueRank > 1 without ArrayDimensions keeps its rank.
- `svr=` indexes map correctly.
- Invalid MinimumSamplingInterval values import as -1, not 0.
- Localized texts prefer the invariant or English translation.
- **StructureDefinitions:**
- They include inherited fields, including for subtypes without their
own fields (e.g. `AnonymousIdentityToken` now publishes PolicyId).
- The StructureType kind covers inherited AllowSubTypes fields.
- Unions ignore IsOptional.
- StructureFields never publish ValueRank 0; a OneOrMoreDimensions field
without dimensions becomes rank 2.
- Fields with ValueRank -2/-3 are published as scalar BaseDataType,
which is what is on the wire.
- **OptionSets:**
- Implicit fields get the next free bit.
- `OptionSetValues` uses null for undefined bits instead of "Reserved",
and structure OptionSets publish all their bits (no 32/96-bit cap).
- Numeric OptionSets are limited to their base type's width, and UInt64
bit 63 works.
- **Schemas:**
- Structures with inline-matrix fields are left out of the `.bsd`
(5.2.5).
- In the BSD, Variant-encoded and non-structure subtyped fields are
described as `ua:Variant`.
- In the `.xsd`, matrix fields are typed `ua:Matrix` with
`Dimensions`/`Elements`, and `EncodingMask` is required.
### NodeSet / model input handling
- **Model selection:**
- The newest NodeSet of a model is chosen by `ModelVersion` (SemVer 2.0
precedence), then PublicationDate. The `Version` attribute, which Annex
F says is not for comparison, is only a tie-break.
- The order is total and does not depend on input order; referenced
assemblies use the same rule.
- **Default names:**
- Invalid default Name/Prefix values are repaired (`201301ISA95` becomes
`_201301ISA95`, `class` becomes `class_`).
- Valid names are unchanged.
- Sanitising no longer depends on the OS.
- **`ModelUri` metadata** that doesn't match the NodeSet raises a
warning instead of silently losing the model.
- **Input detection:**
- Only XML files whose root is `ModelDesign` or `UANodeSet` are treated
as models.
- A malformed NodeSet stays a NodeSet input, so it no longer breaks the
ModelDesign pass.
- **`IdentifierFile` paths:** they are normalized (`./`, `../`), and the
suffix match requires a folder boundary.
- **Dependency payloads** (`ModelDependencyV1`) carry field IsOptional,
AllowSubTypes, ArrayDimensions and the producer's namespace tables in
skippable trailers, so old and new readers stay compatible.
### Roslyn host, diagnostics, packaging
- **New diagnostics:**
- MODELGEN036: `[NodeManager]` target not supported (nested, generic,
file-local or global namespace).
- MODELGEN037: `[DataType]` target not supported (struct, generic,
abstract, file-local or global namespace).
- MODELGEN038: the definition of an encodeable base type can't be found.
- **New validator errors:**
- a structure with both optional and subtyped fields (OPC 10000-6 F.13);
- multi-bit or duplicate OptionSet masks.
- **Diagnostic locations:** `[DataType]`/`[NodeManager]` diagnostics
point at real source locations again, so `#pragma` and `.editorconfig`
apply. MODELGEN010 is the exception.
- **Incremental caching:** pipeline values compare by value, so
unrelated edits no longer regenerate the whole model or all
`[DataType]`s.
- **`ModelSourceGeneratorIgnore`** on a ModelDesign input is honoured;
the design still resolves as a dependency.
- **Cancellation:** a cancelled generation run propagates
`OperationCanceledException` instead of reporting a MODELGEN003 error.
- **Stack package:** the `Stack` NuGet package now ships
`build/OPCFoundation.NetStandard.Opc.Ua.SourceGeneration.Stack.props`,
so `StackSourceGeneratorMode` and `StackSourceGeneratorExclude` reach
the compiler.
## Related Issues
- No tracking issue. The audit, review and spec-grounding reports are
available on request. Contains the matrix wire-format change discussed
for D-5 (OPC 10000-6 5.2.5 Table 28).
## Checklist
- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
(`docs/SourceGeneratedDataTypes.md`, `docs/NodeManagers.md`, generator
readme)
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings. (`UA.slnx` 0 warnings / 0 errors on net48 and
net10.0)
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed. The
affected suites were run on net10.0: SourceGeneration Core/Roslyn/Stack,
Types, Core.Encoders, Encoders.Fuzz, Client, Client.ComplexTypes,
PubSub, Core, Server, GDS, Configuration, Di, Robotics, ISA95,
Positioning, OpenUsd, XRegistry. net48 was built; its test legs, and the
post-rebase verification, run in CI.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
386 lines
17 KiB
C#
386 lines
17 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System.Collections.Generic;
|
|
using System.Diagnostics;
|
|
using System.IO;
|
|
using System.Linq;
|
|
using System.Text;
|
|
using System.Threading.Tasks;
|
|
using System.Xml.Linq;
|
|
using Microsoft.CodeAnalysis;
|
|
using Microsoft.CodeAnalysis.CSharp;
|
|
using Microsoft.CodeAnalysis.Diagnostics;
|
|
using Microsoft.Extensions.Logging;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Schema.Binary;
|
|
using Opc.Ua.Schema.Xml;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.SourceGeneration.Api.Tests
|
|
{
|
|
/// <summary>
|
|
/// Test generating and compiling model design
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Api")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
// [Parallelizable(ParallelScope.All)]
|
|
public class GenerateCodeTests
|
|
{
|
|
[DatapointSource]
|
|
public OptimizationLevel[] OptimizationLevels = CompilerUtils.SupportedOptimizationLevels;
|
|
|
|
[DatapointSource]
|
|
public string[] ModelDesignFiles =
|
|
[
|
|
"TestDataDesign.xml"
|
|
#if TEST_ALL
|
|
, "DemoModel.xml"
|
|
, "TestModel.xml"
|
|
, "OpcUaOnboardingModel.xml"
|
|
, "OpcUaSchedulerModel.xml"
|
|
, "DemoModel.json"
|
|
, "TestDataDesign.json"
|
|
#endif
|
|
];
|
|
|
|
/// <summary>
|
|
/// Only support modern language versions
|
|
/// </summary>
|
|
[DatapointSource]
|
|
public LanguageVersion[] LanguageVersions =
|
|
[
|
|
LanguageVersion.CSharp11
|
|
#if TEST_ALL_LANG_VERSIONS
|
|
,LanguageVersion.CSharp12
|
|
,LanguageVersion.CSharp13
|
|
// ,LanguageVersion.CSharp14
|
|
#endif
|
|
];
|
|
|
|
[Theory]
|
|
[Pairwise]
|
|
public async Task GenerateAndCompileDesignFileAsync(
|
|
string modelDesignFile,
|
|
OptimizationLevel optimizationLevel,
|
|
LanguageVersion languageVersion,
|
|
bool withAnalyzers,
|
|
bool withNodeLoader)
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create(logLevel: LogLevel.Error);
|
|
Dictionary<string, string> generatedText = GenerateCodeFromModel(
|
|
modelDesignFile,
|
|
languageVersion,
|
|
telemetry,
|
|
out Dictionary<string, string> generatedOther);
|
|
Dictionary<string, string> generatedTextStack = GenerateStackTests.GenerateStack(
|
|
StackGenerationType.Models,
|
|
telemetry,
|
|
out Dictionary<string, string> generatedStackOther);
|
|
foreach (KeyValuePair<string, string> item in generatedTextStack)
|
|
{
|
|
generatedText.Add(item.Key, item.Value);
|
|
}
|
|
if (withNodeLoader)
|
|
{
|
|
AddPredefinedNodeLoader(generatedText);
|
|
}
|
|
|
|
var xmlSchemas = generatedOther
|
|
.Concat(generatedStackOther)
|
|
.Where(c => Path.GetExtension(c.Key) == ".xsd")
|
|
.Select(c => c.Value)
|
|
.ToList();
|
|
Assert.That(xmlSchemas, Has.Count.EqualTo(2));
|
|
|
|
// Validate xsd schemas
|
|
using (var xsd = new MemoryStream(Encoding.UTF8.GetBytes(xmlSchemas[0])))
|
|
{
|
|
var xmlValidator = new XmlSchemaValidator(new Dictionary<string, byte[]>
|
|
{
|
|
["http://opcfoundation.org/UA/2008/02/Types.xsd"] = Encoding.UTF8.GetBytes(xmlSchemas[1])
|
|
});
|
|
xmlValidator.Validate(xsd, telemetry.LoggerFactory.CreateLogger<XmlSchemaValidator>());
|
|
}
|
|
|
|
var binSchemas = generatedOther
|
|
.Concat(generatedStackOther)
|
|
.Where(c => Path.GetExtension(c.Key) == ".bsd")
|
|
.Select(c => c.Value)
|
|
.ToList();
|
|
Assert.That(binSchemas, Has.Count.EqualTo(2));
|
|
|
|
// Validate binary schema
|
|
using (var bsd = new MemoryStream(Encoding.UTF8.GetBytes(binSchemas[0])))
|
|
{
|
|
var binValidator = new BinarySchemaValidator(new Dictionary<string, byte[]>
|
|
{
|
|
["http://opcfoundation.org/UA/"] = Encoding.UTF8.GetBytes(binSchemas[1])
|
|
});
|
|
binValidator.Validate(bsd);
|
|
}
|
|
|
|
// Parse and compile the generated code
|
|
var sw = Stopwatch.StartNew();
|
|
using var peStream = new MemoryStream();
|
|
using var xmlStream = new MemoryStream();
|
|
bool success = optimizationLevel
|
|
.CreateCompilation()
|
|
.AddCode(generatedText.WithOpcUaCoreStubs(), languageVersion)
|
|
.WithAnalyzers(withAnalyzers, out CompilationWithAnalyzers compilationWithAnalyzers)
|
|
.Emit(peStream, xmlDocumentationStream: xmlStream)
|
|
.Check(TestContext.Out, out int errorCount, out int warnCount);
|
|
TestContext.Out.WriteLine("Compilation completed in {0} ms", sw.ElapsedMilliseconds);
|
|
if (withAnalyzers)
|
|
{
|
|
if (compilationWithAnalyzers == null)
|
|
{
|
|
Assert.Ignore("Setup does not support analyzer testing");
|
|
}
|
|
AnalysisResult analysisResults =
|
|
await compilationWithAnalyzers.GetAnalysisResultAsync(default).ConfigureAwait(false);
|
|
analysisResults.GetAllDiagnostics().Check(TestContext.Out,
|
|
out int analyzerErrors,
|
|
out int analzyerWarnings);
|
|
Assert.That(analyzerErrors, Is.Zero, $"Analyzers produced {analyzerErrors} errors");
|
|
TestContext.Out.WriteLine($"Analyzers produced {analzyerWarnings} warnings");
|
|
}
|
|
Assert.That(
|
|
success,
|
|
Is.True,
|
|
$"Compilation failed with {errorCount} errors and {warnCount} warnings.");
|
|
xmlStream.Position = 0;
|
|
var xmlDoc = XDocument.Load(xmlStream);
|
|
Assert.That(xmlDoc, Is.Not.Null);
|
|
}
|
|
|
|
[Theory]
|
|
public void GenerateFromDesignFileWithCsharp8(string modelDesignFile)
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create(logLevel: LogLevel.Error);
|
|
Dictionary<string, string> generatedText = GenerateCodeFromModel(
|
|
modelDesignFile,
|
|
LanguageVersion.CSharp8,
|
|
telemetry,
|
|
out _);
|
|
Assert.That(generatedText, Is.Not.Empty);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that DataType structure fields with
|
|
/// <c>ValueRank="OneOrMoreDimensions"</c> are generated as typed
|
|
/// <c>MatrixOf<T></c> properties and that the encode/decode
|
|
/// pipeline writes the inline matrix of OPC 10000-6 5.2.5 with the
|
|
/// calls the DataTypeDefinition driven Structure codec makes:
|
|
/// dedicated <c>WriteEncodeableMatrix</c> / <c>ReadEncodeableMatrix</c>
|
|
/// for concrete encodeable matrices and <c>WriteVariantValue</c> /
|
|
/// <c>ReadVariantValue</c> with the field's type info (no Variant
|
|
/// framing) together with the matching <c>Variant.GetXxxMatrix</c>
|
|
/// getters for everything else.
|
|
/// </summary>
|
|
[Test]
|
|
public void GenerateMatrixValueDataType_EmitsMatrixOfPropertiesAndCalls()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create(logLevel: LogLevel.Error);
|
|
Dictionary<string, string> generatedText = GenerateCodeFromModel(
|
|
"TestDataDesign.xml",
|
|
LanguageVersion.CSharp11,
|
|
telemetry,
|
|
out _);
|
|
|
|
// Concatenate every generated source file so the snippet match
|
|
// is resilient to whichever file the generator chooses to put
|
|
// the type in (each pipeline groups types differently).
|
|
string code = string.Join("\n", generatedText.Values);
|
|
|
|
Assert.That(code, Does.Contain("class MatrixValueDataType"),
|
|
"Expected MatrixValueDataType to be generated.");
|
|
|
|
// Property type assertions - each matrix field must render as a
|
|
// typed MatrixOf<T> in the public surface.
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(code, Does.Contain(
|
|
"global::Opc.Ua.MatrixOf<bool> BooleanMatrix"));
|
|
Assert.That(code, Does.Contain(
|
|
"global::Opc.Ua.MatrixOf<int> Int32Matrix"));
|
|
Assert.That(code, Does.Contain(
|
|
"global::Opc.Ua.MatrixOf<string> StringMatrix"));
|
|
Assert.That(code, Does.Contain(
|
|
"global::Opc.Ua.MatrixOf<global::Opc.Ua.NodeId> NodeIdMatrix"));
|
|
Assert.That(code, Does.Contain(
|
|
"global::Opc.Ua.MatrixOf<global::Opc.Ua.Variant> VariantMatrix"));
|
|
Assert.That(code, Does.Contain(
|
|
"global::Opc.Ua.MatrixOf<global::Opc.Ua.ExtensionObject> ExtensionObjectMatrix"));
|
|
Assert.That(code, Does.Contain(
|
|
"global::Opc.Ua.MatrixOf<global::TestData.Vector> VectorMatrix"));
|
|
// AllowSubTypes structure fields collapse to ExtensionObject
|
|
// during DataTypeNode resolution, so the property emits the
|
|
// matrix-of-extension-object surface even though the design
|
|
// declared the element type as Vector.
|
|
Assert.That(code, Does.Contain(
|
|
"global::Opc.Ua.MatrixOf<global::Opc.Ua.ExtensionObject> AbstractVectorMatrix"));
|
|
// Typed enum matrix surface — fully qualified to the
|
|
// TestData namespace where HeaterStatus is generated.
|
|
Assert.That(code, Does.Contain(
|
|
"global::Opc.Ua.MatrixOf<global::TestData.HeaterStatus> HeaterStatusMatrix"));
|
|
});
|
|
|
|
// Encode assertions: matrix fields are written as the inline
|
|
// matrix of OPC 10000-6 5.2.5, the same calls the
|
|
// DataTypeDefinition driven Structure codec makes.
|
|
Assert.Multiple(() =>
|
|
{
|
|
// Concrete encodeable matrix uses the typed
|
|
// WriteEncodeableMatrix overload.
|
|
Assert.That(code, Does.Contain(
|
|
"""encoder.WriteEncodeableMatrix("VectorMatrix", VectorMatrix);"""));
|
|
Assert.That(code, Does.Not.Match(@"encoder\.WriteVariant\(""\w*Matrix"""),
|
|
"No matrix field may be framed as a Variant.");
|
|
foreach (string name in s_variantValueMatrixFields)
|
|
{
|
|
Assert.That(code, Does.Contain(
|
|
$"global::Opc.Ua.EncoderExtensions.WriteInlineMatrixValue(encoder, \"{name}\", global::Opc.Ua.Variant.From({name}));"));
|
|
}
|
|
});
|
|
|
|
// Decode assertions: read with the field's type info, like
|
|
// Structure.DecodeProperty does.
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(code, Does.Contain(
|
|
"""VectorMatrix = decoder.ReadEncodeableMatrix<global::TestData.Vector>("VectorMatrix");"""));
|
|
Assert.That(code, Does.Not.Match(@"decoder\.ReadVariant\(""\w*Matrix"""),
|
|
"No matrix field may be read as a Variant.");
|
|
Assert.That(code, Does.Contain(ReadMatrix("BooleanMatrix", "Boolean", "GetBooleanMatrix()")));
|
|
Assert.That(code, Does.Contain(ReadMatrix("Int32Matrix", "Int32", "GetInt32Matrix()")));
|
|
Assert.That(code, Does.Contain(ReadMatrix("StringMatrix", "String", "GetStringMatrix()")));
|
|
Assert.That(code, Does.Contain(ReadMatrix("NodeIdMatrix", "NodeId", "GetNodeIdMatrix()")));
|
|
Assert.That(code, Does.Contain(ReadMatrix("VariantMatrix", "Variant", "GetVariantMatrix()")));
|
|
Assert.That(code, Does.Contain(
|
|
ReadMatrix("ExtensionObjectMatrix", "ExtensionObject", "GetExtensionObjectMatrix()")));
|
|
Assert.That(code, Does.Contain(
|
|
ReadMatrix("AbstractVectorMatrix", "ExtensionObject", "GetExtensionObjectMatrix()")));
|
|
// Typed enum matrix decodes through GetEnumerationMatrix<T>
|
|
// (the EnumerationBuilder<T>-backed Variant getter).
|
|
Assert.That(code, Does.Contain(
|
|
ReadMatrix(
|
|
"HeaterStatusMatrix",
|
|
"Enumeration",
|
|
"GetEnumerationMatrix<global::TestData.HeaterStatus>()")));
|
|
});
|
|
|
|
static string ReadMatrix(string name, string builtInType, string getter)
|
|
{
|
|
return $"{name} = decoder.ReadVariantValue(\"{name}\", global::Opc.Ua.TypeInfo.Create(" +
|
|
$"global::Opc.Ua.BuiltInType.{builtInType}, global::Opc.Ua.ValueRanks.TwoDimensions)).{getter};";
|
|
}
|
|
}
|
|
private static readonly string[] s_variantValueMatrixFields =
|
|
[
|
|
"BooleanMatrix",
|
|
"Int32Matrix",
|
|
"StringMatrix",
|
|
"NodeIdMatrix",
|
|
"VariantMatrix",
|
|
"ExtensionObjectMatrix",
|
|
// AllowSubTypes -> field resolves to ExtensionObject.
|
|
"AbstractVectorMatrix",
|
|
// Typed enum matrix -> Variant.From<T>(MatrixOf<T>).
|
|
"HeaterStatusMatrix"
|
|
];
|
|
|
|
private static Dictionary<string, string> GenerateCodeFromModel(
|
|
string modelDesignFile,
|
|
LanguageVersion languageVersion,
|
|
ITelemetryContext telemetry,
|
|
out Dictionary<string, string> nonSourceCode)
|
|
{
|
|
// Generate
|
|
var sw = Stopwatch.StartNew();
|
|
using var fileSystem = new VirtualFileSystem();
|
|
Generators.GenerateCode(new DesignFileCollection
|
|
{
|
|
Targets = [Path.Combine(
|
|
Directory.GetCurrentDirectory(),
|
|
"Resources",
|
|
modelDesignFile)],
|
|
IdentifierFilePath = Path.Combine(
|
|
Directory.GetCurrentDirectory(),
|
|
"Resources",
|
|
Path.GetFileNameWithoutExtension(modelDesignFile) + ".csv"),
|
|
Options = new DesignFileOptions()
|
|
}, fileSystem, string.Empty, telemetry, new GeneratorOptions
|
|
{
|
|
UseUtf8StringLiterals = languageVersion >= LanguageVersion.CSharp11,
|
|
// The test compilation provides Core stubs via
|
|
// WithOpcUaCoreStubs() but no Opc.Ua.Server reference.
|
|
// Suppress fluent-builder emission to keep the generated
|
|
// code self-contained (mirrors model-only csproj
|
|
// configuration in production: Opc.Ua.Di,
|
|
// Opc.Ua.Gds, Opc.Ua.WotCon all opt out via
|
|
// ModelSourceGeneratorOmitFluentApi=true).
|
|
OmitFluentApi = true,
|
|
OmitEventRecords = true
|
|
});
|
|
|
|
var generatedText = fileSystem.CreatedFiles
|
|
.Where(c => Path.GetExtension(c) == ".cs")
|
|
.ToDictionary(c => c, c => Encoding.UTF8.GetString(fileSystem.Get(c)));
|
|
TestContext.Out.WriteLine("Generation completed in {0} ms", sw.ElapsedMilliseconds);
|
|
Assert.That(generatedText.Values, Is.All.StartsWith("// <auto-generated />"));
|
|
|
|
nonSourceCode = fileSystem.CreatedFiles
|
|
.Where(c => Path.GetExtension(c) != ".cs")
|
|
.ToDictionary(c => c, c => Encoding.UTF8.GetString(fileSystem.Get(c)));
|
|
return generatedText;
|
|
}
|
|
|
|
private static void AddPredefinedNodeLoader(Dictionary<string, string> generated)
|
|
{
|
|
generated.Add("Test.cs",
|
|
"""
|
|
namespace Opc.Ua
|
|
{
|
|
public static partial class LoadingTestData
|
|
{
|
|
public static NodeStateCollection Load()
|
|
{
|
|
// Use predefined nodes
|
|
return new NodeStateCollection().AddOpcUa(new SystemContext(null));
|
|
}
|
|
}
|
|
}
|
|
""");
|
|
}
|
|
}
|
|
}
|