Files
romanettandClaude Opus 5.5 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

203 lines
8.1 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System.Collections.Generic;
using System.IO;
using Microsoft.Extensions.Logging;
using NUnit.Framework;
using Opc.Ua.Tests;
namespace Opc.Ua.SourceGeneration.Generator.Tests
{
/// <summary>
/// Unit tests for cross-pass <c>[NodeManager]</c> binding diagnostics.
/// Bindings are resolved across two independent generation passes
/// (NodeSet2 and ModelDesign); the unmatched-binding diagnostics must be
/// reported once, after both passes, against a shared "used" set —
/// reporting per pass false-positives a binding matched by the other pass
/// (regression for issue #3937).
/// </summary>
[TestFixture]
[Category("Generator")]
[Parallelizable(ParallelScope.All)]
public class NodeManagerBindingReportingTests
{
[Test]
public void BindingMatchedByAnyPassIsNotReportedUnmatched()
{
// The binding is recorded in the shared used-set (matched by one
// pass). Even though this reporter call also spans the other pass
// that never matched it, it must stay silent. This is the core
// #3937 case: a NodeSet2 model matched, a ModelDesign model did not.
NodeManagerAttributeBinding matched = CreateBinding(namespaceUri: "urn:types");
HashSet<NodeManagerAttributeBinding> used = [matched];
var reports = new List<string>();
Generators.ReportUnmatchedNodeManagerBindings(
[matched],
used,
totalModelCount: 2,
(_, message) => reports.Add(message));
Assert.That(reports, Is.Empty);
}
[Test]
public void BindingMatchedByNoPassIsReportedOnce()
{
NodeManagerAttributeBinding orphan = CreateBinding(namespaceUri: "urn:missing");
var reports = new List<string>();
Generators.ReportUnmatchedNodeManagerBindings(
[orphan],
[],
totalModelCount: 2,
(_, message) => reports.Add(message));
Assert.That(reports, Has.Count.EqualTo(1));
Assert.That(reports[0], Does.Contain("did not match any model"));
Assert.That(reports[0], Does.Contain("NamespaceUri='urn:missing'"));
}
[Test]
public void SelectorlessBindingWithMultipleModelsIsReportedAsAmbiguity()
{
NodeManagerAttributeBinding selectorless = CreateBinding();
var reports = new List<string>();
Generators.ReportUnmatchedNodeManagerBindings(
[selectorless],
[],
totalModelCount: 2,
(_, message) => reports.Add(message));
Assert.That(reports, Has.Count.EqualTo(1));
Assert.That(reports[0], Does.Contain("multiple models"));
Assert.That(reports[0], Does.Contain("Specify NamespaceUri"));
}
[Test]
public void SelectorlessBindingWithSingleModelIsReportedAsUnmatched()
{
// With a single model a selector-less binding is not ambiguous; it
// simply did not match (for example the model was skipped).
NodeManagerAttributeBinding selectorless = CreateBinding();
var reports = new List<string>();
Generators.ReportUnmatchedNodeManagerBindings(
[selectorless],
[],
totalModelCount: 1,
(_, message) => reports.Add(message));
Assert.That(reports, Has.Count.EqualTo(1));
Assert.That(reports[0], Does.Contain("did not match any model"));
Assert.That(reports[0], Does.Contain("(no selector)"));
}
[Test]
public void ReportIsNoOpWhenBindingsAreNullOrEmpty()
{
Assert.DoesNotThrow(() =>
Generators.ReportUnmatchedNodeManagerBindings(
null!, null!, 2, (_, _) => Assert.Fail("should not report")));
Assert.DoesNotThrow(() =>
Generators.ReportUnmatchedNodeManagerBindings(
[], null!, 2, (_, _) => Assert.Fail("should not report")));
}
[Test]
public void GenerateCodeDefersUnmatchedReportWhenSharedSetProvided()
{
// In shared (multi-pass) mode the pass must not self-report an
// unmatched binding; the caller reports once after all passes.
var reports = new List<string>();
RunDesignGenerate(
CreateBinding(namespaceUri: "urn:not:in:test:model"),
sharedUsedBindings: [],
report: (_, message) => reports.Add(message));
Assert.That(
reports,
Is.Empty,
"a shared-mode pass must defer unmatched-binding reporting");
}
[Test]
public void GenerateCodeReportsUnmatchedWhenNoSharedSet()
{
// Single-pass mode (no shared set): the pass reports directly.
var reports = new List<string>();
RunDesignGenerate(
CreateBinding(namespaceUri: "urn:not:in:test:model"),
sharedUsedBindings: null!,
report: (_, message) => reports.Add(message));
Assert.That(reports, Has.Count.EqualTo(1));
Assert.That(reports[0], Does.Contain("did not match any model"));
}
private static NodeManagerAttributeBinding CreateBinding(
string? namespaceUri = null,
string? design = null,
string className = "TestNodeManager")
{
return new NodeManagerAttributeBinding
{
TargetNamespace = "Test",
TargetClassName = className,
NamespaceUri = namespaceUri!,
Design = design!
};
}
private static void RunDesignGenerate(
NodeManagerAttributeBinding binding,
HashSet<NodeManagerAttributeBinding> sharedUsedBindings,
System.Action<NodeManagerAttributeBinding, string> report)
{
ITelemetryContext telemetry = NUnitTelemetryContext.Create(logLevel: LogLevel.Error);
using var fileSystem = new VirtualFileSystem();
string resources = Path.Combine(TestContext.CurrentContext.TestDirectory, "Resources");
new DesignFileCollection
{
Targets = [Path.Combine(resources, "TestModel.xml")],
IdentifierFilePath = Path.Combine(resources, "TestModel.csv")
}.GenerateCode(
fileSystem,
string.Empty,
telemetry,
nodeManagerBindings: [binding],
reportBindingDiagnostic: report,
sharedUsedBindings: sharedUsedBindings);
}
}
}