Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

269 lines
11 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.IO;
using Moq;
using NUnit.Framework;
namespace Opc.Ua.SourceGeneration.Generator.Tests
{
/// <summary>
/// Unit tests for the TextFileResource class.
/// </summary>
[TestFixture]
[Category("Generator")]
[SetCulture("en-us")]
[SetUICulture("en-us")]
[Parallelizable]
public class TextFileResourceTests
{
/// <summary>
/// Tests that GetLength returns the expected file length from the file system.
/// </summary>
/// <param name = "fileName">The file name to test with.</param>
/// <param name = "expectedLength">The expected length value that the file system should return.</param>
[TestCase("test.txt", 100L)]
[TestCase("file.xml", 0L)]
[TestCase("large.bin", long.MaxValue)]
[TestCase("C:\\path\\to\\file.txt", 12345L)]
[TestCase("../relative/path.txt", 999L)]
[TestCase("file-with-special-chars_@#$.txt", 42L)]
public void GetLength_ValidFileSystemAndFileName_ReturnsExpectedLength(string fileName, long expectedLength)
{
// Arrange
var mockFileSystem = new Mock<IFileSystem>();
mockFileSystem.Setup(fs => fs.GetLength(fileName)).Returns(expectedLength);
var resource = new TextFileResource("TestResource", fileName);
// Act
long actualLength = resource.GetLength(mockFileSystem.Object);
// Assert
Assert.That(actualLength, Is.EqualTo(expectedLength));
mockFileSystem.Verify(fs => fs.GetLength(fileName), Times.Once);
}
/// <summary>
/// Tests that GetLength throws NullReferenceException when fileSystem parameter is null.
/// </summary>
[Test]
public void GetLength_NullFileSystem_ThrowsNullReferenceException()
{
// Arrange
var resource = new TextFileResource("TestResource", "test.txt");
// Act & Assert
Assert.Throws<NullReferenceException>(() => resource.GetLength(null!));
}
/// <summary>
/// Tests that GetLength handles empty file name string.
/// </summary>
[Test]
public void GetLength_EmptyFileName_CallsFileSystemWithEmptyString()
{
// Arrange
var mockFileSystem = new Mock<IFileSystem>();
mockFileSystem.Setup(fs => fs.GetLength(string.Empty)).Returns(0L);
var resource = new TextFileResource("TestResource", string.Empty);
// Act
long actualLength = resource.GetLength(mockFileSystem.Object);
// Assert
Assert.That(actualLength, Is.Zero);
mockFileSystem.Verify(fs => fs.GetLength(string.Empty), Times.Once);
}
/// <summary>
/// Tests that GetLength returns zero for zero-length files.
/// </summary>
[Test]
public void GetLength_ZeroLengthFile_ReturnsZero()
{
// Arrange
var mockFileSystem = new Mock<IFileSystem>();
mockFileSystem.Setup(fs => fs.GetLength("empty.txt")).Returns(0L);
var resource = new TextFileResource("TestResource", "empty.txt");
// Act
long actualLength = resource.GetLength(mockFileSystem.Object);
// Assert
Assert.That(actualLength, Is.Zero);
}
/// <summary>
/// Tests that GetLength correctly handles maximum long value for very large files.
/// </summary>
[Test]
public void GetLength_MaximumFileSize_ReturnsMaxValue()
{
// Arrange
var mockFileSystem = new Mock<IFileSystem>();
mockFileSystem.Setup(fs => fs.GetLength("huge.bin")).Returns(long.MaxValue);
var resource = new TextFileResource("TestResource", "huge.bin");
// Act
long actualLength = resource.GetLength(mockFileSystem.Object);
// Assert
Assert.That(actualLength, Is.EqualTo(long.MaxValue));
}
/// <summary>
/// Tests that GetLength handles negative return values from the file system (edge case).
/// </summary>
[Test]
public void GetLength_NegativeLength_ReturnsNegativeValue()
{
// Arrange
var mockFileSystem = new Mock<IFileSystem>();
mockFileSystem.Setup(fs => fs.GetLength("invalid.txt")).Returns(-1L);
var resource = new TextFileResource("TestResource", "invalid.txt");
// Act
long actualLength = resource.GetLength(mockFileSystem.Object);
// Assert
Assert.That(actualLength, Is.EqualTo(-1L));
}
/// <summary>
/// Tests that GetLength correctly passes the FileName property to the file system.
/// </summary>
[Test]
public void GetLength_DifferentFileNames_PassesCorrectFileNameToFileSystem()
{
// Arrange
const string expectedFileName = "specific-file.txt";
var mockFileSystem = new Mock<IFileSystem>();
mockFileSystem.Setup(fs => fs.GetLength(expectedFileName)).Returns(500L);
var resource = new TextFileResource("TestResource", expectedFileName);
// Act
resource.GetLength(mockFileSystem.Object);
// Assert
mockFileSystem.Verify(fs => fs.GetLength(expectedFileName), Times.Once);
}
/// <summary>
/// Tests that GetLength returns the correct file length from the file system
/// when provided with a valid file name and file system.
/// </summary>
[TestCase(0L)]
[TestCase(1L)]
[TestCase(100L)]
[TestCase(1024L)]
[TestCase(1048576L)]
[TestCase(long.MaxValue)]
public void GetLength_ValidFileSystem_ReturnsExpectedLength(long expectedLength)
{
// Arrange
const string resourceName = "Test.Resource";
const string fileName = "test.txt";
var mockFileSystem = new Mock<IFileSystem>();
mockFileSystem.Setup(fs => fs.GetLength(fileName)).Returns(expectedLength);
var resource = new TextFileResource(resourceName, fileName);
// Act
long actualLength = resource.GetLength(mockFileSystem.Object);
// Assert
Assert.That(actualLength, Is.EqualTo(expectedLength));
mockFileSystem.Verify(fs => fs.GetLength(fileName), Times.Once);
}
/// <summary>
/// Tests that GetLength passes the correct FileName to the file system's GetLength method.
/// </summary>
[TestCase("simple.txt")]
[TestCase("path/to/file.txt")]
[TestCase("C:\\absolute\\path\\file.txt")]
[TestCase("")]
[TestCase("file with spaces.txt")]
[TestCase("file_with_special_chars!@#.txt")]
public void GetLength_VariousFileNames_PassesCorrectFileNameToFileSystem(string fileName)
{
// Arrange
const string resourceName = "Test.Resource";
const long expectedLength = 42L;
var mockFileSystem = new Mock<IFileSystem>();
mockFileSystem.Setup(fs => fs.GetLength(fileName)).Returns(expectedLength);
var resource = new TextFileResource(resourceName, fileName);
// Act
long actualLength = resource.GetLength(mockFileSystem.Object);
// Assert
Assert.That(actualLength, Is.EqualTo(expectedLength));
mockFileSystem.Verify(fs => fs.GetLength(fileName), Times.Once);
}
/// <summary>
/// Tests that GetLength propagates exceptions thrown by the file system's GetLength method.
/// </summary>
[Test]
public void GetLength_FileSystemThrowsIOException_PropagatesException()
{
// Arrange
const string resourceName = "Test.Resource";
const string fileName = "nonexistent.txt";
var mockFileSystem = new Mock<IFileSystem>();
var expectedException = new IOException("File not found");
mockFileSystem.Setup(fs => fs.GetLength(fileName)).Throws(expectedException);
var resource = new TextFileResource(resourceName, fileName);
// Act & Assert
IOException thrownException = Assert.Throws<IOException>(() => resource.GetLength(mockFileSystem.Object));
Assert.That(thrownException.Message, Is.EqualTo("File not found"));
}
/// <summary>
/// Tests that GetLength propagates ArgumentException when the file system throws it.
/// </summary>
[Test]
public void GetLength_FileSystemThrowsArgumentException_PropagatesException()
{
// Arrange
const string resourceName = "Test.Resource";
const string fileName = "invalid:filename.txt";
var mockFileSystem = new Mock<IFileSystem>();
var expectedException = new ArgumentException("Invalid file name");
mockFileSystem.Setup(fs => fs.GetLength(fileName)).Throws(expectedException);
var resource = new TextFileResource(resourceName, fileName);
// Act & Assert
ArgumentException thrownException = Assert.Throws<ArgumentException>(() => resource.GetLength(mockFileSystem.Object));
Assert.That(thrownException.Message, Is.EqualTo("Invalid file name"));
}
/// <summary>
/// Tests that GetLength returns zero when the file system reports a zero-length file.
/// </summary>
[Test]
public void GetLength_EmptyFile_ReturnsZero()
{
// Arrange
const string resourceName = "Test.Resource";
const string fileName = "empty.txt";
var mockFileSystem = new Mock<IFileSystem>();
mockFileSystem.Setup(fs => fs.GetLength(fileName)).Returns(0L);
var resource = new TextFileResource(resourceName, fileName);
// Act
long actualLength = resource.GetLength(mockFileSystem.Object);
// Assert
Assert.That(actualLength, Is.Zero);
}
}
}