Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

179 lines
7.8 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Text;
using Moq;
using NUnit.Framework;
namespace Opc.Ua.SourceGeneration.Generator.Tests
{
/// <summary>
/// Unit tests for the <see cref = "TextResource"/> class.
/// </summary>
[TestFixture]
[Category("Generator")]
[SetCulture("en-us")]
[SetUICulture("en-us")]
[Parallelizable]
public class TextResourceTests
{
/// <summary>
/// Tests that GetLength returns the correct UTF-8 byte count for various text inputs.
/// </summary>
/// <param name = "text">The text to test.</param>
/// <param name = "expectedByteCount">The expected UTF-8 byte count.</param>
[TestCase("", 0, TestName = "GetLength_EmptyString_ReturnsZero")]
[TestCase("Hello", 5, TestName = "GetLength_SimpleAsciiText_ReturnsCorrectByteCount")]
[TestCase("Hello World!", 12, TestName = "GetLength_AsciiTextWithSpace_ReturnsCorrectByteCount")]
[TestCase("café", 5, TestName = "GetLength_LatinExtendedCharacters_ReturnsCorrectByteCount")]
[TestCase("你好", 6, TestName = "GetLength_ChineseCharacters_ReturnsCorrectByteCount")]
[TestCase("こんにちは", 15, TestName = "GetLength_JapaneseCharacters_ReturnsCorrectByteCount")]
[TestCase("🚀", 4, TestName = "GetLength_EmojiCharacter_ReturnsCorrectByteCount")]
[TestCase("Hello 世界 🌍", 17, TestName = "GetLength_MixedAsciiUnicodeEmoji_ReturnsCorrectByteCount")]
[TestCase("\n\r\t", 3, TestName = "GetLength_SpecialCharacters_ReturnsCorrectByteCount")]
[TestCase("Line1\nLine2\r\nLine3", 18, TestName = "GetLength_TextWithNewlines_ReturnsCorrectByteCount")]
public void GetLength_VariousTextInputs_ReturnsCorrectUtf8ByteCount(string text, long expectedByteCount)
{
// Arrange
var resource = new TextResource("Test.Resource", text);
var mockFileSystem = new Mock<IFileSystem>();
// Act
long actualByteCount = resource.GetLength(mockFileSystem.Object);
// Assert
Assert.That(actualByteCount, Is.EqualTo(expectedByteCount));
}
/// <summary>
/// Tests that GetLength returns the correct UTF-8 byte count for a very long string.
/// </summary>
[Test]
public void GetLength_VeryLongString_ReturnsCorrectByteCount()
{
// Arrange
string longText = new('A', 100000);
var resource = new TextResource("Test.Resource", longText);
long expectedByteCount = Encoding.UTF8.GetByteCount(longText);
var mockFileSystem = new Mock<IFileSystem>();
// Act
long actualByteCount = resource.GetLength(mockFileSystem.Object);
// Assert
Assert.That(actualByteCount, Is.EqualTo(expectedByteCount));
Assert.That(actualByteCount, Is.EqualTo(100000));
}
/// <summary>
/// Tests that GetLength throws ArgumentNullException when Text property is null.
/// </summary>
[Test]
public void GetLength_NullText_ThrowsArgumentNullException()
{
// Arrange
var resource = new TextResource("Test.Resource", null!);
var mockFileSystem = new Mock<IFileSystem>();
// Act & Assert
Assert.Throws<ArgumentNullException>(() => resource.GetLength(mockFileSystem.Object));
}
/// <summary>
/// Tests that GetLength works correctly when fileSystem parameter is null,
/// demonstrating that the parameter is not used by the method.
/// </summary>
[Test]
public void GetLength_NullFileSystemParameter_ReturnsCorrectByteCount()
{
// Arrange
const string text = "Test text";
var resource = new TextResource("Test.Resource", text);
long expectedByteCount = Encoding.UTF8.GetByteCount(text);
// Act
long actualByteCount = resource.GetLength(null!);
// Assert
Assert.That(actualByteCount, Is.EqualTo(expectedByteCount));
Assert.That(actualByteCount, Is.EqualTo(9));
}
/// <summary>
/// Tests that GetLength returns correct byte count for text with various control characters.
/// </summary>
[Test]
public void GetLength_TextWithControlCharacters_ReturnsCorrectByteCount()
{
// Arrange
const string text = "Hello\0World\u0001\u0002";
var resource = new TextResource("Test.Resource", text);
long expectedByteCount = Encoding.UTF8.GetByteCount(text);
var mockFileSystem = new Mock<IFileSystem>();
// Act
long actualByteCount = resource.GetLength(mockFileSystem.Object);
// Assert
Assert.That(actualByteCount, Is.EqualTo(expectedByteCount));
}
/// <summary>
/// Tests that GetLength returns correct byte count for text with all valid UTF-8 ranges.
/// </summary>
[Test]
public void GetLength_TextWithVariousUtf8Ranges_ReturnsCorrectByteCount()
{
// Arrange
// 1-byte: ASCII
// 2-byte: Latin Extended
// 3-byte: CJK
// 4-byte: Emoji
const string text = "Aé中🎉";
var resource = new TextResource("Test.Resource", text);
const long expectedByteCount = 1 + 2 + 3 + 4; // Total: 10 bytes
var mockFileSystem = new Mock<IFileSystem>();
// Act
long actualByteCount = resource.GetLength(mockFileSystem.Object);
// Assert
Assert.That(actualByteCount, Is.EqualTo(expectedByteCount));
Assert.That(actualByteCount, Is.EqualTo(10));
}
/// <summary>
/// Tests that GetLength returns correct byte count for whitespace-only text.
/// </summary>
[Test]
public void GetLength_WhitespaceOnlyText_ReturnsCorrectByteCount()
{
// Arrange
const string text = " \t\t\n\r ";
var resource = new TextResource("Test.Resource", text);
long expectedByteCount = Encoding.UTF8.GetByteCount(text);
var mockFileSystem = new Mock<IFileSystem>();
// Act
long actualByteCount = resource.GetLength(mockFileSystem.Object);
// Assert
Assert.That(actualByteCount, Is.EqualTo(expectedByteCount));
}
}
}