Files
romanett e639932b95 Fix source generator defects from the Client/Types/SourceGeneration audit (#4473)
# Description

Fixes the SourceGeneration findings of a read-only bug audit of
`a05a36055` — sections 15 (host generators, Roslyn side), 16
(SourceGeneration.Core schema / ModelDesign loader) and 17
(SourceGeneration.Core generators). 36 of the 39 findings are fixed;
each has a regression test.

### Generated-code correctness

- **State machine NodeId constants** were emitted as `const uint` even
when the aliased `Objects` constant is a `string`, so every model using
string NodeIds with a `FiniteStateMachineType` subtype failed with
CS0029. The constant type now follows the aliased node, looked up from
the same source `NodeIdGenerator` emits from — top-level nodes **plus
each node's instance hierarchy**, since a state or transition only ever
exists as a hierarchy entry.
- `NodeIdGenerator` emitted string identifiers into C# string literals
without escaping them.
- Structure field names are authored data, so they can be C# keywords or
collide with the members every generated data type carries. Properties
and `{Type}Fields` members now go through a sanitizing,
collision-breaking mapping (including two siblings that sanitize to the
same identifier). **Wire names are untouched** — OPC 10000-3 §8.51
requires the StructureField name to match the BrowseName, and the
`DataMember`/encode/decode names still come from `Parameter.Name`.
- `NodeStateGenerator`'s copy-on-write cast now uses the fully qualified
data type name, which a cross-model structure needs.
- `GetScalarValueAsCode` emitted `(double)NaN` and the infinities, which
do not compile.
- `TemplateWriter` formatted with the current culture, so a machine with
a comma decimal separator emitted invalid generated source.

### Served schema documents

- The binary schema described a **different wire layout than the
generated `Encode`/`Decode`**: unions carried no
`SwitchField`/`SwitchValue`, and structures with optional fields carried
no encoding-mask presence bits. Both are now emitted per **OPC 10000-6
§5.2.7**, matching the layout the runtime `BsdSchemaGenerator` produces.
A structure with more than 32 optional fields now fails generation
instead of silently wrapping `1 << 32` back onto the first field's bit.
- Documentation text and attribute values are XML-escaped.

### ModelDesign loading and validation

- Identifiers pinned in a CSV were dropped whenever any other loaded
namespace declared the same symbolic name. Removal is now scoped to the
file's target namespace, and explicit `NumericId`s are keyed by
`(namespace, id)` so the same number in two namespaces is legal.
- Declaration order inside a design file no longer matters — base types
are imported and validated ahead of their subtypes.
- OptionSet `OptionSetValues` were truncated at bit 31 (signed shift)
and bits 32–63 of a 64-bit option set were never emitted.
- An authored `ValueRank` is no longer overwritten by the shape of the
default value (OPC 10000-3 §6.2.8: a ValueRank may only be further
restricted), and a VariableType data type may be narrowed any number of
levels deep rather than exactly one.
- NodeSet import: `AccessRestrictions="0"` means "no restrictions", not
`EncryptionRequired` (OPC 10000-3 §8.56) — an unrecognised mask stays
**fail-closed**; a NodeSet without `<Models>` reports what is wrong; an
optional `<References>` no longer throws; the parent/child reference
scan looks at the parent's references; and `IsTypeOf` terminates on the
self-referential root reference types NodeSets routinely declare.
- Version comparison is numeric per component (ordinally `"1.05.9"`
sorts above `"1.05.10"`) and now lives on `SemVer`, so the NodeSet
collection and the dependency tie-break cannot pick different winners; a
publication-date version no longer outranks a real one.

### Host generator

- `[DataType]` on an `enum` is matched again (an enum is not a
`TypeDeclarationSyntax`), MODELGEN003 renders its arguments instead of
the raw template, and the Types hint name keeps the namespace's dots so
`A.BC` and `AB.C` cannot claim the same one.
- Compilation-derived pipeline stages carry value comparers, so editing
a file no longer re-runs the entire model generation on every keystroke.
- A NodeSet that fails to load skips that file rather than every
remaining one; a file listed twice as an `AdditionalFile` is deduped;
superseded NodeSet versions are still recognised as NodeSet inputs and
not generated a second time by the ModelDesign pass.
- `LogLevel.Critical` maps to a diagnostic instead of being silently
dropped.

### Client

- `EventRecordFieldReaders` gained the readers the event record
generator needs (including `Variant`, enumerations and the array forms).
Fields whose type had no reader were declared on the record but never
populated, so they read as `null`/`default` for every event.

## Not fixed (deliberately)

- **Forward same-namespace hierarchical references in
`NodeSetToModelDesign.ImportReferences`** — the audit flags the
inverse-only handling as asymmetric. Making it symmetric compiles and
passes every generator unit test, but regresses the address space: all
17 `RobotOpenUsdE2eTests` fail in `OneTimeSetUpAsync` because the hosted
server never finishes starting. Reverted, with a comment at the site
recording why.
- **§17.10 and §15.10** (both low + PLAUSIBLE) — each needs a wider
refactor than this PR: a consistent NodeId-constant rename across ~6
cross-reference sites, and replacing `Location` with a serializable
equivalent for incremental cache equality.

## Spec cross-check

The encoding/schema changes were checked against the specification: OPC
10000-6 §5.2.7 (32-bit EncodingMask, one bit per optional field in
order, padded), the union `SwitchField` encoding, OPC 10000-3 §8.56
(AccessRestrictionType bit mask), §6.2.8 and §5.6.2/§5.6.5 (ValueRank),
§8.51 (StructureField name == BrowseName).
`GenerateStackTests.OptionalFieldBitsAgreeBetweenBsdAndGeneratedEncoder`
pins the BSD presence-bit order against the generated encoder's
`LogRecordFields` so the two cannot drift apart again.

## Related Issues

_No tracking issue — this PR implements the SourceGeneration sections of
a bug audit. Happy to open one if maintainers prefer._

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

> Note on the test checkbox: verified on **net10.0 only** — `UA.slnx`
builds clean (0 warnings, 0 errors) and
`Opc.Ua.SourceGeneration.Core.Tests` (3915),
`Opc.Ua.SourceGeneration.Tests` (184), `Opc.Ua.Di.Tests` (425, including
the `RobotOpenUsdE2eTests` end-to-end fixture that catches address-space
content changes) and the `EventRecordFieldReaders` tests (16) all pass.
.NET Framework has **not** been run locally; CI needs to confirm it.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Marc Schier <marcschier@users.noreply.github.com>
2026-09-13 19:07:55 +02:00

179 lines
7.6 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System.Globalization;
using System.Linq;
using Microsoft.CodeAnalysis;
using NUnit.Framework;
namespace Opc.Ua.SourceGeneration
{
/// <summary>
/// Tests for the logger-to-diagnostic bridge in
/// <see cref="SourceGeneratorTelemetry"/> / <see cref="SourceGenerator"/>.
/// </summary>
[TestFixture]
[Category("SourceGeneration")]
[SetCulture("en-us")]
[SetUICulture("en-us")]
public class SourceGeneratorTelemetryTests
{
/// <summary>
/// Documents the underlying bug: reporting an already-formatted message
/// directly against a descriptor whose format declares more placeholders
/// than arguments supplied yields the raw, unsubstituted template.
/// </summary>
[Test]
public void DirectReportAgainstMultiPlaceholderDescriptorLosesMessage()
{
Diagnostic diagnostic = Diagnostic.Create(
SourceGenerator.Exception, Location.None, "boom");
string rendered = diagnostic.GetMessage(CultureInfo.InvariantCulture);
// The single argument cannot satisfy the '{0}': '{1}' format, so the
// real message is dropped and the placeholders leak through verbatim.
Assert.That(rendered, Does.Not.Contain("boom"));
Assert.That(rendered, Does.Contain("{1}"));
}
/// <summary>
/// Verifies the fix: an already-formatted message is rendered verbatim
/// under the correct diagnostic identity regardless of the looked-up
/// descriptor's placeholder arity.
/// </summary>
[Test]
public void CreateFormattedDiagnosticRendersMessageVerbatim()
{
Diagnostic diagnostic = SourceGenerator.CreateFormattedDiagnostic(
SourceGenerator.Exception, "boom");
string rendered = diagnostic.GetMessage(CultureInfo.InvariantCulture);
Assert.That(rendered, Is.EqualTo("boom"));
Assert.That(rendered, Does.Not.Contain("{0}"));
Assert.That(rendered, Does.Not.Contain("{1}"));
}
/// <summary>
/// The passthrough descriptor preserves the looked-up descriptor's
/// identity and metadata (id, severity, category, help link, tags).
/// </summary>
[Test]
public void CreateFormattedDiagnosticPreservesDescriptorMetadata()
{
DiagnosticDescriptor source = SourceGenerator.Exception;
Diagnostic diagnostic = SourceGenerator.CreateFormattedDiagnostic(
source, "boom");
DiagnosticDescriptor result = diagnostic.Descriptor;
Assert.That(result.Id, Is.EqualTo(source.Id));
Assert.That(result.Id, Is.EqualTo("MODELGEN003"));
Assert.That(diagnostic.Severity, Is.EqualTo(source.DefaultSeverity));
Assert.That(result.Category, Is.EqualTo(source.Category));
Assert.That(result.Description, Is.EqualTo(source.Description));
Assert.That(result.HelpLinkUri, Is.EqualTo(source.HelpLinkUri));
Assert.That(result.IsEnabledByDefault, Is.EqualTo(source.IsEnabledByDefault));
Assert.That(result.CustomTags, Is.EquivalentTo(source.CustomTags.ToArray()));
}
/// <summary>
/// Regression: the generator's logger reports Critical as enabled, but
/// the level was not mapped to any descriptor, so every LogCritical
/// message - including "Could not parse NodeSet" - was silently dropped.
/// </summary>
[Test]
public void CriticalLogLevelMapsToADiagnostic()
{
bool mapped = SourceGenerator.TryGetDiagnostic(
Microsoft.Extensions.Logging.LogLevel.Critical,
default,
out DiagnosticDescriptor descriptor);
Assert.That(mapped, Is.True, "Critical must reach the build as a diagnostic");
Assert.That(descriptor.DefaultSeverity, Is.EqualTo(DiagnosticSeverity.Error));
}
/// <summary>
/// Levels below Warning still map to nothing - they are diagnostics-only
/// tracing, and the logger reports them as disabled.
/// </summary>
[TestCase(Microsoft.Extensions.Logging.LogLevel.Trace)]
[TestCase(Microsoft.Extensions.Logging.LogLevel.Debug)]
[TestCase(Microsoft.Extensions.Logging.LogLevel.Information)]
public void SubWarningLogLevelsMapToNothing(
Microsoft.Extensions.Logging.LogLevel level)
{
Assert.That(
SourceGenerator.TryGetDiagnostic(level, default, out _),
Is.False);
}
/// <summary>
/// Regression: MODELGEN003 declares two placeholders, so reporting it
/// with a single argument rendered the raw template. The [DataType]
/// paths now pass the annotated type name and the message separately.
/// </summary>
[Test]
public void ExceptionDescriptorWithBothArgumentsRendersTheMessage()
{
Diagnostic diagnostic = Diagnostic.Create(
SourceGenerator.Exception,
Location.None,
"TestApp.Config.ServerConfig",
"InvalidOperationException: boom");
string rendered = diagnostic.GetMessage(CultureInfo.InvariantCulture);
Assert.That(rendered, Does.Contain("TestApp.Config.ServerConfig"));
Assert.That(rendered, Does.Contain("boom"));
Assert.That(rendered, Does.Not.Contain("{0}"));
Assert.That(rendered, Does.Not.Contain("{1}"));
}
/// <summary>
/// The formatted message is emitted safely even when it contains brace
/// characters that would otherwise be interpreted as format placeholders.
/// </summary>
[Test]
public void CreateFormattedDiagnosticIsSafeForBracesInMessage()
{
const string message = "value {0} was not {closed";
Diagnostic diagnostic = SourceGenerator.CreateFormattedDiagnostic(
SourceGenerator.GenericError, message);
string rendered = diagnostic.GetMessage(CultureInfo.InvariantCulture);
Assert.That(rendered, Is.EqualTo(message));
}
}
}