mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-18 06:31:35 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
236 lines
8.3 KiB
C#
236 lines
8.3 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Globalization;
|
|
using System.IO;
|
|
using Opc.Ua.Schema.Types;
|
|
|
|
namespace Opc.Ua.SourceGeneration
|
|
{
|
|
/// <summary>
|
|
/// Generates code based on a UA Type Dictionary.
|
|
/// </summary>
|
|
internal class AttributesGenerator : IGenerator
|
|
{
|
|
/// <summary>
|
|
/// Generates the attributes constants for nodes
|
|
/// </summary>
|
|
public AttributesGenerator(IGeneratorContext context)
|
|
{
|
|
m_context = context ?? throw new ArgumentNullException(nameof(context));
|
|
}
|
|
|
|
/// <inheritdoc/>
|
|
public IEnumerable<Resource> Emit()
|
|
{
|
|
string fileName = Path.Combine(m_context.OutputFolder,
|
|
CoreUtils.Format("{0}.Attributes.g.cs", Constants.CoreNamespacePrefix));
|
|
using TextWriter writer = m_context.FileSystem.CreateTextWriter(fileName);
|
|
|
|
using var templateWriter = new TemplateWriter(writer);
|
|
var template = new Template(templateWriter, CodeTemplates.StatusCode_Attributes_File);
|
|
|
|
template.AddReplacement(Tokens.Prefix, Constants.CoreNamespacePrefix);
|
|
template.AddReplacement(Tokens.ClassName, "Attributes");
|
|
template.AddReplacement(Tokens.IdType, "uint");
|
|
|
|
// load and validate type dictionary.
|
|
var nodeDictionaries = new Dictionary<string, string>();
|
|
var validator = new TypeDictionaryValidator(
|
|
m_context.FileSystem,
|
|
nodeDictionaries);
|
|
validator.Validate(BuiltInDesignFiles.UAAttributesXml);
|
|
Dictionary<string, int> identifiers =
|
|
LoadIdentifiers(BuiltInDesignFiles.AttributesCsv);
|
|
|
|
var constants = new List<Constant>();
|
|
foreach (DataType datatype in validator.Dictionary!.Items!)
|
|
{
|
|
if (!TypeDictionaryValidator.IsExcluded(m_context.Options.Exclusions, datatype) &&
|
|
datatype is Constant constant &&
|
|
identifiers.TryGetValue(constant.Name!, out int id))
|
|
{
|
|
constant.Identifier = id;
|
|
constant.IdentifierSpecified = true;
|
|
constants.Add(constant);
|
|
}
|
|
}
|
|
|
|
template.AddReplacement(
|
|
Tokens.ListOfIdentifiers,
|
|
CodeTemplates.StatusCode_Attributes_Constant,
|
|
constants,
|
|
WriteTemplate_AttributeConstant);
|
|
|
|
template.AddReplacement(
|
|
Tokens.IdentifierReflection,
|
|
NodeIdTemplates.Reflection,
|
|
[constants],
|
|
WriteTemplate_ReflectionHelpers);
|
|
|
|
template.Render();
|
|
return [fileName.AsTextFileResource()];
|
|
}
|
|
|
|
/// <summary>
|
|
/// Writes a constant.
|
|
/// </summary>
|
|
private bool WriteTemplate_AttributeConstant(IWriteContext context)
|
|
{
|
|
if (context.Target is not Constant constant)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
if (string.IsNullOrEmpty(constant.Value))
|
|
{
|
|
// Other
|
|
context.Template.AddReplacement(Tokens.IdType, "uint");
|
|
context.Template.AddReplacement(Tokens.Identifier, constant.Identifier);
|
|
}
|
|
else
|
|
{
|
|
context.Template.AddReplacement(Tokens.IdType, "string"); // Never hit
|
|
context.Template.AddReplacement(
|
|
Tokens.Identifier,
|
|
CoreUtils.Format("\"{0}\"", constant.Value)); // TODO: Make string resource
|
|
}
|
|
|
|
context.Template.AddReplacement(Tokens.SymbolicId, constant.Name);
|
|
string? description = constant.Documentation.GetDescription();
|
|
context.Template.AddReplacement(Tokens.Description, description);
|
|
|
|
return context.Template.Render();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Write reflection helpers for identifiers.
|
|
/// </summary>
|
|
private bool WriteTemplate_ReflectionHelpers(IWriteContext context)
|
|
{
|
|
if (context.Target is not List<Constant> constants)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
context.Template.AddReplacement(Tokens.IdType, "uint");
|
|
|
|
context.Template.AddReplacement(
|
|
Tokens.ListOfIdentifersToNames,
|
|
constants,
|
|
LoadTemplate_IdentifierLookup);
|
|
|
|
context.Template.AddReplacement(
|
|
Tokens.ListOfNamesToIdentifiers,
|
|
constants,
|
|
LoadTemplate_IdentifierLookup);
|
|
|
|
return context.Template.Render();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Write lookup entries for identifiers.
|
|
/// </summary>
|
|
private TemplateString? LoadTemplate_IdentifierLookup(ILoadContext context)
|
|
{
|
|
if (context.Target is Constant constant)
|
|
{
|
|
string? symbolicId = constant.Name;
|
|
if (context.Token == Tokens.ListOfIdentifersToNames)
|
|
{
|
|
context.Out.WriteLine("lookup[{0}] = \"{0}\";", symbolicId);
|
|
}
|
|
else if (context.Token == Tokens.ListOfNamesToIdentifiers)
|
|
{
|
|
context.Out.WriteLine("lookup[\"{0}\"] = {0};", symbolicId);
|
|
}
|
|
}
|
|
return null;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Loads the identifiers from a CSV file.
|
|
/// </summary>
|
|
/// <exception cref="InvalidOperationException"></exception>
|
|
private Dictionary<string, int> LoadIdentifiers(string identifiersFile)
|
|
{
|
|
var identifiers = new Dictionary<string, int>();
|
|
int maxId = 1;
|
|
|
|
using TextReader reader = m_context.FileSystem.CreateTextReader(identifiersFile);
|
|
while (true)
|
|
{
|
|
string? line = reader.ReadLine();
|
|
if (line == null)
|
|
{
|
|
break;
|
|
}
|
|
|
|
if (string.IsNullOrWhiteSpace(line))
|
|
{
|
|
continue;
|
|
}
|
|
|
|
int index = line.IndexOf(',', StringComparison.Ordinal);
|
|
|
|
if (index == -1)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
// remove the node class if it is present.
|
|
int lastIndex = line.LastIndexOf(',');
|
|
|
|
if (lastIndex != -1 && index != lastIndex)
|
|
{
|
|
line = line[..lastIndex];
|
|
}
|
|
|
|
string name = line[..index].Trim();
|
|
|
|
int uid = Convert.ToInt32(
|
|
line[(index + 1)..].Trim(),
|
|
CultureInfo.InvariantCulture);
|
|
|
|
if (maxId <= uid)
|
|
{
|
|
maxId = uid + 1;
|
|
}
|
|
|
|
identifiers[name] = uid;
|
|
}
|
|
return identifiers;
|
|
}
|
|
|
|
private readonly IGeneratorContext m_context;
|
|
}
|
|
}
|