Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

245 lines
11 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.IO;
using Microsoft.Extensions.Logging;
using Opc.Ua.Schema.Model;
namespace Opc.Ua.SourceGeneration
{
/// <summary>
/// Emits a partial <c>{Namespace}NodeManager</c> deriving from
/// <c>AsyncCustomNodeManager</c> plus a matching
/// <c>{Namespace}NodeManagerFactory</c> implementing
/// <c>IAsyncNodeManagerFactory</c>. Opt-in via
/// <see cref="DesignFileOptions.GenerateNodeManager"/>.
/// </summary>
/// <remarks>
/// The generated manager wires the predefined nodes from the existing
/// <c>Add{Namespace}(NodeStateCollection, ISystemContext)</c> extension
/// (emitted by <see cref="NodeStateGenerator"/>) and exposes a
/// <c>partial void Configure(INodeManagerBuilder builder)</c> hook for
/// user code-behind. Lifecycle dispatchers (<c>AddPredefinedNode</c>,
/// <c>RemovePredefinedNode</c>, <c>OnMonitoredItemCreated</c>) are wired
/// to the runtime fluent dispatcher so callbacks registered via the
/// builder are invoked at the right times.
/// <para>
/// When an attribute-driven binding supplies a class name and namespace
/// override (via <see cref="DesignFileOptions.NodeManagerClassName"/> and
/// <see cref="DesignFileOptions.NodeManagerNamespace"/>), the generator
/// emits the partial under that user-chosen identity instead of the
/// design-derived defaults. Factory emission can be suppressed via
/// <see cref="DesignFileOptions.EmitNodeManagerFactory"/>.
/// </para>
/// </remarks>
internal sealed class NodeManagerGenerator : IGenerator
{
/// <summary>
/// Optional override for the namespace of the generated partial.
/// Defaults to the design's <c>TargetNamespace.Prefix</c>.
/// </summary>
public string? OverrideNamespace { get; init; }
/// <summary>
/// Optional override for the class name of the generated partial.
/// Defaults to <c>{Prefix}NodeManager</c>.
/// </summary>
public string? OverrideClassName { get; init; }
/// <summary>
/// When <c>false</c> the matching <c>{ClassName}Factory</c> is
/// not emitted. Defaults to <c>true</c>.
/// </summary>
public bool EmitFactory { get; init; } = true;
/// <summary>
/// When <c>false</c> the public
/// <c>(IServerInternal, ApplicationConfiguration)</c> constructor
/// is not emitted; only the <c>protected</c> constructor taking
/// the namespace URI array is. Defaults to <c>true</c>.
/// </summary>
public bool EmitDefaultConstructor { get; init; } = true;
/// <summary>
/// Additional namespace URIs (beyond the model namespace) that
/// the generated constructor passes to the base node manager and
/// the generated factory advertises via <c>NamespacesUris</c>.
/// Typically a sample's separate instance namespace. Optional.
/// </summary>
public IReadOnlyList<string>? AdditionalNamespaceUris { get; init; }
/// <summary>
/// Create node manager generator.
/// </summary>
public NodeManagerGenerator(IGeneratorContext context)
{
m_context = context ?? throw new ArgumentNullException(nameof(context));
m_logger = context.Telemetry.CreateLogger<NodeManagerGenerator>();
}
/// <inheritdoc/>
public IEnumerable<Resource> Emit()
{
string nsPrefix = m_context.ModelDesign.TargetNamespace.Prefix;
string typeStem = nsPrefix.Replace(".", string.Empty, StringComparison.Ordinal);
string? nsUriSymbol = m_context.ModelDesign.Namespaces
.GetConstantSymbolForNamespace(m_context.ModelDesign.TargetNamespace.Value);
string targetNamespace = string.IsNullOrEmpty(OverrideNamespace)
? nsPrefix
: OverrideNamespace;
string targetClass = string.IsNullOrEmpty(OverrideClassName)
? typeStem + "NodeManager"
: OverrideClassName;
string factoryClass = string.IsNullOrEmpty(OverrideClassName)
? typeStem + "NodeManagerFactory"
: OverrideClassName + "Factory";
// The namespace is part of the stem: two bound managers may share a
// class name in different namespaces, and the output file system
// silently overwrites an existing file of the same name.
string fileStem = string.IsNullOrEmpty(OverrideClassName)
? nsPrefix
: targetNamespace + "." + OverrideClassName;
var resources = new List<Resource>(2)
{
EmitNodeManager(nsPrefix, targetNamespace, targetClass, typeStem, nsUriSymbol!, fileStem)
};
// The factory body is a call to the public (server, configuration)
// constructor. When that constructor is suppressed the manager cannot
// be built from those two arguments alone, so a factory would not
// compile - skip it and say so rather than emitting broken code.
if (EmitFactory && !EmitDefaultConstructor)
{
m_logger?.LogWarning(
"Node manager '{ClassName}' suppresses the public " +
"(IServerInternal, ApplicationConfiguration) constructor, so no " +
"'{FactoryName}' is generated. Set GenerateFactory=false to " +
"silence this, or allow the default constructor.",
targetClass,
factoryClass);
}
else if (EmitFactory)
{
resources.Add(EmitFactoryFile(targetNamespace, targetClass, factoryClass, nsUriSymbol!, fileStem));
}
return resources;
}
private TextFileResource EmitNodeManager(
string modelNamespace,
string targetNamespace,
string targetClass,
string typeStem,
string nsUriSymbol,
string fileStem)
{
string fileName = Path.Combine(
m_context.OutputFolder,
CoreUtils.Format("{0}.NodeManager.g.cs", fileStem));
using TextWriter writer = m_context.FileSystem.CreateTextWriter(fileName);
using var templateWriter = new TemplateWriter(writer);
var template = new Template(templateWriter, NodeManagerTemplates.File);
template.AddReplacement(Tokens.NamespacePrefix, targetNamespace);
template.AddReplacement(Tokens.Prefix, modelNamespace);
template.AddReplacement(Tokens.Namespace, typeStem);
template.AddReplacement(
Tokens.NodeSetImportFactoryProviderClassName,
typeStem + "NodeSetImportFactoryProvider");
template.AddReplacement(Tokens.NodeManagerClassName, targetClass);
template.AddReplacement(Tokens.NamespaceUri, nsUriSymbol);
template.AddReplacement(
Tokens.AdditionalNamespaceUris,
FormatAdditionalNamespaceUris());
// An empty target list collapses the block, which is how the
// template expresses "omit the default constructor".
template.AddReplacement(
Tokens.NodeManagerDefaultConstructor,
NodeManagerTemplates.DefaultConstructor,
EmitDefaultConstructor ? [targetClass] : Array.Empty<object>());
template.Render();
return fileName.AsTextFileResource();
}
/// <summary>
/// Renders the additional namespace URIs as a trailing
/// <c>, "uri"</c> argument list, or an empty string when none
/// were configured.
/// </summary>
private string FormatAdditionalNamespaceUris()
{
if (AdditionalNamespaceUris == null || AdditionalNamespaceUris.Count == 0)
{
return string.Empty;
}
var buffer = new System.Text.StringBuilder();
foreach (string uri in AdditionalNamespaceUris)
{
if (string.IsNullOrEmpty(uri))
{
continue;
}
buffer.Append(", ").Append(uri.AsStringLiteral());
}
return buffer.ToString();
}
private TextFileResource EmitFactoryFile(
string targetNamespace,
string targetClass,
string factoryClass,
string nsUriSymbol,
string fileStem)
{
string fileName = Path.Combine(
m_context.OutputFolder,
CoreUtils.Format("{0}.NodeManagerFactory.g.cs", fileStem));
using TextWriter writer = m_context.FileSystem.CreateTextWriter(fileName);
using var templateWriter = new TemplateWriter(writer);
var template = new Template(templateWriter, NodeManagerTemplates.FactoryFile);
template.AddReplacement(Tokens.NamespacePrefix, targetNamespace);
template.AddReplacement(Tokens.NodeManagerClassName, targetClass);
template.AddReplacement(Tokens.NodeManagerFactoryClassName, factoryClass);
template.AddReplacement(Tokens.NamespaceUri, nsUriSymbol);
template.AddReplacement(
Tokens.AdditionalNamespaceUris,
FormatAdditionalNamespaceUris());
template.Render();
return fileName.AsTextFileResource();
}
private readonly IGeneratorContext m_context;
private readonly ILogger m_logger;
}
}