Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

284 lines
10 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Globalization;
using System.IO;
using Opc.Ua.Schema.Types;
namespace Opc.Ua.SourceGeneration
{
/// <summary>
/// Generates code based on a UA Type Dictionary.
/// </summary>
internal class StatusCodesGenerator : IGenerator
{
/// <summary>
/// Create status codes generator
/// </summary>
public StatusCodesGenerator(IGeneratorContext context)
{
m_context = context ?? throw new ArgumentNullException(nameof(context));
}
/// <inheritdoc/>
public IEnumerable<Resource> Emit()
{
string fileName = Path.Combine(m_context.OutputFolder,
CoreUtils.Format("{0}.StatusCodes.g.cs", Constants.CoreNamespacePrefix));
using TextWriter writer = m_context.FileSystem.CreateTextWriter(fileName);
using var templateWriter = new TemplateWriter(writer);
var template = new Template(templateWriter, CodeTemplates.StatusCode_Attributes_File);
template.AddReplacement(Tokens.Prefix, Constants.CoreNamespacePrefix);
template.AddReplacement(Tokens.ClassName, "StatusCodes");
var nodeDictionaries = new Dictionary<string, string>();
var validator = new TypeDictionaryValidator(
m_context.FileSystem,
nodeDictionaries);
validator.Validate(BuiltInDesignFiles.UAStatusCodesXml);
Dictionary<string, int> identifiers = LoadIdentifiers(
BuiltInDesignFiles.StatusCodesCsv);
var constants = new List<Constant>
{
new()
{
Severity = Severity.Good,
Name = nameof(Severity.Good),
Documentation = new Documentation { Text = ["Success"] }
},
new()
{
Severity = Severity.Bad,
Name = nameof(Severity.Bad),
Documentation = new Documentation { Text = ["Bad status"] }
},
new()
{
Severity = Severity.Uncertain,
Name = nameof(Severity.Uncertain),
Documentation = new Documentation { Text = ["Uncertain status"] }
}
};
foreach (DataType datatype in validator.Dictionary!.Items!)
{
if (!TypeDictionaryValidator.IsExcluded(m_context.Options.Exclusions, datatype) &&
datatype is Constant constant &&
identifiers.TryGetValue(constant.Name!, out int id))
{
if (constant.Name!.StartsWith(
nameof(Severity.Bad),
StringComparison.Ordinal))
{
constant.Severity = Severity.Bad;
}
else if (constant.Name.StartsWith(
nameof(Severity.Good),
StringComparison.Ordinal))
{
constant.Severity = Severity.Good;
}
else if (constant.Name.StartsWith(
nameof(Severity.Uncertain),
StringComparison.Ordinal))
{
constant.Severity = Severity.Uncertain;
}
constant.Identifier = id;
constant.IdentifierSpecified = true;
constants.Add(constant);
}
}
// collect datatypes with the specified type.
template.AddReplacement(
Tokens.ListOfIdentifiers,
CodeTemplates.StatusCodes_Declaration,
constants,
WriteTemplate_StatusCodeDeclaration);
template.AddReplacement(
Tokens.IdentifierReflection,
CodeTemplates.StatusCode_TypeInterning,
[constants],
WriteTemplate_StatusCodeInterning);
template.Render();
return [fileName.AsTextFileResource()];
}
/// <summary>
/// Writes the status code declaration
/// </summary>
private bool WriteTemplate_StatusCodeDeclaration(IWriteContext context)
{
if (context.Target is not Constant constant)
{
return false;
}
// Status codes
uint id = Convert.ToUInt32(constant.Identifier, CultureInfo.InvariantCulture);
id <<= 16;
switch (constant.Severity)
{
case Severity.Bad:
id += 0x80000000;
break;
case Severity.Uncertain:
id += 0x40000000;
break;
}
context.Template.AddReplacement(Tokens.Identifier, CoreUtils.Format("0x{0:X8}", id));
string? symbolicId = constant.Name;
if (constant.Identifier != 0)
{
// Status codes
string? name = constant.Name;
int index = name!.IndexOf('_', StringComparison.Ordinal);
if (index != -1)
{
name = name[(index + 1)..];
}
symbolicId = CoreUtils.Format("{0}{1}", constant.Severity, name);
}
context.Template.AddReplacement(Tokens.SymbolicId, symbolicId);
string? description = constant.Documentation.GetDescription();
context.Template.AddReplacement(Tokens.Description, description);
return context.Template.Render();
}
/// <summary>
/// Write Status code interning context.Template
/// </summary>
private bool WriteTemplate_StatusCodeInterning(IWriteContext context)
{
if (context.Target is not List<Constant> constants)
{
return false;
}
context.Template.AddReplacement(Tokens.IdType, "global::Opc.Ua.StatusCode");
context.Template.AddReplacement(
Tokens.ListOfIdentifiers,
constants,
LoadTemplate_StatusCodeIdentifier);
return context.Template.Render();
}
/// <summary>
/// Write identifiers for interning
/// </summary>
private TemplateString? LoadTemplate_StatusCodeIdentifier(ILoadContext context)
{
if (context.Target is Constant constant)
{
string? symbolicId = constant.Name;
if (constant.Severity != Severity.None && constant.Identifier != 0)
{
// Status codes
string? name = constant.Name;
int index = name!.IndexOf('_', StringComparison.Ordinal);
if (index != -1)
{
name = name[(index + 1)..];
}
symbolicId = CoreUtils.Format("{0}{1}", constant.Severity, name);
}
context.Out.Write(symbolicId!);
context.Out.WriteLine(",");
}
return null;
}
/// <summary>
/// Loads the identifiers from a CSV file.
/// </summary>
/// <exception cref="InvalidOperationException"></exception>
private Dictionary<string, int> LoadIdentifiers(string identifiersFile)
{
var identifiers = new Dictionary<string, int>();
int maxId = 1;
using TextReader reader = m_context.FileSystem.CreateTextReader(identifiersFile);
while (true)
{
string? line = reader.ReadLine();
if (line == null)
{
break;
}
if (string.IsNullOrWhiteSpace(line))
{
continue;
}
int index = line.IndexOf(',', StringComparison.Ordinal);
if (index == -1)
{
continue;
}
// remove the node class if it is present.
int lastIndex = line.LastIndexOf(',');
if (lastIndex != -1 && index != lastIndex)
{
line = line[..lastIndex];
}
string name = line[..index].Trim();
int uid = Convert.ToInt32(
line[(index + 1)..].Trim(),
CultureInfo.InvariantCulture);
if (maxId <= uid)
{
maxId = uid + 1;
}
identifiers[name] = uid;
}
return identifiers;
}
private readonly IGeneratorContext m_context;
}
}