Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

203 lines
7.6 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.IO;
using System.Runtime.CompilerServices;
using Opc.Ua.SourceGeneration.Dependency;
namespace Opc.Ua.SourceGeneration
{
/// <summary>
/// Information read from a referenced assembly's
/// <see cref="ModelDependencyAttribute"/>. Value-type equatable so the
/// incremental source-generator cache keys behave correctly.
/// </summary>
public readonly struct ModelDependencyReference : IEquatable<ModelDependencyReference>
{
/// <summary>
/// Create a reference.
/// </summary>
public ModelDependencyReference(
string assemblyName,
string modelUri,
string prefix,
string version,
string publicationDate,
string? name = null,
string? payload = null)
{
AssemblyName = assemblyName ?? string.Empty;
ModelUri = modelUri ?? string.Empty;
Prefix = prefix ?? string.Empty;
Version = version ?? string.Empty;
PublicationDate = publicationDate ?? string.Empty;
Name = name ?? string.Empty;
Payload = payload ?? string.Empty;
}
/// <summary>
/// Returns true when the entry has both a model URI and a C# prefix.
/// </summary>
public bool IsValid => ModelUri.Length != 0 && Prefix.Length != 0;
/// <summary>
/// The assembly the attribute was read from.
/// </summary>
public string AssemblyName { get; }
/// <summary>
/// The OPC UA model URI recorded in the attribute.
/// </summary>
public string ModelUri { get; }
/// <summary>
/// The C# namespace the assembly used for this model's generated types.
/// </summary>
public string Prefix { get; }
/// <summary>
/// The model version string (may be empty).
/// </summary>
public string Version { get; }
/// <summary>
/// The model publication date (ISO-8601; may be empty).
/// </summary>
public string PublicationDate { get; }
/// <summary>The C# identifier used for the model's name constant inside
/// the referenced assembly's <c>Namespaces</c> class (may be empty).</summary>
public string Name { get; }
/// <summary>
/// Base64-encoded Deflate-compressed <c>ModelDependencyV1</c>
/// payload. Empty on transitive-dependency entries; non-empty
/// only on the producing assembly's self-declaration entry.
/// </summary>
public string Payload { get; }
/// <summary>
/// Decodes and memoises the <see cref="Payload"/> as a
/// <see cref="ModelDependencyV1"/>. Returns <c>null</c> when the
/// payload is empty, malformed, or carries an unknown version.
/// </summary>
/// <remarks>
/// Memoisation is keyed on the payload string to avoid re-decoding
/// the same multi-kilobyte byte block when the same dependency
/// flows through Roslyn's incremental cache multiple times.
/// </remarks>
public ModelDependencyV1? GetDependency()
{
if (string.IsNullOrEmpty(Payload))
{
return null;
}
return s_decoded.GetValue(Payload, DecodePayload).Value;
}
private static DecodedDependency DecodePayload(string payload)
{
try
{
return new DecodedDependency(ModelDependencyV1.FromBase64Payload(payload));
}
catch (Exception ex) when (
ex is InvalidDataException ||
ex is IOException ||
ex is ArgumentException ||
ex is FormatException ||
ex is OverflowException)
{
return new DecodedDependency(null);
}
}
private sealed class DecodedDependency
{
public DecodedDependency(ModelDependencyV1? value)
{
Value = value;
}
public ModelDependencyV1? Value { get; }
}
private static readonly ConditionalWeakTable<string, DecodedDependency> s_decoded
= new();
/// <inheritdoc/>
public bool Equals(ModelDependencyReference other)
{
return
string.Equals(AssemblyName, other.AssemblyName, StringComparison.Ordinal) &&
string.Equals(ModelUri, other.ModelUri, StringComparison.Ordinal) &&
string.Equals(Prefix, other.Prefix, StringComparison.Ordinal) &&
string.Equals(Version, other.Version, StringComparison.Ordinal) &&
string.Equals(PublicationDate, other.PublicationDate, StringComparison.Ordinal) &&
string.Equals(Name, other.Name, StringComparison.Ordinal) &&
string.Equals(Payload, other.Payload, StringComparison.Ordinal);
}
/// <inheritdoc/>
public override bool Equals(object? obj)
{
return obj is ModelDependencyReference other && Equals(other);
}
/// <inheritdoc/>
public override int GetHashCode()
{
unchecked
{
int hash = StringComparer.Ordinal.GetHashCode(AssemblyName);
hash = (hash * 397) ^ StringComparer.Ordinal.GetHashCode(ModelUri);
hash = (hash * 397) ^ StringComparer.Ordinal.GetHashCode(Prefix);
hash = (hash * 397) ^ StringComparer.Ordinal.GetHashCode(Version);
hash = (hash * 397) ^ StringComparer.Ordinal.GetHashCode(PublicationDate);
hash = (hash * 397) ^ StringComparer.Ordinal.GetHashCode(Name);
hash = (hash * 397) ^ StringComparer.Ordinal.GetHashCode(Payload);
return hash;
}
}
/// <inheritdoc/>
public static bool operator ==(ModelDependencyReference left, ModelDependencyReference right)
{
return left.Equals(right);
}
/// <inheritdoc/>
public static bool operator !=(ModelDependencyReference left, ModelDependencyReference right)
{
return !left.Equals(right);
}
}
}