Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

183 lines
6.8 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System.Text;
namespace Opc.Ua.SourceGeneration.Templating
{
/// <summary>
/// Escapes a value so it can be safely interpolated into a generated
/// C# verbatim or regular string literal (the literal's surrounding
/// double-quote characters are NOT included in the returned value).
/// </summary>
/// <remarks>
/// Defence-in-depth helper for the source generator. The generator
/// only consumes design XML from the local repository at build time;
/// anyone able to edit design XML can already write arbitrary C#.
/// This helper still hardens the generator so that an ill-formed
/// <c>BrowseName</c> (e.g. one containing <c>"</c>, <c>\</c>, control
/// characters, or BIDI overrides) cannot produce an unbalanced
/// string literal that breaks the consuming build with a confusing
/// compiler error. Instead the value is safely escaped and an
/// optional diagnostic is surfaced to the host generator.
/// </remarks>
public static class StringLiteralEscaper
{
/// <summary>
/// Returns the escaped content for a C# regular string literal
/// (i.e. wrap the result in <c>"</c>) without including the
/// surrounding quotes.
/// </summary>
/// <param name="raw">
/// The raw input. <c>null</c> is treated as an empty string.
/// </param>
public static string AsCSharpStringLiteralContent(string? raw)
{
return AsCSharpStringLiteralContent(raw, out _);
}
/// <summary>
/// Returns the escaped content for a C# regular string literal
/// and reports whether any character had to be escaped.
/// </summary>
/// <param name="raw">
/// The raw input. <c>null</c> is treated as an empty string.
/// </param>
/// <param name="modified">
/// <c>true</c> when the returned value differs from
/// <paramref name="raw"/>; <c>false</c> when no escaping was
/// required. Callers use this signal to emit the
/// <c>UASG_BROWSENAME_UNSAFE</c> diagnostic.
/// </param>
public static string AsCSharpStringLiteralContent(string? raw, out bool modified)
{
modified = false;
if (string.IsNullOrEmpty(raw))
{
return string.Empty;
}
// Fast scan to avoid allocating a builder when the input is
// already a plain printable ASCII string with no escape-
// requiring characters.
bool needsEscape = false;
for (int i = 0; i < raw.Length; i++)
{
if (RequiresEscape(raw[i]))
{
needsEscape = true;
break;
}
}
if (!needsEscape)
{
return raw;
}
modified = true;
var builder = new StringBuilder(raw.Length + 8);
for (int i = 0; i < raw.Length; i++)
{
char c = raw[i];
switch (c)
{
case '\\':
builder.Append("\\\\");
break;
case '"':
builder.Append("\\\"");
break;
case '\r':
builder.Append("\\r");
break;
case '\n':
builder.Append("\\n");
break;
case '\t':
builder.Append("\\t");
break;
default:
if (IsControl(c) || IsNewLine(c))
{
builder.Append("\\u")
.Append(((int)c).ToString("X4",
System.Globalization.CultureInfo.InvariantCulture));
}
else
{
builder.Append(c);
}
break;
}
}
return builder.ToString();
}
/// <summary>
/// Returns <c>true</c> when the supplied raw string contains at
/// least one character that would require escaping when
/// interpolated into a C# regular string literal.
/// </summary>
public static bool RequiresEscaping(string raw)
{
if (string.IsNullOrEmpty(raw))
{
return false;
}
for (int i = 0; i < raw.Length; i++)
{
if (RequiresEscape(raw[i]))
{
return true;
}
}
return false;
}
private static bool RequiresEscape(char c)
{
return c == '\\' || c == '"' || IsControl(c) || IsNewLine(c);
}
private static bool IsControl(char c)
{
// C0 control range and DEL.
return c is < (char)0x20 or (char)0x7f;
}
private static bool IsNewLine(char c)
{
// Besides CR and LF (C0), C# treats NEL, LINE SEPARATOR and
// PARAGRAPH SEPARATOR as new-line characters, which terminate a
// regular string literal (CS1010).
return c is '\u0085' or '\u2028' or '\u2029';
}
}
}