Files
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

221 lines
7.0 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Globalization;
using System.IO;
namespace Opc.Ua.SourceGeneration
{
/// <summary>
/// Template writer that handles indentation and line break management.
/// </summary>
internal sealed class TemplateWriter : IDisposable, ITemplateWriter
{
/// <summary>
/// Create template
/// </summary>
public TemplateWriter(TextWriter writer, bool leaveOpen = true)
{
m_writer = writer;
m_leaveOpen = leaveOpen;
m_indentCharCount = new Stack<int>();
m_indentCharCount.Push(0);
}
/// <summary>
/// Indent character count
/// </summary>
public int IndentationCharCount => m_indentCharCount.Peek();
/// <inheritdoc/>
public void Dispose()
{
while (m_newLineCount > 0)
{
m_writer.Write(Environment.NewLine);
m_newLineCount--;
}
if (!m_leaveOpen)
{
m_writer.Dispose();
}
}
/// <summary>
/// Increases the current indentation level by the
/// specified number of characters.
/// </summary>
/// <param name="charCount">The number of characters
/// to add to the current indentation level. Must be
/// zero or greater.</param>
public void PushIndentChars(int charCount)
{
m_indentCharCount.Push(IndentationCharCount + charCount);
}
/// <summary>
/// Decreases the current indentation level back
/// </summary>
public void PopIndentation()
{
if (m_indentCharCount.Count > 1)
{
m_indentCharCount.Pop();
TrimLineBreak(0);
}
}
/// <summary>
/// Trim any whitespace and line breaks on the current line.
/// </summary>
public void TrimLineBreak(int maxNewLines = 1)
{
if (m_newLineCount > maxNewLines)
{
m_newLineCount = maxNewLines;
}
}
/// <inheritdoc/>
public void Write(char text)
{
WriteWhiteSpaceIfNeeded();
m_writer.Write(text);
}
/// <inheritdoc/>
public void Write(string? text)
{
WriteWhiteSpaceIfNeeded();
m_writer.Write(text ?? string.Empty);
}
/// <inheritdoc/>
public void Write(string format, object arg1)
{
WriteWhiteSpaceIfNeeded();
m_writer.Write(
string.Format(CultureInfo.InvariantCulture, format ?? string.Empty, arg1));
}
/// <inheritdoc/>
public void Write(string format, object arg1, object arg2)
{
WriteWhiteSpaceIfNeeded();
m_writer.Write(
string.Format(CultureInfo.InvariantCulture, format ?? string.Empty, arg1, arg2));
}
/// <inheritdoc/>
public void Write(string format, object arg1, object arg2, object arg3)
{
WriteWhiteSpaceIfNeeded();
m_writer.Write(string.Format(
CultureInfo.InvariantCulture, format ?? string.Empty, arg1, arg2, arg3));
}
/// <inheritdoc/>
public void WriteLine()
{
WriteNewLine(2); // do not write more than 2 new lines - make configurable
}
/// <inheritdoc/>
public void WriteLine(string text)
{
WriteWhiteSpaceIfNeeded();
m_writer.Write(text ?? string.Empty);
WriteNewLine(int.MaxValue);
}
/// <inheritdoc/>
public void WriteLine(string text, params object?[] args)
{
WriteWhiteSpaceIfNeeded();
// Always format invariantly: the sink is generated source code and
// schema documents, which must not pick up the machine's culture
// (a culture specific minus sign or decimal separator would make the
// generated output invalid).
m_writer.Write(
string.Format(CultureInfo.InvariantCulture, text ?? string.Empty, args ?? []));
WriteNewLine(int.MaxValue);
}
/// <summary>
/// Write whitespace
/// </summary>
public void WriteWhiteSpace(int charCount)
{
// Queue up spaces to write on next write to drop trailing whitespace
m_writeSpaceCount += charCount;
}
/// <summary>
/// Begin new line
/// </summary>
public bool WriteNewLine(int maxNewLines)
{
if (m_newLineCount >= maxNewLines)
{
return false;
}
m_newLineCount++;
// Reset to current indent level
m_writeSpaceCount = IndentationCharCount;
return true;
}
/// <summary>
/// Write indent if needed.
/// </summary>
private void WriteWhiteSpaceIfNeeded()
{
// Write pending spaces.
while (m_newLineCount > 0)
{
m_writer.Write(Environment.NewLine);
m_newLineCount--;
}
if (m_writeSpaceCount > 0)
{
m_writer.Write(new string(' ', m_writeSpaceCount));
m_writeSpaceCount = 0;
}
}
private int m_writeSpaceCount;
private int m_newLineCount;
private readonly TextWriter m_writer;
private readonly bool m_leaveOpen;
private readonly Stack<int> m_indentCharCount;
}
}