Files
Suciu Mircea Adrian 0744066357 [master378] Fix Publish with maximum TimeoutHint (#4373)
# Description

Fixes server side handling of PublishRequests with maximum TimeoutHint
on master378 branch.

## Related Issues


- Fixes master378 coresponding 4371 issue

## Checklist

_Put an `x` in the boxes that apply. You can complete these step by step
after opening the PR._

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [ ] I have added all necessary documentation.
- [ ] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
2026-09-03 18:36:39 +00:00

743 lines
28 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Threading;
using Microsoft.Extensions.Logging;
using System.Threading.Tasks;
using System.Collections.Concurrent;
namespace Opc.Ua.Server
{
/// <summary>
/// Manages the publish queues for a session.
/// </summary>
public class SessionPublishQueue : IDisposable
{
/// <summary>
/// Creates a new queue.
/// </summary>
public SessionPublishQueue(IServerInternal server, ISession session, int maxPublishRequests)
{
m_server = server ?? throw new ArgumentNullException(nameof(server));
m_logger = server.Telemetry.CreateLogger<SessionPublishQueue>();
m_session = session ?? throw new ArgumentNullException(nameof(session));
m_queuedRequests = new LinkedList<QueuedPublishRequest>();
m_queuedSubscriptions = new ConcurrentDictionary<uint, QueuedSubscription>();
m_maxRequestCount = maxPublishRequests;
}
/// <summary>
/// Frees any unmanaged resources.
/// </summary>
public void Dispose()
{
Dispose(true);
GC.SuppressFinalize(this);
}
/// <summary>
/// An overrideable version of the Dispose.
/// </summary>
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
lock (m_lock)
{
while (m_queuedRequests.Count > 0)
{
QueuedPublishRequest request = m_queuedRequests.First.Value;
m_queuedRequests.RemoveFirst();
try
{
request.Tcs.TrySetException(new ServiceResultException(StatusCodes.BadServerHalted));
request.Dispose();
}
catch
{
// ignore errors.
}
}
m_queuedSubscriptions.Clear();
}
}
}
/// <summary>
/// Waits for a subscription to be ready to publish.
/// </summary>
public Task<ISubscription> PublishAsync(string secureChannelId,
DateTime operationTimeout,
bool requeue,
CancellationToken cancellationToken)
{
if (m_queuedSubscriptions.IsEmpty)
{
return Task.FromException<ISubscription>(
new ServiceResultException(StatusCodes.BadNoSubscription));
}
QueuedSubscription subscriptionToPublish;
lock (m_lock)
{
// find the waiting subscription with the highest priority.
subscriptionToPublish = GetSubscriptionToPublish();
if (subscriptionToPublish != null)
{
return Task.FromResult(subscriptionToPublish.Subscription);
}
// check if queue is full.
if (m_queuedRequests.Count >= m_maxRequestCount)
{
return Task.FromException<ISubscription>(
new ServiceResultException(StatusCodes.BadTooManyPublishRequests));
}
// add to queue.
var request = new QueuedPublishRequest(secureChannelId, operationTimeout, cancellationToken);
if (requeue)
{
m_queuedRequests.AddFirst(request);
}
else
{
m_queuedRequests.AddLast(request);
}
return request.Tcs.Task;
}
}
/// <summary>
/// Clears the queues because the session is closing.
/// </summary>
/// <returns>The list of subscriptions in the queue.</returns>
public IList<ISubscription> Close()
{
List<ISubscription> subscriptions;
lock (m_lock)
{
subscriptions = new List<ISubscription>(m_queuedSubscriptions.Count);
// TraceState("SESSION CLOSED");
// set any waiting publish requests to Status BadSessionClosed.
while (m_queuedRequests.Count > 0)
{
QueuedPublishRequest request = m_queuedRequests.First.Value;
m_queuedRequests.RemoveFirst();
request.Tcs.TrySetException(new ServiceResultException(StatusCodes.BadSessionClosed));
request.Dispose();
}
// tell the subscriptions that the session is closed.
foreach (KeyValuePair<uint, QueuedSubscription> entry in m_queuedSubscriptions)
{
subscriptions.Add(entry.Value.Subscription);
}
// clear the queue.
m_queuedSubscriptions.Clear();
}
foreach (ISubscription subscription in subscriptions)
{
subscription.SessionClosed();
}
return subscriptions;
}
/// <summary>
/// Adds a subscription from the publish queue.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="subscription"/> is <c>null</c>.</exception>
public void Add(ISubscription subscription)
{
if (subscription == null)
{
throw new ArgumentNullException(nameof(subscription));
}
m_queuedSubscriptions[subscription.Id] = new QueuedSubscription(subscription);
// TraceState("SUBSCRIPTION QUEUED");
}
/// <summary>
/// Removes a subscription from the publish queue.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="subscription"/> is <c>null</c>.</exception>
public void Remove(ISubscription subscription, bool removeQueuedRequests)
{
if (subscription == null)
{
throw new ArgumentNullException(nameof(subscription));
}
// remove the subscription from the queue.
m_queuedSubscriptions.TryRemove(subscription.Id, out _);
if (removeQueuedRequests)
{
RemoveQueuedRequests();
}
// TraceState("SUBSCRIPTION REMOVED");
}
/// <summary>
/// Removes outstanding requests if no subscriptions exist for the Session.
/// </summary>
public void RemoveQueuedRequests()
{
if (!m_queuedSubscriptions.IsEmpty)
{
return;
}
lock (m_lock)
{
// remove any outstanding publishes.
while (m_queuedRequests.Count > 0)
{
QueuedPublishRequest request = m_queuedRequests.First.Value;
m_queuedRequests.RemoveFirst();
request.Tcs.TrySetException(new ServiceResultException(StatusCodes.BadNoSubscription));
request.Dispose();
}
}
}
/// <summary>
/// Try to publish a custom status message
/// using a queued publish request.
/// Returns true if a queued request was found and processed.
/// Returns the found publish request immediately to the caller.
/// If status code is good, the caller is expected to publish any queued status messages.
/// If status code is bad a ServiceResultException is thrown to the caller.
/// </summary>
public bool TryPublishCustomStatus(StatusCode statusCode)
{
lock (m_lock)
{
while (m_queuedRequests.Count > 0)
{
QueuedPublishRequest request = m_queuedRequests.Last.Value;
m_queuedRequests.RemoveLast();
if (request.Tcs.Task.IsCompleted)
{
request.Dispose();
continue;
}
// for good status codes return to caller (SubscriptionManager) with null subscription
// to publish queued StatusMessages from there
if (ServiceResult.IsGood(statusCode))
{
request.Tcs.TrySetResult(null);
}
// throw a ServiceResultException for bad status codes
else
{
request.Tcs.TrySetException(new ServiceResultException(statusCode));
}
request.Dispose();
return true;
}
return false;
}
}
/// <summary>
/// Processes acknowledgements for previously published messages.
/// </summary>
/// <exception cref="ArgumentNullException"><paramref name="context"/> is <c>null</c>.</exception>
public void Acknowledge(
OperationContext context,
SubscriptionAcknowledgementCollection subscriptionAcknowledgements,
out StatusCodeCollection acknowledgeResults,
out DiagnosticInfoCollection acknowledgeDiagnosticInfos)
{
if (context == null)
{
throw new ArgumentNullException(nameof(context));
}
if (subscriptionAcknowledgements == null)
{
throw new ArgumentNullException(nameof(subscriptionAcknowledgements));
}
bool diagnosticsExist = false;
acknowledgeResults = new StatusCodeCollection(subscriptionAcknowledgements.Count);
acknowledgeDiagnosticInfos = new DiagnosticInfoCollection(
subscriptionAcknowledgements.Count);
for (int ii = 0; ii < subscriptionAcknowledgements.Count; ii++)
{
SubscriptionAcknowledgement acknowledgement = subscriptionAcknowledgements[ii];
if (m_queuedSubscriptions.TryGetValue(acknowledgement.SubscriptionId, out QueuedSubscription subscription))
{
ServiceResult result = subscription.Subscription.Acknowledge(
context,
acknowledgement.SequenceNumber);
if (ServiceResult.IsGood(result))
{
acknowledgeResults.Add(StatusCodes.Good);
if ((context.DiagnosticsMask & DiagnosticsMasks.OperationAll) != 0)
{
acknowledgeDiagnosticInfos.Add(null);
}
}
else
{
acknowledgeResults.Add(result.Code);
if ((context.DiagnosticsMask & DiagnosticsMasks.OperationAll) != 0)
{
DiagnosticInfo diagnosticInfo = ServerUtils
.CreateDiagnosticInfo(
m_server,
context,
result,
m_logger);
acknowledgeDiagnosticInfos.Add(diagnosticInfo);
diagnosticsExist = true;
}
}
}
else
{
var result = new ServiceResult(StatusCodes.BadSubscriptionIdInvalid);
acknowledgeResults.Add(result.Code);
if ((context.DiagnosticsMask & DiagnosticsMasks.OperationAll) != 0)
{
DiagnosticInfo diagnosticInfo = ServerUtils.CreateDiagnosticInfo(
m_server,
context,
result,
m_logger);
acknowledgeDiagnosticInfos.Add(diagnosticInfo);
diagnosticsExist = true;
}
}
}
if (!diagnosticsExist)
{
acknowledgeDiagnosticInfos.Clear();
}
}
/// <summary>
/// Adds a subscription back into the queue because it has more notifications to publish.
/// </summary>
public void PublishCompleted(ISubscription subscription, bool moreNotifications)
{
if (m_queuedSubscriptions.TryGetValue(subscription.Id,
out QueuedSubscription queuedSubscription))
{
lock (m_lock)
{
queuedSubscription.Publishing = false;
if (moreNotifications)
{
AssignSubscriptionToRequest(queuedSubscription);
}
else
{
queuedSubscription.ReadyToPublish = false;
queuedSubscription.Timestamp = DateTime.UtcNow;
}
}
}
}
/// <summary>
/// Puts a subscription back in the queue to be published.
/// </summary>
public void Requeue(ISubscription subscription)
{
if (m_queuedSubscriptions.TryGetValue(subscription.Id, out QueuedSubscription queuedSubscription))
{
lock (m_lock)
{
queuedSubscription.Publishing = false;
queuedSubscription.ReadyToPublish = true;
}
}
}
/// <summary>
/// Checks the state of the subscriptions.
/// </summary>
public void PublishTimerExpired()
{
var subscriptionsToDelete = new List<ISubscription>();
// check each available subscription.
foreach (KeyValuePair<uint, QueuedSubscription> entry in m_queuedSubscriptions)
{
QueuedSubscription subscription = entry.Value;
PublishingState state = subscription.Subscription.PublishTimerExpired();
// check for expired subscription.
if (state == PublishingState.Expired)
{
m_queuedSubscriptions.TryRemove(subscription.Subscription.Id, out _);
subscriptionsToDelete.Add(subscription.Subscription);
((SubscriptionManager)m_server.SubscriptionManager).SubscriptionExpired(
subscription.Subscription);
continue;
}
// check if idle.
if (state == PublishingState.Idle)
{
subscription.ReadyToPublish = false;
continue;
}
// do nothing if subscription has already been flagged as available.
if (subscription.ReadyToPublish)
{
continue;
}
// assign subscription to request if one is available.
if (!subscription.Publishing && !subscription.ReadyToPublish)
{
lock (m_lock)
{
if (!subscription.Publishing && !subscription.ReadyToPublish)
{
AssignSubscriptionToRequest(subscription);
}
}
}
}
// schedule cleanup on a background thread.
SubscriptionManager.CleanupSubscriptions(m_server, subscriptionsToDelete, m_logger);
}
/// <summary>
/// Checks the state of the subscriptions.
/// </summary>
private void AssignSubscriptionToRequest(QueuedSubscription subscription)
{
lock (m_lock)
{
// find a request.
while (m_queuedRequests.Count > 0)
{
QueuedPublishRequest request = m_queuedRequests.First.Value;
m_queuedRequests.RemoveFirst();
if (request.Tcs.Task.IsCompleted)
{
request.Dispose();
continue;
}
// check secure channel.
if (!m_session.IsSecureChannelValid(request.SecureChannelId))
{
m_logger.LogWarning("Publish abandoned because the secure channel changed.");
request.Tcs.TrySetException(new ServiceResultException(StatusCodes.BadSecureChannelIdInvalid));
request.Dispose();
continue;
}
m_logger.LogTrace(
"PUBLISH: #{Id} Assigned To Subscription({SubscriptionId}).",
request.SecureChannelId,
subscription.Subscription.Id);
subscription.Publishing = true;
request.Tcs.TrySetResult(subscription.Subscription);
request.Dispose();
return;
}
// mark it as available.
subscription.ReadyToPublish = true;
subscription.Timestamp = DateTime.UtcNow;
}
}
/// <summary>
/// Selects a subscription to publish based on priority and timestamp.
/// </summary>
private QueuedSubscription GetSubscriptionToPublish()
{
var availableSubscriptions = new List<QueuedSubscription>();
foreach (KeyValuePair<uint, QueuedSubscription> entry in m_queuedSubscriptions)
{
QueuedSubscription subscription = entry.Value;
if (subscription.ReadyToPublish && !subscription.Publishing)
{
availableSubscriptions.Add(subscription);
}
}
// find the subscription that has been waiting the longest.
if (availableSubscriptions.Count > 0)
{
byte maxPriority = 0;
DateTime earliestTimestamp = DateTime.MaxValue;
QueuedSubscription subscriptionToPublish = null;
for (int ii = 0; ii < availableSubscriptions.Count; ii++)
{
QueuedSubscription subscription = availableSubscriptions[ii];
byte priority = subscription.Subscription.Priority;
if (priority > maxPriority)
{
maxPriority = priority;
earliestTimestamp = DateTime.MaxValue;
}
if (priority >= maxPriority && earliestTimestamp > subscription.Timestamp)
{
earliestTimestamp = subscription.Timestamp;
subscriptionToPublish = subscription;
}
}
subscriptionToPublish.Publishing = true;
return subscriptionToPublish;
}
return null;
}
/// <summary>
/// A request queued while waiting for a subscription to be ready to publish.
/// </summary>
private sealed class QueuedPublishRequest : IDisposable
{
public QueuedPublishRequest(string secureChannelId, DateTime operationTimeout, CancellationToken cancellationToken)
{
SecureChannelId = secureChannelId;
OperationTimeout = operationTimeout;
Tcs = new TaskCompletionSource<ISubscription>(
TaskCreationOptions.RunContinuationsAsynchronously);
m_cancellationTokenRegistration = cancellationToken.Register(
() => Tcs.TrySetCanceled());
// Cancel publish request if it times out
TimeSpan timeOut = operationTimeout < DateTime.MaxValue ? operationTimeout.AddMilliseconds(500) - DateTime.UtcNow : TimeSpan.Zero;
if (operationTimeout < DateTime.MaxValue && timeOut.TotalMilliseconds > 0)
{
m_cancellationTokenSource = CreateCancellationTokenSource(timeOut);
m_cancellationTokenRegistration2 = m_cancellationTokenSource.Token.Register(
() => Tcs.TrySetException(new ServiceResultException(StatusCodes.BadTimeout)));
}
}
private static CancellationTokenSource CreateCancellationTokenSource(TimeSpan delay)
{
// uint.MaxValue is reserved by the underlying timer for an infinite delay.
TimeSpan maximumTimerDelay = TimeSpan.FromMilliseconds(uint.MaxValue - 1u);
if (delay > maximumTimerDelay)
{
delay = maximumTimerDelay;
}
// The .NET Framework CancellationTokenSource constructor only accepts
// delays up to int.MaxValue milliseconds. Timer supports the full range.
if (delay.TotalMilliseconds > int.MaxValue)
{
return new TimerCancellationTokenSource(delay);
}
return new CancellationTokenSource(delay);
}
private sealed class TimerCancellationTokenSource : CancellationTokenSource
{
public TimerCancellationTokenSource(TimeSpan delay)
{
Timer timer = new Timer(
state =>
{
var source = (TimerCancellationTokenSource)state;
try
{
source.Cancel();
}
catch (ObjectDisposedException)
{
}
},
this,
delay,
Timeout.InfiniteTimeSpan);
m_timer = timer;
m_timerRegistration = Token.Register(
state => ((Timer)state).Dispose(),
timer);
}
protected override void Dispose(bool disposing)
{
if (disposing)
{
m_timerRegistration.Dispose();
m_timer?.Dispose();
m_timer = null;
}
base.Dispose(disposing);
}
private Timer m_timer;
private CancellationTokenRegistration m_timerRegistration;
}
public void Dispose()
{
Utils.SilentDispose(m_cancellationTokenRegistration);
Utils.SilentDispose(m_cancellationTokenSource);
Utils.SilentDispose(m_cancellationTokenRegistration2);
}
public readonly string SecureChannelId;
public readonly DateTime OperationTimeout;
public readonly TaskCompletionSource<ISubscription> Tcs;
private readonly CancellationTokenRegistration m_cancellationTokenRegistration;
private readonly CancellationTokenSource m_cancellationTokenSource;
private readonly CancellationTokenRegistration m_cancellationTokenRegistration2;
}
/// <summary>
/// Stores a subscription that belongs to this Session Publish Queue.
/// </summary>
private sealed class QueuedSubscription
{
public QueuedSubscription(ISubscription subscription)
{
Subscription = subscription;
ReadyToPublish = false;
Timestamp = DateTime.UtcNow;
}
public ISubscription Subscription { get; }
public DateTime Timestamp { get; set; }
public bool ReadyToPublish { get; set; }
public bool Publishing { get; set; }
}
/// <summary>
/// Dumps the current state of the session queue.
/// </summary>
internal void TraceState(string context, params object[] args)
{
// Pseudocode:
// 1. Fast exit if trace not enabled.
// 2. Format context with args (InvariantCulture).
// 3. Under lock gather:
// - sessionId
// - subscriptionCount
// - requestCount
// - readyToPublishCount
// - expiredCount
// 4. Emit single structured LogTrace with constant template.
if (!m_logger.IsEnabled(LogLevel.Trace))
{
return;
}
object sessionId = null;
int subscriptionCount;
int requestCount;
int readyToPublishCount = 0;
int expiredCount = 0;
lock (m_lock)
{
sessionId = m_session?.Id;
subscriptionCount = m_queuedSubscriptions.Count;
requestCount = m_queuedRequests.Count;
foreach (KeyValuePair<uint, QueuedSubscription> entry in m_queuedSubscriptions)
{
if (entry.Value.ReadyToPublish)
{
readyToPublishCount++;
}
}
foreach (QueuedPublishRequest request in m_queuedRequests)
{
if (request.OperationTimeout < DateTime.UtcNow)
{
expiredCount++;
}
}
}
m_logger.LogTrace(
"PublishQueue {Context}, SessionId={SessionId}, SubscriptionCount={SubscriptionCount}, RequestCount={RequestCount}, ReadyToPublishCount={ReadyToPublishCount}, ExpiredCount={ExpiredCount}",
Utils.Format(context, args),
sessionId,
subscriptionCount,
requestCount,
readyToPublishCount,
expiredCount);
}
private readonly Lock m_lock = new();
private readonly ILogger m_logger;
private readonly IServerInternal m_server;
private readonly ISession m_session;
private readonly LinkedList<QueuedPublishRequest> m_queuedRequests;
private readonly ConcurrentDictionary<uint, QueuedSubscription> m_queuedSubscriptions;
private readonly int m_maxRequestCount;
}
}