# Description **Server/core audit fixes with regression tests. Latest review-fix validation, merge validation and earlier acceptance results are distinguished below.** This addresses a 95-finding server/core report. Every finding was reviewed with the OPC UA specification knowledge base or, where the standard does not prescribe a C# implementation, the corresponding ownership/configuration contract. Incorrect or withdrawn subclaims remain qualified rather than being presented as additional fixes. The original checkpoint covers session identity/certificate validation and revocation; certificate/key ownership and transactional updates; TCP reconnect, receive/admission and buffer lifetime; HTTP quotas; subscription admission, durability and pooled payloads; file-operation lifecycle; historian aggregates; fluent/state-machine behavior; and related utilities. It includes targeted regressions and directly related documentation. The approved acceptance cleanup is separate in the commit history: | Cleanup | Verified result | | --- | --- | | Invalid identity-policy and KeyCredential fixture inputs | Fixtures explicitly advertise Username and use its generated policy ID. Credential persistence uses valid clear mode inside the existing encrypted admin context. Original permission, lockout and negative encryption assertions remain. | | Native GDS lifetime and concurrent connection failures | Retain ApplicationInstance until client teardown. A deterministic native reproducer proved the test-only channel cap of 10 was exhausted; removing that override restores the existing bounded default of 1000. No global serialization or production quota change. | | Stress certificate ownership and close accounting | Balance two helper references and the fake transport's server-certificate ownership. Replace the invalid event-count bound with exactly-once physical disposal, opens = closes, zero active entries and one logical entry lifetime. | | Participant deadlines | Use the injected TimeProvider with the existing cross-framework WaitAsync overload. Tests pin one tick before, exact expiry, terminal notification, recovery and timely completion. | | Reproducibility and platform assertions | Preserve canonical WoT bytes/hashes, explicit display-culture contracts and exact numeric-vector assertions. Accept Apple's CryptographicException subtype without weakening disposal balance. | | Missing user-signature proof | Reject null/empty proofs before OS crypto. Return BadUserSignatureInvalid per Part 4, 5.7.3.3. None-policy and valid-signature controls remain. A CI-only test nullable-context error was corrected without changing production behavior. | | Durable sample restore and shared test storage | Dequeue waits for actual batch residency instead of treating failed restore completion as success, and restored files close before deletion. Five deterministic regressions failed before the fix. The two fixtures that clear the shared batch directory are isolated; all original 3,000-item assertions remain unchanged. | ## Latest review follow-up Commit `828856850219518970e8e2f580b8f94b3c1fc748` fixes the deferred robotics disposal reported in the latest review. `RobotIntentNodeManager.DisposeAsync` now joins a shared controller-host drain and then explicitly awaits base node-manager disposal. A controller's bounded shutdown wait may defer its cleanup, but no longer lets the node-manager override finish early. Concurrent callers, including an asynchronous call after synchronous `Dispose`, cannot bypass the drain after the host list has been detached. Synchronous disposal remains nonblocking for deferred work. Deferred initialization failures are logged and retained, and base cleanup failures propagate to asynchronous callers. The existing controller-level bounded disposal contract is unchanged; the node-manager contract is documented in `docs/Robotics.md`. | Regression requirement | Evidence | | --- | --- | | Wait for deferred hosts; preserve synchronous compatibility and concurrent joins | `NodeManagerAsyncDisposalWaitsForDeferredHostsAsync`: four cases covering both entry-point orders and zero/positive host shutdown waits. All four failed before the fix. | | Wait through base cleanup and observe failures | `NodeManagerDisposalWaitsForBaseCleanupAndReportsItsFailureAsync`: four cases hold the actual base-resource semaphore, verify pending callers after the host finishes, then check success or the same propagated exception and exactly-once cleanup. | The focused `IntentHostingCoverageTests` and `IntentControllerHostTests.Dispose` selection passed **30/30 on net10.0 and 30/30 on net48**, with no failures or skips. The final net10 solution build passed with zero errors and only the four previously documented CA2249 warnings in unchanged fuzz-test code. No new warnings, analyzer suppressions, dependencies, or weakened assertions were added. The review thread received a commit-specific reply and was explicitly resolved. This verification is scoped to the robotics feedback; the earlier full Subscriptions-run limitation remains recorded in the merge section below. ## Documentation review follow-up (2026-09-14) Commit `f9a9686fcc5d3cfd19cbbc8c2d826e20f5c7e72f` addresses the six follow-up threads on documentation and implementation rationale. Each has an in-thread reply citing the commit and an explicit resolution. Multiline XML documentation now covers the declarations introduced or modified throughout the entire PR, including internal contracts, samples, tests, and public members of related private helpers. A syntax-aware inventory checked **2,031 declarations across all 256 PR C# paths with zero documentation gaps**. A supplementary check also covers **75 previously unchanged public members** of private helpers involved in the changed code. Token comparison across the conditional-compilation branches proves this follow-up changes **no executable C# or test assertions**. Project-file changes are rationale comments only. The implementation questions are documented at their source: | Question | Resolution | | --- | --- | | Certificate assembly friendship | Server Push configuration reuses the internal explicit-subject CSR helper with the existing key; no public crypto API was added. | | Core.Types assembly friendship | Server builders use internal transition callbacks/revision guards; Server.Tests checks the revision deterministically without creating a public compatibility contract. | | Always-single-reader notifications | One dequeuer preserves event order; optional concurrency fans out within one event and joins before the next event. | | Asynchronous disposal completion | `DisposeAsync` already joins the completion published after admitted operations and all cleanup attempts. The compatibility `Dispose` remains nonblocking to avoid deadlocking an admitted callback against its own drain. | The requested detailed review disposition follows. It distinguishes actual fixes from confirmed policies and incorrect subclaims rather than counting every comment as a new runtime change. ### Detailed disposition of review 5191795284 The [SDK review](https://github.com/OPCFoundation/UA-.NETStandard/pull/4477#pullrequestreview-5191795284) was submitted against `1c4a9df6c`, before the subsequent merge and feedback fixes. Its **15 inline threads** have each received an action-specific reply and an explicit resolution. A fresh GraphQL query verified those replies and resolution states; the fixes in `b8a59990f` remain ancestors of the current branch. | Review concern | Action and disposition | Concrete regression evidence | | --- | --- | --- | | Injected certificate-store providers bypassed | **Fixed.** Registration, configuration snapshots, and validation use the injected providers. Explicit custom types remain authoritative; the built-in Directory catch-all is deferred so native X509 paths and later custom providers are not captured. Failed store opens dispose the created store. | `InjectedProviderResolvesRegisteredAndConfiguredTrustStores` covers default-provider ordering and both registration paths; provider validation/open-failure cases and the unchanged `TrustedCertificateInjectedViaIndependentX509StoreIsObservedAsync` cover real use and independent-store visibility. | | Unguarded timer-thread leadership callbacks | **Fixed.** Each subscriber's exception is logged independently and cannot suppress subsequent subscribers or fail lease operations. `IsLeader` reads the deadline without invoking application callbacks. | `ThrowingLeadershipSubscriberDoesNotFailAcquireOrDisposeAsync`, `ExpiryNotifiesOtherSubscribersWhenOneThrowsAsync`, and `IsLeaderDoesNotDispatchExpiryNotificationsAsync` were all demonstrated failing before the fix. | | Legacy pending-key provider accepts an unfinishable regenerated CSR | **Fixed by explicit capability validation.** A provider implementing only `IPendingCertificateKeyStore` receives `BadNotSupported` before key generation or persistence when regeneration is requested. Existing-key CSR/update remains supported. Regeneration requires matching-only consumption; no unsafe destructive probing was introduced. | `LegacyPendingProviderRejectsRegenerationBeforeCreatingOrSavingAKeyAsync` checks no key or store mutation; `LegacyPendingProviderCompletesExistingKeySigningAndUpdateAsync` proves the supported flow completes. | | Shutdown waits behind user deactivation | **Fixed.** Accepted deactivations drain before the master's lifecycle gate is taken. Configuration retains its binding until the shared drain completes, including concurrent shutdown callers and direct master disposal. | Four cases of `ShutdownDrainsDeactivationOutsideTheSessionClosingGateAsync` exercise real configuration/binding/ServerInternalData/master reentry, retained address space, exact session/subscription closure, and no production cancellation shortcut. | | Subclass cleanup runs under the operation-lifetime lock | **Fixed.** Cleanup starts outside that lock. A pre-published completion joins all disposers, and only the active asynchronous teardown context may use guarded helpers. Captured contexts lose that privilege when the callback exits. | `SynchronousOwnedCleanupLetsSamplingWorkerReachClosedAdmissionAsync`, `DisposeCoreCanUseGuardedMembersWithoutReopeningCallerAdmissionAsync`, captured-context rejection, and exact cleanup-failure/ownership assertions cover both synchronous and suspended cleanup. | | Discovery requestId-zero chunk read after pool return | **Fixed by the earlier merge.** Discovery validation precedes `SaveIntermediateChunk`; no read occurs after that path can return the buffer. The ordering is retained. | `DiscoveryChannelReadsTheFirstChunkBeforeItIsReturnedAsync` uses a poisoning pool and the requestId-zero path. | | T1.8 OPN cleanup misses post-decryption throws | **Fixed by the earlier merge and pinned with new regressions.** Both sequence rejection and certificate mismatch release the decrypted body and input ownership. | `OpenSecureChannelRejectionAfterDecryptionReturnsEveryRentalAsync` checks the exact audit status and pool conservation. Omitting either corresponding release in an isolated snapshot made its case fail; no mutation remains. | | T1.2 mount-root protection depends on the provider | **Fixed at the host boundary.** Separator-only aliases resolve to the protected root. Traversal, empty/whitespace segments, backslashes, and drive/stream qualifiers are rejected before arbitrary providers are invoked. Valid nested paths and root destinations remain supported. | A deliberately permissive provider is used by `NonCanonicalObjectPathsCannotDeleteMoveOrCopyAsync` and invalid-target cases; exact zero-call checks are paired with legitimate nested-path/root-destination controls. | | Inline trusted/issuer entries now face CRL checks | **Intentional strict behavior, documented and tested.** A configured backing store with strict unknown-status rejection requires current revocation information. Explicit-only lists without a store retain their no-store behavior. Actual revocation cannot be suppressed; a matching store entry's policy takes precedence. | `InlineIssuerWithStoreHonorsStrictUnknownRevocationPolicyAsync`, `InlineIssuerRevocationIsNeverSuppressedAsync`, store-precedence cases, and explicit-only controls preserve the missing-information versus actual-revocation distinction in Part 4 6.1.3. | | RSA minimum applied to unspecified ECC identifiers | **Fixed at the application-certificate check.** The RSA minimum is compared only with an actual RSA public key. An unspecified ECC identity is not replaced simply because its key size is below an RSA threshold. | `SilentCertificateCheckPreservesUnspecifiedEccIdentityAsync` checks DER, thumbprint, store contents, and private-key retention; explicit RSA and HTTPS minimum controls remain. | | Failed directory refresh wedges corrective mutations | **Fixed.** Recoverable automatic pre-refresh failures are logged and leave reconciliation pending, but do not block corrective provider mutations. Explicit refresh errors, capacity admission, caller cancellation, and actual provider denials remain enforced. | `CorrectiveDeleteRecoversAfterPersistentOverLimitRefreshFailureAsync` converges an externally over-limit directory back to its exact allowed contents. Capacity, cancellation/token, and six refresh-error controls check negative paths. | | Timed-transition rejection logs at 10 Hz | **Fixed.** Repeated `(state, revision, status)` warnings are deduplicated without changing the retry cadence. A different status or state entry permits another warning. | `RepeatedTimedRejectionLogsOnceAndRecoversAsync` checks one warning over eleven rejections and success on the next attempt. Status-change and same/different-state reentry controls pin reset behavior. | | Bad unsubscribe strands retired-generation bookkeeping | **Fixed.** Retired all-event bookkeeping completes even when unsubscribe reports Bad; the first Bad is still returned to the caller. | Good and BadCommunicationError cases of `RetiredAllEventsDeletionCompletesBookkeepingAndReleasesGenerationAsync` check event/snapshot removal, generation release, and exactly one unsubscribe without finalization replay. | | CSR subject parsing and fallback | **Fixed for existing and regenerated keys.** Omitted subjects fall back to the actual stored certificate. Regeneration resolves the public certificate's subject before creating a key. Malformed or unresolvable subjects return `BadInvalidArgument` before pending-key mutation. | Store-only fallback, real-generator null/empty cases, and missing-subject/malformed-DN controls verify the signed CSR, matching fresh pending key, unchanged active identity, and no destructive side effects. | | Committed RemoveUser change reported as failed | **Fixed for RemoveUser and ModifyUser.** Accepted cleanup is still awaited and close failures remain logged, but cannot replace the committed mutation result. Precommit failures retain their original result and side effects. | `CommittedUserChangeKeepsResultAndPublishedUsersWhenCloseFailsAsync` checks published Users, Good result, logging, and continued closes. `FailedUserChangeKeepsPublishedUsersAndDoesNotCloseSessionsAsync` checks BadNotFound with no publication or close. | | Alleged pooled decoded-request aliasing | **No runtime redesign needed; reviewer rebuttal confirmed.** The decoder copies the relevant input data. Misleading ownership comments were corrected rather than introducing a new dispatch model. | `DecodedRequestRetainsValuesAfterInputBuffersAreReturnedAsync` checks the exact decoded NodeId and ByteString after returned arrays are poisoned. | The current documentation-only follow-up rechecked **104 Core, 473 Server, and 4 Configuration cases** covering these concerns: **581 passed, zero failed or skipped**. The final net10 solution build also passed with **zero warnings and errors**. The complete earlier Core/Server/Configuration and net48 results remain listed separately rather than being presented as rerun current-head acceptance. ## Earlier review follow-up Commit `b8a59990fe2e8e967a12ffd5d9158beed7831143` addresses all 19 review threads. Each thread has an in-thread reply naming this commit and was explicitly resolved after verification; the final paginated query found 19 resolved and zero unresolved threads. The follow-up fixes injected certificate-store selection (including default provider ordering and native X509 paths), actual-RSA minimum enforcement, and CSR capability/subject validation before key mutation. Node-manager teardown uses simpler scoped ownership and drains accepted user revocation outside the master gate; committed user results and retired-event cleanup remain correct when cleanup reports failure. File mutations can recover after failed refresh without bypassing capacity or cancellation, provider paths protect mount roots, and repeated timed rejections no longer flood logs. Leadership subscriber failures are isolated without callbacks from `IsLeader`. Regressions also pin the already-merged OPN/discovery buffer fixes and prove decoded request values do not borrow returned input buffers. The strict inline issuer revocation policy is documented and tested, not weakened. Existing tests were changed only for the reviewed behavior: the incorrect committed-user result was corrected, and inline-issuer/root-alias controls were expanded. ### Review-fix validation | Suite | Scope | Framework | Passed | Existing TRX NotExecuted | | --- | --- | --- | ---: | ---: | | Core | Complete project | net10.0 | 4,970 | 88 | | Server | Complete project | net10.0 | 6,414 | 69 | | Configuration | Complete project | net10.0 | 231 | 0 | | Core | Certificate, lease and buffer compatibility slice | net48 | 153 | 0 | | Server | Reviewed lifecycle, user, file, timer and CSR compatibility slice | net48 | 692 | 0 | | Configuration | Complete project | net48 | 231 | 0 | | CSR provider regressions | Final portable-mock follow-up | net10.0 | 11 | 0 | All runs exited successfully with normal concurrency and leak detection. The Server console reports 5 skips; its TRX additionally records existing assumption/explicit cases, hence the 69-record count above. The Framework build caught two modern-only `ValueTask.CompletedTask` usages in new mock setup; only those expressions changed to the equivalent portable `default(ValueTask)`. The complete modern suites precede that test-only correction; all production files remained byte-identical, and the corrected fixture passed on both targets. The final net10 solution build succeeded with 0 errors and the same 4 CA2249 warnings in unchanged fuzz-test code. Diff checks and changed-line whitespace checks are clean; whole-file formatting still identifies 10 unchanged baseline lines, which were not reformatted outside the feedback scope. The committed 35-file tree was hash-verified against the validation inputs. This is the review-feedback verification scope, not a rerun or sign-off of the historical complete platform/native/soak acceptance campaign below. ## Latest upstream merge Merge `9d9bf679f317164c5b2b90924cd3cdc27a86d451` integrates `master` through `162fc5ebb` (#4486), including the AddNodes child-name index, shared certificate-error reporting, CTT sample-data corrections, and the accompanying regressions and documentation. The CreateSession conflict preserves this branch's certificate ownership, required certificate, application-URI, and channel-certificate checks. The validation result now retains nested errors through `ThrowIfInvalid`, allowing the upstream shared reporting helper to mask trust, policy, and revocation failures consistently without losing audit detail. The new indexed AddNodes regression initially attempted to reuse a deterministic NodeId after renaming its existing node. Renaming frees the BrowseName, not that NodeId. `IndexedBrowseNameReusePreservesExistingNodeIdentityAsync` now proves both contracts: the derived-ID collision leaves the original node intact, then a fresh explicitly requested ID can reuse the old name while the new name remains protected against duplicates. No production identity rule was relaxed. The incoming seeded random-index test uses the existing `UnsecureRandom` wrapper with the same seed and sequence; no new analyzer suppression was added. | Local merge validation | Framework | Passed | Existing exclusions | | --- | --- | ---: | ---: | | Core, complete project | net10.0 | 5,081 | 88 | | NodeState / BaseInstanceState | net10.0 | 579 | 0 | | Server node management, certificate and session-security selection | net10.0 | 112 | 0 | | InformationModel node-management services | net10.0 | 29 | 1 | | NodeState / BaseInstanceState | net48 | 578 | 0 | | Core certificate validation, error reporting and TCP buffers | net48 | 111 | 0 | | Server node management, certificate and session-security selection | net48 | 112 | 0 | All selected runs exited successfully at normal concurrency: **6,602 passing test executions**. Modified test assemblies were explicitly rebuilt, and the combined name/identity regression was verified by name in both net10 and net48 results. No skips or weakened assertions were introduced. The final `dotnet build UA.slnx -c Release --no-restore -m:1` with `CustomTestTarget=net10.0` succeeded with **zero warnings and zero errors**. The resolved source and adjusted tests pass whitespace verification, and their source hashes match the validation inputs. This is merge-specific verification. Earlier review results and the previously reported incomplete full Subscriptions runs below remain scoped to their own commits; they were not reopened or relabeled as passing by this operation. ## Previous upstream merge (2026-09-15 morning) Merge `c4694e20ab089c555af233642042133ff3a03ac8` integrates `master` through `484d6c887`, retaining #4481's shared Like parser/GDS query fixes, #4488's RequestHandle recovery in ServiceFaults, and #4487's expired-session and durable-transfer corrections. Three conflict resolutions preserve both sides: - Alias searches now use the shared `LikePattern` implementation, including upstream malformed-list validation. A timeout overload retains this branch's 100 ms per-alias deadline and `BadTimeout` reporting without keeping a second wildcard translator. The shared matcher's original unlimited overload remains unchanged for existing GDS/ContentFilter callers. New regressions cover bounded prefix/list scans, reuse after timeout, and the alias service result. - Expired activation closes outside the session-manager gate using upstream's once-only timeout claim, audit, and diagnostic accounting. This branch's original-channel and security-policy checks remain in place. - TCP buffer tests retain this branch's ownership, poisoning-pool and post-decryption checks alongside the upstream RequestHandle/fault overload tests; neither set was discarded. The upstream HTTPS binary behavior is intentionally retained: a decoder `ServiceResultException` produces HTTP 200 with an OPC UA ServiceFault carrying the decoder status, response timestamp, and recoverable RequestHandle, rather than the previous HTTP 500 text response. Other exceptions retain their existing HTTP error handling. | Local validation | Framework | Passed | TRX NotExecuted | | --- | --- | ---: | ---: | | Core, complete project | net10.0 | 5,054 | 88 | | Sessions, complete project | net10.0 | 780 | 610 | | Server aliases, expiry/security and subscriptions | net10.0 | 288 | 0 | | GDS database, paging and live directory calls | net10.0 | 263 | 0 | | Shared Like patterns and bounded evaluation | net10.0 | 109 | 0 | | Subscriptions transfer/durability/service selection | net10.0 | 23 | 1 | | HTTPS WebApi, complete project | net10.0 | 346 | 0 | | InformationModel aliases | net10.0 | 54 | 5 | | Shared Like patterns and bounded evaluation | net48 | 109 | 0 | | Core fault handles, TCP/HTTPS and filters | net48 | 268 | 0 | | Server aliases, expiry/security and subscriptions | net48 | 288 | 0 | These selected runs exited successfully with normal test concurrency: **7,582 passing test executions**. Sessions' console reports 379 skips; the TRX also contains conditional/assumption exclusions, so the table uses the actual 610 NotExecuted records. No skips or weakened assertions were added. The new `EvaluationTimeoutBoundsWorkAndPreservesPatternReuse` and `SharedPatternTimeoutRemainsAnAliasServiceError` tests passed on both targets. **Validation limitation:** two unfiltered Subscriptions runs did not produce a final result and were stopped, including a retry with a hang guard. They are not counted as passing. The isolated failover fixture passed 2/2, and the transfer/durability/service selection above passed. The stall's cause was not established; no unrelated code or test was changed to conceal it. The final `dotnet build UA.slnx -c Release --no-restore -m:1` with `CustomTestTarget=net10.0` succeeded with **0 warnings and 0 errors**. Whitespace verification passed for all hand-reconciled files, and staged source hashes match the validation inputs. These are merge-specific checks, not a new full platform/native/soak acceptance sign-off. Earlier review and acceptance evidence below remains dated to its own commit. ## Previous upstream merge (2026-09-14) Merge `c3e09553e4d1509502d4ba751960d58491bea2cf` integrates `master` through `6313e38a0` (#4478), including the CTT-driven Part 13 aggregate corrections and FindAlias argument validation. The upstream tests and CTT documentation are retained. The single conflict in `AliasNameWildcardMatcher` is reconciled through the branch's shared regex compiler: upstream malformed-pattern rejection and `IsValidPattern` coexist with OPC UA character escaping, whole-string/newline matching, the 100 ms timeout, and service-level error reporting. The upstream ReferenceTypeFilter checks and chronological aggregate behavior are preserved. Local merge verification: | Suite / selection | Framework | Passed | Existing skips | | --- | --- | ---: | ---: | | Server aliases, aggregates and historian | net10.0 | 1,011 | 0 | | Server aliases, aggregates and historian | net48 | 1,011 | 0 | | InformationModel aliases | net10.0 | 54 | 5 | | Features aliases | net10.0 | 11 | 0 | | Client aliases | net10.0 | 28 | 0 | | History aggregate/historical-access consumers | net10.0 | 265 | 0 | All selected tests passed at normal concurrency. The final net10 solution build passed with 0 errors and 0 warnings. The resolved file's whitespace check and the staged diff check passed. These are merge-specific checks, not a new full platform/native/soak acceptance claim. ## Previous upstream merges Integrates `master` through `8e874d073`, including the Client, Types, Core and source-generator audit fixes in #4471, #4473, #4474 and #4475, plus the event queue-size revision from #4480. The merge commits are `150ea0439` (26 conflict resolutions) and `a0e17c07c` (the base update that arrived during validation). The overlapping fixes are reconciled rather than replacing either branch: - **Rejected-certificate retention follows this branch, as explicitly requested:** zero means unlimited history; negative values disable new storage while preserving existing backend trimming behavior (Directory clears prior history; shared key/value leaves it intact). The processor and manager policy are not redefined, and documentation/tests describe the distinction. - Preserve owned certificate snapshots and borrowed validation-core lifetimes alongside upstream cache invalidation, store-first CRL checks and `BadCertificateRevocationUnknown` for unsupported revocation lookup. - Combine exactly-once chunk ownership, receive-loop cancellation, stale-epoch rejection and detach-before-adoption with upstream signature-before-padding verification and secret cleanup. - Preserve pooled `HttpClient` per-request configuration together with bounded response reads and deadlines that remain active through body consumption. Regression cases exercise already-used clients and both timeout precedence cases. - Retain the binary-compatible channel-key constructor and normalize omitted profiles; preserve exact profile filtering and upstream binary-first HTTPS/WSS endpoint ordering. - Preserve monotonic lease expiry and stale-confirmation fencing while adding ordered, non-reentrant leadership notifications outside the state lock. ## Validation Local validation of the conflict-resolution merge: | Suite | Framework | Passed | Existing skips | | --- | --- | ---: | ---: | | Core | net10.0 | 4,940 | 88 | | Client | net10.0 | 2,278 | 0 | | Server | net10.0 | 6,088 | 5 | | Types | net10.0 | 10,394 | 1 | | SourceGeneration.Core | net10.0 | 3,940 | 8 | | SourceGeneration | net10.0 | 185 | 0 | | Core | net48 | 4,855 | 104 | After the subsequent four-file #4480 update, the related Server slice passed 811 tests with 5 existing skips, the real durable queue-size cases passed 6/6, and EventManager's 21 cases passed again after analyzer-only expected-array cleanup. The final `dotnet build UA.slnx -c Release` with `CustomTestTarget=net10.0` succeeded: 0 errors and 4 pre-existing CA2249 warnings in unchanged fuzz-test code. Whitespace verification passed for the resolved files and the follow-up. Merge-specific proof includes `RequestTimeoutRemainsActiveWhileReadingTheOpenApiBodyAsync` on already-used shared clients with either the request or HttpClient timeout shorter, the existing ownership/expiry regressions from both branches, and both branches' retention tests adjusted only to the explicitly chosen zero/negative contract. Earlier acceptance at `1c4a9df6c` passed hosted Linux/macOS CI, CodeQL, image builds and the canonical coverage gate (87.15% line, 77.27% branch, 92.14% patch). Both Framework project matrices, all three Windows native suites (183 cases), and the unfiltered net10 stress project (230 cases, including full 60-minute chaos and 30-minute memory soaks) also passed. Those are **pre-merge results**, not a claim that the full framework/platform/native/soak matrix has been rerun on this merge. The previous acceptance workflow remains separate from this review-feedback operation. Security checks, meaningful assertions, leak detection, default native concurrency, full soak durations and coverage thresholds remain intact. The user-set ready-for-review state is unchanged. No architectural or complete merged-head acceptance sign-off is claimed. ## Related Issues - Fixes #4476 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [x] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [x] I have addressed **all** PR feedback received.
25 KiB
OPC UA Part 17 — Alias Names
OPC UA Part 17 defines a small but valuable address-space pattern: a hierarchy of human-readable alias names that point at one or more nodes via a non-hierarchical reference type. Clients can search the hierarchy by wildcard pattern and resolve a name to its targets without needing to know the target NodeId in advance — useful for tag-naming schemes (PI / SCADA / DCS), pub/sub topic registries, MES integration, and any scenario where humans pick names but machines need ids.
This stack ships full Part 17 support in Opc.Ua.Server (server
side) and Opc.Ua.Client (client side). The implementation covers:
| Spec section | Type / Method | Status |
|---|---|---|
| §6.2 | AliasNameType (browsable instance nodes) |
✔ opt-in — see below |
| §6.3.1 | AliasNameCategoryType (incl. nesting) |
✔ (nested instances opt-in — see below) |
| §6.3.1 | LastChange (VersionTime) |
✔ |
| §6.3.2 | FindAlias |
✔ |
| §6.3.3 | FindAliasVerbose |
✔ |
| §6.3.4 | AddAliasesToCategory |
✔ |
| §6.3.5 | DeleteAliasesFromCategory |
✔ |
| §7.2 | AliasNameDataType |
✔ |
| §7.3 | AliasNameVerboseDataType |
✔ |
| §8.2 | AliasFor reference type |
✔ |
| §9.2 | Well-known Aliases (i=23470) |
✔ wired; optional methods opt-in — see below |
| §9.3 | Well-known TagVariables (i=23479) |
✔ wired; optional methods opt-in — see below |
| §9.4 | Well-known Topics (i=23488) |
✔ wired; optional methods opt-in — see below |
| Annex D | PubSub replication (LastChange notifications) | ✔ transport-agnostic — see below |
Server side — Opc.Ua.Server.AliasNames
Search patterns use the shared LikePattern parser and matcher, with case-sensitive whole-string
matching. Backslashes escape literal characters inside and outside
character sets; [^...] negates a set ([!...] remains accepted for
compatibility). Wildcards match line breaks. Trailing escapes, malformed sets,
descending ranges, and unescaped ^ outside the start of a set return
BadInvalidArgument from both FindAlias variants even with an empty
store. Matching each alias name has a 100 ms time limit; exceeding it returns
BadTimeout. The server also checks for request cancellation before matching
the next name.
The server library exposes a pluggable backend (IAliasNameStore) plus
a default in-memory implementation. Apps assemble their alias inventory
inside a store, then either:
- Register the store through
AddAliasNameStore(...)on the DI server builder, or directly with the server-wideIAliasNameStoreRegistry, so the standard well-knownAliases/TagVariables/Topicsnodes start dispatching through it, or - Wrap the store in an
AliasNameNodeManagerto expose application- defined categories under a custom namespace (with fullAddAliasesToCategory/DeleteAliasesFromCategorysupport).
Both approaches can be combined.
Quick start — serving standard categories
using Microsoft.Extensions.DependencyInjection;
using Opc.Ua;
using Opc.Ua.Server.AliasNames;
var tagVariables = new AliasNameCategoryDescriptor(
ObjectIds.TagVariables,
QualifiedName.From(BrowseNames.TagVariables),
AliasNameCapabilities.FindAliasVerbose);
var store = new InMemoryAliasNameStore([tagVariables]);
store.Seed(ObjectIds.TagVariables, "ServerCurrentTime",
new ExpandedNodeId(VariableIds.Server_ServerStatus_CurrentTime),
serverUri: null,
referenceTypeId: ReferenceTypeIds.AliasFor);
services.AddOpcUa()
.AddServer(options =>
{
options.ApplicationName = "AliasServer";
options.EndpointUrls.Add("opc.tcp://localhost:4840/AliasServer");
})
.AddAliasNameStore(store)
.ConfigureAliasNames(options => options.MaterializeAliasNodes = true);
AddAliasNameStore(...) and AddAliasNameStoreRegistry(...) register
their stores before address-space startup, after application
IServerPreStartupTask registrations have finished initializing source
registries. The opt-in
ConfigureAliasNames(Action<AliasNameServerOptions>) extension is on
IOpcUaServerBuilder in Microsoft.Extensions.DependencyInjection.
AliasNameServerOptions is in Opc.Ua.Server.AliasNames, and its
MaterializeAliasNodes property defaults to false.
When enabled, the normal ConfigurationNodeManager materializes
registered standard-category aliases and their declared optional
capabilities after the standard nodes have loaded. No server or
diagnostics-node-manager subclass is needed. The same setting applies
to stores for Topics; their targets must be PublishedDataSetType
instances. Omit ConfigureAliasNames(...) when only method-based
lookup is needed.
When a client calls Aliases.FindAlias (i=23476),
TagVariables.FindAlias (i=23485) or Topics.FindAlias (i=23494),
DiagnosticsNodeManager's late binder routes the call through the
registry to the matching store.
Direct IAliasNameStoreRegistry registration remains available for
custom hosting. Register stores before the materialization pass when
their aliases must also be browsable.
Quick start — application-defined categories
AliasNameNodeManager is a CustomNodeManager2 that owns a namespace
and creates its own category tree from the store's
RootCategories. Add it to your server's node-manager list:
var myRoot = new AliasNameCategoryDescriptor(
new NodeId("My/Category", myNamespaceIndex),
new QualifiedName("My/Category", myNamespaceIndex),
AliasNameCapabilities.All); // expose every optional method
var store = new InMemoryAliasNameStore([myRoot]);
nodeManagers.Add(new AliasNameNodeManager(server, configuration, store));
Options:
NamespaceUri— controls the namespace under which the manager registers its category instances. Defaults tohttp://opcfoundation.org/UA/AliasName/. Every category descriptor's NodeId must lie in this namespace; descriptors pointing anywhere else are skipped with a warning rather than claiming another manager's ids.MaterializeAliasNodes(defaulttrue, unchanged forAliasNameNodeManagerOptions) — creates one browsableAliasNameTypenode per alias, withAliasForreferences to its targets, exactly as the standard-node materialization below does. Disable to expose only the category tree.LinkToStandardAliasesObject(defaulttrue) — addsOrganizesexternal references from the well-knownAliases (i=23470)object to the manager's root categories so they show up in the standard browse tree.RequireSecurityAdminForMutations(defaulttrue) — rejectsAddAliasesToCategory/DeleteAliasesFromCategorycalls from unauthenticated users or sessions without theWellKnownRole_SecurityAdminrole on aSignAndEncryptchannel.RegisterWithServerRegistry(defaulttrue) — also registers the store withIAliasNameStoreRegistryso the well-known standard nodes see it.
Browsable alias nodes
Registering a store makes FindAlias answer from it, but the aliases
themselves stay inside the store — nothing in the address space shows
them. Part 17 §6.2 clients (the OPC Foundation CTT among them) also
browse for aliases, so a server under conformance test needs the
alias hierarchy materialized as real nodes.
Both materialization paths — AliasNameNodeManager for
application-defined namespaces and
DiagnosticsNodeManager.MaterializeRegisteredAliasNameNodesAsync for
the standard well-known nodes — run the same shared walker
(AliasNameNodeMaterializer), so they produce structurally identical
Part 17 trees and every fix lands in both at once.
For the standard DI server, ConfigureAliasNames(options => options.MaterializeAliasNodes = true) makes the normal
ConfigurationNodeManager invoke that helper. Its default is false,
independent of the custom AliasNameNodeManagerOptions default of
true. Metadata, resource, and alias configuration use the
DependencyInjectionStandardServer hooks; a non-DI custom
AddServer<TServer>() rejects these DI-only settings rather than
silently ignoring them.
DiagnosticsNodeManager.MaterializeRegisteredAliasNameNodesAsync does
that for every registered store: one AliasNameType instance per alias
— BrowseName carrying the alias name, AliasFor references to its
targets, and the inverse HasAlias reference added on each local
target — plus an AliasNameCategoryType instance for every store
category the standard NodeSet does not already ship (nested categories
included; a root category from the store is organized under the
standard Aliases object so it stays browse-discoverable). Remote
targets get their server URI registered in the server's ServerUris
table and referenced with the matching ServerIndex. Server-defined
BrowseNames that a descriptor left in namespace 0 — reserved for
OPC-Foundation-defined names — are re-homed into the diagnostics
namespace; Part 17 clients compare alias names ignoring the namespace,
so this is transparent to them. The pass is idempotent, and only
creates category nodes whose NodeId lies in the diagnostics namespace —
a descriptor pointing anywhere else is skipped with a warning rather
than claiming another manager's (or the standard NodeSet's) ids.
Custom diagnostics-node-manager implementations can still call the
helper from an overridden CreateAddressSpaceAsync, after base has
loaded the standard categories:
public override async ValueTask CreateAddressSpaceAsync(
IDictionary<NodeId, IList<IReference>> externalReferences,
CancellationToken cancellationToken = default)
{
await base.CreateAddressSpaceAsync(externalReferences, cancellationToken)
.ConfigureAwait(false);
await MaterializeRegisteredAliasNameNodesAsync(
externalReferences, cancellationToken).ConfigureAwait(false);
}
The same pass also instantiates the optional Part 17 members —
FindAliasVerbose, AddAliasesToCategory, DeleteAliasesFromCategory
and LastChange — on every category whose descriptor declares them
through AliasNameCapabilities, including the well-known ones the
standard NodeSet ships without them:
var tagVariables = new AliasNameCategoryDescriptor(
ObjectIds.TagVariables,
QualifiedName.From(BrowseNames.TagVariables),
AliasNameCapabilities.All); // verbose + add + delete + LastChange
Mutation calls are gated on a SecurityAdmin caller over a
SignAndEncrypt channel and return BadUserAccessDenied otherwise.
Standard-category materialization is opt-in: servers that only need
FindAlias to answer from their store do not create alias instance
nodes. The created nodes are a snapshot taken at address-space creation
— aliases added or removed later through
AddAliasesToCategory / DeleteAliasesFromCategory change what
FindAlias returns and advance LastChange, but do not add or remove
AliasNameType nodes.
The browse view carries AliasFor associations only: an entry a store
holds under an unrelated reference type is not a Part 17 §6.2 alias
association, so it is served by FindAlias (with a matching filter)
but not materialized. Entries stored under an AliasFor subtype are
materialized, but always as the base AliasFor reference — the
verbose record does not carry the concrete reference type.
Two things the caller controls:
- Give category descriptors a BrowseName in a namespace the server
owns. The store stamps that namespace onto every alias
QualifiedNameit reports, and the materializer re-homes ns=0 BrowseNames out of the reserved OPC Foundation namespace — with a server-owned descriptor namespace the query results and the browsable nodes agree, so a returned alias name resolves viaTranslateBrowsePathsToNodeIds. The reference server uses the diagnostics namespace for all its descriptors. - Part 17 §9 constrains
Topicsaliases toPublishedDataSetTypetargets. Neither the store norAddAliasesToCategoryenforces this — a server that exposes the mutation methods onTopicsshould only grant them to operators who preserve the constraint.
Quickstarts.ReferenceServer uses this in
ReferenceServerConfigurationNodeManager, which also creates the
PublishedDataSet instances and seeds the Topics aliases that point
at them — in the same place, so an alias can never target a dataset
that was not created. The nested Devices sub-category under
TagVariables is declared with the store seeding in
ReferenceServer.ConfigureAliasNameStore.
Custom backend
Implement IAliasNameStore to back the alias inventory with your own
storage (DB, file, MES, …). The interface is small:
public interface IAliasNameStore
{
IReadOnlyList<AliasNameCategoryDescriptor> RootCategories { get; }
event EventHandler<AliasStoreChangedEventArgs>? Changed;
uint? GetLastChange(NodeId categoryId);
bool OwnsCategory(NodeId categoryId);
ValueTask<IReadOnlyList<AliasNameDataType>> FindAliasAsync(...);
ValueTask<IReadOnlyList<AliasNameVerboseDataType>> FindAliasVerboseAsync(...);
ValueTask<StatusCode[]> AddAliasesAsync(...);
ValueTask<StatusCode[]> DeleteAliasesAsync(...);
}
The reference InMemoryAliasNameStore is thread-safe (SemaphoreSlim),
supports nested categories and emits Changed events that bubble up to
the address-space LastChange property. A mutation on a nested
category bumps — and notifies for — every ancestor category as well,
per Part 17 §6.3.1/§9.2: a category's LastChange reflects the most
recent change anywhere in its subtree, and the root Aliases value
reflects any change at all.
Client side — Opc.Ua.Client.AliasNames
The client library provides a high-level AliasNameClient plus a
caching AliasNameResolver.
using Opc.Ua.Client.AliasNames;
// Standard categories have hardcoded method NodeIds so the first call
// is one round-trip — no extra TranslateBrowsePaths probe needed.
AliasNameClient client = AliasNameClient.OpenStandardTagVariables(session);
IReadOnlyList<AliasNameDataType> result =
await client.FindAliasAsync("TIC%", referenceTypeFilter: null, ct);
AliasNameClient exposes the full Part 17 method surface:
FindAliasAsync(pattern, referenceTypeFilter, ct)FindAliasVerboseAsync(...)— throwsNotSupportedExceptionwhen the category does not expose the optional method.AddAliasesToCategoryAsync(IEnumerable<AliasNameAddRequest>, ct)DeleteAliasesFromCategoryAsync(IEnumerable<AliasNameDeleteRequest>, ct)EnumerateSubCategoriesAsync(ct)—IAsyncEnumerableof childAliasNameSubCategoryInfo.ReadLastChangeAsync(ct)— returns theVersionTime(ornullwhen the category does not exposeLastChange).
Per-call errors map to typed exceptions:
| Status code | Exception |
|---|---|
BadUserAccessDenied |
UnauthorizedAccessException |
BadNotSupported |
NotSupportedException |
BadNotImplemented |
NotSupportedException |
other BadXxx |
ServiceResultException |
AliasNameResolver — cached alias→NodeId
await using var resolver = new AliasNameResolver(
AliasNameClient.OpenStandardTagVariables(session));
IReadOnlyList<ExpandedNodeId> targets =
await resolver.ResolveAsync("TIC101_Setpoint", ct);
string aliasName = await resolver.ResolveAliasNameAsync(targets[0], ct);
Default refresh mode is Manual — callers invoke RefreshAsync
(or rely on lazy-load via ResolveAsync). Opt in to automatic cache
invalidation via one of:
AliasNameResolverRefreshMode |
Strategy | When to use |
|---|---|---|
Manual (default) |
ManualAliasNameRefreshStrategy |
Caller drives refresh explicitly. Safe everywhere. |
AutoOnLastChangePolling |
PollingAliasNameRefreshStrategy |
Server lacks Subscriptions or you want a fixed Read cadence. |
AutoOnLastChangeMonitoredItem |
MonitoredItemAliasNameRefreshStrategy |
Server supports Subscriptions. Push-based — no Read per interval. |
Custom strategies (e.g. the Annex D PubSub bridge in
Opc.Ua.Client.AliasNames.PubSub — see Annex D below) plug in via:
new AliasNameResolverOptions
{
RefreshStrategy = new MyCustomStrategy() // takes precedence over RefreshMode
}
The IAliasNameRefreshStrategy contract is tiny:
public interface IAliasNameRefreshStrategy : IAsyncDisposable
{
ValueTask StartAsync(AliasNameClient client, Action onInvalidate, CancellationToken ct);
}
Implementations watch for stale-cache triggers and invoke
onInvalidate whenever they detect a change. MonitoredItemAliasNameRefreshStrategyOptions
controls the underlying Subscription: it can be left owned (default
— created + deleted by the strategy) or set via SharedSubscription
to plug the monitored item into an externally managed subscription.
Disposing the resolver (await using / DisposeAsync) tears down the
strategy: timer for polling, MonitoredItem + Subscription for the
monitored-item variant. Disposal is idempotent and never throws.
Spec deviations / wrinkles
-
AliasNameDataType.ReferencedNodes— the wire format defines this asExpandedNodeId[](NodeSeti=18), notNodeId[]. The source-generatedAliasNameDataTypeis correct; the historical Quickstart sample usedNodeId[]and has been removed. -
Standard well-known nodes — the OPC UA NodeSet instantiates only
FindAliasonAliases/TagVariables/Topics(plusLastChangeonAliases), so the always-on binder wires just those. The optional methods are added byMaterializeRegisteredAliasNameNodesAsyncthrough the generatedAddFindAliasVerbose/AddAddAliasesToCategory/AddDeleteAliasesFromCategoryoptional- child helpers, for each category whose descriptor declares the matchingAliasNameCapabilities. Each child is created at the NodeId the OPC Foundation reserves for it (Aliases.FindAliasVerbose=i=24054,TagVariables.LastChange=i=32854, and so on).Those identifiers are allocated in the standard identifier registry (
StandardTypes.csv) but are deliberately not declared in the ModelDesign and not present in the published NodeSet — the standard address space does not instantiate optional children. A reserved id is a number set aside for the node if a server chooses to expose it, not a node the server must have. Consequently the source generator emits no parent-to-instance mapping and noMethodIdsconstant for them, andDiagnosticsNodeManager.ReservedChildIdssupplies the nine method ids and the two missingLastChangeids explicitly, each traceable to its registry row. The argument properties do have generatedVariableIdsconstants and are referenced through those.Do not "fix" this by declaring the children in
StandardTypes.xml: that file is a verbatim copy of the OPC Foundation's ModelDesign and is re-synced from upstream, so a local edit is lost on the next sync and the NodeIds silently revert to factory-minted ones. -
AliasNameCapabilities.AddAliasesToCategory/DeleteAliasesFromCategory— on anAliasNameNodeManagerthis defaults toSecurityAdmin-only viaAliasNameNodeManagerOptions.RequireSecurityAdminForMutations; on the standard well-known nodes the same check is always applied and cannot be opted out of. It requires both the role grant AND aSignAndEncryptchannel. -
ReferenceTypeFiltersemantics — null/empty andReferenceTypeIds.Referencesmatch every alias regardless of reference type. Otherwise matches are limited to aliases whose reference type is, or is a subtype of, the filter (usingServer.TypeTree.IsTypeOf).
Annex D — PubSub LastChange notifications
Part 17 Annex D defines a lightweight PubSub schema for alias-change
notifications between servers. The schema carries only each category's
current LastChange value (a VersionTime/uint) — subscribers learn
that a publisher's category changed, then refetch alias contents via
FindAlias/FindAliasVerbose if needed.
The data types (already emitted by the source generator):
| NodeId | Type | Fields |
|---|---|---|
i=24052 |
AliasCategoryUpdateDataType |
Category : PortableNodeId, LastChange : VersionTime |
i=24053 |
AliasUpdateDataType |
ApplicationUri : string, Categories : AliasCategoryUpdateDataType[] |
Server side — Opc.Ua.Server.AliasNames.PubSub
The server library exposes a transport-agnostic publisher that emits
fully-built AliasUpdateDataType messages whenever an
IAliasNameStoreRegistry-tracked store changes:
using Opc.Ua.Server.AliasNames;
using Opc.Ua.Server.AliasNames.PubSub;
// inside server startup (after the alias store is registered):
var resolver = new ServerPortableNodeIdResolver(server);
var publisher = new AliasNamePublisher(
registry: ((IAliasNameStoreRegistryProvider)server).AliasNameStoreRegistry,
portableResolver: resolver,
applicationUri: configuration.ApplicationUri);
publisher.AliasUpdateProduced += (_, e) =>
{
// Hand `e.Update` to your transport — e.g. publish a DataSetMessage
// through Opc.Ua.PubSub.UaPubSubApplication with the DataSet
// built by AliasUpdateDataSetFactory.Create(...).
};
Helpers shipped:
IPortableNodeIdResolver+ServerPortableNodeIdResolver— converts a localNodeIdinto the spec-requiredPortableNodeId(NamespaceUri + Identifier with namespace index stripped).AliasUpdateDataSetFactory.Create(dataSetClassId)— builds the fixed-by-specDataSetMetaDataTypedescribing theAliasUpdateDataSet (ApplicationUri : string,Categories : AliasCategoryUpdateDataType[]).AliasNamePublisher— subscribes to the registry, builds and emitsAliasUpdateDataTypemessages via theAliasUpdateProducedevent.
The library deliberately stays transport-agnostic: it raises the
fully-built AliasUpdateDataType and lets the application wire it
into Opc.Ua.PubSub.UaPubSubApplication (UDP / JSON / MQTT) or any
other transport that can carry the AliasUpdateDataType payload.
Client side — Opc.Ua.Client.AliasNames.PubSub
The client library mirrors the publisher:
using Opc.Ua.Client.AliasNames;
using Opc.Ua.Client.AliasNames.PubSub;
var reader = new AliasNamePubSubReader(
new AliasNamePubSubReaderOptions
{
ExpectedApplicationUri = "urn:opcfoundation:publisher",
});
// Hand incoming AliasUpdateDataType messages off to the reader from
// your transport (e.g. UaPubSubApplication.DataReceived, an MQTT
// subscriber callback, ...):
reader.Submit(receivedAliasUpdate);
// Wire reader into the resolver so the cache invalidates on every
// LastChange bump observed via PubSub.
await using var resolver = new AliasNameResolver(
AliasNameClient.OpenStandardAliases(session),
new AliasNameResolverOptions
{
RefreshStrategy = new AliasNamePubSubRefreshStrategy(reader),
});
Helpers shipped:
AliasNamePubSubReader— surfaces incomingAliasUpdateDataTypemessages as theAliasUpdateReceivedevent. OptionalExpectedApplicationUrifilter drops messages from other publishers.AliasNamePubSubRefreshStrategy : IAliasNameRefreshStrategy— bridges the reader into the resolver. Matches incoming entries by the resolver's categoryNamespaceUri+ identifier; firesInvalidateon any value-difference (wrap-safe — the comparison is inequality, not strict greater-than).
The PubSub bridge plugs into the same IAliasNameRefreshStrategy
extension point as the polling and monitored-item strategies — apps
can mix-and-match, e.g. fall back to polling on a particular category
while letting PubSub drive the rest.
See also
- OPC UA Part 17 specification: https://reference.opcfoundation.org/v105/Core/docs/Part17/
- Dependency Injection — hosted store registration and standard-category materialization.
tools/Opc.Ua.SourceGeneration.Core/Design/StandardTypes.xml— Part 17 type definitions consumed by the source generator.tests/Opc.Ua.Server.Tests/AliasNames/— server-side unit tests.tests/Opc.Ua.Client.Tests/AliasNames/— mocked-session and live integration tests.samples/Quickstarts.Servers/ReferenceServer/ReferenceServer.cs—ConfigureAliasNameStoreshows how to seed and register a store.