mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-27 04:59:55 +08:00
# Description
Fixes the SourceGeneration findings of a read-only bug audit of
`a05a36055` — sections 15 (host generators, Roslyn side), 16
(SourceGeneration.Core schema / ModelDesign loader) and 17
(SourceGeneration.Core generators). 36 of the 39 findings are fixed;
each has a regression test.
### Generated-code correctness
- **State machine NodeId constants** were emitted as `const uint` even
when the aliased `Objects` constant is a `string`, so every model using
string NodeIds with a `FiniteStateMachineType` subtype failed with
CS0029. The constant type now follows the aliased node, looked up from
the same source `NodeIdGenerator` emits from — top-level nodes **plus
each node's instance hierarchy**, since a state or transition only ever
exists as a hierarchy entry.
- `NodeIdGenerator` emitted string identifiers into C# string literals
without escaping them.
- Structure field names are authored data, so they can be C# keywords or
collide with the members every generated data type carries. Properties
and `{Type}Fields` members now go through a sanitizing,
collision-breaking mapping (including two siblings that sanitize to the
same identifier). **Wire names are untouched** — OPC 10000-3 §8.51
requires the StructureField name to match the BrowseName, and the
`DataMember`/encode/decode names still come from `Parameter.Name`.
- `NodeStateGenerator`'s copy-on-write cast now uses the fully qualified
data type name, which a cross-model structure needs.
- `GetScalarValueAsCode` emitted `(double)NaN` and the infinities, which
do not compile.
- `TemplateWriter` formatted with the current culture, so a machine with
a comma decimal separator emitted invalid generated source.
### Served schema documents
- The binary schema described a **different wire layout than the
generated `Encode`/`Decode`**: unions carried no
`SwitchField`/`SwitchValue`, and structures with optional fields carried
no encoding-mask presence bits. Both are now emitted per **OPC 10000-6
§5.2.7**, matching the layout the runtime `BsdSchemaGenerator` produces.
A structure with more than 32 optional fields now fails generation
instead of silently wrapping `1 << 32` back onto the first field's bit.
- Documentation text and attribute values are XML-escaped.
### ModelDesign loading and validation
- Identifiers pinned in a CSV were dropped whenever any other loaded
namespace declared the same symbolic name. Removal is now scoped to the
file's target namespace, and explicit `NumericId`s are keyed by
`(namespace, id)` so the same number in two namespaces is legal.
- Declaration order inside a design file no longer matters — base types
are imported and validated ahead of their subtypes.
- OptionSet `OptionSetValues` were truncated at bit 31 (signed shift)
and bits 32–63 of a 64-bit option set were never emitted.
- An authored `ValueRank` is no longer overwritten by the shape of the
default value (OPC 10000-3 §6.2.8: a ValueRank may only be further
restricted), and a VariableType data type may be narrowed any number of
levels deep rather than exactly one.
- NodeSet import: `AccessRestrictions="0"` means "no restrictions", not
`EncryptionRequired` (OPC 10000-3 §8.56) — an unrecognised mask stays
**fail-closed**; a NodeSet without `<Models>` reports what is wrong; an
optional `<References>` no longer throws; the parent/child reference
scan looks at the parent's references; and `IsTypeOf` terminates on the
self-referential root reference types NodeSets routinely declare.
- Version comparison is numeric per component (ordinally `"1.05.9"`
sorts above `"1.05.10"`) and now lives on `SemVer`, so the NodeSet
collection and the dependency tie-break cannot pick different winners; a
publication-date version no longer outranks a real one.
### Host generator
- `[DataType]` on an `enum` is matched again (an enum is not a
`TypeDeclarationSyntax`), MODELGEN003 renders its arguments instead of
the raw template, and the Types hint name keeps the namespace's dots so
`A.BC` and `AB.C` cannot claim the same one.
- Compilation-derived pipeline stages carry value comparers, so editing
a file no longer re-runs the entire model generation on every keystroke.
- A NodeSet that fails to load skips that file rather than every
remaining one; a file listed twice as an `AdditionalFile` is deduped;
superseded NodeSet versions are still recognised as NodeSet inputs and
not generated a second time by the ModelDesign pass.
- `LogLevel.Critical` maps to a diagnostic instead of being silently
dropped.
### Client
- `EventRecordFieldReaders` gained the readers the event record
generator needs (including `Variant`, enumerations and the array forms).
Fields whose type had no reader were declared on the record but never
populated, so they read as `null`/`default` for every event.
## Not fixed (deliberately)
- **Forward same-namespace hierarchical references in
`NodeSetToModelDesign.ImportReferences`** — the audit flags the
inverse-only handling as asymmetric. Making it symmetric compiles and
passes every generator unit test, but regresses the address space: all
17 `RobotOpenUsdE2eTests` fail in `OneTimeSetUpAsync` because the hosted
server never finishes starting. Reverted, with a comment at the site
recording why.
- **§17.10 and §15.10** (both low + PLAUSIBLE) — each needs a wider
refactor than this PR: a consistent NodeId-constant rename across ~6
cross-reference sites, and replacing `Location` with a serializable
equivalent for incremental cache equality.
## Spec cross-check
The encoding/schema changes were checked against the specification: OPC
10000-6 §5.2.7 (32-bit EncodingMask, one bit per optional field in
order, padded), the union `SwitchField` encoding, OPC 10000-3 §8.56
(AccessRestrictionType bit mask), §6.2.8 and §5.6.2/§5.6.5 (ValueRank),
§8.51 (StructureField name == BrowseName).
`GenerateStackTests.OptionalFieldBitsAgreeBetweenBsdAndGeneratedEncoder`
pins the BSD presence-bit order against the generated encoder's
`LogRecordFields` so the two cannot drift apart again.
## Related Issues
_No tracking issue — this PR implements the SourceGeneration sections of
a bug audit. Happy to open one if maintainers prefer._
## Checklist
- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
> Note on the test checkbox: verified on **net10.0 only** — `UA.slnx`
builds clean (0 warnings, 0 errors) and
`Opc.Ua.SourceGeneration.Core.Tests` (3915),
`Opc.Ua.SourceGeneration.Tests` (184), `Opc.Ua.Di.Tests` (425, including
the `RobotOpenUsdE2eTests` end-to-end fixture that catches address-space
content changes) and the `EventRecordFieldReaders` tests (16) all pass.
.NET Framework has **not** been run locally; CI needs to confirm it.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Marc Schier <marcschier@users.noreply.github.com>
528 lines
25 KiB
C#
528 lines
25 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Collections.Immutable;
|
|
using System.Linq;
|
|
using System.Text;
|
|
using System.Threading;
|
|
using Microsoft.CodeAnalysis;
|
|
using Microsoft.CodeAnalysis.CSharp;
|
|
using Opc.Ua.SourceGeneration.Dependency;
|
|
|
|
namespace Opc.Ua.SourceGeneration
|
|
{
|
|
/// <summary>
|
|
/// Compiles the model. This honors the options of the compile command
|
|
/// of the tool. However, it does not generate identifier files and
|
|
/// assumes that if identifiers are required they are loaded from a
|
|
/// csv file that is side by side with the design files. Also, this
|
|
/// does not produce xsd or bsd nor nodeset files, which cannot be
|
|
/// added to a compilation using roslyn source generator (yet).
|
|
/// </summary>
|
|
internal sealed class ModelCompilation
|
|
{
|
|
/// <summary>
|
|
/// Create compilation
|
|
/// </summary>
|
|
public ModelCompilation(
|
|
SourceProductionContext context,
|
|
ImmutableArray<(AdditionalText, NodesetFileOptions)> inputFiles,
|
|
ImmutableArray<AdditionalText> csvFiles,
|
|
ImmutableArray<AdditionalText> identifierFiles,
|
|
ModelCompilationOptions options,
|
|
CompilationOptions compilationOptions,
|
|
ImmutableArray<ModelDependencyReference> referencedModels,
|
|
ImmutableArray<ModelFluentAccessorProviderReference> referencedAccessorProviders,
|
|
ImmutableArray<NodeManagerAttributeDiscovery> nodeManagerBindings,
|
|
ImmutableHashSet<string> availableStateTypeNames)
|
|
{
|
|
m_context = context;
|
|
m_input = inputFiles;
|
|
m_csvFiles = csvFiles;
|
|
m_identifierFiles = identifierFiles;
|
|
m_options = options;
|
|
m_compilationOptions = compilationOptions;
|
|
m_nodeManagerBindings = nodeManagerBindings;
|
|
m_referencedModels = referencedModels;
|
|
m_referencedAccessorProviders = referencedAccessorProviders;
|
|
m_availableStateTypeNames = availableStateTypeNames;
|
|
m_telemetry = SourceGeneratorTelemetry.Create(m_context);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Perform the compilation
|
|
/// </summary>
|
|
public void Emit(CancellationToken cancellationToken)
|
|
{
|
|
if (!CheckCompilationOptions())
|
|
{
|
|
return;
|
|
}
|
|
var sourceFiles = new SourceGeneratorFileSystem(
|
|
m_input.Select(i => i.Item1).Concat(m_csvFiles));
|
|
|
|
using var vfs = new VirtualFileSystem(); // Use a virtual file sytem
|
|
try
|
|
{
|
|
if (m_input.Length == 0)
|
|
{
|
|
// Nothing to do
|
|
return;
|
|
}
|
|
|
|
string[] exclusions = [.. m_options.Exclude
|
|
.Append("Draft")
|
|
.Distinct()];
|
|
var generatorOptions = new GeneratorOptions
|
|
{
|
|
Cancellation = cancellationToken,
|
|
Exclusions = exclusions,
|
|
// csharp10 or below does not support utf8 string literals
|
|
UseUtf8StringLiterals =
|
|
m_compilationOptions.LanguageVersion >= LanguageVersion.CSharp11,
|
|
OptimizeForCompileSpeed =
|
|
m_compilationOptions.OptimizationLevel == OptimizationLevel.Debug,
|
|
OmitObjectTypeProxies = m_options.OmitObjectTypeProxies,
|
|
ObjectTypeProxyNamespace =
|
|
string.IsNullOrWhiteSpace(m_options.ObjectTypeProxyNamespace)
|
|
? null
|
|
: m_options.ObjectTypeProxyNamespace,
|
|
UseTypeDefinitionModellingRules =
|
|
m_options.UseTypeDefinitionModellingRules,
|
|
EmitDependencyMetadata = ResolveEmitDependencyMetadata(),
|
|
OmitFluentApi = m_options.OmitFluentApi,
|
|
FluentAccessorsOnly = m_options.FluentAccessorsOnly,
|
|
OmitEventRecords = m_options.OmitEventRecords
|
|
};
|
|
|
|
// Load all available nodeset files from the input
|
|
NodesetFileCollection nodesets = m_input.ToNodeSetFileCollection(
|
|
m_csvFiles,
|
|
sourceFiles, // .WithFallback(vfs),
|
|
m_telemetry);
|
|
ReportNodesetIdentifierDiagnostics(nodesets.IdentifierValidationErrors);
|
|
|
|
// Resolve [NodeManager] bindings: validate partial-ness and
|
|
// build the binding list to pass into both GenerateCode calls
|
|
// (nodeset-derived and design-file-derived).
|
|
var bindings = new List<NodeManagerAttributeBinding>();
|
|
var bindingByPayload =
|
|
new Dictionary<NodeManagerAttributeBinding, NodeManagerAttributeDiscovery>();
|
|
foreach (NodeManagerAttributeDiscovery discovery in m_nodeManagerBindings)
|
|
{
|
|
if (discovery == null)
|
|
{
|
|
continue;
|
|
}
|
|
if (!discovery.InvalidExpressions.IsDefaultOrEmpty)
|
|
{
|
|
string targetType = string.IsNullOrEmpty(
|
|
discovery.Binding.TargetNamespace)
|
|
? discovery.Binding.TargetClassName
|
|
: discovery.Binding.TargetNamespace +
|
|
"." +
|
|
discovery.Binding.TargetClassName;
|
|
foreach (NodeManagerAttributeExpressionError error in
|
|
discovery.InvalidExpressions)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.NodeManagerArgumentUnresolved,
|
|
error.Location,
|
|
error.ArgumentName,
|
|
error.Expression,
|
|
targetType));
|
|
}
|
|
continue;
|
|
}
|
|
if (!discovery.IsPartial)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.NodeManagerNotPartial,
|
|
discovery.Location,
|
|
discovery.Binding.TargetNamespace +
|
|
"." +
|
|
discovery.Binding.TargetClassName));
|
|
continue;
|
|
}
|
|
bindings.Add(discovery.Binding);
|
|
bindingByPayload[discovery.Binding] = discovery;
|
|
}
|
|
|
|
void reportBinding(NodeManagerAttributeBinding binding, string message)
|
|
{
|
|
Location loc =
|
|
bindingByPayload.TryGetValue(binding, out NodeManagerAttributeDiscovery d) &&
|
|
d != null
|
|
? d.Location
|
|
: Location.None;
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.NodeManagerBindingError,
|
|
loc,
|
|
message));
|
|
}
|
|
|
|
void reportFluentAccessorsOnly(
|
|
string modelUri,
|
|
string prefix,
|
|
string path,
|
|
string reason)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.FluentAccessorsOnlyModelError,
|
|
Location.None,
|
|
modelUri,
|
|
prefix,
|
|
path,
|
|
reason));
|
|
}
|
|
|
|
// Reduce referenced model attributes to a single dictionary by
|
|
// model URI (with tie-break on highest version+publication date)
|
|
// so the downstream generators can apply override resolution
|
|
// and decode the carried dependency payloads.
|
|
IReadOnlyDictionary<string, ModelDependencyReference>
|
|
referencedModels = BuildReferencedModelMap();
|
|
|
|
// The design files that are not NodeSet2 inputs form the
|
|
// ModelDesign pass. Compute them up front so the total model
|
|
// count (NodeSet2 models + ModelDesign targets) can be shared
|
|
// with both passes: [NodeManager] bindings are resolved across
|
|
// both passes, so single-model fallback / ambiguity detection
|
|
// must see the global model count, not the per-pass count.
|
|
// Use a set for O(1) membership tests instead of an O(n)
|
|
// ContainsValue scan per input (Ordinal preserves the previous
|
|
// dictionary-value equality semantics exactly).
|
|
// AllFilePaths, not Files.Values: Files exposes one entry per
|
|
// model URI, so a superseded NodeSet2 version would not be
|
|
// recognised as a NodeSet input and would be picked up as a
|
|
// ModelDesign target and generated a second time.
|
|
var nodesetPaths = new HashSet<string>(
|
|
nodesets.AllFilePaths, StringComparer.Ordinal);
|
|
// Distinct: a project can list the same file as an AdditionalFile
|
|
// more than once (a glob overlapping an explicit item). The file
|
|
// system dedupes its own view, but a repeated design target is
|
|
// generated twice and the second AddSource throws on the
|
|
// duplicate hint name - and it also inflates totalModelCount,
|
|
// which decides the single-model [NodeManager] fallback.
|
|
List<string> designTargets = [.. m_input
|
|
.Where(f => !nodesetPaths.Contains(f.Item1.Path))
|
|
.Select(f => f.Item1.Path)
|
|
.Distinct(StringComparer.Ordinal)];
|
|
|
|
var designDependencies = new List<string>(nodesets.DesignFileEntries);
|
|
designDependencies.AddRange(designTargets);
|
|
|
|
// A [NodeManager] may bind to a model produced by either pass
|
|
// (a NodeSet2 type model or a ModelDesign instance model). The
|
|
// "used" set is therefore shared across both passes and the
|
|
// unmatched-binding diagnostics are reported once, after both
|
|
// passes — reporting per pass would false-positive a binding
|
|
// that the other pass matched (issue #3937).
|
|
HashSet<NodeManagerAttributeBinding> usedBindings =
|
|
bindings.Count > 0 ? [] : null;
|
|
int totalModelCount = nodesets.ModelUris.Count() + designTargets.Count;
|
|
|
|
// Enter the standard method-state fallback scope for the whole
|
|
// model-generation pass: a reference to a standard
|
|
// global::Opc.Ua.*MethodState class degrades to the base
|
|
// MethodState only when the typed class is neither present in
|
|
// the compilation nor declared by this pass. The Stack
|
|
// generator (which builds Opc.Ua.Core) never enters this scope.
|
|
using IDisposable fallbackScope =
|
|
StandardMethodStateFallback.Enter(m_availableStateTypeNames);
|
|
|
|
nodesets.GenerateCode(
|
|
sourceFiles.WithFallback(vfs),
|
|
string.Empty,
|
|
m_telemetry,
|
|
generatorOptions,
|
|
m_options.UseAllowSubtypes,
|
|
referencedModels,
|
|
bindings.Count > 0 ? bindings : null,
|
|
bindings.Count > 0 ? reportBinding : null,
|
|
// Derived from referencedModels, which carries the payloads.
|
|
null,
|
|
usedBindings,
|
|
totalModelCount,
|
|
reportFluentAccessorsOnly,
|
|
m_referencedModels,
|
|
m_referencedAccessorProviders);
|
|
|
|
// Process the remaining design files. Every NodeSet2 input
|
|
// (encoded with the prefix/name computed by the nodeset
|
|
// pass) and every other ModelDesign input is supplied as a
|
|
// dependency so cross-model references resolve — both
|
|
// ModelDesign -> NodeSet2 (e.g. an instance whose
|
|
// TypeDefinition is a NodeSet2-defined ObjectType) and
|
|
// ModelDesign -> ModelDesign across directories. The
|
|
// referenced models carry the upstream dependency payloads,
|
|
// so a design file can also subtype a structure of a
|
|
// referenced model that is not present in AdditionalFiles.
|
|
new DesignFileCollection
|
|
{
|
|
Targets = designTargets,
|
|
Dependencies = designDependencies,
|
|
Options = m_options.Options
|
|
}.GenerateCode(
|
|
sourceFiles.WithFallback(vfs),
|
|
string.Empty,
|
|
m_telemetry,
|
|
generatorOptions,
|
|
m_options.UseAllowSubtypes,
|
|
[.. m_identifierFiles.Select(i => i.Path)],
|
|
referencedModels,
|
|
bindings.Count > 0 ? bindings : null,
|
|
bindings.Count > 0 ? reportBinding : null,
|
|
usedBindings,
|
|
totalModelCount,
|
|
reportFluentAccessorsOnly,
|
|
m_referencedModels,
|
|
m_referencedAccessorProviders);
|
|
|
|
// Report any [NodeManager] bindings that neither pass matched,
|
|
// once, against the shared used-set aggregated across passes.
|
|
Generators.ReportUnmatchedNodeManagerBindings(
|
|
bindings,
|
|
usedBindings,
|
|
totalModelCount,
|
|
reportBinding);
|
|
|
|
// Collect all generated cs files and produce them into the compilation
|
|
foreach (string file in vfs.CreatedFiles
|
|
.Where(f => f.EndsWith(".cs", StringComparison.OrdinalIgnoreCase)))
|
|
{
|
|
string content = Encoding.UTF8.GetString(vfs.Get(file));
|
|
m_context.AddSource(file, content);
|
|
}
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.Exception,
|
|
Location.None,
|
|
ex.Message,
|
|
ex.ToString()));
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests the compilation options are valid
|
|
/// </summary>
|
|
/// <returns></returns>
|
|
private bool CheckCompilationOptions()
|
|
{
|
|
if (m_compilationOptions.LanguageVersion < LanguageVersion.CSharp8)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.GenericError,
|
|
Location.None,
|
|
"Minimum required language version is CSharp 8."));
|
|
return false;
|
|
}
|
|
if (m_options.FluentAccessorsOnly && m_options.OmitFluentApi)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.FluentAccessorsOnlyOptionsError,
|
|
Location.None,
|
|
"ModelSourceGeneratorFluentAccessorsOnly and " +
|
|
"ModelSourceGeneratorOmitFluentApi cannot both be enabled."));
|
|
return false;
|
|
}
|
|
// The project-wide switch would emit a conventionally named
|
|
// manager into the *referenced* model's own C# namespace for
|
|
// every design in the project. A [NodeManager] says which model
|
|
// gets a manager and what it is called, so that is the way to
|
|
// put one on a model a reference supplies.
|
|
if (m_options.FluentAccessorsOnly && m_options.Options.GenerateNodeManager)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.FluentAccessorsOnlyOptionsError,
|
|
Location.None,
|
|
"ModelSourceGeneratorFluentAccessorsOnly cannot be combined with " +
|
|
"ModelSourceGeneratorGenerateNodeManager. Apply a [NodeManager] " +
|
|
"attribute to the manager class instead; it binds to a model a " +
|
|
"referenced assembly supplies without re-emitting the model."));
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
private void ReportNodesetIdentifierDiagnostics(
|
|
IEnumerable<NodesetIdentifierValidationError> errors)
|
|
{
|
|
foreach (NodesetIdentifierValidationError error in errors)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
error.Kind switch
|
|
{
|
|
NodesetIdentifierValidationErrorKind.MissingFile =>
|
|
SourceGenerator.NodesetIdentifierFileMissing,
|
|
NodesetIdentifierValidationErrorKind.DuplicateSymbolicName =>
|
|
SourceGenerator.NodesetIdentifierDuplicateSymbolicName,
|
|
NodesetIdentifierValidationErrorKind.DuplicateNumericId =>
|
|
SourceGenerator.NodesetIdentifierDuplicateNumericId,
|
|
NodesetIdentifierValidationErrorKind.UnknownSymbol =>
|
|
SourceGenerator.NodesetIdentifierUnknownSymbol,
|
|
NodesetIdentifierValidationErrorKind.NumericIdMismatch =>
|
|
SourceGenerator.NodesetIdentifierNumericIdMismatch,
|
|
NodesetIdentifierValidationErrorKind.NodeClassMismatch =>
|
|
SourceGenerator.NodesetIdentifierNodeClassMismatch,
|
|
NodesetIdentifierValidationErrorKind.AssignedToMultipleModels =>
|
|
SourceGenerator.NodesetIdentifierAssignedToMultipleModels,
|
|
_ => SourceGenerator.NodesetIdentifierInvalidRow
|
|
},
|
|
Location.None,
|
|
error.NodeSetFilePath,
|
|
error.IdentifierFilePath,
|
|
error.SymbolicName,
|
|
error.Value));
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Group the referenced-assembly attributes by model URI; when more
|
|
/// than one assembly contributes the same URI, prefer a payload-bearing
|
|
/// self producer over payloadless transitive re-exports, then use the
|
|
/// highest <c>(Version, PublicationDate)</c> lexicographic tuple per
|
|
/// the contract on <see cref="ModelDependencyAttribute"/>.
|
|
/// </summary>
|
|
private IReadOnlyDictionary<string, ModelDependencyReference>
|
|
BuildReferencedModelMap()
|
|
{
|
|
if (m_referencedModels.IsDefaultOrEmpty)
|
|
{
|
|
return ImmutableDictionary<string, ModelDependencyReference>.Empty;
|
|
}
|
|
var map = new Dictionary<string, ModelDependencyReference>(
|
|
StringComparer.Ordinal);
|
|
foreach (ModelDependencyReference candidate in m_referencedModels)
|
|
{
|
|
if (!candidate.IsValid)
|
|
{
|
|
continue;
|
|
}
|
|
if (!map.TryGetValue(candidate.ModelUri, out ModelDependencyReference existing))
|
|
{
|
|
map[candidate.ModelUri] = candidate;
|
|
continue;
|
|
}
|
|
bool candidateIsProducer = IsModelProducer(candidate);
|
|
bool existingIsProducer = IsModelProducer(existing);
|
|
int cmp = candidateIsProducer.CompareTo(existingIsProducer);
|
|
if (cmp == 0)
|
|
{
|
|
// Compare the version numerically: ordinally "1.05.9" sorts
|
|
// above "1.05.10", which would pick the older model. Shared
|
|
// with NodesetFileCollection so the two halves of the
|
|
// pipeline cannot pick different winners for the same pair;
|
|
// it reports a date against a version as equal, which the
|
|
// PublicationDate tie-break below then settles.
|
|
cmp = SemVer.CompareVersionStrings(
|
|
candidate.Version, existing.Version);
|
|
}
|
|
if (cmp == 0)
|
|
{
|
|
cmp = string.CompareOrdinal(
|
|
candidate.PublicationDate, existing.PublicationDate);
|
|
}
|
|
if (cmp > 0)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.ModelDependencyTieBreak,
|
|
Location.None,
|
|
candidate.ModelUri,
|
|
candidate.AssemblyName,
|
|
existing.AssemblyName));
|
|
map[candidate.ModelUri] = candidate;
|
|
}
|
|
else if (cmp < 0)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.ModelDependencyTieBreak,
|
|
Location.None,
|
|
existing.ModelUri,
|
|
existing.AssemblyName,
|
|
candidate.AssemblyName));
|
|
}
|
|
}
|
|
return map;
|
|
}
|
|
|
|
private static bool IsModelProducer(ModelDependencyReference reference)
|
|
{
|
|
ModelDependencyV1 dependency = reference.GetDependency();
|
|
return dependency != null &&
|
|
string.Equals(dependency.ModelUri, reference.ModelUri, StringComparison.Ordinal);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Resolve whether the model-dependency assembly attribute
|
|
/// should be emitted, honouring the compilation's OutputKind
|
|
/// in <c>Auto</c> mode.
|
|
/// </summary>
|
|
private bool ResolveEmitDependencyMetadata()
|
|
{
|
|
return m_options.EmitDependencyMetadata switch
|
|
{
|
|
EmitDependencyMetadataMode.Always => true,
|
|
EmitDependencyMetadataMode.Never => false,
|
|
_ => m_compilationOptions.OutputKind is
|
|
OutputKind.DynamicallyLinkedLibrary or
|
|
OutputKind.NetModule
|
|
};
|
|
}
|
|
|
|
private readonly SourceProductionContext m_context;
|
|
private readonly ImmutableArray<(AdditionalText, NodesetFileOptions)> m_input;
|
|
private readonly ImmutableArray<AdditionalText> m_csvFiles;
|
|
private readonly ImmutableArray<AdditionalText> m_identifierFiles;
|
|
private readonly ModelCompilationOptions m_options;
|
|
private readonly CompilationOptions m_compilationOptions;
|
|
private readonly ImmutableArray<ModelDependencyReference> m_referencedModels;
|
|
private readonly ImmutableArray<ModelFluentAccessorProviderReference>
|
|
m_referencedAccessorProviders;
|
|
private readonly ImmutableArray<NodeManagerAttributeDiscovery> m_nodeManagerBindings;
|
|
private readonly ImmutableHashSet<string> m_availableStateTypeNames;
|
|
private readonly SourceGeneratorTelemetry m_telemetry;
|
|
}
|
|
}
|