mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-17 05:11:13 +08:00
442889cba5
# Description
This PR fixes a bug audit of the source generation projects
(`tools/Opc.Ua.SourceGeneration*`: model loading, NodeSet import, all
emitters, the Roslyn hosts and packaging). It also fixes a max-effort
code review of those fixes, and a check of every spec-relevant change
against the OPC UA 1.05 text.
- **Scope:** about 85 audit findings, 48 review findings and 32
spec-grounding items were addressed. Each fix has a regression test that
fails without it.
- **Wire change:** it includes one deliberate, stack-wide wire change:
**structure-field matrices now follow OPC 10000-6 5.2.5 Table 28**.
Most changes are internal correctness fixes. The sections below list
every change a user can observe: wire formats, generated code and API,
generated address-space content, diagnostics and runtime behaviour.
## Behaviour / user-facing changes
### Wire format (encoders)
- **Binary inline matrices** (OPC 10000-6 5.2.5 Table 28).
- **Layout:** a multi-dimensional *structure field* is encoded as
`Int32[] Dimensions`, then the values **without a length prefix**, with
at least 2 dimensions.
- **Empty and null:** any dimension <= 0 means no values follow, and a
null matrix is `-1`. An empty matrix is written as `[0,0]`.
- **Compatibility:** this is **not compatible with earlier builds of
this SDK** for matrix fields. It applies to generated types,
`[DataType]` types, `Structure`, client ComplexTypes and
`WriteEncodeableMatrix`.
- **Unchanged:** Variant matrices (5.2.2.16) keep their old encoding.
- **Declared rank decides matrix vs array.** A 1-D `MatrixOf<T>` in an
array field or a Variable value is written as an array again.
Matrix-declared fields go through the new public
`EncoderExtensions.WriteInlineMatrixValue`, which generated code also
uses. A non-empty 1-D value in a matrix field throws `BadEncodingError`.
- **Decoder hardening:**
- Before allocating, the decoder bounds all matrix dimensions against
overflow, `MaxArrayLength` and the remaining message length.
- The decoder rejects:
- a matrix with fewer than 2 dimensions;
- a populated matrix whose rank differs from the field's declared rank;
- a union SwitchField greater than the number of fields;
- an EncodingMask with unassigned bits set.
- **Encoder `MaxArrayLength`:** the encoder enforces `MaxArrayLength`
for inline matrices, as it already did for arrays.
- **XML structure fields** (5.3.1, 5.3.4, 5.3.5).
- **Fields:** `Structure` and client ComplexTypes write fields like
typed fields (`<A>1</A>`, array elements directly) instead of a Variant
body.
- **Matrix fields:** `Dimensions` and `Elements` go directly inside the
field element, with no `<Matrix>` wrapper.
- **Empty matrices:** written as nil, because XML dimensions must be
greater than 0.
- **Compatibility:** decoders still accept the old shapes.
- **Enum fixes:** enum array elements with value 0 are no longer
dropped, and enum array element names are fixed.
- **Other encoding fixes:**
- A null `DiagnosticInfo` structure field writes `0x00` instead of
nothing.
- A null scalar field in a runtime `Structure` is written as its default
instead of zero bytes, which used to shift every following field.
- A Variant holding an empty matrix encodes as an empty array instead of
throwing.
- `Variant.Copy` keeps the matrix identity of null and empty matrices.
- **NodeSet export and the DataContract surrogate** write Variable
values with the Variant rules again. A null or empty `MatrixOf` variable
no longer produces invalid XML or unreadable NodeSets.
- **`JsonEncoder.CanOmitFields`** is `true` only for Compact encoding.
Verbose and RawData JSON include default-valued fields.
### `[DataType]` source-generated types
- **Default-value handling** (OPC 10000-6 5.4.1, Table 1).
- **Encode:** a field is omitted only when its value *and* its declared
default are the type's default (0, false, null). Fields with a
non-default initializer or constructor default, and empty strings, are
always written, so configuration files get slightly larger.
- **JSON decode:** a field missing from JSON decodes to the type
default.
- **XML decode:** a field missing from XML keeps its declared default,
which older configuration files rely on.
- **Why:** this fixes silent round-trip loss, for example
`SamplingInterval = 0` read back as `-1`.
- **Nested `[DataType]` types:** they are now generated inside their
containing types. Without an explicit id, their default TypeId and
XmlName are qualified (e.g. `s=Outer.Foo`); **wire identity change** for
nested types. Colliding activator names get a `_2` suffix.
- **Activators:** they are `internal` when the type, or any containing
type, is not public (was CS0060).
- **Matrix properties:**
- `MatrixOf<T>` properties use the inline matrix encoding.
- Matrices of non-sealed structures, or with
`StructureHandling.ExtensionObject`, are written as ExtensionObjects.
- Their published ValueRank is 2, because the rank can't be known from
`MatrixOf<T>`.
- **Published StructureDefinitions:**
- They include base-class fields.
- Nullable properties are no longer marked optional.
- Inline structure fields name their concrete type.
- **`[Flags]` enums:** they are published as plain enumerations with
their member values, which matches how they are encoded.
- **Other generated code:**
- `Clone` deep-copies arrays and matrices of structures, Variants,
ExtensionObjects and DataValues.
- `IsEqual` and `GetHashCode` are consistent: EncodingMask, active union
member and NaN handling agree.
- Pooled `Reuse()` restores the freshly constructed state through the
new `protected virtual ResetForReuse()`, and returns an instance to its
runtime type's pool.
- **Enum capture:** enum member values are captured culture-invariantly.
Negative values were lost on cultures that use U+2212 as the minus sign.
### Model-driven generator: generated code, API and file names
- **Removed API:** generated `*_Placeholder` proxy accessors (e.g.
`PowerTrainTypeClient.GetMotorIdentifier_PlaceholderAsync`) and fluent
`X_Placeholder()` accessors are removed; they could never resolve
anything.
- Proxy accessors now look children up by BrowseName with the right
namespace.
- `RoboticsClient` finds motors and gears by type and drives via
`IsDrivenBy`. Its topology snapshots used to be empty.
- **Renamed files:** generated files for a bound `[NodeManager]` are now
named `{Namespace}.{Class}.NodeManager.g.cs` (also `.Factory` and
`.FluentBuilders`).
- **Generated NodeState code:**
- Attributes are set through `baseState`/`nodeState` locals, so children
named like base attributes (e.g. `DataType`, `EventNotifier`) compile.
- Children that hide base members are declared `public new`, using names
reflected from the runtime.
- `global::` qualification is used throughout.
- **Proxies and fluent builders:** a proxy whose supertype is excluded
(e.g. Draft) derives from the nearest emitted ancestor. Fluent wrappers
and NodeState factories fall back the same way; they used to fail with
CS0246.
- **Derived structures:**
- The optional-field `EncodingMask` continues across inheritance.
- A derived structure over a base type from another model no longer
relies on `base.ResetForReuse`.
- **Default values:**
- NodeId, QualifiedName and ExpandedNodeId defaults resolve by namespace
URI (`context.NamespaceUris.GetIndexOrAppend`) and server URI.
- StatusCode, negative enum, `double`/`float` (shortest round-trip
literal) and escaped string defaults now compile.
- **Event records:**
- Vendor event records have `Decoder.GetStandardFields(NamespaceTable)`,
and their browse paths use the model's namespace.
- A field whose namespace is unknown to the session no longer matches a
namespace-0 field.
- Companion `StandardFields` is `[Obsolete]`.
- Vendor simple subtypes such as `Percent : Double` map to their
built-in type.
- **Other fixes:**
- `MethodState.CallAsync` passes the real `objectId` to synchronous
`OnCallMethod2` handlers; it used to pass `NodeId.Null`.
- Enumeration fields with an explicit `Identifier` keep it, instead of
taking a trailing `_<digits>`.
- Explicit NumericIds are no longer reused by automatic numbering.
- Dependencies are loaded in topological order.
### Generated address-space content
- **Arguments:**
- Methods without arguments no longer get empty
`InputArguments`/`OutputArguments` properties (OPC 10000-3 5.7).
- About 2,660 automatically assigned namespace-0 NodeIds of 15000 and
above shift. Every NodeId in `StandardTypes.csv` is unchanged.
- **Permissions:** type nodes and method declarations on types now carry
the model's `RolePermissions`/`AccessRestrictions`.
- **Restored nodes:** NodeSet import keeps nodes that were silently
dropped before:
- `NamespaceMetadata` objects and the NodeSet's own TypeDictionary
variables;
- ISA95 placeholders linked only non-hierarchically;
- instances whose parent is in another namespace.
- **Import details:**
- ValueRank > 1 without ArrayDimensions keeps its rank.
- `svr=` indexes map correctly.
- Invalid MinimumSamplingInterval values import as -1, not 0.
- Localized texts prefer the invariant or English translation.
- **StructureDefinitions:**
- They include inherited fields, including for subtypes without their
own fields (e.g. `AnonymousIdentityToken` now publishes PolicyId).
- The StructureType kind covers inherited AllowSubTypes fields.
- Unions ignore IsOptional.
- StructureFields never publish ValueRank 0; a OneOrMoreDimensions field
without dimensions becomes rank 2.
- Fields with ValueRank -2/-3 are published as scalar BaseDataType,
which is what is on the wire.
- **OptionSets:**
- Implicit fields get the next free bit.
- `OptionSetValues` uses null for undefined bits instead of "Reserved",
and structure OptionSets publish all their bits (no 32/96-bit cap).
- Numeric OptionSets are limited to their base type's width, and UInt64
bit 63 works.
- **Schemas:**
- Structures with inline-matrix fields are left out of the `.bsd`
(5.2.5).
- In the BSD, Variant-encoded and non-structure subtyped fields are
described as `ua:Variant`.
- In the `.xsd`, matrix fields are typed `ua:Matrix` with
`Dimensions`/`Elements`, and `EncodingMask` is required.
### NodeSet / model input handling
- **Model selection:**
- The newest NodeSet of a model is chosen by `ModelVersion` (SemVer 2.0
precedence), then PublicationDate. The `Version` attribute, which Annex
F says is not for comparison, is only a tie-break.
- The order is total and does not depend on input order; referenced
assemblies use the same rule.
- **Default names:**
- Invalid default Name/Prefix values are repaired (`201301ISA95` becomes
`_201301ISA95`, `class` becomes `class_`).
- Valid names are unchanged.
- Sanitising no longer depends on the OS.
- **`ModelUri` metadata** that doesn't match the NodeSet raises a
warning instead of silently losing the model.
- **Input detection:**
- Only XML files whose root is `ModelDesign` or `UANodeSet` are treated
as models.
- A malformed NodeSet stays a NodeSet input, so it no longer breaks the
ModelDesign pass.
- **`IdentifierFile` paths:** they are normalized (`./`, `../`), and the
suffix match requires a folder boundary.
- **Dependency payloads** (`ModelDependencyV1`) carry field IsOptional,
AllowSubTypes, ArrayDimensions and the producer's namespace tables in
skippable trailers, so old and new readers stay compatible.
### Roslyn host, diagnostics, packaging
- **New diagnostics:**
- MODELGEN036: `[NodeManager]` target not supported (nested, generic,
file-local or global namespace).
- MODELGEN037: `[DataType]` target not supported (struct, generic,
abstract, file-local or global namespace).
- MODELGEN038: the definition of an encodeable base type can't be found.
- **New validator errors:**
- a structure with both optional and subtyped fields (OPC 10000-6 F.13);
- multi-bit or duplicate OptionSet masks.
- **Diagnostic locations:** `[DataType]`/`[NodeManager]` diagnostics
point at real source locations again, so `#pragma` and `.editorconfig`
apply. MODELGEN010 is the exception.
- **Incremental caching:** pipeline values compare by value, so
unrelated edits no longer regenerate the whole model or all
`[DataType]`s.
- **`ModelSourceGeneratorIgnore`** on a ModelDesign input is honoured;
the design still resolves as a dependency.
- **Cancellation:** a cancelled generation run propagates
`OperationCanceledException` instead of reporting a MODELGEN003 error.
- **Stack package:** the `Stack` NuGet package now ships
`build/OPCFoundation.NetStandard.Opc.Ua.SourceGeneration.Stack.props`,
so `StackSourceGeneratorMode` and `StackSourceGeneratorExclude` reach
the compiler.
## Related Issues
- No tracking issue. The audit, review and spec-grounding reports are
available on request. Contains the matrix wire-format change discussed
for D-5 (OPC 10000-6 5.2.5 Table 28).
## Checklist
- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
(`docs/SourceGeneratedDataTypes.md`, `docs/NodeManagers.md`, generator
readme)
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings. (`UA.slnx` 0 warnings / 0 errors on net48 and
net10.0)
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed. The
affected suites were run on net10.0: SourceGeneration Core/Roslyn/Stack,
Types, Core.Encoders, Encoders.Fuzz, Client, Client.ComplexTypes,
PubSub, Core, Server, GDS, Configuration, Di, Robotics, ISA95,
Positioning, OpenUsd, XRegistry. net48 was built; its test legs, and the
post-rebase verification, run in CI.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
568 lines
27 KiB
C#
568 lines
27 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Collections.Immutable;
|
|
using System.Globalization;
|
|
using System.Linq;
|
|
using System.Text;
|
|
using System.Threading;
|
|
using Microsoft.CodeAnalysis;
|
|
using Microsoft.CodeAnalysis.CSharp;
|
|
using Opc.Ua.SourceGeneration.Dependency;
|
|
|
|
namespace Opc.Ua.SourceGeneration
|
|
{
|
|
/// <summary>
|
|
/// Compiles the model. This honors the options of the compile command
|
|
/// of the tool. However, it does not generate identifier files and
|
|
/// assumes that if identifiers are required they are loaded from a
|
|
/// csv file that is side by side with the design files. Also, this
|
|
/// does not produce xsd or bsd nor nodeset files, which cannot be
|
|
/// added to a compilation using roslyn source generator (yet).
|
|
/// </summary>
|
|
internal sealed class ModelCompilation
|
|
{
|
|
/// <summary>
|
|
/// Create compilation
|
|
/// </summary>
|
|
public ModelCompilation(
|
|
SourceProductionContext context,
|
|
ImmutableArray<(AdditionalText, NodesetFileOptions)> inputFiles,
|
|
ImmutableArray<AdditionalText> csvFiles,
|
|
ImmutableArray<AdditionalText> identifierFiles,
|
|
ModelCompilationOptions options,
|
|
CompilationOptions compilationOptions,
|
|
ImmutableArray<ModelDependencyReference> referencedModels,
|
|
ImmutableArray<ModelFluentAccessorProviderReference> referencedAccessorProviders,
|
|
ImmutableArray<NodeManagerAttributeDiscovery> nodeManagerBindings,
|
|
ImmutableHashSet<string> availableStateTypeNames)
|
|
{
|
|
m_context = context;
|
|
m_input = inputFiles;
|
|
m_csvFiles = csvFiles;
|
|
m_identifierFiles = identifierFiles;
|
|
m_options = options;
|
|
m_compilationOptions = compilationOptions;
|
|
m_nodeManagerBindings = nodeManagerBindings;
|
|
m_referencedModels = referencedModels;
|
|
m_referencedAccessorProviders = referencedAccessorProviders;
|
|
m_availableStateTypeNames = availableStateTypeNames;
|
|
m_telemetry = SourceGeneratorTelemetry.Create(m_context);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Perform the compilation
|
|
/// </summary>
|
|
public void Emit(CancellationToken cancellationToken)
|
|
{
|
|
if (!CheckCompilationOptions())
|
|
{
|
|
return;
|
|
}
|
|
var sourceFiles = new SourceGeneratorFileSystem(
|
|
m_input.Select(i => i.Item1).Concat(m_csvFiles));
|
|
|
|
using var vfs = new VirtualFileSystem(); // Use a virtual file sytem
|
|
try
|
|
{
|
|
if (m_input.Length == 0)
|
|
{
|
|
// Nothing to do
|
|
return;
|
|
}
|
|
|
|
string[] exclusions = [.. m_options.Exclude
|
|
.Append("Draft")
|
|
.Distinct()];
|
|
var generatorOptions = new GeneratorOptions
|
|
{
|
|
Cancellation = cancellationToken,
|
|
Exclusions = exclusions,
|
|
// csharp10 or below does not support utf8 string literals
|
|
UseUtf8StringLiterals =
|
|
m_compilationOptions.LanguageVersion >= LanguageVersion.CSharp11,
|
|
OptimizeForCompileSpeed =
|
|
m_compilationOptions.OptimizationLevel == OptimizationLevel.Debug,
|
|
OmitObjectTypeProxies = m_options.OmitObjectTypeProxies,
|
|
ObjectTypeProxyNamespace =
|
|
string.IsNullOrWhiteSpace(m_options.ObjectTypeProxyNamespace)
|
|
? null
|
|
: m_options.ObjectTypeProxyNamespace,
|
|
UseTypeDefinitionModellingRules =
|
|
m_options.UseTypeDefinitionModellingRules,
|
|
EmitDependencyMetadata = ResolveEmitDependencyMetadata(),
|
|
OmitFluentApi = m_options.OmitFluentApi,
|
|
FluentAccessorsOnly = m_options.FluentAccessorsOnly,
|
|
OmitEventRecords = m_options.OmitEventRecords
|
|
};
|
|
|
|
// Load all available nodeset files from the input
|
|
NodesetFileCollection nodesets = m_input.ToNodeSetFileCollection(
|
|
m_csvFiles,
|
|
sourceFiles, // .WithFallback(vfs),
|
|
m_telemetry);
|
|
ReportNodesetIdentifierDiagnostics(nodesets.IdentifierValidationErrors);
|
|
|
|
// Resolve [NodeManager] bindings: validate partial-ness and
|
|
// build the binding list to pass into both GenerateCode calls
|
|
// (nodeset-derived and design-file-derived).
|
|
var bindings = new List<NodeManagerAttributeBinding>();
|
|
var bindingByPayload =
|
|
new Dictionary<NodeManagerAttributeBinding, NodeManagerAttributeDiscovery>();
|
|
foreach (NodeManagerAttributeDiscovery discovery in m_nodeManagerBindings)
|
|
{
|
|
// An invalid discovery is reported by
|
|
// NodeManagerAttributeDiscovery.ReportDiagnostics, in a
|
|
// separate output that has the compilation to report it
|
|
// at a source location.
|
|
if (discovery == null || discovery.IsInvalid)
|
|
{
|
|
continue;
|
|
}
|
|
bindings.Add(discovery.Binding);
|
|
bindingByPayload[discovery.Binding] = discovery;
|
|
}
|
|
|
|
void reportBinding(NodeManagerAttributeBinding binding, string message)
|
|
{
|
|
// Reported while the models are generated, which does not
|
|
// depend on the compilation (to stay cached), so there is
|
|
// no syntax tree to report at: an external location.
|
|
Location loc =
|
|
bindingByPayload.TryGetValue(binding, out NodeManagerAttributeDiscovery d) &&
|
|
d != null
|
|
? d.Location.ToLocation()
|
|
: Location.None;
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.NodeManagerBindingError,
|
|
loc,
|
|
message));
|
|
}
|
|
|
|
void reportFluentAccessorsOnly(
|
|
string modelUri,
|
|
string prefix,
|
|
string path,
|
|
string reason)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.FluentAccessorsOnlyModelError,
|
|
Location.None,
|
|
modelUri,
|
|
prefix,
|
|
path,
|
|
reason));
|
|
}
|
|
|
|
// Reduce referenced model attributes to a single dictionary by
|
|
// model URI (with tie-break on highest version+publication date)
|
|
// so the downstream generators can apply override resolution
|
|
// and decode the carried dependency payloads.
|
|
IReadOnlyDictionary<string, ModelDependencyReference>
|
|
referencedModels = BuildReferencedModelMap();
|
|
|
|
// The design files that are not NodeSet2 inputs form the
|
|
// ModelDesign pass. Compute them up front so the total model
|
|
// count (NodeSet2 models + ModelDesign targets) can be shared
|
|
// with both passes: [NodeManager] bindings are resolved across
|
|
// both passes, so single-model fallback / ambiguity detection
|
|
// must see the global model count, not the per-pass count.
|
|
// Use a set for O(1) membership tests instead of an O(n)
|
|
// ContainsValue scan per input (Ordinal preserves the previous
|
|
// dictionary-value equality semantics exactly).
|
|
// AllFilePaths, not Files.Values: Files exposes one entry per
|
|
// model URI, so a superseded NodeSet2 version would not be
|
|
// recognised as a NodeSet input and would be picked up as a
|
|
// ModelDesign target and generated a second time.
|
|
var nodesetPaths = new HashSet<string>(
|
|
nodesets.AllFilePaths, StringComparer.Ordinal);
|
|
// Distinct: a project can list the same file as an AdditionalFile
|
|
// more than once (a glob overlapping an explicit item). The file
|
|
// system dedupes its own view, but a repeated design target is
|
|
// generated twice and the second AddSource throws on the
|
|
// duplicate hint name - and it also inflates totalModelCount,
|
|
// which decides the single-model [NodeManager] fallback.
|
|
List<string> designInputs = [.. m_input
|
|
.Where(f => !nodesetPaths.Contains(f.Item1.Path))
|
|
.Select(f => f.Item1.Path)
|
|
.Distinct(StringComparer.Ordinal)];
|
|
// A design marked ModelSourceGeneratorIgnore is, like an
|
|
// ignored NodeSet2 input, only there to resolve references
|
|
// of the other inputs: it stays a dependency but is not
|
|
// generated, or its types would be emitted a second time
|
|
// next to the assembly that already provides them.
|
|
var ignoredDesigns = new HashSet<string>(
|
|
m_input.Where(f => f.Item2?.Ignore == true).Select(f => f.Item1.Path),
|
|
StringComparer.Ordinal);
|
|
List<string> designTargets = [.. designInputs
|
|
.Where(path => !ignoredDesigns.Contains(path))];
|
|
|
|
var designDependencies = new List<string>(nodesets.DesignFileEntries);
|
|
designDependencies.AddRange(designInputs);
|
|
|
|
// A CSV that a NodeSet claims through its IdentifierFile metadata
|
|
// is that NodeSet's sidecar. Left in the list, the ModelDesign
|
|
// pass adopts it as the identifier file of a design that has no
|
|
// same-named CSV and is the only design in the folder, and the
|
|
// design silently takes the NodeSet's numeric ids.
|
|
var claimedIdentifierFiles = new HashSet<string>(
|
|
nodesets.IdentifierFilePaths, StringComparer.Ordinal);
|
|
List<string> designIdentifierFiles = [.. m_identifierFiles
|
|
.Select(i => i.Path)
|
|
.Where(path => !claimedIdentifierFiles.Contains(path))];
|
|
|
|
// A [NodeManager] may bind to a model produced by either pass
|
|
// (a NodeSet2 type model or a ModelDesign instance model). The
|
|
// "used" set is therefore shared across both passes and the
|
|
// unmatched-binding diagnostics are reported once, after both
|
|
// passes — reporting per pass would false-positive a binding
|
|
// that the other pass matched (issue #3937).
|
|
HashSet<NodeManagerAttributeBinding> usedBindings =
|
|
bindings.Count > 0 ? [] : null;
|
|
int totalModelCount = nodesets.ModelUris.Count() + designTargets.Count;
|
|
|
|
// Enter the standard method-state fallback scope for the whole
|
|
// model-generation pass: a reference to a standard
|
|
// global::Opc.Ua.*MethodState class degrades to the base
|
|
// MethodState only when the typed class is neither present in
|
|
// the compilation nor declared by this pass. The Stack
|
|
// generator (which builds Opc.Ua.Core) never enters this scope.
|
|
using IDisposable fallbackScope =
|
|
StandardMethodStateFallback.Enter(m_availableStateTypeNames);
|
|
|
|
nodesets.GenerateCode(
|
|
sourceFiles.WithFallback(vfs),
|
|
string.Empty,
|
|
m_telemetry,
|
|
generatorOptions,
|
|
m_options.UseAllowSubtypes,
|
|
referencedModels,
|
|
bindings.Count > 0 ? bindings : null,
|
|
bindings.Count > 0 ? reportBinding : null,
|
|
// Derived from referencedModels, which carries the payloads.
|
|
null,
|
|
usedBindings,
|
|
totalModelCount,
|
|
reportFluentAccessorsOnly,
|
|
m_referencedModels,
|
|
m_referencedAccessorProviders);
|
|
|
|
// Process the remaining design files. Every NodeSet2 input
|
|
// (encoded with the prefix/name computed by the nodeset
|
|
// pass) and every other ModelDesign input is supplied as a
|
|
// dependency so cross-model references resolve — both
|
|
// ModelDesign -> NodeSet2 (e.g. an instance whose
|
|
// TypeDefinition is a NodeSet2-defined ObjectType) and
|
|
// ModelDesign -> ModelDesign across directories. The
|
|
// referenced models carry the upstream dependency payloads,
|
|
// so a design file can also subtype a structure of a
|
|
// referenced model that is not present in AdditionalFiles.
|
|
new DesignFileCollection
|
|
{
|
|
Targets = designTargets,
|
|
Dependencies = designDependencies,
|
|
Options = m_options.Options
|
|
}.GenerateCode(
|
|
sourceFiles.WithFallback(vfs),
|
|
string.Empty,
|
|
m_telemetry,
|
|
generatorOptions,
|
|
m_options.UseAllowSubtypes,
|
|
designIdentifierFiles,
|
|
referencedModels,
|
|
bindings.Count > 0 ? bindings : null,
|
|
bindings.Count > 0 ? reportBinding : null,
|
|
usedBindings,
|
|
totalModelCount,
|
|
reportFluentAccessorsOnly,
|
|
m_referencedModels,
|
|
m_referencedAccessorProviders);
|
|
|
|
// Report any [NodeManager] bindings that neither pass matched,
|
|
// once, against the shared used-set aggregated across passes.
|
|
Generators.ReportUnmatchedNodeManagerBindings(
|
|
bindings,
|
|
usedBindings,
|
|
totalModelCount,
|
|
reportBinding);
|
|
|
|
// Collect all generated cs files and produce them into the compilation
|
|
foreach (string file in vfs.CreatedFiles
|
|
.Where(f => f.EndsWith(".cs", StringComparison.OrdinalIgnoreCase)))
|
|
{
|
|
string content = Encoding.UTF8.GetString(vfs.Get(file));
|
|
m_context.AddSource(file, content);
|
|
}
|
|
}
|
|
catch (OperationCanceledException) when (cancellationToken.IsCancellationRequested)
|
|
{
|
|
// A cancelled run is not a generator failure: let the driver
|
|
// see the cancellation instead of caching an error diagnostic.
|
|
throw;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.Exception,
|
|
Location.None,
|
|
ex.Message,
|
|
ex.ToString()));
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests the compilation options are valid
|
|
/// </summary>
|
|
/// <returns></returns>
|
|
private bool CheckCompilationOptions()
|
|
{
|
|
if (m_compilationOptions.LanguageVersion < LanguageVersion.CSharp8)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.GenericError,
|
|
Location.None,
|
|
"Minimum required language version is CSharp 8."));
|
|
return false;
|
|
}
|
|
if (m_options.FluentAccessorsOnly && m_options.OmitFluentApi)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.FluentAccessorsOnlyOptionsError,
|
|
Location.None,
|
|
"ModelSourceGeneratorFluentAccessorsOnly and " +
|
|
"ModelSourceGeneratorOmitFluentApi cannot both be enabled."));
|
|
return false;
|
|
}
|
|
// The project-wide switch would emit a conventionally named
|
|
// manager into the *referenced* model's own C# namespace for
|
|
// every design in the project. A [NodeManager] says which model
|
|
// gets a manager and what it is called, so that is the way to
|
|
// put one on a model a reference supplies.
|
|
if (m_options.FluentAccessorsOnly && m_options.Options.GenerateNodeManager)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.FluentAccessorsOnlyOptionsError,
|
|
Location.None,
|
|
"ModelSourceGeneratorFluentAccessorsOnly cannot be combined with " +
|
|
"ModelSourceGeneratorGenerateNodeManager. Apply a [NodeManager] " +
|
|
"attribute to the manager class instead; it binds to a model a " +
|
|
"referenced assembly supplies without re-emitting the model."));
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
private void ReportNodesetIdentifierDiagnostics(
|
|
IEnumerable<NodesetIdentifierValidationError> errors)
|
|
{
|
|
foreach (NodesetIdentifierValidationError error in errors)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
error.Kind switch
|
|
{
|
|
NodesetIdentifierValidationErrorKind.MissingFile =>
|
|
SourceGenerator.NodesetIdentifierFileMissing,
|
|
NodesetIdentifierValidationErrorKind.DuplicateSymbolicName =>
|
|
SourceGenerator.NodesetIdentifierDuplicateSymbolicName,
|
|
NodesetIdentifierValidationErrorKind.DuplicateNumericId =>
|
|
SourceGenerator.NodesetIdentifierDuplicateNumericId,
|
|
NodesetIdentifierValidationErrorKind.UnknownSymbol =>
|
|
SourceGenerator.NodesetIdentifierUnknownSymbol,
|
|
NodesetIdentifierValidationErrorKind.NumericIdMismatch =>
|
|
SourceGenerator.NodesetIdentifierNumericIdMismatch,
|
|
NodesetIdentifierValidationErrorKind.NodeClassMismatch =>
|
|
SourceGenerator.NodesetIdentifierNodeClassMismatch,
|
|
NodesetIdentifierValidationErrorKind.AssignedToMultipleModels =>
|
|
SourceGenerator.NodesetIdentifierAssignedToMultipleModels,
|
|
_ => SourceGenerator.NodesetIdentifierInvalidRow
|
|
},
|
|
Location.None,
|
|
error.NodeSetFilePath,
|
|
error.IdentifierFilePath,
|
|
error.SymbolicName,
|
|
error.Value));
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Group the referenced-assembly attributes by model URI; when more
|
|
/// than one assembly contributes the same URI, prefer a payload-bearing
|
|
/// self producer over payloadless transitive re-exports, then use the
|
|
/// highest <c>(Version, PublicationDate)</c> tuple per the contract on
|
|
/// <see cref="ModelDependencyAttribute"/> (see
|
|
/// <see cref="CompareReferencedModels"/>).
|
|
/// </summary>
|
|
private IReadOnlyDictionary<string, ModelDependencyReference>
|
|
BuildReferencedModelMap()
|
|
{
|
|
if (m_referencedModels.IsDefaultOrEmpty)
|
|
{
|
|
return ImmutableDictionary<string, ModelDependencyReference>.Empty;
|
|
}
|
|
var map = new Dictionary<string, ModelDependencyReference>(
|
|
StringComparer.Ordinal);
|
|
foreach (ModelDependencyReference candidate in m_referencedModels)
|
|
{
|
|
if (!candidate.IsValid)
|
|
{
|
|
continue;
|
|
}
|
|
if (!map.TryGetValue(candidate.ModelUri, out ModelDependencyReference existing))
|
|
{
|
|
map[candidate.ModelUri] = candidate;
|
|
continue;
|
|
}
|
|
int cmp = CompareReferencedModels(candidate, existing);
|
|
if (cmp > 0)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.ModelDependencyTieBreak,
|
|
Location.None,
|
|
candidate.ModelUri,
|
|
candidate.AssemblyName,
|
|
existing.AssemblyName));
|
|
map[candidate.ModelUri] = candidate;
|
|
}
|
|
else if (cmp < 0)
|
|
{
|
|
m_context.ReportDiagnostic(
|
|
Diagnostic.Create(
|
|
SourceGenerator.ModelDependencyTieBreak,
|
|
Location.None,
|
|
existing.ModelUri,
|
|
existing.AssemblyName,
|
|
candidate.AssemblyName));
|
|
}
|
|
}
|
|
return map;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Orders two referenced-assembly entries for the same model URI: a
|
|
/// payload-bearing self producer first, then the version, then the
|
|
/// publication date. The newest entry is picked by pairwise
|
|
/// replacement, so this must be a total order or the winner depends on
|
|
/// the order the assemblies are referenced in. The versions go through
|
|
/// <see cref="SemVer.CompareModels"/>, the OPC 10000-6 F.2 comparator
|
|
/// NodesetFileCollection uses, so the two halves of the pipeline cannot
|
|
/// pick different winners.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// <see cref="ModelDependencyAttribute"/> and its ModelDependencyV1
|
|
/// payload carry a single version string and no separate ModelVersion.
|
|
/// That string is the version the producing generator publishes as the
|
|
/// model's version (the ModelDesign pipeline derives the
|
|
/// NamespaceMetadata ModelVersion from it), so it takes the ModelVersion
|
|
/// slot of the comparison; there is no separate Version label to fall
|
|
/// back to. The raw publication date text breaks what is left.
|
|
/// </remarks>
|
|
internal static int CompareReferencedModels(
|
|
ModelDependencyReference candidate,
|
|
ModelDependencyReference existing)
|
|
{
|
|
int cmp = IsModelProducer(candidate).CompareTo(IsModelProducer(existing));
|
|
if (cmp == 0)
|
|
{
|
|
cmp = SemVer.CompareModels(
|
|
candidate.Version,
|
|
ParsePublicationDate(candidate.PublicationDate),
|
|
null,
|
|
existing.Version,
|
|
ParsePublicationDate(existing.PublicationDate),
|
|
null);
|
|
}
|
|
if (cmp == 0)
|
|
{
|
|
cmp = string.CompareOrdinal(
|
|
candidate.PublicationDate, existing.PublicationDate);
|
|
}
|
|
return cmp;
|
|
}
|
|
|
|
private static DateTime ParsePublicationDate(string publicationDate)
|
|
{
|
|
return !string.IsNullOrEmpty(publicationDate) &&
|
|
DateTime.TryParse(
|
|
publicationDate,
|
|
CultureInfo.InvariantCulture,
|
|
DateTimeStyles.AdjustToUniversal | DateTimeStyles.AssumeUniversal,
|
|
out DateTime date)
|
|
? date
|
|
: DateTime.MinValue;
|
|
}
|
|
|
|
private static bool IsModelProducer(ModelDependencyReference reference)
|
|
{
|
|
ModelDependencyV1 dependency = reference.GetDependency();
|
|
return dependency != null &&
|
|
string.Equals(dependency.ModelUri, reference.ModelUri, StringComparison.Ordinal);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Resolve whether the model-dependency assembly attribute
|
|
/// should be emitted, honouring the compilation's OutputKind
|
|
/// in <c>Auto</c> mode.
|
|
/// </summary>
|
|
private bool ResolveEmitDependencyMetadata()
|
|
{
|
|
return m_options.EmitDependencyMetadata switch
|
|
{
|
|
EmitDependencyMetadataMode.Always => true,
|
|
EmitDependencyMetadataMode.Never => false,
|
|
_ => m_compilationOptions.OutputKind is
|
|
OutputKind.DynamicallyLinkedLibrary or
|
|
OutputKind.NetModule
|
|
};
|
|
}
|
|
|
|
private readonly SourceProductionContext m_context;
|
|
private readonly ImmutableArray<(AdditionalText, NodesetFileOptions)> m_input;
|
|
private readonly ImmutableArray<AdditionalText> m_csvFiles;
|
|
private readonly ImmutableArray<AdditionalText> m_identifierFiles;
|
|
private readonly ModelCompilationOptions m_options;
|
|
private readonly CompilationOptions m_compilationOptions;
|
|
private readonly ImmutableArray<ModelDependencyReference> m_referencedModels;
|
|
private readonly ImmutableArray<ModelFluentAccessorProviderReference>
|
|
m_referencedAccessorProviders;
|
|
private readonly ImmutableArray<NodeManagerAttributeDiscovery> m_nodeManagerBindings;
|
|
private readonly ImmutableHashSet<string> m_availableStateTypeNames;
|
|
private readonly SourceGeneratorTelemetry m_telemetry;
|
|
}
|
|
}
|