Files
UA-.NETStandard/tools/Opc.Ua.SourceGeneration.Core/NodesetFile.cs
T
romanett 442889cba5 Fix source generator audit findings; conform structure-field matrices and type metadata to OPC UA 1.05 (#4569)
# Description

This PR fixes a bug audit of the source generation projects
(`tools/Opc.Ua.SourceGeneration*`: model loading, NodeSet import, all
emitters, the Roslyn hosts and packaging). It also fixes a max-effort
code review of those fixes, and a check of every spec-relevant change
against the OPC UA 1.05 text.

- **Scope:** about 85 audit findings, 48 review findings and 32
spec-grounding items were addressed. Each fix has a regression test that
fails without it.
- **Wire change:** it includes one deliberate, stack-wide wire change:
**structure-field matrices now follow OPC 10000-6 5.2.5 Table 28**.

Most changes are internal correctness fixes. The sections below list
every change a user can observe: wire formats, generated code and API,
generated address-space content, diagnostics and runtime behaviour.

## Behaviour / user-facing changes

### Wire format (encoders)
- **Binary inline matrices** (OPC 10000-6 5.2.5 Table 28).
- **Layout:** a multi-dimensional *structure field* is encoded as
`Int32[] Dimensions`, then the values **without a length prefix**, with
at least 2 dimensions.
- **Empty and null:** any dimension <= 0 means no values follow, and a
null matrix is `-1`. An empty matrix is written as `[0,0]`.
- **Compatibility:** this is **not compatible with earlier builds of
this SDK** for matrix fields. It applies to generated types,
`[DataType]` types, `Structure`, client ComplexTypes and
`WriteEncodeableMatrix`.
  - **Unchanged:** Variant matrices (5.2.2.16) keep their old encoding.
- **Declared rank decides matrix vs array.** A 1-D `MatrixOf<T>` in an
array field or a Variable value is written as an array again.
Matrix-declared fields go through the new public
`EncoderExtensions.WriteInlineMatrixValue`, which generated code also
uses. A non-empty 1-D value in a matrix field throws `BadEncodingError`.
- **Decoder hardening:**
- Before allocating, the decoder bounds all matrix dimensions against
overflow, `MaxArrayLength` and the remaining message length.
  - The decoder rejects:
    - a matrix with fewer than 2 dimensions;
- a populated matrix whose rank differs from the field's declared rank;
    - a union SwitchField greater than the number of fields;
    - an EncodingMask with unassigned bits set.
- **Encoder `MaxArrayLength`:** the encoder enforces `MaxArrayLength`
for inline matrices, as it already did for arrays.
- **XML structure fields** (5.3.1, 5.3.4, 5.3.5).
- **Fields:** `Structure` and client ComplexTypes write fields like
typed fields (`<A>1</A>`, array elements directly) instead of a Variant
body.
- **Matrix fields:** `Dimensions` and `Elements` go directly inside the
field element, with no `<Matrix>` wrapper.
- **Empty matrices:** written as nil, because XML dimensions must be
greater than 0.
  - **Compatibility:** decoders still accept the old shapes.
- **Enum fixes:** enum array elements with value 0 are no longer
dropped, and enum array element names are fixed.
- **Other encoding fixes:**
- A null `DiagnosticInfo` structure field writes `0x00` instead of
nothing.
- A null scalar field in a runtime `Structure` is written as its default
instead of zero bytes, which used to shift every following field.
- A Variant holding an empty matrix encodes as an empty array instead of
throwing.
  - `Variant.Copy` keeps the matrix identity of null and empty matrices.
- **NodeSet export and the DataContract surrogate** write Variable
values with the Variant rules again. A null or empty `MatrixOf` variable
no longer produces invalid XML or unreadable NodeSets.
- **`JsonEncoder.CanOmitFields`** is `true` only for Compact encoding.
Verbose and RawData JSON include default-valued fields.

### `[DataType]` source-generated types
- **Default-value handling** (OPC 10000-6 5.4.1, Table 1).
- **Encode:** a field is omitted only when its value *and* its declared
default are the type's default (0, false, null). Fields with a
non-default initializer or constructor default, and empty strings, are
always written, so configuration files get slightly larger.
- **JSON decode:** a field missing from JSON decodes to the type
default.
- **XML decode:** a field missing from XML keeps its declared default,
which older configuration files rely on.
- **Why:** this fixes silent round-trip loss, for example
`SamplingInterval = 0` read back as `-1`.
- **Nested `[DataType]` types:** they are now generated inside their
containing types. Without an explicit id, their default TypeId and
XmlName are qualified (e.g. `s=Outer.Foo`); **wire identity change** for
nested types. Colliding activator names get a `_2` suffix.
- **Activators:** they are `internal` when the type, or any containing
type, is not public (was CS0060).
- **Matrix properties:**
  - `MatrixOf<T>` properties use the inline matrix encoding.
- Matrices of non-sealed structures, or with
`StructureHandling.ExtensionObject`, are written as ExtensionObjects.
- Their published ValueRank is 2, because the rank can't be known from
`MatrixOf<T>`.
- **Published StructureDefinitions:**
  - They include base-class fields.
  - Nullable properties are no longer marked optional.
  - Inline structure fields name their concrete type.
- **`[Flags]` enums:** they are published as plain enumerations with
their member values, which matches how they are encoded.
- **Other generated code:**
- `Clone` deep-copies arrays and matrices of structures, Variants,
ExtensionObjects and DataValues.
- `IsEqual` and `GetHashCode` are consistent: EncodingMask, active union
member and NaN handling agree.
- Pooled `Reuse()` restores the freshly constructed state through the
new `protected virtual ResetForReuse()`, and returns an instance to its
runtime type's pool.
- **Enum capture:** enum member values are captured culture-invariantly.
Negative values were lost on cultures that use U+2212 as the minus sign.

### Model-driven generator: generated code, API and file names
- **Removed API:** generated `*_Placeholder` proxy accessors (e.g.
`PowerTrainTypeClient.GetMotorIdentifier_PlaceholderAsync`) and fluent
`X_Placeholder()` accessors are removed; they could never resolve
anything.
- Proxy accessors now look children up by BrowseName with the right
namespace.
- `RoboticsClient` finds motors and gears by type and drives via
`IsDrivenBy`. Its topology snapshots used to be empty.
- **Renamed files:** generated files for a bound `[NodeManager]` are now
named `{Namespace}.{Class}.NodeManager.g.cs` (also `.Factory` and
`.FluentBuilders`).
- **Generated NodeState code:**
- Attributes are set through `baseState`/`nodeState` locals, so children
named like base attributes (e.g. `DataType`, `EventNotifier`) compile.
- Children that hide base members are declared `public new`, using names
reflected from the runtime.
  - `global::` qualification is used throughout.
- **Proxies and fluent builders:** a proxy whose supertype is excluded
(e.g. Draft) derives from the nearest emitted ancestor. Fluent wrappers
and NodeState factories fall back the same way; they used to fail with
CS0246.
- **Derived structures:**
  - The optional-field `EncodingMask` continues across inheritance.
- A derived structure over a base type from another model no longer
relies on `base.ResetForReuse`.
- **Default values:**
- NodeId, QualifiedName and ExpandedNodeId defaults resolve by namespace
URI (`context.NamespaceUris.GetIndexOrAppend`) and server URI.
- StatusCode, negative enum, `double`/`float` (shortest round-trip
literal) and escaped string defaults now compile.
- **Event records:**
- Vendor event records have `Decoder.GetStandardFields(NamespaceTable)`,
and their browse paths use the model's namespace.
- A field whose namespace is unknown to the session no longer matches a
namespace-0 field.
  - Companion `StandardFields` is `[Obsolete]`.
- Vendor simple subtypes such as `Percent : Double` map to their
built-in type.
- **Other fixes:**
- `MethodState.CallAsync` passes the real `objectId` to synchronous
`OnCallMethod2` handlers; it used to pass `NodeId.Null`.
- Enumeration fields with an explicit `Identifier` keep it, instead of
taking a trailing `_<digits>`.
  - Explicit NumericIds are no longer reused by automatic numbering.
  - Dependencies are loaded in topological order.

### Generated address-space content
- **Arguments:**
- Methods without arguments no longer get empty
`InputArguments`/`OutputArguments` properties (OPC 10000-3 5.7).
- About 2,660 automatically assigned namespace-0 NodeIds of 15000 and
above shift. Every NodeId in `StandardTypes.csv` is unchanged.
- **Permissions:** type nodes and method declarations on types now carry
the model's `RolePermissions`/`AccessRestrictions`.
- **Restored nodes:** NodeSet import keeps nodes that were silently
dropped before:
- `NamespaceMetadata` objects and the NodeSet's own TypeDictionary
variables;
  - ISA95 placeholders linked only non-hierarchically;
  - instances whose parent is in another namespace.
- **Import details:**
  - ValueRank > 1 without ArrayDimensions keeps its rank.
  - `svr=` indexes map correctly.
  - Invalid MinimumSamplingInterval values import as -1, not 0.
  - Localized texts prefer the invariant or English translation.
- **StructureDefinitions:**
- They include inherited fields, including for subtypes without their
own fields (e.g. `AnonymousIdentityToken` now publishes PolicyId).
  - The StructureType kind covers inherited AllowSubTypes fields.
  - Unions ignore IsOptional.
- StructureFields never publish ValueRank 0; a OneOrMoreDimensions field
without dimensions becomes rank 2.
- Fields with ValueRank -2/-3 are published as scalar BaseDataType,
which is what is on the wire.
- **OptionSets:**
  - Implicit fields get the next free bit.
- `OptionSetValues` uses null for undefined bits instead of "Reserved",
and structure OptionSets publish all their bits (no 32/96-bit cap).
- Numeric OptionSets are limited to their base type's width, and UInt64
bit 63 works.
- **Schemas:**
- Structures with inline-matrix fields are left out of the `.bsd`
(5.2.5).
- In the BSD, Variant-encoded and non-structure subtyped fields are
described as `ua:Variant`.
- In the `.xsd`, matrix fields are typed `ua:Matrix` with
`Dimensions`/`Elements`, and `EncodingMask` is required.

### NodeSet / model input handling
- **Model selection:**
- The newest NodeSet of a model is chosen by `ModelVersion` (SemVer 2.0
precedence), then PublicationDate. The `Version` attribute, which Annex
F says is not for comparison, is only a tie-break.
- The order is total and does not depend on input order; referenced
assemblies use the same rule.
- **Default names:**
- Invalid default Name/Prefix values are repaired (`201301ISA95` becomes
`_201301ISA95`, `class` becomes `class_`).
  - Valid names are unchanged.
  - Sanitising no longer depends on the OS.
- **`ModelUri` metadata** that doesn't match the NodeSet raises a
warning instead of silently losing the model.
- **Input detection:**
- Only XML files whose root is `ModelDesign` or `UANodeSet` are treated
as models.
- A malformed NodeSet stays a NodeSet input, so it no longer breaks the
ModelDesign pass.
- **`IdentifierFile` paths:** they are normalized (`./`, `../`), and the
suffix match requires a folder boundary.
- **Dependency payloads** (`ModelDependencyV1`) carry field IsOptional,
AllowSubTypes, ArrayDimensions and the producer's namespace tables in
skippable trailers, so old and new readers stay compatible.

### Roslyn host, diagnostics, packaging
- **New diagnostics:**
- MODELGEN036: `[NodeManager]` target not supported (nested, generic,
file-local or global namespace).
- MODELGEN037: `[DataType]` target not supported (struct, generic,
abstract, file-local or global namespace).
- MODELGEN038: the definition of an encodeable base type can't be found.
- **New validator errors:**
- a structure with both optional and subtyped fields (OPC 10000-6 F.13);
  - multi-bit or duplicate OptionSet masks.
- **Diagnostic locations:** `[DataType]`/`[NodeManager]` diagnostics
point at real source locations again, so `#pragma` and `.editorconfig`
apply. MODELGEN010 is the exception.
- **Incremental caching:** pipeline values compare by value, so
unrelated edits no longer regenerate the whole model or all
`[DataType]`s.
- **`ModelSourceGeneratorIgnore`** on a ModelDesign input is honoured;
the design still resolves as a dependency.
- **Cancellation:** a cancelled generation run propagates
`OperationCanceledException` instead of reporting a MODELGEN003 error.
- **Stack package:** the `Stack` NuGet package now ships
`build/OPCFoundation.NetStandard.Opc.Ua.SourceGeneration.Stack.props`,
so `StackSourceGeneratorMode` and `StackSourceGeneratorExclude` reach
the compiler.

## Related Issues

- No tracking issue. The audit, review and spec-grounding reports are
available on request. Contains the matrix wire-format change discussed
for D-5 (OPC 10000-6 5.2.5 Table 28).

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
(`docs/SourceGeneratedDataTypes.md`, `docs/NodeManagers.md`, generator
readme)
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings. (`UA.slnx` 0 warnings / 0 errors on net48 and
net10.0)
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed. The
affected suites were run on net10.0: SourceGeneration Core/Roslyn/Stack,
Types, Core.Encoders, Encoders.Fuzz, Client, Client.ComplexTypes,
PubSub, Core, Server, GDS, Configuration, Di, Robotics, ISA95,
Positioning, OpenUsd, XRegistry. net48 was built; its test legs, and the
post-rebase verification, run in CI.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-29 00:47:40 +02:00

617 lines
25 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Globalization;
using System.IO;
using System.Linq;
using Microsoft.Extensions.Logging;
using Opc.Ua.Export;
using Opc.Ua.Schema.Model;
using Opc.Ua.Types;
namespace Opc.Ua.SourceGeneration
{
/// <summary>
/// An entry in the collection
/// </summary>
public sealed class NodesetFile
{
/// <summary>
/// Nodeset information
/// </summary>
public NodesetFileOptions Info { get; init; }
/// <summary>
/// File name
/// </summary>
public string FileName { get; init; }
/// <summary>
/// The nodeset parsed
/// </summary>
public UANodeSet NodeSet { get; init; }
/// <summary>
/// Previous versions
/// </summary>
internal List<NodesetFile> PreviousVersions { get; set; }
/// <summary>
/// The ModelVersion used to order editions of the model: the item
/// metadata Version when set, otherwise the ModelTableEntry
/// ModelVersion (OPC 10000-6 F.2). Null when neither declares one.
/// </summary>
internal string ModelVersion { get; init; }
}
/// <summary>
/// Nodeset information
/// </summary>
public sealed record class NodesetFileOptions
{
/// <summary>
/// Model uri
/// </summary>
public string ModelUri { get; init; }
/// <summary>
/// Name
/// </summary>
public string Name { get; init; }
/// <summary>
/// Prefix to use
/// </summary>
public string Prefix { get; init; }
/// <summary>
/// Should be ignored
/// </summary>
public bool Ignore { get; init; }
/// <summary>
/// Version
/// </summary>
public string Version { get; init; }
/// <summary>
/// Optional identifier CSV explicitly associated with this NodeSet.
/// </summary>
public string IdentifierFile { get; init; }
}
/// <summary>
/// Nodeset compiler
/// </summary>
public sealed class NodesetFileCollection
{
/// <summary>
/// The files in the collection
/// </summary>
public Dictionary<string, string> Files => m_nodesets
.ToDictionary(x => x.Key, x => x.Value.FileName);
/// <summary>
/// The path of every file identified as a NodeSet2 input, including the
/// superseded versions <see cref="Files"/> hides behind the winning one
/// and the ones that failed to load. Callers use this to tell NodeSet2
/// inputs apart from ModelDesign inputs: a superseded NodeSet is still a
/// NodeSet and must not be generated a second time by the ModelDesign
/// pass, and a NodeSet that failed to load is still not a ModelDesign -
/// handing it to the ModelDesign pass only turns a skipped file into a
/// second, more confusing failure.
/// </summary>
public IEnumerable<string> AllFilePaths => m_nodesetPaths;
/// <summary>
/// The models in the collection
/// </summary>
public IEnumerable<string> ModelUris => m_nodesets.Values
.Where(x => !x.Info.Ignore)
.Select(x => x.Info.ModelUri)
.Where(x => !string.IsNullOrEmpty(x));
/// <summary>
/// The design file entries for every nodeset in the collection,
/// encoded as <c>"{file},{prefix},{name}"</c> (the same encoding
/// used by <see cref="GetDesignFileListForModel"/>). These are
/// suitable for use as <c>Dependencies</c> of a ModelDesign
/// generation pass so that a ModelDesign referencing a type
/// defined in a NodeSet2 input can resolve it. The built-in OpcUa
/// namespace and ignored nodesets are excluded.
/// </summary>
public IEnumerable<string> DesignFileEntries => m_nodesets.Values
.Where(x => !x.Info.Ignore && x.Info.ModelUri != Namespaces.OpcUa)
.Select(x => $"{x.FileName},{x.Info.Prefix},{x.Info.Name}");
/// <summary>
/// The identifier CSV files claimed by a NodeSet through its
/// <c>IdentifierFile</c> metadata. They belong to that NodeSet and must
/// not be picked up as the identifier file of a ModelDesign input.
/// </summary>
public IEnumerable<string> IdentifierFilePaths => m_identifierFiles
.Select(entry => entry.IdentifierFile);
/// <summary>
/// Identifier sidecar validation errors discovered while loading NodeSets.
/// </summary>
public IReadOnlyList<NodesetIdentifierValidationError> IdentifierValidationErrors
=> m_identifierValidationErrors;
/// <summary>
/// Create collection
/// </summary>
public NodesetFileCollection(
ImmutableArray<(string, NodesetFileOptions)> nodeset2Files,
IReadOnlyList<string> csvFiles,
IFileSystem fileSystem,
ITelemetryContext telemetry)
{
m_logger = telemetry.CreateLogger<NodesetFileCollection>();
foreach ((string file, NodesetFileOptions options) in nodeset2Files)
{
try
{
if (!NodeSetToModelDesign.IsNodeSet(fileSystem, file))
{
continue;
}
// Positively identified as a NodeSet2 input. Record it
// before the load is attempted: a file that fails to load
// is still not a ModelDesign, and letting it fall through
// to the ModelDesign pass turns a skipped file into a
// second failure that aborts the whole pass.
m_nodesetPaths.Add(file);
using Stream istrm = fileSystem.OpenRead(file);
SystemContext systemContext = new(telemetry)
{
NamespaceUris = new NamespaceTable(),
ServerUris = new StringTable()
};
var nodeset = UANodeSet.Read(istrm);
#if !SKIP_NODE_STATE_LOADING
var collection = new NodeStateCollection();
try
{
nodeset.Import(systemContext, collection);
}
catch (Exception e)
{
m_logger.LogError(e, "NodeSet could not be loaded ({File})", file);
// Skip this NodeSet, not every remaining one - the other
// inputs are independent and must still be loaded.
continue;
}
#endif
if (nodeset.Models == null ||
nodeset.Models.Length == 0 ||
string.IsNullOrEmpty(nodeset.Models[0].ModelUri))
{
m_logger.LogError("NodeSet is missing model definition ({File}).", file);
continue;
}
ModelTableEntry model = nodeset.Models[0];
if (!Uri.IsWellFormedUriString(model.ModelUri, UriKind.Absolute))
{
m_logger.LogError(
"NodeSet ModelURI is not valid ({ModelUri}).", model.ModelUri);
continue;
}
// The model URI is the one the NodeSet declares. An item
// ModelUri that differs cannot rename the model - the nodes
// stay in the NodeSet's namespace, and the collection is
// keyed and its dependencies resolved by the declared URI -
// so honouring it made the model vanish without a word.
if (!string.IsNullOrEmpty(options.ModelUri) &&
!string.Equals(options.ModelUri, model.ModelUri, StringComparison.Ordinal))
{
m_logger.LogWarning(
"NodeSet ({File}) declares model URI {DeclaredModelUri}, " +
"which differs from the ModelUri item metadata {ModelUri}. " +
"The declared model URI is used.",
file,
model.ModelUri,
options.ModelUri);
}
// Get a sane name and prefix
string name = GetDefaultNameFromUri(model.ModelUri);
string prefix = GetDefaultPrefixFromUri(model.ModelUri);
var info = new NodesetFile
{
FileName = file,
NodeSet = nodeset,
// OPC 10000-6 F.2 Table F.1: editions are ordered by the
// SemVer ModelVersion; the Version attribute is "not
// intended for programmatic comparisons".
ModelVersion = FirstNonEmpty(options.Version, model.ModelVersion),
Info = new NodesetFileOptions // Set reasonable defaults if not provided
{
ModelUri = model.ModelUri,
// A label only; ordering uses ModelVersion above.
Version = FirstNonEmpty(
options.Version,
model.ModelVersion,
model.Version,
model.PublicationDate.ToString(
"yyyy-MM-dd", CultureInfo.InvariantCulture)),
Name = !string.IsNullOrEmpty(options.Name) ?
options.Name : name,
Prefix = !string.IsNullOrEmpty(options.Prefix) ?
options.Prefix : prefix,
Ignore = options.Ignore,
IdentifierFile = options.IdentifierFile
}
};
if (!string.IsNullOrWhiteSpace(options.IdentifierFile))
{
string identifierFile = NodesetIdentifierFileValidator.ResolvePath(
file,
options.IdentifierFile,
csvFiles);
if (identifierFile == null)
{
m_identifierValidationErrors.Add(
NodesetIdentifierValidationError.MissingFile(
file,
options.IdentifierFile));
}
else
{
m_identifierFiles.Add((info, identifierFile));
}
}
if (m_nodesets.TryGetValue(model.ModelUri, out NodesetFile existing))
{
// Keep the newest version under the model URI and record
// the superseded one. Replacing unconditionally used to
// drop a newer NodeSet that happened to be read first.
if (CompareVersions(existing, info) < 0)
{
info.PreviousVersions = [];
if (existing.PreviousVersions != null)
{
info.PreviousVersions.AddRange(existing.PreviousVersions);
}
existing.PreviousVersions = null;
info.PreviousVersions.Add(existing);
m_nodesets[model.ModelUri] = info;
}
else
{
existing.PreviousVersions ??= [];
existing.PreviousVersions.Add(info);
}
continue;
}
m_nodesets[model.ModelUri] = info;
}
catch (Exception ex)
{
if (m_logger.IsEnabled(LogLevel.Critical))
{
m_logger.LogCritical(ex, "Could not parse NodeSet ({File}).", file);
}
}
}
foreach (IGrouping<string, (NodesetFile NodeSet, string IdentifierFile)> group in
m_identifierFiles
.GroupBy(entry => entry.IdentifierFile, StringComparer.Ordinal)
.OrderBy(entry => entry.Key, StringComparer.Ordinal))
{
if (group.Count() > 1)
{
foreach ((NodesetFile nodeset, string identifierFile) in group
.OrderBy(entry => entry.NodeSet.FileName, StringComparer.Ordinal))
{
m_identifierValidationErrors.Add(
NodesetIdentifierValidationError.AssignedToMultipleModels(
nodeset.FileName,
identifierFile));
}
continue;
}
(NodesetFile singleNodeset, string singleIdentifierFile) = group.Single();
m_identifierValidationErrors.AddRange(
NodesetIdentifierFileValidator.Validate(
fileSystem,
singleNodeset.FileName,
singleNodeset.Info.ModelUri,
singleIdentifierFile,
telemetry));
}
}
/// <summary>
/// Get nodeset and dependencies for the model uri
/// </summary>
/// <returns></returns>
public List<string> GetDesignFileListForModel(
string modelUri,
out NodesetFile nodeset,
IReadOnlyDictionary<string, ModelDependencyReference> referencedModels = null)
{
if (!m_nodesets.TryGetValue(modelUri, out nodeset))
{
return null;
}
// Seed the visited set with the root: a dependency that lists the
// root among its own NamespaceUris (mutual references) must not
// add the root a second time.
Dictionary<string, NodesetFile> dependencies = new(StringComparer.Ordinal)
{
[nodeset.Info.ModelUri] = nodeset
};
if (!CollectDependencies(nodeset, dependencies, referencedModels))
{
return null;
}
NodesetFile root = nodeset;
List<string> files = [$"{root.FileName},{root.Info.Prefix},{root.Info.Name}"];
foreach (NodesetFile dependency in dependencies.Values
.Where(x => !ReferenceEquals(x, root) && x.Info.ModelUri != Namespaces.OpcUa))
{
files.Add($"{dependency.FileName},{dependency.Info.Prefix},{dependency.Info.Name}");
}
return files;
}
/// <summary>
/// Collect dependencies
/// </summary>
private bool CollectDependencies(
NodesetFile target,
Dictionary<string, NodesetFile> dependencies,
IReadOnlyDictionary<string, ModelDependencyReference> referencedModels)
{
if (target.NodeSet.NamespaceUris == null)
{
return true;
}
foreach (string ns in target.NodeSet.NamespaceUris)
{
if (dependencies.ContainsKey(ns) || ns == target.Info.ModelUri)
{
continue;
}
if (!m_nodesets.TryGetValue(ns, out NodesetFile nodeset))
{
if (referencedModels != null && referencedModels.ContainsKey(ns))
{
// Dependency is supplied by a referenced assembly's
// generated code; not present in AdditionalFiles is
// expected. Skip without erroring.
if (m_logger.IsEnabled(LogLevel.Information))
{
m_logger.LogInformation(
"NodeSet ({ModelUri}) dependency ({Namespace}) " +
"satisfied by referenced assembly.",
target.Info.ModelUri,
ns);
}
continue;
}
m_logger.LogError(
"NodeSet ({ModelUri}) dependency is missing ({Namespace}).",
target.Info.ModelUri,
ns);
return false;
}
// favour the version in the same directory as the target.
if (nodeset.PreviousVersions != null &&
Path.GetDirectoryName(nodeset.FileName) !=
Path.GetDirectoryName(target.FileName))
{
foreach (NodesetFile ii in nodeset.PreviousVersions)
{
if (Path.GetDirectoryName(ii.FileName) ==
Path.GetDirectoryName(target.FileName))
{
nodeset = ii;
break;
}
}
}
dependencies[ns] = nodeset;
if (!CollectDependencies(nodeset, dependencies, referencedModels))
{
return false;
}
}
return true;
}
/// <summary>
/// Compares two NodeSets of the same model URI with
/// <see cref="SemVer.CompareModels"/>: the ModelVersion (item metadata
/// Version overrides the declared one) with SemVer precedence, then the
/// publication date, then the declared Version as a last heuristic. The
/// comparison must be a total order, because the newest of several
/// inputs is picked by pairwise replacement.
/// </summary>
private static int CompareVersions(NodesetFile left, NodesetFile right)
{
// OPC 10000-6 F.2 Table F.1: ModelVersion, then PublicationDate;
// the Version attribute only as a last heuristic.
return SemVer.CompareModels(
left.ModelVersion,
GetPublicationDate(left),
GetModel(left)?.Version,
right.ModelVersion,
GetPublicationDate(right),
GetModel(right)?.Version);
}
private static ModelTableEntry GetModel(NodesetFile nodeset)
{
ModelTableEntry[] models = nodeset.NodeSet?.Models;
return models != null && models.Length > 0 ? models[0] : null;
}
/// <summary>
/// The first of the candidates that carries a value.
/// </summary>
private static string FirstNonEmpty(params string[] candidates)
{
foreach (string candidate in candidates)
{
if (!string.IsNullOrEmpty(candidate))
{
return candidate;
}
}
return string.Empty;
}
private static DateTime GetPublicationDate(NodesetFile nodeset)
{
ModelTableEntry[] models = nodeset.NodeSet?.Models;
return models != null && models.Length > 0
? models[0].PublicationDate
: DateTime.MinValue;
}
private static string GetNameFromUri(string uri)
{
var builder = new Uri(uri);
string path = builder.LocalPath.TrimEnd('/');
if (path.StartsWith("/UA/", StringComparison.OrdinalIgnoreCase))
{
path = path[4..];
}
if (path.StartsWith("/OpcUa/", StringComparison.OrdinalIgnoreCase))
{
path = path[7..];
}
path = path.Trim('/')
.Replace("/", string.Empty, StringComparison.Ordinal)
.Replace('-', '_')
.Replace('+', '_');
int colon = path.LastIndexOf(':');
if (colon != -1)
{
path = path[(colon + 1)..];
}
if (string.IsNullOrEmpty(path))
{
// "http://example.com/" has no path to name the model after.
path = builder.IsAbsoluteUri ? builder.Host : string.Empty;
}
// Control characters became '_' on Windows (invalid file name
// characters) and must keep doing so everywhere; every other
// character an identifier cannot hold is repaired by the callers.
return new string([.. path.Select(c => char.IsControl(c) ? '_' : c)]);
}
/// <summary>
/// The default <c>Namespaces</c> constant name for a model URI: a single
/// C# identifier. A name that already is one is returned unchanged;
/// anything else (a leading digit as in "2013/01/ISA95", a '.', or any
/// other character an identifier cannot hold) is repaired. The repair is
/// the same on every OS - it used to depend on the platform's invalid
/// file name characters.
/// </summary>
internal static string GetDefaultNameFromUri(string uri)
{
string name = GetNameFromUri(uri);
return string.IsNullOrEmpty(name) ? name : ToKeywordSafeIdentifier(name);
}
/// <summary>
/// A C# identifier that needs no '@' escape. The Name and Prefix are
/// also used in generated member names ("Add{Prefix}"), Roslyn hint
/// names and as XML namespace prefix, where the '@' that escapes a
/// keyword ("@class") is not allowed - a keyword gets a trailing '_'
/// ("class_") instead. Every other identifier is returned unchanged.
/// </summary>
private static string ToKeywordSafeIdentifier(string name)
{
string identifier = name.ToCSharpIdentifierPreserveCase();
return identifier.Length > 0 && identifier[0] == '@'
? identifier[1..] + "_"
: identifier;
}
/// <summary>
/// The default C# namespace (prefix) for a model URI: dot separated C#
/// identifiers. Every segment that already is an identifier is kept
/// unchanged, so a prefix that compiled before is not renamed.
/// </summary>
internal static string GetDefaultPrefixFromUri(string uri)
{
string name = GetNameFromUri(uri);
if (string.IsNullOrEmpty(name))
{
return name;
}
return string.Join(
".",
name.Split(['.'], StringSplitOptions.RemoveEmptyEntries)
.Select(ToKeywordSafeIdentifier));
}
private readonly ILogger m_logger;
private readonly Dictionary<string, NodesetFile> m_nodesets = [];
/// <summary>
/// Every input recognised as a NodeSet2 file, whether or not it loaded
/// and whether or not it won its model URI. See <see cref="AllFilePaths"/>.
/// </summary>
private readonly HashSet<string> m_nodesetPaths = new(StringComparer.Ordinal);
private readonly List<(NodesetFile NodeSet, string IdentifierFile)> m_identifierFiles = [];
private readonly List<NodesetIdentifierValidationError> m_identifierValidationErrors = [];
}
}