mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-22 17:50:03 +08:00
442889cba5
# Description
This PR fixes a bug audit of the source generation projects
(`tools/Opc.Ua.SourceGeneration*`: model loading, NodeSet import, all
emitters, the Roslyn hosts and packaging). It also fixes a max-effort
code review of those fixes, and a check of every spec-relevant change
against the OPC UA 1.05 text.
- **Scope:** about 85 audit findings, 48 review findings and 32
spec-grounding items were addressed. Each fix has a regression test that
fails without it.
- **Wire change:** it includes one deliberate, stack-wide wire change:
**structure-field matrices now follow OPC 10000-6 5.2.5 Table 28**.
Most changes are internal correctness fixes. The sections below list
every change a user can observe: wire formats, generated code and API,
generated address-space content, diagnostics and runtime behaviour.
## Behaviour / user-facing changes
### Wire format (encoders)
- **Binary inline matrices** (OPC 10000-6 5.2.5 Table 28).
- **Layout:** a multi-dimensional *structure field* is encoded as
`Int32[] Dimensions`, then the values **without a length prefix**, with
at least 2 dimensions.
- **Empty and null:** any dimension <= 0 means no values follow, and a
null matrix is `-1`. An empty matrix is written as `[0,0]`.
- **Compatibility:** this is **not compatible with earlier builds of
this SDK** for matrix fields. It applies to generated types,
`[DataType]` types, `Structure`, client ComplexTypes and
`WriteEncodeableMatrix`.
- **Unchanged:** Variant matrices (5.2.2.16) keep their old encoding.
- **Declared rank decides matrix vs array.** A 1-D `MatrixOf<T>` in an
array field or a Variable value is written as an array again.
Matrix-declared fields go through the new public
`EncoderExtensions.WriteInlineMatrixValue`, which generated code also
uses. A non-empty 1-D value in a matrix field throws `BadEncodingError`.
- **Decoder hardening:**
- Before allocating, the decoder bounds all matrix dimensions against
overflow, `MaxArrayLength` and the remaining message length.
- The decoder rejects:
- a matrix with fewer than 2 dimensions;
- a populated matrix whose rank differs from the field's declared rank;
- a union SwitchField greater than the number of fields;
- an EncodingMask with unassigned bits set.
- **Encoder `MaxArrayLength`:** the encoder enforces `MaxArrayLength`
for inline matrices, as it already did for arrays.
- **XML structure fields** (5.3.1, 5.3.4, 5.3.5).
- **Fields:** `Structure` and client ComplexTypes write fields like
typed fields (`<A>1</A>`, array elements directly) instead of a Variant
body.
- **Matrix fields:** `Dimensions` and `Elements` go directly inside the
field element, with no `<Matrix>` wrapper.
- **Empty matrices:** written as nil, because XML dimensions must be
greater than 0.
- **Compatibility:** decoders still accept the old shapes.
- **Enum fixes:** enum array elements with value 0 are no longer
dropped, and enum array element names are fixed.
- **Other encoding fixes:**
- A null `DiagnosticInfo` structure field writes `0x00` instead of
nothing.
- A null scalar field in a runtime `Structure` is written as its default
instead of zero bytes, which used to shift every following field.
- A Variant holding an empty matrix encodes as an empty array instead of
throwing.
- `Variant.Copy` keeps the matrix identity of null and empty matrices.
- **NodeSet export and the DataContract surrogate** write Variable
values with the Variant rules again. A null or empty `MatrixOf` variable
no longer produces invalid XML or unreadable NodeSets.
- **`JsonEncoder.CanOmitFields`** is `true` only for Compact encoding.
Verbose and RawData JSON include default-valued fields.
### `[DataType]` source-generated types
- **Default-value handling** (OPC 10000-6 5.4.1, Table 1).
- **Encode:** a field is omitted only when its value *and* its declared
default are the type's default (0, false, null). Fields with a
non-default initializer or constructor default, and empty strings, are
always written, so configuration files get slightly larger.
- **JSON decode:** a field missing from JSON decodes to the type
default.
- **XML decode:** a field missing from XML keeps its declared default,
which older configuration files rely on.
- **Why:** this fixes silent round-trip loss, for example
`SamplingInterval = 0` read back as `-1`.
- **Nested `[DataType]` types:** they are now generated inside their
containing types. Without an explicit id, their default TypeId and
XmlName are qualified (e.g. `s=Outer.Foo`); **wire identity change** for
nested types. Colliding activator names get a `_2` suffix.
- **Activators:** they are `internal` when the type, or any containing
type, is not public (was CS0060).
- **Matrix properties:**
- `MatrixOf<T>` properties use the inline matrix encoding.
- Matrices of non-sealed structures, or with
`StructureHandling.ExtensionObject`, are written as ExtensionObjects.
- Their published ValueRank is 2, because the rank can't be known from
`MatrixOf<T>`.
- **Published StructureDefinitions:**
- They include base-class fields.
- Nullable properties are no longer marked optional.
- Inline structure fields name their concrete type.
- **`[Flags]` enums:** they are published as plain enumerations with
their member values, which matches how they are encoded.
- **Other generated code:**
- `Clone` deep-copies arrays and matrices of structures, Variants,
ExtensionObjects and DataValues.
- `IsEqual` and `GetHashCode` are consistent: EncodingMask, active union
member and NaN handling agree.
- Pooled `Reuse()` restores the freshly constructed state through the
new `protected virtual ResetForReuse()`, and returns an instance to its
runtime type's pool.
- **Enum capture:** enum member values are captured culture-invariantly.
Negative values were lost on cultures that use U+2212 as the minus sign.
### Model-driven generator: generated code, API and file names
- **Removed API:** generated `*_Placeholder` proxy accessors (e.g.
`PowerTrainTypeClient.GetMotorIdentifier_PlaceholderAsync`) and fluent
`X_Placeholder()` accessors are removed; they could never resolve
anything.
- Proxy accessors now look children up by BrowseName with the right
namespace.
- `RoboticsClient` finds motors and gears by type and drives via
`IsDrivenBy`. Its topology snapshots used to be empty.
- **Renamed files:** generated files for a bound `[NodeManager]` are now
named `{Namespace}.{Class}.NodeManager.g.cs` (also `.Factory` and
`.FluentBuilders`).
- **Generated NodeState code:**
- Attributes are set through `baseState`/`nodeState` locals, so children
named like base attributes (e.g. `DataType`, `EventNotifier`) compile.
- Children that hide base members are declared `public new`, using names
reflected from the runtime.
- `global::` qualification is used throughout.
- **Proxies and fluent builders:** a proxy whose supertype is excluded
(e.g. Draft) derives from the nearest emitted ancestor. Fluent wrappers
and NodeState factories fall back the same way; they used to fail with
CS0246.
- **Derived structures:**
- The optional-field `EncodingMask` continues across inheritance.
- A derived structure over a base type from another model no longer
relies on `base.ResetForReuse`.
- **Default values:**
- NodeId, QualifiedName and ExpandedNodeId defaults resolve by namespace
URI (`context.NamespaceUris.GetIndexOrAppend`) and server URI.
- StatusCode, negative enum, `double`/`float` (shortest round-trip
literal) and escaped string defaults now compile.
- **Event records:**
- Vendor event records have `Decoder.GetStandardFields(NamespaceTable)`,
and their browse paths use the model's namespace.
- A field whose namespace is unknown to the session no longer matches a
namespace-0 field.
- Companion `StandardFields` is `[Obsolete]`.
- Vendor simple subtypes such as `Percent : Double` map to their
built-in type.
- **Other fixes:**
- `MethodState.CallAsync` passes the real `objectId` to synchronous
`OnCallMethod2` handlers; it used to pass `NodeId.Null`.
- Enumeration fields with an explicit `Identifier` keep it, instead of
taking a trailing `_<digits>`.
- Explicit NumericIds are no longer reused by automatic numbering.
- Dependencies are loaded in topological order.
### Generated address-space content
- **Arguments:**
- Methods without arguments no longer get empty
`InputArguments`/`OutputArguments` properties (OPC 10000-3 5.7).
- About 2,660 automatically assigned namespace-0 NodeIds of 15000 and
above shift. Every NodeId in `StandardTypes.csv` is unchanged.
- **Permissions:** type nodes and method declarations on types now carry
the model's `RolePermissions`/`AccessRestrictions`.
- **Restored nodes:** NodeSet import keeps nodes that were silently
dropped before:
- `NamespaceMetadata` objects and the NodeSet's own TypeDictionary
variables;
- ISA95 placeholders linked only non-hierarchically;
- instances whose parent is in another namespace.
- **Import details:**
- ValueRank > 1 without ArrayDimensions keeps its rank.
- `svr=` indexes map correctly.
- Invalid MinimumSamplingInterval values import as -1, not 0.
- Localized texts prefer the invariant or English translation.
- **StructureDefinitions:**
- They include inherited fields, including for subtypes without their
own fields (e.g. `AnonymousIdentityToken` now publishes PolicyId).
- The StructureType kind covers inherited AllowSubTypes fields.
- Unions ignore IsOptional.
- StructureFields never publish ValueRank 0; a OneOrMoreDimensions field
without dimensions becomes rank 2.
- Fields with ValueRank -2/-3 are published as scalar BaseDataType,
which is what is on the wire.
- **OptionSets:**
- Implicit fields get the next free bit.
- `OptionSetValues` uses null for undefined bits instead of "Reserved",
and structure OptionSets publish all their bits (no 32/96-bit cap).
- Numeric OptionSets are limited to their base type's width, and UInt64
bit 63 works.
- **Schemas:**
- Structures with inline-matrix fields are left out of the `.bsd`
(5.2.5).
- In the BSD, Variant-encoded and non-structure subtyped fields are
described as `ua:Variant`.
- In the `.xsd`, matrix fields are typed `ua:Matrix` with
`Dimensions`/`Elements`, and `EncodingMask` is required.
### NodeSet / model input handling
- **Model selection:**
- The newest NodeSet of a model is chosen by `ModelVersion` (SemVer 2.0
precedence), then PublicationDate. The `Version` attribute, which Annex
F says is not for comparison, is only a tie-break.
- The order is total and does not depend on input order; referenced
assemblies use the same rule.
- **Default names:**
- Invalid default Name/Prefix values are repaired (`201301ISA95` becomes
`_201301ISA95`, `class` becomes `class_`).
- Valid names are unchanged.
- Sanitising no longer depends on the OS.
- **`ModelUri` metadata** that doesn't match the NodeSet raises a
warning instead of silently losing the model.
- **Input detection:**
- Only XML files whose root is `ModelDesign` or `UANodeSet` are treated
as models.
- A malformed NodeSet stays a NodeSet input, so it no longer breaks the
ModelDesign pass.
- **`IdentifierFile` paths:** they are normalized (`./`, `../`), and the
suffix match requires a folder boundary.
- **Dependency payloads** (`ModelDependencyV1`) carry field IsOptional,
AllowSubTypes, ArrayDimensions and the producer's namespace tables in
skippable trailers, so old and new readers stay compatible.
### Roslyn host, diagnostics, packaging
- **New diagnostics:**
- MODELGEN036: `[NodeManager]` target not supported (nested, generic,
file-local or global namespace).
- MODELGEN037: `[DataType]` target not supported (struct, generic,
abstract, file-local or global namespace).
- MODELGEN038: the definition of an encodeable base type can't be found.
- **New validator errors:**
- a structure with both optional and subtyped fields (OPC 10000-6 F.13);
- multi-bit or duplicate OptionSet masks.
- **Diagnostic locations:** `[DataType]`/`[NodeManager]` diagnostics
point at real source locations again, so `#pragma` and `.editorconfig`
apply. MODELGEN010 is the exception.
- **Incremental caching:** pipeline values compare by value, so
unrelated edits no longer regenerate the whole model or all
`[DataType]`s.
- **`ModelSourceGeneratorIgnore`** on a ModelDesign input is honoured;
the design still resolves as a dependency.
- **Cancellation:** a cancelled generation run propagates
`OperationCanceledException` instead of reporting a MODELGEN003 error.
- **Stack package:** the `Stack` NuGet package now ships
`build/OPCFoundation.NetStandard.Opc.Ua.SourceGeneration.Stack.props`,
so `StackSourceGeneratorMode` and `StackSourceGeneratorExclude` reach
the compiler.
## Related Issues
- No tracking issue. The audit, review and spec-grounding reports are
available on request. Contains the matrix wire-format change discussed
for D-5 (OPC 10000-6 5.2.5 Table 28).
## Checklist
- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
(`docs/SourceGeneratedDataTypes.md`, `docs/NodeManagers.md`, generator
readme)
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings. (`UA.slnx` 0 warnings / 0 errors on net48 and
net10.0)
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed. The
affected suites were run on net10.0: SourceGeneration Core/Roslyn/Stack,
Types, Core.Encoders, Encoders.Fuzz, Client, Client.ComplexTypes,
PubSub, Core, Server, GDS, Configuration, Di, Robotics, ISA95,
Positioning, OpenUsd, XRegistry. net48 was built; its test legs, and the
post-rebase verification, run in CI.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
441 lines
16 KiB
C#
441 lines
16 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Globalization;
|
|
using System.IO;
|
|
using System.Linq;
|
|
using Opc.Ua.Schema.Model;
|
|
|
|
namespace Opc.Ua.SourceGeneration
|
|
{
|
|
/// <summary>
|
|
/// The category of an explicit NodeSet identifier sidecar validation error.
|
|
/// </summary>
|
|
public enum NodesetIdentifierValidationErrorKind
|
|
{
|
|
/// <summary>
|
|
/// The configured sidecar was not provided as an additional file.
|
|
/// </summary>
|
|
MissingFile,
|
|
|
|
/// <summary>
|
|
/// A CSV symbolic name occurs more than once.
|
|
/// </summary>
|
|
DuplicateSymbolicName,
|
|
|
|
/// <summary>
|
|
/// A CSV numeric identifier occurs more than once.
|
|
/// </summary>
|
|
DuplicateNumericId,
|
|
|
|
/// <summary>
|
|
/// A CSV symbol was not imported from the NodeSet.
|
|
/// </summary>
|
|
UnknownSymbol,
|
|
|
|
/// <summary>
|
|
/// A CSV numeric identifier differs from the NodeSet node identifier.
|
|
/// </summary>
|
|
NumericIdMismatch,
|
|
|
|
/// <summary>
|
|
/// A CSV node class differs from the NodeSet node class.
|
|
/// </summary>
|
|
NodeClassMismatch,
|
|
|
|
/// <summary>
|
|
/// An explicit sidecar was configured for more than one NodeSet.
|
|
/// </summary>
|
|
AssignedToMultipleModels,
|
|
|
|
/// <summary>
|
|
/// A CSV row does not follow the identifier CSV format.
|
|
/// </summary>
|
|
InvalidRow
|
|
}
|
|
|
|
/// <summary>
|
|
/// A validation error for an explicit NodeSet identifier CSV sidecar.
|
|
/// </summary>
|
|
public sealed record class NodesetIdentifierValidationError
|
|
{
|
|
/// <summary>
|
|
/// The error category.
|
|
/// </summary>
|
|
public NodesetIdentifierValidationErrorKind Kind { get; init; }
|
|
|
|
/// <summary>
|
|
/// The NodeSet XML file declaring the sidecar.
|
|
/// </summary>
|
|
public string NodeSetFilePath { get; init; }
|
|
|
|
/// <summary>
|
|
/// The configured or resolved sidecar path.
|
|
/// </summary>
|
|
public string IdentifierFilePath { get; init; }
|
|
|
|
/// <summary>
|
|
/// The related symbolic name, if applicable.
|
|
/// </summary>
|
|
public string SymbolicName { get; init; }
|
|
|
|
/// <summary>
|
|
/// The related value, if applicable.
|
|
/// </summary>
|
|
public string Value { get; init; }
|
|
|
|
/// <summary>
|
|
/// Creates a missing-sidecar validation error.
|
|
/// </summary>
|
|
public static NodesetIdentifierValidationError MissingFile(
|
|
string nodeSetFilePath,
|
|
string identifierFilePath)
|
|
{
|
|
return new NodesetIdentifierValidationError
|
|
{
|
|
Kind = NodesetIdentifierValidationErrorKind.MissingFile,
|
|
NodeSetFilePath = nodeSetFilePath,
|
|
IdentifierFilePath = identifierFilePath
|
|
};
|
|
}
|
|
|
|
/// <summary>
|
|
/// Creates a shared-sidecar validation error.
|
|
/// </summary>
|
|
public static NodesetIdentifierValidationError AssignedToMultipleModels(
|
|
string nodeSetFilePath,
|
|
string identifierFilePath)
|
|
{
|
|
return new NodesetIdentifierValidationError
|
|
{
|
|
Kind = NodesetIdentifierValidationErrorKind.AssignedToMultipleModels,
|
|
NodeSetFilePath = nodeSetFilePath,
|
|
IdentifierFilePath = identifierFilePath
|
|
};
|
|
}
|
|
}
|
|
|
|
internal static class NodesetIdentifierFileValidator
|
|
{
|
|
public static string ResolvePath(
|
|
string nodeSetFilePath,
|
|
string identifierFilePath,
|
|
IReadOnlyList<string> csvFiles)
|
|
{
|
|
if (csvFiles == null || csvFiles.Count == 0)
|
|
{
|
|
return null;
|
|
}
|
|
|
|
string relativePath = identifierFilePath.Trim();
|
|
string adjacentPath = Path.IsPathRooted(relativePath)
|
|
? relativePath
|
|
: Path.Combine(Path.GetDirectoryName(nodeSetFilePath) ?? string.Empty, relativePath);
|
|
|
|
// AdditionalFiles paths are full, normalized paths; the metadata
|
|
// is whatever the project author typed ("./x.csv", "..\x.csv",
|
|
// "sub/x.csv"). Compare both sides in the same lexical normal form.
|
|
// Lexical, not Path.GetFullPath: the inputs need not be file system
|
|
// paths at all (in-memory AdditionalTexts).
|
|
string normalizedAdjacent = NormalizePath(adjacentPath);
|
|
string directMatch = csvFiles.FirstOrDefault(path =>
|
|
string.Equals(NormalizePath(path), normalizedAdjacent, s_pathComparison));
|
|
if (directMatch != null)
|
|
{
|
|
return directMatch;
|
|
}
|
|
|
|
// Fall back to a unique AdditionalFile whose path ends with the
|
|
// given one - on a directory boundary, or "NodeIds.csv" would also
|
|
// match "Opc.Ua.Di.NodeIds.csv". Leading "./" and "../" segments
|
|
// cannot be part of an AdditionalFile path, so they are dropped.
|
|
string suffix = NormalizePath(relativePath);
|
|
while (suffix.StartsWith("../", StringComparison.Ordinal) ||
|
|
suffix.StartsWith("./", StringComparison.Ordinal) ||
|
|
suffix.StartsWith('/'))
|
|
{
|
|
suffix = suffix[(suffix.IndexOf('/', StringComparison.Ordinal) + 1)..];
|
|
}
|
|
if (suffix.Length == 0)
|
|
{
|
|
return null;
|
|
}
|
|
string[] matches = [.. csvFiles
|
|
.Where(path => EndsWithPathSegments(NormalizePath(path), suffix))
|
|
.OrderBy(path => path, StringComparer.Ordinal)];
|
|
return matches.Length == 1 ? matches[0] : null;
|
|
}
|
|
|
|
/// <summary>
|
|
/// True when <paramref name="path"/> ends with <paramref name="suffix"/>
|
|
/// and the suffix starts at a directory boundary.
|
|
/// </summary>
|
|
private static bool EndsWithPathSegments(string path, string suffix)
|
|
{
|
|
if (!path.EndsWith(suffix, s_pathComparison))
|
|
{
|
|
return false;
|
|
}
|
|
return path.Length == suffix.Length ||
|
|
path[path.Length - suffix.Length - 1] == '/';
|
|
}
|
|
|
|
/// <summary>
|
|
/// Lexically normalizes a path: both separators become '/', "."
|
|
/// segments are removed and ".." segments cancel the segment before
|
|
/// them. Roots ("C:", "memory:", a leading "/") are kept as they are.
|
|
/// </summary>
|
|
internal static string NormalizePath(string path)
|
|
{
|
|
if (string.IsNullOrEmpty(path))
|
|
{
|
|
return string.Empty;
|
|
}
|
|
|
|
string[] segments = path.Replace('\\', '/').Split('/');
|
|
var result = new List<string>(segments.Length);
|
|
for (int ii = 0; ii < segments.Length; ii++)
|
|
{
|
|
string segment = segments[ii];
|
|
if (segment == "." && ii > 0)
|
|
{
|
|
continue;
|
|
}
|
|
if (segment == ".." &&
|
|
result.Count > 0 &&
|
|
result[^1].Length > 0 &&
|
|
result[^1] != ".." &&
|
|
result[^1] != "." &&
|
|
!result[^1].EndsWith(':'))
|
|
{
|
|
result.RemoveAt(result.Count - 1);
|
|
continue;
|
|
}
|
|
result.Add(segment);
|
|
}
|
|
return string.Join("/", result);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Windows file systems are case insensitive; a path typed in the
|
|
/// project with another casing still names the same file there.
|
|
/// </summary>
|
|
private static readonly StringComparison s_pathComparison =
|
|
Path.DirectorySeparatorChar == '\\'
|
|
? StringComparison.OrdinalIgnoreCase
|
|
: StringComparison.Ordinal;
|
|
|
|
public static IEnumerable<NodesetIdentifierValidationError> Validate(
|
|
IFileSystem fileSystem,
|
|
string nodeSetFilePath,
|
|
string modelUri,
|
|
string identifierFilePath,
|
|
ITelemetryContext telemetry)
|
|
{
|
|
var settings = new NodeSetReaderSettings();
|
|
var importer = new NodeSetToModelDesign(
|
|
fileSystem,
|
|
nodeSetFilePath,
|
|
settings,
|
|
telemetry);
|
|
var symbols = importer
|
|
.GetImportedSymbols(modelUri)
|
|
.ToDictionary(symbol => symbol.SymbolicName, StringComparer.Ordinal);
|
|
List<NodesetIdentifierCsvRow> rows = Parse(identifierFilePath, fileSystem);
|
|
var errors = new List<NodesetIdentifierValidationError>();
|
|
var names = new HashSet<string>(StringComparer.Ordinal);
|
|
var ids = new HashSet<uint>();
|
|
|
|
foreach (NodesetIdentifierCsvRow row in rows)
|
|
{
|
|
if (!row.IsValid)
|
|
{
|
|
errors.Add(CreateError(
|
|
NodesetIdentifierValidationErrorKind.InvalidRow,
|
|
nodeSetFilePath,
|
|
identifierFilePath,
|
|
null,
|
|
row.LineNumber.ToString(CultureInfo.InvariantCulture)));
|
|
continue;
|
|
}
|
|
|
|
if (!names.Add(row.SymbolicName))
|
|
{
|
|
errors.Add(CreateError(
|
|
NodesetIdentifierValidationErrorKind.DuplicateSymbolicName,
|
|
nodeSetFilePath,
|
|
identifierFilePath,
|
|
row.SymbolicName,
|
|
null));
|
|
}
|
|
|
|
if (!ids.Add(row.NumericId))
|
|
{
|
|
errors.Add(CreateError(
|
|
NodesetIdentifierValidationErrorKind.DuplicateNumericId,
|
|
nodeSetFilePath,
|
|
identifierFilePath,
|
|
row.SymbolicName,
|
|
row.NumericId.ToString(CultureInfo.InvariantCulture)));
|
|
}
|
|
|
|
if (!symbols.TryGetValue(row.SymbolicName, out NodesetImportedSymbol symbol))
|
|
{
|
|
errors.Add(CreateError(
|
|
NodesetIdentifierValidationErrorKind.UnknownSymbol,
|
|
nodeSetFilePath,
|
|
identifierFilePath,
|
|
row.SymbolicName,
|
|
null));
|
|
continue;
|
|
}
|
|
|
|
if (symbol.NumericId != row.NumericId)
|
|
{
|
|
errors.Add(CreateError(
|
|
NodesetIdentifierValidationErrorKind.NumericIdMismatch,
|
|
nodeSetFilePath,
|
|
identifierFilePath,
|
|
row.SymbolicName,
|
|
row.NumericId.ToString(CultureInfo.InvariantCulture)));
|
|
}
|
|
|
|
if (symbol.NodeClass != row.NodeClass)
|
|
{
|
|
errors.Add(CreateError(
|
|
NodesetIdentifierValidationErrorKind.NodeClassMismatch,
|
|
nodeSetFilePath,
|
|
identifierFilePath,
|
|
row.SymbolicName,
|
|
row.NodeClass.ToString()));
|
|
}
|
|
}
|
|
|
|
return errors;
|
|
}
|
|
|
|
private static List<NodesetIdentifierCsvRow> Parse(
|
|
string identifierFilePath,
|
|
IFileSystem fileSystem)
|
|
{
|
|
var rows = new List<NodesetIdentifierCsvRow>();
|
|
using Stream stream = fileSystem.OpenRead(identifierFilePath);
|
|
using var reader = new StreamReader(stream);
|
|
int lineNumber = 0;
|
|
|
|
while (reader.ReadLine() is string line)
|
|
{
|
|
lineNumber++;
|
|
line = line.TrimStart('\uFEFF').Trim();
|
|
if (string.IsNullOrEmpty(line) ||
|
|
line.StartsWith('#'))
|
|
{
|
|
continue;
|
|
}
|
|
|
|
string[] columns = line.Split(',');
|
|
if (IsHeader(columns))
|
|
{
|
|
continue;
|
|
}
|
|
|
|
if (columns.Length != 3 ||
|
|
!uint.TryParse(
|
|
columns[1].Trim(),
|
|
NumberStyles.None,
|
|
CultureInfo.InvariantCulture,
|
|
out uint numericId) ||
|
|
!Enum.TryParse(columns[2].Trim(), true, out NodeClass nodeClass) ||
|
|
nodeClass == NodeClass.Unspecified ||
|
|
string.IsNullOrWhiteSpace(columns[0]))
|
|
{
|
|
rows.Add(new NodesetIdentifierCsvRow { LineNumber = lineNumber });
|
|
continue;
|
|
}
|
|
|
|
rows.Add(new NodesetIdentifierCsvRow
|
|
{
|
|
LineNumber = lineNumber,
|
|
SymbolicName = columns[0].Trim(),
|
|
NumericId = numericId,
|
|
NodeClass = nodeClass,
|
|
IsValid = true
|
|
});
|
|
}
|
|
|
|
return rows;
|
|
}
|
|
|
|
private static bool IsHeader(string[] columns)
|
|
{
|
|
return columns.Length >= 3 &&
|
|
string.Equals(
|
|
columns[0].TrimStart('\uFEFF').Trim(),
|
|
"SymbolicName",
|
|
StringComparison.OrdinalIgnoreCase) &&
|
|
(string.Equals(columns[1].Trim(), "Id", StringComparison.OrdinalIgnoreCase) ||
|
|
string.Equals(columns[1].Trim(), "NodeId", StringComparison.OrdinalIgnoreCase) ||
|
|
string.Equals(columns[1].Trim(), "NumericId", StringComparison.OrdinalIgnoreCase)) &&
|
|
string.Equals(columns[2].Trim(), "NodeClass", StringComparison.OrdinalIgnoreCase);
|
|
}
|
|
|
|
private static NodesetIdentifierValidationError CreateError(
|
|
NodesetIdentifierValidationErrorKind kind,
|
|
string nodeSetFilePath,
|
|
string identifierFilePath,
|
|
string symbolicName,
|
|
string value)
|
|
{
|
|
return new NodesetIdentifierValidationError
|
|
{
|
|
Kind = kind,
|
|
NodeSetFilePath = nodeSetFilePath,
|
|
IdentifierFilePath = identifierFilePath,
|
|
SymbolicName = symbolicName,
|
|
Value = value
|
|
};
|
|
}
|
|
|
|
private sealed record class NodesetIdentifierCsvRow
|
|
{
|
|
public int LineNumber { get; init; }
|
|
|
|
public string SymbolicName { get; init; }
|
|
|
|
public uint NumericId { get; init; }
|
|
|
|
public NodeClass NodeClass { get; init; }
|
|
|
|
public bool IsValid { get; init; }
|
|
}
|
|
}
|
|
}
|