mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-23 10:23:13 +08:00
Kurt
300d9ffd62
* Use nameof() where applicable Category: Maintainability https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1015.md * Rethrow original exception Preserves original stack trace of the exception, easier to diagnose Category: Maintainability https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1044.md https://stackoverflow.com/a/178464 Remove variable from the catch if not logged (compiler warning). * Combine Where->FirstOrDefault, use Find if applicable Category: Performance https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1077.md In ApplicationConfiguration: ServerSecurityPolicyCollection inherits from List<T>, so use List.Find (better performance than FirstOrDefault) * Use List.Count rather than LINQ Any() Category: Performance https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1080.md refsToRemove is a List<T>, which we know the count of (no need to iterate). * Add [Flags] Attribute for OpenFileMode Each enum is a bitflag here Just noticed this is in the "Generated" folder... some prior commits had touched other "Generated" files -- see nameof commit. * Minor performance behavior - EventArgs.Empty instead of allocating a new blank EventArgs It only really happens on Connect/Disconnect so it's not like a single allocation really matters - Use array[0] instead of First() https://stackoverflow.com/a/25607951 - Use !Any() instead of Count() == 0 If a dependent field is found, it will stop evaluating the rest and Add instead of Insert. Count() == 0 required evaluation of all - Use All() instead of FirstOrDefault(any) == null Clearer intent (all are not matching the group BrowseName => clear default) Slightly faster as the first match found doesn't have to be compared against null * Revert changes to generated files * Fix mistake fixes compile error