From 2871411d90320b371de6519c549cb974859cd506 Mon Sep 17 00:00:00 2001 From: Jonathan Lipps Date: Wed, 9 Apr 2014 18:40:03 -0700 Subject: [PATCH] remove 'mobile: waitForPageLoad' --- lib/devices/android/android-controller.js | 4 ---- lib/devices/ios/ios-controller.js | 4 ---- lib/server/controller.js | 10 ---------- 3 files changed, 18 deletions(-) diff --git a/lib/devices/android/android-controller.js b/lib/devices/android/android-controller.js index 108e7feb8..62b33090d 100644 --- a/lib/devices/android/android-controller.js +++ b/lib/devices/android/android-controller.js @@ -399,10 +399,6 @@ androidController.getPageSource = function (cb) { }); }; -androidController.waitForPageLoad = function (timeout, cb) { - this.proxy(["waitForIdle", {timeout: timeout}], cb); -}; - androidController.getAlertText = function (cb) { cb(new NotYetImplementedError(), null); }; diff --git a/lib/devices/ios/ios-controller.js b/lib/devices/ios/ios-controller.js index 43c1aa04d..2e4dd9a98 100644 --- a/lib/devices/ios/ios-controller.js +++ b/lib/devices/ios/ios-controller.js @@ -1035,10 +1035,6 @@ iOSController.getPageSource = function (cb) { } }; -iOSController.waitForPageLoad = function (timeout, cb) { - this.proxy("au.waitForPageLoad(" + timeout + ")", cb); -}; - iOSController.getAlertText = function (cb) { this.proxy("au.getAlertText()", cb); }; diff --git a/lib/server/controller.js b/lib/server/controller.js index e2d099a68..3a2139578 100644 --- a/lib/server/controller.js +++ b/lib/server/controller.js @@ -627,15 +627,6 @@ exports.getPageSource = function (req, res) { req.device.getPageSource(getResponseHandler(req, res)); }; -exports.waitForPageLoad = function (req, res) { - logCustomDeprecationWarning('mobile method', 'waitForPageLoad', - "waitForPageLoad will be removed in a future version of Appium."); - req.body = _.defaults(req.body, { timeout: 30 }); - var timeout = req.body.timeout; - - req.device.waitForPageLoad(timeout, getResponseHandler(req, res)); -}; - exports.getAlertText = function (req, res) { req.device.getAlertText(getResponseHandler(req, res)); }; @@ -1065,7 +1056,6 @@ var mobileCmdMap = { , 'background' : exports.background , 'keyevent' : exports.keyevent , 'find': exports.find -, 'waitForPageLoad': exports.waitForPageLoad , 'currentActivity': exports.getCurrentActivity , 'findElementNameContains': exports.findElementNameContains , 'installApp': exports.installApp