mirror of
https://github.com/appium/appium.git
synced 2026-10-24 01:28:55 +08:00
2d76923e72
BREAKING CHANGES Some plugin tests were calling code which called the `update()` method of `DeviceSettings`, but there's apparently no code that actually sets the `onUpdateSettings` listener anywhere (maybe drivers can opt-in to this behavior?), which was causing exceptions to get thrown. The E2E tests expected this code to reject, but the plugin tests expected it to _not_ reject, so I'm not sure what's right. - adds unit tests for `DeviceSettings` _Note: after further investigation, I think this was throwing simply due to `base-plugin` using an old version of `appium-fake-driver` which used an old `appium-base-driver`. @jlipps says this change is OK._