GithubStar/codegraph
1
0
Fork 0
mirror of https://github.com/colbymchenry/codegraph.git synced 2026-10-17 05:07:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(graph): don't lose dependents within the depth limit to edge order (#1974) (#2000)

Browse Source 
getImpactRadius, getCallers and getCallees are depth-limited DFS walks
with one visited set. A node first reached through a longer path at the
depth limit was marked visited without being expanded, so when a shorter
path reached it later it was skipped and its own dependents within the
limit were lost. Record the shallowest depth each node was expanded at
and expand it again when a nearer path reaches it. Results and edges are
still reported once, and output order is unchanged where nothing was
missing.


(cherry picked from commit ec56377b37)

Co-authored-by: danusha2345 <ewidusoc498@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Colby Mchenry
2026-09-27 12:25:43 +00:00
committed by GitHub
parent 98718cf6db
commit 52df4d24ef
2 changed files with 93 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
__tests__/graph.test.ts
+38
View File
@@ -612,4 +612,42 @@ describe('Traversal edge-completeness & limits (#1086–#1090)', () => {
// The regression: this direct dependency edge used to vanish.
expect(sub.edges.some((e) => e.source === 'Q' && e.target === 'P' && e.kind === 'calls')).toBe(true);
});
// The issue's graph: a→t, b→a, b→t, c→b. Edge order sends the walk to b
// through a first, at the depth limit, before the direct b→t edge (#1974).
const depthNodes = ['t', 'a', 'b', 'c'].map((n) => tNode(n));
const depthEdges: Edge[] = [
{ source: 'a', target: 't', kind: 'calls', line: 1 },
{ source: 'b', target: 'a', kind: 'calls', line: 2 },
{ source: 'b', target: 't', kind: 'calls', line: 3 },
{ source: 'c', target: 'b', kind: 'calls', line: 4 },
];
it('getImpactRadius finds a dependent within the depth even when a longer path reaches its parent first (#1974)', () => {
const sub = tGraph(depthNodes, depthEdges).getImpactRadius('t', 2);
// c → b → t is two hops. Pre-fix: b was first reached via a at depth 2 and
// never expanded again, so c was missing.
expect([...sub.nodes.keys()].sort()).toEqual(['a', 'b', 'c', 't']);
expect(sub.edges.some((e) => e.source === 'c' && e.target === 'b')).toBe(true);
// Re-expanding b does not record its incoming edges twice.
const keys = sub.edges.map((e) => `${e.source}>${e.target}:${e.line}`);
expect(new Set(keys).size).toBe(keys.length);
});
it('getCallers at depth N finds every caller within N hops, each once (#1974)', () => {
const callers = tGraph(depthNodes, depthEdges).getCallers('t', 2);
expect(callers.map((c) => c.node.id).sort()).toEqual(['a', 'b', 'c']);
});
it('getCallees at depth N finds every callee within N hops, each once (#1974)', () => {
// Mirror image: t→a, a→b, t→b, b→c. From t, b is 1 hop and c is 2.
const edges: Edge[] = [
{ source: 't', target: 'a', kind: 'calls', line: 1 },
{ source: 'a', target: 'b', kind: 'calls', line: 2 },
{ source: 't', target: 'b', kind: 'calls', line: 3 },
{ source: 'b', target: 'c', kind: 'calls', line: 4 },
];
const callees = tGraph(depthNodes, edges).getCallees('t', 2);
expect(callees.map((c) => c.node.id).sort()).toEqual(['a', 'b', 'c']);
});
});