fix(js,ts): a callee that names nothing records no reference, and a wrapped callee is the plain call (#2742)

mirror of https://github.com/colbymchenry/codegraph.git synced 2026-10-25 12:00:02 +08:00

A TS/JS call whose callee was no name and no member access (an IIFE, a
curried `connect(mapState)(View)`, `handlers[type]()`, `(0, fn)()`, a
tagged template on a call) stored the callee's whole source text as the
reference's name. Nothing can answer such a name, so each one parked as a
failed reference, an IIFE's entire body among them. extractCall now reads
the callee past the wrappers that keep it the same callee (parentheses,
`!`, `as` / `satisfies`, `await`, type arguments) and records nothing when
that is not a name or a dotted chain; the calls inside are visited on
their own. Mirrored in the kernel (tsjs/extractors.rs callee_name_of).

The reference of a wrapped callee sits at its name, where a plain call's
does, and the resolver's bare-call check reads `fn!(`, `(fn)(`,
`(fn as F)(` and `(fn satisfies F)(` as it reads `fn(`: SigNoz's
`(callback as FrameRequestCallback)(0)` and `(callback)(0)` name the
arrow's own parameter, and from the `(` they bound a generated interface's
`callback` property.

tree-sitter-typescript parses a prefix operator over a generic call as it
parses `await f<T>()` (#2586): `!settings.get<boolean>('X')` and
`void apiRequest<T>()` are calls whose callee is `!settings.get` /
`void apiRequest`. The callee peel that handled `await` now peels a prefix
operator too (peelTsPrefixedCallee; the kernel's peel_await_callee), so the
call is to `settings.get`, and `void apiRequest<T>().then()` encodes as
`apiRequest().then`, not `voidapiRequest().then`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This commit is contained in:

Colby Mchenry

2026-10-21 11:01:53 +00:00

committed by

GitHub

co-authored by

Claude Opus 5.5

parent aa01692620

commit ae0fc631e0

8 changed files with 211 additions and 19 deletions

									
										codegraph-kernel/src/textutil.rs
									
		+2
		
												View File
												
				@@ -22,6 +22,8 @@ re!(styled_callee, r"^styled\b");

				re!(pascal_case, r"^[A-Z]");

				// extractCall parenthesized-conversion normalization

				re!(paren_conversion, r"^\(\s*\*?\s*([A-Za-z_][\w.]*)\s*\)$");

				// tsJsCalleeName's dotted chain (`a.b.c`); ASCII classes, as JS's `\w` is

				re!(dotted_chain, r"^[A-Za-z_$][0-9A-Za-z_$]*(?:\.[A-Za-z_$][0-9A-Za-z_$]*)+$");

				// flushFnRefCandidates SIMPLE_NAME

				re!(simple_name, r"^[A-Za-z_$][A-Za-z0-9_$]*$");

				// flushFnRefCandidates QUALIFIED_IMPORT