2 Commits

Author	SHA1	Message	Date
Colby Mchenry	f40db4b9cc	fix(js,ts): index the functions in every named object literal, not only exported ones (#2300) (#2363) ... Issue #2300: a function written inside an object literal became a symbol only when the object was an `export const`. A plain `const api = {...}`, an object declared inside an IIFE or a function, and a namespace hung on the page (`window.WS = {...}`, `ns.mod = {...}`) produced no member nodes, and no node for `WS` either. Calls made inside those members were credited to the enclosing constant or lost, and calls into them resolved to nothing. Script-tag JavaScript, written almost entirely this way, was mostly missing from callers and impact. Cause: the TS/JS extractor, and the kernel's tsjs mirror of it, minted members only for exported object-of-functions; any other literal was walked as one opaque initializer, and an assignment to a member path was never a declaration. Resolution had no way to reach a member through `App.init()`, `window.App.init()` or `App.utils.pad()`. Fix (extraction, TS and kernel byte-identical): a named object literal owns its function members (method shorthand, `key: function`, `key: () =>`, generators; static keys only), whether it is declared at module scope, in a function body or IIFE, assigned to a path (`window.App = {...}`, `App.utils = {...}`) or assigned to a plain name at module level (`dw_page = {...}`). Members are `function` nodes qualified under the owner (`api::load`, `window.App::init`, `App.utils::pad`), the exported case included; a path owner is named by its last link and qualified by the path. Calls in a member are the member's; other values are walked where they were before. CommonJS exports, prototypes, `this.x = {...}`, call-argument literals, a name reassigned inside a function, and generated or minified files keep the old shape. Minified files are now also recognised by content, in both extractors, and the kernel's `.min.js` pattern matches the TS one. Fix (resolution): a member is reached through its object only: `App.init()`, `window.App.init()`, `App.utils.pad()`, a sibling's `this.render()`, a `const { init } = App` binding; never a bare `init()`. A same-file holder is chosen by lexical block (an IIFE's own `App` first); otherwise a global one (`window.App = {...}`, or a classic script's top-level `App`) when the caller neither imports nor binds the name. Arrow members keep the `this` of the method around the literal, in the `this.x` resolvers too. A dotted-path holder is never reached by its last name alone, and Svelte's `$store` rule now applies only in `.svelte` components, so the new local holders are not taken for `$n` in plain scripts. The lookups read each file once (destructuring patterns only when the raw text has a `} =`) and keep only the last 32 files' scans. Contributor PR #2310 (@danusha2345): adopted its model (owner-qualified members exported or not, path owners, IIFE/local owners, static keys, no bare-name reach, `<script setup>` contains edges, SFC languages, test scenarios), re-implemented on current main. Not taken: the EXTRACTION_VERSION bump (already 28), the extraction-time binding oracle with its ref/edge metadata and kernel ref patching (replaced by resolution-time lookups), naming the owner `window.WS`, rewriting `window.X.m()` ref names, flipping exported members' isExported, and unrelated bare-call changes. Verification: new js-object-literal-members suite (native + wasm, 18 tests); the issue's shapes fail on main and the guard test fails without the guards. kernel-tsjs-parity passes with CODEGRAPH_KERNEL_EXPECT=1 (object-literal owners LF/CRLF, minified bundles); kernel parity sweeps show 0 diffs on DokuWiki, vue-realworld, TodoMVC, excalidraw and this repo. Validation (kernel loaded, before = origin/main 023fc311): - DokuWiki: nodes +85, calls +105; 17 removed edges = 13 moved to the member, 4 re-resolved from a wrong LinkWizard::init to the right init. - TodoMVC: nodes +427, calls +148; 306 removed = 226 moved, 33 re-resolved (14 fixed `this.render()`/`this.save()`/`this.track()`, 19 wrong-to-wrong fallback guesses), 47 dropped wrong edges (43 to a helper local to jQuery Mobile's scrollstart setup). - excalidraw: nodes +86, calls +75; 34 removed = 33 moved, 1 fuzzy 0.3 guess dropped. - vue-realworld: nodes +10, calls +11; 7 calls re-resolved from the ApiService constant to its members. New self-loops are real recursion, bar one lazily redefined method that calls itself as written. 81 sampled added edges, 80 correct (the other is main's own window.open guess, re-attributed). Whole-run index time, median of 3 interleaved: vue-realworld 1.2s -> 1.2s, DokuWiki 8.6s -> 9.1s, excalidraw 10.8s -> 10.7s, TodoMVC 16.9s -> 16.9s (within run-to-run noise). Co-authored-by: danusha2345 <ewidusoc498@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-05 22:45:43 +00:00
Colby McHenry	03d54e47a1	feat(kernel): R4 — Java port with Lombok synthesis, gate passed, default-on ... Java joins the native kernel (codegraph-kernel/src/java.rs), mirroring the wasm extractor's Java paths bug-for-bug: package namespaces, imports, javadoc, annotations→decorates, type_list inheritance, static-final constants, enum constants, anonymous classes (including the TS side's 0-based-line quirk on the extends ref), method_invocation calls with the this.field unwrap and the Foo.getInstance().bar() chain encoding (#645/#608), static-member value reads, method-reference fn-refs (#756), value-reference edges, and the full Lombok member synthesizer (#912: Getter/Setter/Data/Value/Builder/ToString/ EqualsAndHashCode/Slf4j-family with taken-member dedup). The shared docstring/textutil modules moved to crate level. Grammar: tree-sitter-java 0.23.5, with the wasm grammar vendored from the same tag (parser.c sha-matched) replacing tree-sitter-wasms' 2023-era build. Gate (plan §4c): extraction sweeps 100% — gson 262/262, retrofit 341/341, dubbo 4,048/4,048 — plus a Java torture fixture in npm test; full-init dump-diffs byte-identical on gson (49,766 rows), retrofit (62,735), and dubbo (441,266 rows); all R2/R3 repos re-verified; Linux container runs all 23 kernel tests green under CODEGRAPH_KERNEL_EXPECT=1. The gate caught a real cross-language bug: fn-ref dedupe and value-ref self-target checks must compare node ID STRINGS, not node-table rows — ids collide for same-(kind, name, line) nodes, which minified one-line bundles hit routinely (retrofit's website JS exposed it; latent in the TS/JS walker since R2, never released). Fixed in both walkers. Benchmark honesty: dubbo fresh-init on an 11-core Mac is ~flat (parse-loop wall 5,020→4,394ms; total ~11.3s both arms) because that wall is main-thread-bound (reads + store), not worker-CPU-bound — the §6 expectation assumed otherwise. Where worker CPU binds the kernel delivers: dubbo on a 2-CPU/6GB container drops 27.8-28.6s → 22.3-22.8s (~1.25×). The identified lever for the many-core headline is decoding kernel buffers directly into store rows (skipping per-node JS object materialization); the buffer contract already carries everything. DEFAULT_ROUTED now includes java. Full suite: 2,467 tests pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-16 23:25:29 -05:00