mirror of
https://github.com/colbymchenry/codegraph.git
synced 2026-10-17 05:07:37 +08:00
3f96f80fcb
tree-sitter-dart parses a generic call with arguments as two comparisons about as often as it parses it as a call, depending on the code around it: `ref.read<Repo>(p)` comes out as `relational_expression(relational_expression(ref.read < Repo) > (p))`. Generic constructors (`Provider<int>((ref) => 0)`), named arguments (which then parse as a `record_literal`) and calls after `await` or a prefix operator are hit too. Neither extractor recorded a call for that shape, only a member read of `ref.read` that linked nothing, so providers, repository reads and bloc lookups written with a type argument had no callers. Across felangel/bloc, rrousselGit/riverpod and flutter/samples there are 2,853 such calls, against 2,836 generic calls with arguments that parse as calls. - Both extractors (the TS walker and the native kernel) recover the call at its `<` when the type argument names a type and the code is laid out as a call: `<` against the callee and `(` against the `>`. A comparison such as `a < b` is left alone. The recovered call gets what a parsed one does: the call at the `<`, a reference to the type argument, and no member read of the callee or of a prefixed type argument. - A call chained on a recovered call keeps its bare name. The `BlocProvider.of().increment` encoding a parsed chain gets resolves through what `of` returns, which for a generic factory is its type parameter, so it would drop the edge the bare name finds. - When the grammar ends an arrow function in front of a generic call (`(ref) => ref.watch<int>(p)` as `((ref) => ref).watch<int>(p)`), the receiver is read from the end of the arrow's body, so the call is `ref.watch` rather than a bare `watch`. Validated with the kernel loaded: bloc +85, riverpod +1,580 and flutter/samples +54 edges, none lost; kernel/wasm parity has 0 diffs on all three repos. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
204 lines
9.1 KiB
TypeScript
204 lines
9.1 KiB
TypeScript
/**
|
|
* Kernel↔wasm Dart extraction parity (R7b batch 4 of the kernel migration —
|
|
* the final R7b language).
|
|
*
|
|
* Asserts the native walker (codegraph-kernel/src/dart.rs) produces the SAME
|
|
* ExtractionResult as the wasm TreeSitterExtractor — nodes, edges, and
|
|
* unresolved refs compared as canonicalized multisets — over the checked-in
|
|
* fixtures (torture.dart: the master inventory — imports incl. deferred
|
|
* invisibility, dartdoc in all three comment forms with the
|
|
* annotation-broken chain, stacked annotations in reverse order, the
|
|
* static_final_declaration constants hook, the full ctor set with the
|
|
* unnamed-ctor skip and named-ctor renaming, operator methods as
|
|
* `<anonymous>`, the extractBareCall matrix incl. cascade invisibility and
|
|
* `?.`-as-`.`, the `ConfigT.load()` calls+references double emission,
|
|
* extends/with/implements ref kinds, enum `with` silence, anonymous
|
|
* extensions named after the ON type, value-ref targets with the sibling
|
|
* body pull; TortureDoubleWalk.dart: THE SIBLING-BODY DOUBLE-WALK — the
|
|
* duplicate local-function nodes with the same id under different parents
|
|
* and the exact duplicated-ref interleave; TortureFnrefDart.dart: fn-ref
|
|
* capture channels incl. named-argument non-capture and the file/class
|
|
* twins; TortureMini/TortureSigs/TortureCtors/TortureVrefDart: signatures
|
|
* verbatim, prefixed-return-type prefix bug, a const factory as a method,
|
|
* value-ref matrix with `$X` vs `${X}` asymmetry; TortureReadsTypes.dart:
|
|
* getter-read refs and the type positions outside signatures — #2338/#2327;
|
|
* TortureInitializers.dart: initializers walked as the code their constant,
|
|
* class or file runs, every member-body kind, and a local declaration's
|
|
* second variable left to its function; TortureConstCtors.dart: `const`
|
|
* constructors and redirecting factories as methods with the unnamed ones
|
|
* skipped, every redirect-target form, and constructors called with type
|
|
* arguments, as statements and as expressions; TortureGenericCalls.dart:
|
|
* generic calls parsed as two comparisons, recovered as calls) and their CRLF
|
|
* variants
|
|
* (derived in-memory — #1329), plus defer and generated-file pins.
|
|
*
|
|
* The full-repo sweeps live in scripts/kernel-parity.mjs (shelf/bloc/flutter
|
|
* with --max-deferral 0.3); this suite keeps the invariant alive in
|
|
* `npm test`. Skips when no kernel binary is staged; CODEGRAPH_KERNEL_EXPECT=1
|
|
* turns that into a failure.
|
|
*/
|
|
|
|
import { describe, it, expect, beforeAll, beforeEach, afterEach } from 'vitest';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import { extractFromSource } from '../src/extraction';
|
|
import { initGrammars, loadGrammarsForLanguages } from '../src/extraction/grammars';
|
|
import { tryKernelExtract, resetKernelForTests } from '../src/extraction/kernel';
|
|
import type { ExtractionResult } from '../src/types';
|
|
|
|
const KERNEL_PATH = path.join(
|
|
__dirname,
|
|
'..',
|
|
'codegraph-kernel',
|
|
'prebuilds',
|
|
`${process.platform}-${process.arch}`,
|
|
'codegraph-kernel.node'
|
|
);
|
|
const kernelBuilt = fs.existsSync(KERNEL_PATH);
|
|
|
|
const FIXTURE_DIR = path.join(__dirname, 'fixtures', 'kernel-parity');
|
|
|
|
function canon(result: ExtractionResult): { nodes: string[]; edges: string[]; refs: string[] } {
|
|
return {
|
|
nodes: result.nodes
|
|
.map(({ updatedAt: _u, ...n }) => JSON.stringify(n, Object.keys(n).sort()))
|
|
.sort(),
|
|
edges: result.edges.map((e) => JSON.stringify(e, Object.keys(e).sort())).sort(),
|
|
refs: result.unresolvedReferences
|
|
.map((r) => JSON.stringify(r, Object.keys(r).sort()))
|
|
.sort(),
|
|
};
|
|
}
|
|
|
|
const ENV_KEYS = ['CODEGRAPH_KERNEL', 'CODEGRAPH_KERNEL_LANGS'] as const;
|
|
let savedEnv: Record<string, string | undefined>;
|
|
|
|
describe.skipIf(!kernelBuilt)('kernel Dart extraction parity', () => {
|
|
beforeAll(async () => {
|
|
await initGrammars();
|
|
await loadGrammarsForLanguages(['dart']);
|
|
});
|
|
|
|
beforeEach(() => {
|
|
savedEnv = Object.fromEntries(ENV_KEYS.map((k) => [k, process.env[k]]));
|
|
resetKernelForTests();
|
|
});
|
|
|
|
afterEach(() => {
|
|
for (const k of ENV_KEYS) {
|
|
if (savedEnv[k] === undefined) delete process.env[k];
|
|
else process.env[k] = savedEnv[k];
|
|
}
|
|
resetKernelForTests();
|
|
});
|
|
|
|
function assertParity(filePath: string, source: string, minNodes = 2): ExtractionResult {
|
|
process.env.CODEGRAPH_KERNEL_LANGS = 'all';
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
const viaKernel = tryKernelExtract(filePath, source, 'dart');
|
|
expect(viaKernel, `kernel extraction failed for ${filePath}`).not.toBeNull();
|
|
|
|
process.env.CODEGRAPH_KERNEL = '0';
|
|
const viaWasm = extractFromSource(filePath, source, 'dart');
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
|
|
const k = canon(viaKernel!);
|
|
const w = canon(viaWasm);
|
|
expect(k.nodes, `${filePath}: nodes`).toEqual(w.nodes);
|
|
expect(k.edges, `${filePath}: edges`).toEqual(w.edges);
|
|
expect(k.refs, `${filePath}: refs`).toEqual(w.refs);
|
|
expect(viaWasm.nodes.length).toBeGreaterThanOrEqual(minNodes);
|
|
return viaKernel!;
|
|
}
|
|
|
|
const FIXTURES = [
|
|
['torture.dart', 30],
|
|
['TortureDoubleWalk.dart', 5],
|
|
['TortureFnrefDart.dart', 3],
|
|
['TortureMini.dart', 5],
|
|
['TortureSigs.dart', 4],
|
|
['TortureCtors.dart', 3],
|
|
['TortureVrefDart.dart', 4],
|
|
// Getter reads (#2338) and type positions outside signatures (#2327):
|
|
// extension `on` types, field / enum-field / top-level types, constant and
|
|
// field initializers, body types, and the read shapes that are not reads.
|
|
['TortureReadsTypes.dart', 20],
|
|
// Initializers (top-level, static and instance) walked as code: calls,
|
|
// instantiations, reads, closures with block bodies and local functions,
|
|
// and function values captured once, for the declaration.
|
|
['TortureInitializers.dart', 30],
|
|
// `const` constructors and redirecting factories as methods (the unnamed
|
|
// ones skipped), every redirect-target form, and constructors called
|
|
// with type arguments in statements and expressions.
|
|
['TortureConstCtors.dart', 20],
|
|
// Generic calls the grammar parses as two comparisons (`ref.read<Repo>(p)`
|
|
// as `(ref.read < Repo) > (p)`): every callee, type-argument and argument
|
|
// shape, in bodies and initializers, and the comparisons that look alike.
|
|
['TortureGenericCalls.dart', 10],
|
|
] as const;
|
|
|
|
for (const [file, minNodes] of FIXTURES) {
|
|
it(`${file}: parity`, () => {
|
|
const src = fs.readFileSync(path.join(FIXTURE_DIR, file), 'utf8');
|
|
assertParity(`fixtures/${file}`, src, minNodes);
|
|
});
|
|
|
|
it(`${file}: CRLF parity`, () => {
|
|
const src = fs.readFileSync(path.join(FIXTURE_DIR, file), 'utf8');
|
|
const crlf = src.replace(/(?<!\r)\n/g, '\r\n');
|
|
assertParity(`fixtures/${file} (crlf)`, crlf, minNodes);
|
|
});
|
|
}
|
|
|
|
it('double-walk pins: duplicate local-fn nodes share an id; refs interleave', () => {
|
|
const src = fs.readFileSync(path.join(FIXTURE_DIR, 'TortureDoubleWalk.dart'), 'utf8');
|
|
const result = assertParity('fixtures/TortureDoubleWalk.dart', src, 5);
|
|
// Local functions are minted TWICE — same (kind,name,line) → the SAME id
|
|
// — once under the enclosing function, once under the file/class (the
|
|
// sibling-body revisit). A dedupe here would silently diverge.
|
|
const byId = new Map<string, number>();
|
|
for (const n of result.nodes) byId.set(n.id, (byId.get(n.id) ?? 0) + 1);
|
|
const dupes = [...byId.values()].filter((c) => c > 1);
|
|
expect(dupes.length).toBeGreaterThan(0);
|
|
});
|
|
|
|
it('generated files extract but skip fn-ref and value-ref flushes', () => {
|
|
const src = fs.readFileSync(path.join(FIXTURE_DIR, 'TortureVrefDart.dart'), 'utf8');
|
|
process.env.CODEGRAPH_KERNEL_LANGS = 'all';
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
const viaKernel = tryKernelExtract('lib/model.g.dart', src, 'dart');
|
|
expect(viaKernel).not.toBeNull();
|
|
process.env.CODEGRAPH_KERNEL = '0';
|
|
const viaWasm = extractFromSource('lib/model.g.dart', src, 'dart');
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
const k = canon(viaKernel!);
|
|
const w = canon(viaWasm);
|
|
expect(k.nodes).toEqual(w.nodes);
|
|
expect(k.edges).toEqual(w.edges);
|
|
expect(k.refs).toEqual(w.refs);
|
|
// The skips: no function_ref refs, no valueRef edges.
|
|
expect(viaKernel!.unresolvedReferences.some((r) => r.referenceKind === 'function_ref')).toBe(
|
|
false
|
|
);
|
|
expect(viaKernel!.edges.some((e) => e.metadata?.valueRef === true)).toBe(false);
|
|
});
|
|
|
|
it('empty object patterns defer (the dominant dart-3 error class)', () => {
|
|
const broken = 'int f(Object x) => switch (x) { Init() => 1, _ => 0 };\n';
|
|
process.env.CODEGRAPH_KERNEL_LANGS = 'all';
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
expect(tryKernelExtract('lib/pat.dart', broken, 'dart')).toBeNull();
|
|
process.env.CODEGRAPH_KERNEL = '0';
|
|
const viaWasm = extractFromSource('lib/pat.dart', broken, 'dart');
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
expect(viaWasm.nodes.some((n) => n.kind === 'file')).toBe(true);
|
|
});
|
|
|
|
it('unnamed `library;` defers', () => {
|
|
const broken = '/// Doc.\nlibrary;\n\nvoid f() {}\n';
|
|
process.env.CODEGRAPH_KERNEL_LANGS = 'all';
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
expect(tryKernelExtract('lib/lib.dart', broken, 'dart')).toBeNull();
|
|
});
|
|
});
|