mirror of
https://github.com/colbymchenry/codegraph.git
synced 2026-10-25 03:49:59 +08:00
A Ruby class method (`def self.build`, `def Widget.build`, or a def inside
`class << self`) was indexed exactly like an instance method: is_static 0,
under the same qualified name as an instance method of that name
(Widget::build twice). So every call took whichever of the two the class
declared first. Widget.build could reach `def build`, and widget.build on an
instance could reach `def self.build`. In the repro for issue 2503,
`card = Billing::ChargeCard.new(...); card.call` linked to `def self.call`
rather than `def call`.
Fix:
- Extraction, both engines: the Ruby isStatic hook (isRubyClassMethod in
languages/ruby.ts, is_class_method in codegraph-kernel/src/ruby.rs) marks a
singleton_method, or a method whose parent past one body_statement is a
singleton_class, as static. Every other def is marked not static, the same
way on both, so the graph only changes for class methods.
- Resolution, Ruby only, where the call says which kind it is:
rubyMethodsOfKindFirst orders a call's candidates with the wanted kind
first. A call on a constant (Strategy 1, its inherited walk, and the
namespaced path in ruby-constant-paths.ts) wants the class method. A
receiver typed by `x = Widget.new` (resolveMethodOnType) wants the
instance method. A bare call splits only a real pair, one qualified name
among its candidates as both kinds, keeping the caller's kind: a block
may run on another object, so nothing else moves. A receiver known only
by its name (Strategies 2 and 3) says nothing of its kind and is left as
it was: rubocop's `cop.cop_name` runs over cop classes. With only one
kind present, every path picks what it did before.
Validation:
- New __tests__/ruby-singleton-methods.test.ts (6 cases, each on the
kernel and on wasm) and a parity case in kernel-ruby-parity.test.ts. On
main 9 of the 18 tests in the two files fail, every one that checks the
new behaviour; the guards and the old parity cases pass. All pass with
the fix.
- A/B against main f7820b58 (kernel path): nodes are unchanged except
is_static going 0 to 1 on the class methods, 167 on sinatra, 358 on
rubocop and 266 on mastodon's Ruby tree. Edges: none added or removed.
20 changed their target or confidence: sinatra 10, rubocop 0, mastodon
10. 19 are right: 13 moved from the wrong twin to the right one, such as
InlineRenderer.render to def self.render and sinatra's instance methods'
force_encoding to def force_encoding, and 6 kept their target with
higher confidence. One kept a target wrong in both arms: a call inside
sinatra's define_method block. Controls express and flask are
byte-identical.
- The A/B narrowed two rules. Preferring instance methods for a receiver
known only by its name moved rubocop's 19 right cop.cop_name edges, and
dropping other-kind methods from any bare call moved block-DSL calls on
sinatra. Both are gone: only a real pair is split.
- kernel-parity.mjs --lang ruby is the same on both arms: sinatra 147/147,
rubocop 1799/1801 (2 deferred), mastodon 3333/3333, 0 diffs. The fix
arm's kernel and wasm graphs are byte-identical on sinatra and rubocop.
- Index time, median of 3 interleaved runs: sinatra -3.7%, rubocop +0.5%,
mastodon +0.7%, controls express -2.7% and flask +1.0%.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
221 lines
8.8 KiB
TypeScript
221 lines
8.8 KiB
TypeScript
/**
|
|
* Kernel↔wasm Ruby extraction parity (R7b of the kernel migration).
|
|
*
|
|
* Asserts the native walker (codegraph-kernel/src/ruby.rs) produces the SAME
|
|
* ExtractionResult as the wasm TreeSitterExtractor — nodes, edges, and
|
|
* unresolved refs compared as canonicalized multisets — over the checked-in
|
|
* torture fixture (torture.rb: the importTypes:['call'] funnel and its
|
|
* class-body DSL blindness, mixin implements refs WITH filePath (the v2
|
|
* ref-flag wire path), module nesting + the hook multiply-capture, the
|
|
* sibling-scan visibility trio, require/require_relative path refs incl. the
|
|
* Kernel.require and interpolated-path quirks, the ruby call branch
|
|
* (`.new` instantiates, constant-receiver references, `&.` joins, raw chain
|
|
* text), bare-call statements (do…end vs brace-block blindness), heredocs,
|
|
* `=begin` docstring marker survival, value-ref targets + shadow prune,
|
|
* `__END__` trailer) and its CRLF variant (derived in-memory — #1329).
|
|
*
|
|
* The full-repo sweep lives in scripts/kernel-parity.mjs (sinatra/jekyll/
|
|
* rails for the §5 gate); this suite keeps the invariant alive in `npm test`.
|
|
* Skips when no kernel binary is staged; CODEGRAPH_KERNEL_EXPECT=1 turns that
|
|
* into a failure (kernel-scaffold.test.ts).
|
|
*/
|
|
|
|
import { describe, it, expect, beforeAll, beforeEach, afterEach } from 'vitest';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import { extractFromSource } from '../src/extraction';
|
|
import { initGrammars, loadGrammarsForLanguages } from '../src/extraction/grammars';
|
|
import { tryKernelExtract, resetKernelForTests } from '../src/extraction/kernel';
|
|
import type { ExtractionResult } from '../src/types';
|
|
|
|
const KERNEL_PATH = path.join(
|
|
__dirname,
|
|
'..',
|
|
'codegraph-kernel',
|
|
'prebuilds',
|
|
`${process.platform}-${process.arch}`,
|
|
'codegraph-kernel.node'
|
|
);
|
|
const kernelBuilt = fs.existsSync(KERNEL_PATH);
|
|
|
|
const FIXTURE_DIR = path.join(__dirname, 'fixtures', 'kernel-parity');
|
|
|
|
function canon(result: ExtractionResult): { nodes: string[]; edges: string[]; refs: string[] } {
|
|
return {
|
|
nodes: result.nodes
|
|
.map(({ updatedAt: _u, ...n }) => JSON.stringify(n, Object.keys(n).sort()))
|
|
.sort(),
|
|
edges: result.edges.map((e) => JSON.stringify(e, Object.keys(e).sort())).sort(),
|
|
refs: result.unresolvedReferences
|
|
.map((r) => JSON.stringify(r, Object.keys(r).sort()))
|
|
.sort(),
|
|
};
|
|
}
|
|
|
|
const ENV_KEYS = ['CODEGRAPH_KERNEL', 'CODEGRAPH_KERNEL_LANGS'] as const;
|
|
let savedEnv: Record<string, string | undefined>;
|
|
|
|
describe.skipIf(!kernelBuilt)('kernel Ruby extraction parity', () => {
|
|
beforeAll(async () => {
|
|
await initGrammars();
|
|
await loadGrammarsForLanguages(['ruby']);
|
|
});
|
|
|
|
beforeEach(() => {
|
|
savedEnv = Object.fromEntries(ENV_KEYS.map((k) => [k, process.env[k]]));
|
|
resetKernelForTests();
|
|
});
|
|
|
|
afterEach(() => {
|
|
for (const k of ENV_KEYS) {
|
|
if (savedEnv[k] === undefined) delete process.env[k];
|
|
else process.env[k] = savedEnv[k];
|
|
}
|
|
resetKernelForTests();
|
|
});
|
|
|
|
function assertParity(filePath: string, source: string, minNodes = 3): void {
|
|
process.env.CODEGRAPH_KERNEL_LANGS = 'all';
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
const viaKernel = tryKernelExtract(filePath, source, 'ruby');
|
|
expect(viaKernel, `kernel extraction failed for ${filePath}`).not.toBeNull();
|
|
|
|
process.env.CODEGRAPH_KERNEL = '0';
|
|
const viaWasm = extractFromSource(filePath, source, 'ruby');
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
|
|
const k = canon(viaKernel!);
|
|
const w = canon(viaWasm);
|
|
expect(k.nodes, `${filePath}: nodes`).toEqual(w.nodes);
|
|
expect(k.edges, `${filePath}: edges`).toEqual(w.edges);
|
|
expect(k.refs, `${filePath}: refs`).toEqual(w.refs);
|
|
expect(viaWasm.nodes.length).toBeGreaterThanOrEqual(minNodes);
|
|
}
|
|
|
|
it('torture fixture: modules/mixins, visibility scan, requires, call zoo, value refs', () => {
|
|
const file = path.join(FIXTURE_DIR, 'torture.rb');
|
|
assertParity('fixtures/torture.rb', fs.readFileSync(file, 'utf8'), 30);
|
|
});
|
|
|
|
// CRLF variant — the shape every Windows autocrlf checkout has. Derived in
|
|
// memory so no platform or editor can silently normalize it away; pins the
|
|
// JS-multiline-^ docstring semantics for `#` runs and `=begin` bodies
|
|
// (#1329), plus heredoc/`%`-literal CRLF parsing.
|
|
it('torture fixture CRLF parity', () => {
|
|
const file = path.join(FIXTURE_DIR, 'torture.rb');
|
|
const crlf = fs.readFileSync(file, 'utf8').replace(/(?<!\r)\n/g, '\r\n');
|
|
assertParity('fixtures/torture.rb (crlf)', crlf, 30);
|
|
});
|
|
|
|
// A receiver written with its namespace (`Billing::ChargeCard.call`, `::Foo.call`)
|
|
// is a constant read, as a bare `ChargeCard.call`'s is (#2503): both backends
|
|
// emit the same `references` ref for it, under the receiver as written, at
|
|
// the receiver. A path through a value (`obj::Thing`, `self.class::LIMIT`)
|
|
// names no constant the index can know, and `.new` stays an instantiation.
|
|
it('namespaced constant receivers', () => {
|
|
const src = [
|
|
'class Callers',
|
|
' def a',
|
|
' Billing::ChargeCard.call(amount: 1)',
|
|
' ::Billing::ChargeCard.call',
|
|
' ::Foo.call',
|
|
' Users::Create&.call',
|
|
' A::B::C.run!',
|
|
' Config::DEFAULTS.fetch(:x)',
|
|
' Foo::Bar::baz',
|
|
' obj::Thing.go',
|
|
' self.class::LIMIT.times { }',
|
|
' Billing::ChargeCard.new(amount: 3)',
|
|
' end',
|
|
'end',
|
|
'',
|
|
].join('\n');
|
|
assertParity('src/callers.rb', src);
|
|
process.env.CODEGRAPH_KERNEL = '0';
|
|
const refs = extractFromSource('src/callers.rb', src, 'ruby').unresolvedReferences
|
|
.filter((r) => r.referenceKind === 'references' || r.referenceKind === 'instantiates')
|
|
.map((r) => `${r.referenceKind} ${r.referenceName} ${r.line}:${r.column}`);
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
expect(refs.sort()).toEqual([
|
|
'instantiates ChargeCard 12:4',
|
|
'references ::Billing::ChargeCard 4:4',
|
|
'references ::Foo 5:4',
|
|
'references A::B::C 7:4',
|
|
'references Billing::ChargeCard 3:4',
|
|
'references Config::DEFAULTS 8:4',
|
|
'references Foo::Bar 9:4',
|
|
'references Users::Create 6:4',
|
|
]);
|
|
});
|
|
|
|
// A class method (`def self.x`, `def Widget.x`, a `def` in `class << self`)
|
|
// is static on both backends, every other def is not: they share a
|
|
// qualified name with any instance method of the name.
|
|
it('class methods are static', () => {
|
|
const src = [
|
|
'class Widget',
|
|
' def build = self',
|
|
' def self.build(opts) = new',
|
|
' def Widget.named = 1',
|
|
' class << self',
|
|
' def make = new',
|
|
' def other',
|
|
' def nested = 2',
|
|
' end',
|
|
' end',
|
|
' def run',
|
|
' def inner = 3',
|
|
' end',
|
|
'end',
|
|
'def self.top = 4',
|
|
'def plain = 5',
|
|
'',
|
|
].join('\n');
|
|
assertParity('src/widget.rb', src);
|
|
process.env.CODEGRAPH_KERNEL_LANGS = 'all';
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
const viaKernel = tryKernelExtract('src/widget.rb', src, 'ruby');
|
|
const statics = viaKernel!.nodes
|
|
.filter((n) => n.kind === 'method' || n.kind === 'function')
|
|
.map((n) => `${n.kind} ${n.name}:${n.startLine} ${n.isStatic === true ? 'static' : n.isStatic === false ? 'instance' : 'unset'}`)
|
|
.sort();
|
|
expect(statics).toEqual([
|
|
'function inner:12 instance',
|
|
'function nested:8 instance',
|
|
'function plain:16 instance',
|
|
'function top:15 static',
|
|
'method build:2 instance',
|
|
'method build:3 static',
|
|
'method make:6 static',
|
|
'method named:4 static',
|
|
'method other:7 static',
|
|
'method run:11 instance',
|
|
]);
|
|
});
|
|
|
|
it('mixin implements refs carry filePath through the v2 ref-flag wire path', () => {
|
|
const src = 'class Widget\n include Comparable\nend\n';
|
|
process.env.CODEGRAPH_KERNEL_LANGS = 'all';
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
const viaKernel = tryKernelExtract('src/widget.rb', src, 'ruby');
|
|
expect(viaKernel).not.toBeNull();
|
|
const impl = viaKernel!.unresolvedReferences.find((r) => r.referenceKind === 'implements');
|
|
expect(impl?.referenceName).toBe('Comparable');
|
|
expect(impl?.filePath).toBe('src/widget.rb');
|
|
// Ordinary refs stay un-denormalized.
|
|
const other = viaKernel!.unresolvedReferences.find((r) => r.referenceKind !== 'implements');
|
|
if (other) expect(other.filePath).toBeUndefined();
|
|
});
|
|
|
|
it('files with parse errors defer to the wasm extractor (recovery is encoding-dependent)', () => {
|
|
const broken = 'def broken(\n x = [1,\nend\n';
|
|
process.env.CODEGRAPH_KERNEL_LANGS = 'all';
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
expect(tryKernelExtract('src/broken.rb', broken, 'ruby')).toBeNull();
|
|
process.env.CODEGRAPH_KERNEL = '0';
|
|
const viaWasm = extractFromSource('src/broken.rb', broken, 'ruby');
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
expect(viaWasm.nodes.some((n) => n.kind === 'file')).toBe(true);
|
|
});
|
|
});
|