mirror of
https://github.com/colbymchenry/codegraph.git
synced 2026-10-18 13:53:01 +08:00
9d0cd3a7d1
* chore: ignore .kommandr/ directory * fix(sync): resolve cross-file refs when an edit adds or removes the satisfying symbol (#1240) Incremental sync scoped reference resolution to the changed files' own refs, and a completed pass deleted every ref it failed to resolve — so a symbol change in one file could never repair references in UNCHANGED files, in either direction, until a full re-index: - New-export case: a.ts imports/calls `greet` before b.ts defines it. The failed refs were deleted at index time; when b.ts later gained `greet`, nothing revisited a.ts — the calls/imports edges stayed missing while status reported a clean index. - Removal case: when a re-index (or file deletion) dropped a symbol, the incoming edges cascade-deleted and the callers — whose resolved refs had been consumed — never got a chance to rebind to an alternative definition or reconnect when the symbol returned. Fix, sharing one lifecycle: - Schema v8: unresolved_refs gains status ('pending'/'failed') and name_tail (last dotted segment, so `h.greet` is findable by `greet`). Both resolver persist paths now park unresolvable refs as failed instead of deleting them. All pending-work readers (batched drain, non-progress guard, #1187 orphan sweep, status pendingRefs) filter to pending, preserving their invariants and keeping status honest. - Sync retry: after scoped resolution, failed refs whose name tail matches a symbol name now present in the changed files are re-resolved through a per-ref-yielding path (watchdog-safe, #1091 class). Names matching >500 failed refs are skipped as external/builtin noise (#999 rationale). - Removal side: createEdges stamps each resolution edge with its originating reference (metadata.refName, + refKind when kind promotion rewrote it). When the #899 restore misses a target or sync deletes a file, the dropped edge is resurrected as exactly that ref — re-resolved in the same sync (rebinding to an alternative definition) or parked failed until the symbol reappears. Edges without the stamp (pre-upgrade, synthesized) still drop silently: reconstructing from the target's plain name would strip receiver context and risk a rebind a full re-index would never make. - Pure-removal syncs clear resolver caches so a long-lived daemon can't resolve resurrected refs against the pre-removal graph. Validated: issue repro now yields a graph byte-identical to a full re-index; move/remove-readd/file-deletion scenarios all rebind or heal; baseline-vs-new A/B on express and gin shows identical node/edge counts and no timing regression (DB grows ~25% from the parked ref rows — pure cache, reset by any full re-index). 8 regression tests added. Fixes #1240 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
195 lines
8.3 KiB
SQL
195 lines
8.3 KiB
SQL
-- CodeGraph SQLite Schema
|
|
-- Version 1
|
|
|
|
-- Schema version tracking
|
|
CREATE TABLE IF NOT EXISTS schema_versions (
|
|
version INTEGER PRIMARY KEY,
|
|
applied_at INTEGER NOT NULL,
|
|
description TEXT
|
|
);
|
|
|
|
-- Insert initial version
|
|
INSERT INTO schema_versions (version, applied_at, description)
|
|
VALUES (1, strftime('%s', 'now') * 1000, 'Initial schema');
|
|
|
|
-- =============================================================================
|
|
-- Core Tables
|
|
-- =============================================================================
|
|
|
|
-- Nodes: Code symbols (functions, classes, variables, etc.)
|
|
CREATE TABLE IF NOT EXISTS nodes (
|
|
id TEXT PRIMARY KEY,
|
|
kind TEXT NOT NULL,
|
|
name TEXT NOT NULL,
|
|
qualified_name TEXT NOT NULL,
|
|
file_path TEXT NOT NULL,
|
|
language TEXT NOT NULL,
|
|
start_line INTEGER NOT NULL,
|
|
end_line INTEGER NOT NULL,
|
|
start_column INTEGER NOT NULL,
|
|
end_column INTEGER NOT NULL,
|
|
docstring TEXT,
|
|
signature TEXT,
|
|
visibility TEXT,
|
|
is_exported INTEGER DEFAULT 0,
|
|
is_async INTEGER DEFAULT 0,
|
|
is_static INTEGER DEFAULT 0,
|
|
is_abstract INTEGER DEFAULT 0,
|
|
decorators TEXT, -- JSON array
|
|
type_parameters TEXT, -- JSON array
|
|
return_type TEXT, -- normalized return/result type name (e.g. C++ method return, for receiver-type inference)
|
|
updated_at INTEGER NOT NULL
|
|
);
|
|
|
|
-- Edges: Relationships between nodes
|
|
CREATE TABLE IF NOT EXISTS edges (
|
|
id INTEGER PRIMARY KEY AUTOINCREMENT,
|
|
source TEXT NOT NULL,
|
|
target TEXT NOT NULL,
|
|
kind TEXT NOT NULL,
|
|
metadata TEXT, -- JSON object
|
|
line INTEGER,
|
|
col INTEGER,
|
|
provenance TEXT DEFAULT NULL,
|
|
FOREIGN KEY (source) REFERENCES nodes(id) ON DELETE CASCADE,
|
|
FOREIGN KEY (target) REFERENCES nodes(id) ON DELETE CASCADE
|
|
);
|
|
|
|
-- Files: Tracked source files
|
|
CREATE TABLE IF NOT EXISTS files (
|
|
path TEXT PRIMARY KEY,
|
|
content_hash TEXT NOT NULL,
|
|
language TEXT NOT NULL,
|
|
size INTEGER NOT NULL,
|
|
modified_at INTEGER NOT NULL,
|
|
indexed_at INTEGER NOT NULL,
|
|
node_count INTEGER DEFAULT 0,
|
|
errors TEXT -- JSON array
|
|
);
|
|
|
|
-- Unresolved References: References that need resolution after full indexing.
|
|
-- status lifecycle: rows are inserted 'pending' by extraction; a completed
|
|
-- resolution pass either deletes a row (resolved) or marks it 'failed'
|
|
-- (attempted, no match — kept so a later sync can retry it when a changed
|
|
-- file introduces a symbol that could satisfy it, #1240). name_tail is the
|
|
-- last segment of reference_name ('util.greet' → 'greet'), written when a
|
|
-- row is marked failed, so the retry lookup matches new node names against
|
|
-- dotted refs too. Rows follow their from_node via ON DELETE CASCADE, so
|
|
-- re-extracting or deleting a file clears its stale rows in any status.
|
|
CREATE TABLE IF NOT EXISTS unresolved_refs (
|
|
id INTEGER PRIMARY KEY AUTOINCREMENT,
|
|
from_node_id TEXT NOT NULL,
|
|
reference_name TEXT NOT NULL,
|
|
reference_kind TEXT NOT NULL,
|
|
line INTEGER NOT NULL,
|
|
col INTEGER NOT NULL,
|
|
candidates TEXT, -- JSON array
|
|
file_path TEXT NOT NULL DEFAULT '',
|
|
language TEXT NOT NULL DEFAULT 'unknown',
|
|
status TEXT NOT NULL DEFAULT 'pending',
|
|
name_tail TEXT NOT NULL DEFAULT '',
|
|
FOREIGN KEY (from_node_id) REFERENCES nodes(id) ON DELETE CASCADE
|
|
);
|
|
|
|
-- =============================================================================
|
|
-- Indexes for Query Performance
|
|
-- =============================================================================
|
|
|
|
-- Node indexes
|
|
CREATE INDEX IF NOT EXISTS idx_nodes_kind ON nodes(kind);
|
|
CREATE INDEX IF NOT EXISTS idx_nodes_name ON nodes(name);
|
|
CREATE INDEX IF NOT EXISTS idx_nodes_qualified_name ON nodes(qualified_name);
|
|
CREATE INDEX IF NOT EXISTS idx_nodes_file_path ON nodes(file_path);
|
|
CREATE INDEX IF NOT EXISTS idx_nodes_language ON nodes(language);
|
|
CREATE INDEX IF NOT EXISTS idx_nodes_file_line ON nodes(file_path, start_line);
|
|
CREATE INDEX IF NOT EXISTS idx_nodes_lower_name ON nodes(lower(name));
|
|
|
|
-- Full-text search index on node names, docstrings, and signatures
|
|
CREATE VIRTUAL TABLE IF NOT EXISTS nodes_fts USING fts5(
|
|
id,
|
|
name,
|
|
qualified_name,
|
|
docstring,
|
|
signature,
|
|
content='nodes',
|
|
content_rowid='rowid'
|
|
);
|
|
|
|
-- Triggers to keep FTS index in sync
|
|
CREATE TRIGGER IF NOT EXISTS nodes_ai AFTER INSERT ON nodes BEGIN
|
|
INSERT INTO nodes_fts(rowid, id, name, qualified_name, docstring, signature)
|
|
VALUES (NEW.rowid, NEW.id, NEW.name, NEW.qualified_name, NEW.docstring, NEW.signature);
|
|
END;
|
|
|
|
CREATE TRIGGER IF NOT EXISTS nodes_ad AFTER DELETE ON nodes BEGIN
|
|
INSERT INTO nodes_fts(nodes_fts, rowid, id, name, qualified_name, docstring, signature)
|
|
VALUES ('delete', OLD.rowid, OLD.id, OLD.name, OLD.qualified_name, OLD.docstring, OLD.signature);
|
|
END;
|
|
|
|
CREATE TRIGGER IF NOT EXISTS nodes_au AFTER UPDATE ON nodes BEGIN
|
|
INSERT INTO nodes_fts(nodes_fts, rowid, id, name, qualified_name, docstring, signature)
|
|
VALUES ('delete', OLD.rowid, OLD.id, OLD.name, OLD.qualified_name, OLD.docstring, OLD.signature);
|
|
INSERT INTO nodes_fts(rowid, id, name, qualified_name, docstring, signature)
|
|
VALUES (NEW.rowid, NEW.id, NEW.name, NEW.qualified_name, NEW.docstring, NEW.signature);
|
|
END;
|
|
|
|
-- Prose-word → symbol-name lookup for the prompt hook's graph-derived gate.
|
|
-- One row per (segment, name): segment is a lowercased word of a symbol name
|
|
-- ("OrderStateMachine" → order, state, machine — see identifier-segments.ts),
|
|
-- which lets natural-language prompt words be verified against the graph in
|
|
-- any language whose technical nouns are Latin script. File nodes are
|
|
-- excluded — a file's basename duplicates the symbols inside it and skews the
|
|
-- singleton-vs-cluster rarity statistics. FTS can't serve this lookup (its
|
|
-- tokenizer keeps camelCase names as single tokens), so segments are
|
|
-- materialized on the node write path.
|
|
-- Deletions leave orphan rows ON PURPOSE: rows are PROPOSALS, always
|
|
-- re-verified against nodes before being surfaced (CodeGraph.getSegmentMatches),
|
|
-- and a full index clears the table at its start. Populated lazily on old
|
|
-- databases (empty until the next index/sync heals it).
|
|
CREATE TABLE IF NOT EXISTS name_segment_vocab (
|
|
segment TEXT NOT NULL,
|
|
name TEXT NOT NULL,
|
|
PRIMARY KEY (segment, name)
|
|
) WITHOUT ROWID;
|
|
|
|
-- Edge indexes.
|
|
-- idx_edges_source / idx_edges_target are intentionally omitted —
|
|
-- the (source, kind) and (target, kind) composites below cover the
|
|
-- corresponding source-only / target-only lookups via SQLite's
|
|
-- left-prefix scan, so the narrow indexes are dead weight on writes.
|
|
-- Migration v4 drops them on existing databases.
|
|
CREATE INDEX IF NOT EXISTS idx_edges_kind ON edges(kind);
|
|
CREATE INDEX IF NOT EXISTS idx_edges_source_kind ON edges(source, kind);
|
|
CREATE INDEX IF NOT EXISTS idx_edges_target_kind ON edges(target, kind);
|
|
|
|
-- Edge identity uniqueness. An edge IS uniquely (source, target, kind, line,
|
|
-- col); insertEdge uses `INSERT OR IGNORE`, but without something UNIQUE to
|
|
-- conflict on it behaved like a plain INSERT, so two passes emitting the same
|
|
-- edge produced byte-identical duplicate rows that inflated counts and flowed
|
|
-- into callers/impact (#1034). IFNULL folds the nullable line/col so
|
|
-- coordinate-less edges (synthesized / file-level) dedup too — SQLite treats
|
|
-- each NULL as distinct otherwise. Migration v6 dedups existing rows + adds
|
|
-- this on older databases.
|
|
CREATE UNIQUE INDEX IF NOT EXISTS idx_edges_identity
|
|
ON edges(source, target, kind, IFNULL(line, -1), IFNULL(col, -1));
|
|
|
|
-- File indexes
|
|
CREATE INDEX IF NOT EXISTS idx_files_language ON files(language);
|
|
CREATE INDEX IF NOT EXISTS idx_files_modified_at ON files(modified_at);
|
|
|
|
-- Unresolved refs indexes
|
|
CREATE INDEX IF NOT EXISTS idx_unresolved_from_node ON unresolved_refs(from_node_id);
|
|
CREATE INDEX IF NOT EXISTS idx_unresolved_name ON unresolved_refs(reference_name);
|
|
CREATE INDEX IF NOT EXISTS idx_unresolved_file_path ON unresolved_refs(file_path);
|
|
CREATE INDEX IF NOT EXISTS idx_unresolved_from_name ON unresolved_refs(from_node_id, reference_name);
|
|
CREATE INDEX IF NOT EXISTS idx_unresolved_status ON unresolved_refs(status);
|
|
CREATE INDEX IF NOT EXISTS idx_unresolved_failed_tail ON unresolved_refs(name_tail) WHERE status = 'failed';
|
|
CREATE INDEX IF NOT EXISTS idx_edges_provenance ON edges(provenance);
|
|
|
|
-- Project metadata for version/provenance tracking
|
|
CREATE TABLE IF NOT EXISTS project_metadata (
|
|
key TEXT PRIMARY KEY,
|
|
value TEXT NOT NULL,
|
|
updated_at INTEGER NOT NULL
|
|
);
|