Allow creating places and sources from more selectors (#1517)

Enable inline creation on the place selector of the New Event dialog
and view, the place selector of the event details and place reference
dialogs, and the source selector of the citation details dialog.

The Enclosed By selector of the New Place view allows it too, but not
when the New Place form is itself the create dialog of an object
selector, so that inline creation stays one dialog deep.

Part of #1183.

src/components/GrampsjsFormEditCitationDetails.js

@@ -31,6 +31,7 @@ class GrampsjsFormEditCitationDetails extends GrampsjsObjectForm {
       <grampsjs-form-select-object-list
         id="source"
         objectType="source"
+        allowNew
         .objectsInitial="${this.data.source_handle
           ? [
               {

src/components/GrampsjsFormEditEventDetails.js

@@ -41,6 +41,7 @@ class GrampsjsFormEditEventDetails extends GrampsjsObjectForm {
           fixedMenuPosition
           style="min-height: 300px;"
           objectType="place"
+          allowNew
           .appState="${this.appState}"
           id="place"
           label="${this._('Select')}"

src/components/GrampsjsFormPlaceRef.js

@@ -29,6 +29,7 @@ class GrampsjsFormPlaceRef extends GrampsjsObjectForm {
           notDeletable
           style="min-height: 300px;"
           objectType="place"
+          allowNew
           .objectsInitial="${this.data.ref
             ? [
                 {

src/mixins/GrampsjsNewEventMixin.js

@@ -47,6 +47,7 @@ export const GrampsjsNewEventMixin = superClass =>
           fixedMenuPosition
           id="place"
           objectType="place"
+          allowNew
           .appState="${this.appState}"
         ></grampsjs-form-select-object-list>
 

src/mixins/GrampsjsNewPlaceMixin.js

@@ -24,6 +24,9 @@ export const GrampsjsNewPlaceMixin = superClass =>
       super()
       this.data = {_class: 'Place'}
       this._latLongDialogOpen = false
+      // Off in the create dialog of an object selector, so that inline
+      // creation stays one dialog deep.
+      this.allowNewEnclosedBy = false
     }
 
     renderForm() {
@@ -58,6 +61,7 @@ export const GrampsjsNewPlaceMixin = superClass =>
           id="enclosed"
           multiple
           objectType="place"
+          ?allowNew="${this.allowNewEnclosedBy}"
           .appState="${this.appState}"
         ></grampsjs-form-select-object-list>
 

src/views/GrampsjsViewNewPlace.js

@@ -11,6 +11,7 @@ export class GrampsjsViewNewPlace extends GrampsjsNewPlaceMixin(
     this.postUrl = '/api/places/'
     this.itemPath = 'place'
     this.objClass = 'Place'
+    this.allowNewEnclosedBy = true
   }
 
   renderContent() {

test/unit/newPlace.test.js

@@ -0,0 +1,13 @@
+import {describe, it, expect} from 'vitest'
+import {GrampsjsFormNewPlace} from '../../src/components/GrampsjsFormNewPlace.js'
+import {GrampsjsViewNewPlace} from '../../src/views/GrampsjsViewNewPlace.js'
+
+describe('new place: creating the enclosing place', () => {
+  it('is offered in the New Place view', () => {
+    expect(new GrampsjsViewNewPlace().allowNewEnclosedBy).toBe(true)
+  })
+
+  it('is not offered in the create dialog of an object selector', () => {
+    expect(new GrampsjsFormNewPlace().allowNewEnclosedBy).toBe(false)
+  })
+})