From 57dc135db7930a331d22ef0a639c19f6857b6859 Mon Sep 17 00:00:00 2001 From: eeff <33566201+eeff@users.noreply.github.com> Date: Wed, 6 Sep 2023 15:57:00 +0800 Subject: [PATCH] test: add ft for template group name update --- ft/resource/api.resource | 5 +- ft/template.robot | 105 +++++++++++++++++++++++++++++++++++---- 2 files changed, 99 insertions(+), 11 deletions(-) diff --git a/ft/resource/api.resource b/ft/resource/api.resource index 1379dd38..446d0f55 100644 --- a/ft/resource/api.resource +++ b/ft/resource/api.resource @@ -258,8 +258,9 @@ Add Template Group [RETURN] ${res}[0] Put Template Group - [Arguments] ${tmpl} ${group} ${interval} - PUT /api/v2/template/group {"template": "${tmpl}", "group": "${group}", "interval": ${interval}} + [Arguments] ${tmpl} ${group} &{updates} + ${data} = Evaluate json.dumps({"template": "${tmpl}", "group": "${group}", **$updates}) json + PUT /api/v2/template/group ${data} ${res} = Object response body [RETURN] ${res}[0] diff --git a/ft/template.robot b/ft/template.robot index 5bc02fda..814642b4 100644 --- a/ft/template.robot +++ b/ft/template.robot @@ -496,7 +496,7 @@ Get groups from existent template having one group, it should success. Update group interval when template does not exist, it should fail. - ${res} = Put Template Group ${g_template} ${g_group1}[name] ${1000} + ${res} = Put Template Group ${g_template} ${g_group1}[name] interval=${1000} Check Response Status ${res} 404 Check Error Code ${res} ${NEU_ERR_TEMPLATE_NOT_FOUND} @@ -508,7 +508,7 @@ Update group using too long template name in request, it should fail. Check Response Status ${res} 200 Check Error Code ${res} ${NEU_ERR_SUCCESS} - ${res} = Put Template Group ${g_long_str} ${g_group1}[name] ${2000} + ${res} = Put Template Group ${g_long_str} ${g_group1}[name] interval=${2000} Check Response Status ${res} 400 Check Error Code ${res} ${NEU_ERR_TEMPLATE_NAME_TOO_LONG} @@ -520,7 +520,7 @@ Update group using too long group name in request, it should fail. Check Response Status ${res} 200 Check Error Code ${res} ${NEU_ERR_SUCCESS} - ${res} = Put Template Group ${g_template} ${g_long_str} ${2000} + ${res} = Put Template Group ${g_template} ${g_long_str} interval=${2000} Check Response Status ${res} 400 Check Error Code ${res} ${NEU_ERR_GROUP_NAME_TOO_LONG} @@ -532,7 +532,7 @@ Update group interval when group does not exist, it should fail. Check Response Status ${res} 200 Check Error Code ${res} ${NEU_ERR_SUCCESS} - ${res} = Put Template Group ${g_template} ${g_group1}[name] ${1000} + ${res} = Put Template Group ${g_template} ${g_group1}[name] interval=${1000} Check Response Status ${res} 404 Check Error Code ${res} ${NEU_ERR_GROUP_NOT_EXIST} @@ -544,7 +544,7 @@ Update group interval to invalid value, it should fail. Check Response Status ${res} 200 Check Error Code ${res} ${NEU_ERR_SUCCESS} - ${res} = Put Template Group ${g_template} ${g_group1}[name] ${10} + ${res} = Put Template Group ${g_template} ${g_group1}[name] interval=${10} Check Response Status ${res} 400 Check Error Code ${res} ${NEU_ERR_GROUP_PARAMETER_INVALID} @@ -556,7 +556,7 @@ Update group interval, it should success. Check Response Status ${res} 200 Check Error Code ${res} ${NEU_ERR_SUCCESS} - ${res} = Put Template Group ${g_template} ${g_group1}[name] ${1000} + ${res} = Put Template Group ${g_template} ${g_group1}[name] interval=${1000} Check Response Status ${res} 200 Check Error Code ${res} ${NEU_ERR_SUCCESS} @@ -568,6 +568,93 @@ Update group interval, it should success. [Teardown] Del Template ${g_template} +Update group with empty new name, it should fail. + ${res} = Add Template ${g_template} ${g_plugin} ${g_groups} + Check Response Status ${res} 200 + Check Error Code ${res} ${NEU_ERR_SUCCESS} + + ${res} = Put Template Group ${g_template} ${g_group1}[name] new_name=${EMPTY} + Check Response Status ${res} 400 + Check Error Code ${res} ${NEU_ERR_BODY_IS_WRONG} + + [Teardown] Del Template ${g_template} + + +Update group with too long new name, it should fail. + ${res} = Add Template ${g_template} ${g_plugin} ${g_groups} + Check Response Status ${res} 200 + Check Error Code ${res} ${NEU_ERR_SUCCESS} + + ${res} = Put Template Group ${g_template} ${g_group1}[name] new_name=${g_long_str} + Check Response Status ${res} 400 + Check Error Code ${res} ${NEU_ERR_GROUP_NAME_TOO_LONG} + + [Teardown] Del Template ${g_template} + + +Update group name to conflicting group name, it should fail. + ${res} = Add Template ${g_template} ${g_plugin} ${g_groups} + Check Response Status ${res} 200 + Check Error Code ${res} ${NEU_ERR_SUCCESS} + + ${res} = Add Template Group ${g_template} grp ${1000} + Check Response Status ${res} 200 + Check Error Code ${res} ${NEU_ERR_SUCCESS} + + + ${res} = Put Template Group ${g_template} ${g_group1}[name] new_name=grp + Check Response Status ${res} 409 + Check Error Code ${res} ${NEU_ERR_GROUP_EXIST} + + [Teardown] Del Template ${g_template} + + +Update group name, it should success. + ${res} = Add Template ${g_template} ${g_plugin} ${g_groups} + Check Response Status ${res} 200 + Check Error Code ${res} ${NEU_ERR_SUCCESS} + + ${res} = Put Template Group ${g_template} ${g_group1}[name] new_name=grp + Check Response Status ${res} 200 + Check Error Code ${res} ${NEU_ERR_SUCCESS} + + ${res} = Get Template Groups ${g_template} + Check Response Status ${res} 200 + Should Have Only One Group ${res}[groups] grp ${g_group1}[interval] + Group Tag Count Should Be ${res}[groups][0] 2 + + [Teardown] Del Template ${g_template} + + +Update group with at least name or interval, otherwise it should fail. + ${res} = Add Template ${g_template} ${g_plugin} ${g_groups} + Check Response Status ${res} 200 + Check Error Code ${res} ${NEU_ERR_SUCCESS} + + ${res} = Put Template Group ${g_template} ${g_group1}[name] + Check Response Status ${res} 400 + Check Error Code ${res} ${NEU_ERR_BODY_IS_WRONG} + + [Teardown] Del Template ${g_template} + + +Update group name and interval, it should success. + ${res} = Add Template ${g_template} ${g_plugin} ${g_groups} + Check Response Status ${res} 200 + Check Error Code ${res} ${NEU_ERR_SUCCESS} + + ${res} = Put Template Group ${g_template} ${g_group1}[name] new_name=grp interval=${1000} + Check Response Status ${res} 200 + Check Error Code ${res} ${NEU_ERR_SUCCESS} + + ${res} = Get Template Groups ${g_template} + Check Response Status ${res} 200 + Should Have Only One Group ${res}[groups] grp ${1000} + Group Tag Count Should Be ${res}[groups][0] 2 + + [Teardown] Del Template ${g_template} + + Delete group from nonexistent template, it should fail. ${res} = Del Template Group ${g_template} ${g_group1}[name] Check Response Status ${res} 404 @@ -642,7 +729,7 @@ Template groups should be persisted. Should Have Only One Group ${res}[groups] ${g_group1}[name] ${g_group1}[interval] Group Tag Count Should Be ${res}[groups][0] 0 - ${res} = Put Template Group ${g_template} ${g_group1}[name] ${1000} + ${res} = Put Template Group ${g_template} ${g_group1}[name] new_name=grp interval=${1000} Check Response Status ${res} 200 Check Error Code ${res} ${NEU_ERR_SUCCESS} @@ -650,10 +737,10 @@ Template groups should be persisted. ${res} = Get Template Groups ${g_template} Check Response Status ${res} 200 - Should Have Only One Group ${res}[groups] ${g_group1}[name] ${1000} + Should Have Only One Group ${res}[groups] grp ${1000} Group Tag Count Should Be ${res}[groups][0] 0 - ${res} = Del Template Group ${g_template} ${g_group1}[name] + ${res} = Del Template Group ${g_template} grp Check Response Status ${res} 200 Check Error Code ${res} ${NEU_ERR_SUCCESS}