From a89a1b2044b036d5c3c1b1fe5eea6bb85649f2ea Mon Sep 17 00:00:00 2001
From: "xiang.zhou" <xiang.zhou@emqx.io>
Date: Mon, 4 Dec 2023 08:59:16 +0800
Subject: [PATCH] fix:memory leak

---
 src/adapter/driver/driver.c | 19 +++++++++++++++++++
 tests/ft/neuron/process.py  |  5 +++++
 2 files changed, 24 insertions(+)

diff --git a/src/adapter/driver/driver.c b/src/adapter/driver/driver.c
index 2db0fef1..5131e011 100644
--- a/src/adapter/driver/driver.c
+++ b/src/adapter/driver/driver.c
@@ -244,6 +244,13 @@ static void update_im(neu_adapter_t *adapter, const char *group,
                     }
                 }
             } else {
+                utarray_foreach(data->tags, neu_resp_tag_value_meta_t *,
+                                tag_value)
+                {
+                    if (tag_value->value.type == NEU_TYPE_PTR) {
+                        free(tag_value->value.value.ptr.ptr);
+                    }
+                }
                 utarray_free(data->tags);
                 free(data->group);
                 free(data->driver);
@@ -251,6 +258,12 @@ static void update_im(neu_adapter_t *adapter, const char *group,
 
             pthread_mutex_unlock(&find->apps_mtx);
         } else {
+            utarray_foreach(data->tags, neu_resp_tag_value_meta_t *, tag_value)
+            {
+                if (tag_value->value.type == NEU_TYPE_PTR) {
+                    free(tag_value->value.value.ptr.ptr);
+                }
+            }
             utarray_free(data->tags);
             free(data->group);
             free(data->driver);
@@ -1649,6 +1662,9 @@ static void read_report_group(int64_t timestamp, int64_t timeout,
 
         if (!neu_tag_attribute_test(tag, NEU_ATTRIBUTE_STATIC) &&
             (timestamp - value.timestamp) > timeout && timeout > 0) {
+            if (value.value.type == NEU_TYPE_PTR) {
+                free(value.value.value.ptr.ptr);
+            }
             tag_value.value.type      = NEU_TYPE_ERROR;
             tag_value.value.value.i32 = NEU_ERR_PLUGIN_TAG_VALUE_EXPIRED;
         } else {
@@ -1801,6 +1817,9 @@ static void read_group(int64_t timestamp, int64_t timeout,
         if (cache_type != NEU_TAG_CACHE_TYPE_NEVER &&
             !neu_tag_attribute_test(tag, NEU_ATTRIBUTE_STATIC) &&
             (timestamp - value.timestamp) > timeout) {
+            if (value.value.type == NEU_TYPE_PTR) {
+                free(value.value.value.ptr.ptr);
+            }
             tag_value.value.type      = NEU_TYPE_ERROR;
             tag_value.value.value.i32 = NEU_ERR_PLUGIN_TAG_VALUE_EXPIRED;
         } else {
diff --git a/tests/ft/neuron/process.py b/tests/ft/neuron/process.py
index e294fa81..bd708ce7 100644
--- a/tests/ft/neuron/process.py
+++ b/tests/ft/neuron/process.py
@@ -40,6 +40,7 @@ def restart_neuron(process, dir='build/'):
 
 def stop_neuron(process):
     result = process.terminate()
+    process.wait()
     stderr = process.stderr.read().decode()
     stderr = re.sub(
         "(libfaketime|Please check specification).*\n?", "", stderr)
@@ -57,3 +58,7 @@ def start_simulator(args, dir='build/simulator'):
 def stop_simulator(process):
     assert process.poll() is None
     process.terminate()
+    process.wait()
+    stderr = process.stderr.read().decode()
+    if stderr != '':
+        print("Simulator process has errors: " + stderr)