diff --git a/ft/normal_test.robot b/ft/normal_test.robot index 961145bb..a20c7a27 100644 --- a/ft/normal_test.robot +++ b/ft/normal_test.robot @@ -9,12 +9,12 @@ Suite Teardown Stop Neuronx login with invalid username, it should return failure POST /api/v2/login {"name":"admin1", "pass": "0000"} Integer response status 401 - Integer $.error ${NEU_ERR_INVALID_USER} + Integer $.error ${NEU_ERR_INVALID_USER_OR_PASSWORD} login with invalid password, it should return failure POST /api/v2/login {"name":"admin", "pass": "2333"} Integer response status 401 - Integer $.error ${NEU_ERR_INVALID_PASSWORD} + Integer $.error ${NEU_ERR_INVALID_USER_OR_PASSWORD} login with username and password, it should return success POST /api/v2/login {"name":"admin", "pass": "0000"} diff --git a/include/neuron/errcodes.h b/include/neuron/errcodes.h index 55b731a7..4921ebe8 100644 --- a/include/neuron/errcodes.h +++ b/include/neuron/errcodes.h @@ -47,8 +47,6 @@ typedef enum { NEU_ERR_COMMAND_EXECUTION_FAILED = 1014, NEU_ERR_IP_ADDRESS_INVALID = 1015, NEU_ERR_IP_ADDRESS_IN_USE = 1016, - NEU_ERR_INVALID_USER = 1017, - NEU_ERR_INVALID_PASSWORD = 1018, NEU_ERR_NODE_EXIST = 2002, NEU_ERR_NODE_NOT_EXIST = 2003, diff --git a/plugins/restful/normal_handle.c b/plugins/restful/normal_handle.c index 1d013c1c..52fb800a 100644 --- a/plugins/restful/normal_handle.c +++ b/plugins/restful/normal_handle.c @@ -58,7 +58,7 @@ void handle_login(nng_aio *aio) if (NULL == user) { nlog_error("could not find user `%s`", req->name); - NEU_JSON_RESPONSE_ERROR(NEU_ERR_INVALID_USER, { + NEU_JSON_RESPONSE_ERROR(NEU_ERR_INVALID_USER_OR_PASSWORD, { neu_http_response(aio, error_code.error, result_error); }); } else if (pass_len < NEU_USER_PASSWORD_MIN_LEN || @@ -90,7 +90,7 @@ void handle_login(nng_aio *aio) free(result); } else { nlog_error("user `%s` password check fail", req->name); - NEU_JSON_RESPONSE_ERROR(NEU_ERR_INVALID_PASSWORD, { + NEU_JSON_RESPONSE_ERROR(NEU_ERR_INVALID_USER_OR_PASSWORD, { neu_http_response(aio, error_code.error, result_error); }); } @@ -114,10 +114,10 @@ void handle_password(nng_aio *aio) rv = NEU_ERR_INVALID_PASSWORD_LEN; } else if (NULL == (user = neu_load_user(req->name))) { nlog_error("could not find user `%s`", req->name); - rv = NEU_ERR_INVALID_USER; + rv = NEU_ERR_INVALID_USER_OR_PASSWORD; } else if (!neu_user_check_password(user, req->old_pass)) { nlog_error("user `%s` password check fail", req->name); - rv = NEU_ERR_INVALID_PASSWORD; + rv = NEU_ERR_INVALID_USER_OR_PASSWORD; } else if (0 != (rv = neu_user_update_password(user, req->new_pass))) { nlog_error("user `%s` update password fail", req->name);