From d837ca94bf49ffebc7f5b98b150daa1154ee65ba Mon Sep 17 00:00:00 2001
From: eeff <eeff at eeff dot dev>
Date: Tue, 14 Dec 2021 17:33:15 +0800
Subject: [PATCH] Fix use-after-free in mqtt api GET_SUBSCRIBE_GROUP_CONFIG

---
 plugins/mqtt/command/group_config.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/plugins/mqtt/command/group_config.c b/plugins/mqtt/command/group_config.c
index 8407e9ef..d5f62b5c 100644
--- a/plugins/mqtt/command/group_config.c
+++ b/plugins/mqtt/command/group_config.c
@@ -215,11 +215,13 @@ char *command_get_group_config_subscribes(neu_plugin_t *   plugin,
     }
 
     vector_free(configs);
-    free(sub_grp_configs.groups);
 
     char *result = NULL;
     neu_json_encode_with_mqtt(&sub_grp_configs,
                               neu_json_encode_get_subscribe_resp, mqtt,
                               neu_json_encode_mqtt_resp, &result);
+
+    free(sub_grp_configs.groups);
+
     return result;
 }