From 5fdb4ccfc9d8bbdb9ec8bd0107dfd4fc71f8894d Mon Sep 17 00:00:00 2001 From: avwo Date: Wed, 9 Oct 2019 23:59:06 +0800 Subject: [PATCH] refactor: handle request errors --- lib/https/h2.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/https/h2.js b/lib/https/h2.js index b9fc50354..9809ba345 100644 --- a/lib/https/h2.js +++ b/lib/https/h2.js @@ -27,7 +27,7 @@ function getSocket(options, callback) { NPNProtocols: SUPPORTED_PROTOS }, function(err, socket) { if (err) { - return callback(); + return callback(false, null, err); } var proto = socket.alpnProtocol || socket.npnProtocol; callback(proto === 'h2', socket); @@ -124,7 +124,7 @@ exports.request = function(req, res, callback) { pendingList[name] = [[req, res, callback]]; } } - getSocket(client ? null : options, function(isH2, socket) { + getSocket(client ? null : options, function(isH2, socket, err) { client = client || (isH2 && getClient(req, socket, name)); var pendingItem = pendingList[name]; delete pendingList[name]; @@ -138,7 +138,7 @@ exports.request = function(req, res, callback) { requestH2(client, req, res); } } else { - notH2.set(name, 1); + !err && notH2.set(name, 1); if (pendingItem) { pendingItem.forEach(function(list) { list[2](socket);