GithubStar/MMKV
1
0
Fork 0
mirror of https://github.com/Tencent/MMKV.git synced 2026-10-21 14:51:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove buffer to decrease copy when encode NSString

Browse Source
This commit is contained in:
zhongwuzw
2018-09-28 17:19:17 +08:00
parent b01341bef5
commit fdcb00a96c
1 changed files with 2 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
iOS/MMKV/MMKV/MiniPBCoder.mm
+2 -21
View File
@@ -38,9 +38,6 @@
NSMutableData *m_outputBuffer;
MiniCodedOutputData *m_outputData;
std::vector<MiniPBEncodeItem> *m_encodeItems;
void *m_formatBuffer;
size_t m_formatBufferSize;
}
- (id)initForReadingWithData:(NSData *)data {
@@ -76,12 +73,6 @@
delete m_outputData;
m_outputData = nullptr;
}
if (m_formatBuffer) {
free(m_formatBuffer);
m_formatBuffer = nullptr;
m_formatBufferSize = 0;
}
}
#pragma mark - encode
@@ -134,18 +125,8 @@
if ([obj isKindOfClass:[NSString class]]) {
NSString *str = (NSString *) obj;
encodeItem->type = PBEncodeItemType_NSString;
size_t maxSize = MAX(1, [str maximumLengthOfBytesUsingEncoding:NSUTF8StringEncoding]);
if (m_formatBufferSize < maxSize) {
m_formatBufferSize = maxSize;
if (m_formatBuffer) {
free(m_formatBuffer);
}
m_formatBuffer = malloc(m_formatBufferSize);
}
NSUInteger realSize = 0;
[str getBytes:m_formatBuffer maxLength:maxSize usedLength:&realSize encoding:NSUTF8StringEncoding options:0 range:NSMakeRange(0, str.length) remainingRange:nullptr];
NSData *buffer = [NSData dataWithBytes:m_formatBuffer length:realSize];
encodeItem->value.tmpObjectValue = (void *) CFBridgingRetain(buffer);
NSData *buffer = [str dataUsingEncoding:NSUTF8StringEncoding];
encodeItem->value.tmpObjectValue = (__bridge_retained void *) buffer;
encodeItem->valueSize = static_cast<int32_t>(buffer.length);
} else if ([obj isKindOfClass:[NSDate class]]) {
NSDate *oDate = (NSDate *) obj;