GithubStar/UA-.NETStandard
1
0
Fork 0
mirror of https://github.com/OPCFoundation/UA-.NETStandard.git synced 2026-10-26 04:19:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Server] Fix Sampling Group creating a new long running task for every Client AddMonitoredItems Method Call (#2984)

Browse Source 
* fix Sampling Group creating a new long running task for every Client Add MonitoredItems Method Call

* reset also on shutdown

* dispose shutdown event
This commit is contained in:
romanett
2025-02-11 14:23:56 +02:00
committed by GitHub
parent 7cbeee7155
commit 1baf420168
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Libraries/Opc.Ua.Server/NodeManager/SamplingGroup.cs
+6 -2
View File
@@ -106,7 +106,7 @@ namespace Opc.Ua.Server
{
m_shutdownEvent.Reset();
Task.Factory.StartNew(() => {
m_samplingTask = Task.Factory.StartNew(() => {
SampleMonitoredItems(m_samplingInterval);
}, TaskCreationOptions.LongRunning | TaskCreationOptions.DenyChildAttach);
}
@@ -121,6 +121,9 @@ namespace Opc.Ua.Server
{
m_shutdownEvent.Set();
m_items.Clear();
Utils.SilentDispose(m_samplingTask);
m_samplingTask = null;
Utils.SilentDispose(m_shutdownEvent);
}
}
@@ -243,7 +246,7 @@ namespace Opc.Ua.Server
m_itemsToRemove.Clear();
// start the group if it is not running.
if (m_items.Count > 0)
if (m_samplingTask == null && m_items.Count > 0)
{
Startup();
}
@@ -487,6 +490,7 @@ namespace Opc.Ua.Server
private Dictionary<uint, ISampledDataChangeMonitoredItem> m_items;
private ManualResetEvent m_shutdownEvent;
private List<SamplingRateGroup> m_samplingRates;
private Task m_samplingTask;
#endregion
}
}