GithubStar/UA-.NETStandard
1
0
Fork 0
mirror of https://github.com/OPCFoundation/UA-.NETStandard.git synced 2026-10-28 22:55:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Client tests: bound ManagedSession connect retries in failing-factory tests

Browse Source 
Four ManagedSession tests used MaxRetries = 0, which means unlimited, so
the initial connect retried every 1-5 ms until the 5-10 s budget ran out.
The mocked factory rethrew one exception instance, whose stack trace grows
by a frame per throw, so the log grew quadratically (~124k stack lines in
30 s) and the Linux runner lost communication mid-flood.

Use MaxRetries = 1 and create a fresh exception per attempt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Roman Ettlinger
2026-10-27 10:30:02 +01:00
co-authored by Claude Opus 5.5
parent d3506f2b75
commit 48565dbae0
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Opc.Ua.Client.Tests/Session/ManagedSessionTests.cs
+10 -5
View File
@@ -1288,7 +1288,8 @@ namespace Opc.Ua.Client.Tests.ManagedSession
.Callback<ApplicationConfiguration, ConfiguredEndpoint, bool, bool, string, uint,
IUserIdentity?, ArrayOf<string>, CancellationToken>(
(_, _, _, _, _, _, identity, _, _) => observed = identity)
.ThrowsAsync(new ServiceResultException(StatusCodes.BadCertificateUntrusted));
.Returns(() => Task.FromException<ISession>(
new ServiceResultException(StatusCodes.BadCertificateUntrusted)));
var provider = new Mock<IClientIdentityProvider>();
@@ -1339,7 +1340,8 @@ namespace Opc.Ua.Client.Tests.ManagedSession
.Callback<ApplicationConfiguration, ConfiguredEndpoint, bool, bool, string, uint,
IUserIdentity?, ArrayOf<string>, CancellationToken>(
(_, _, _, _, _, _, identity, _, _) => observed = identity)
.ThrowsAsync(new ServiceResultException(StatusCodes.BadCertificateUntrusted));
.Returns(() => Task.FromException<ISession>(
new ServiceResultException(StatusCodes.BadCertificateUntrusted)));
var provider = new Mock<IClientIdentityProvider>(MockBehavior.Strict);
@@ -1365,11 +1367,13 @@ namespace Opc.Ua.Client.Tests.ManagedSession
private static ReconnectPolicy NoRetryPolicy()
{
// MaxRetries = 0 means unlimited: the connect would retry every
// millisecond until MaxTotalReconnectTime and flood the log.
return new ReconnectPolicy
{
Strategy = BackoffStrategy.Constant,
InitialDelay = TimeSpan.FromMilliseconds(1),
MaxRetries = 0,
MaxRetries = 1,
JitterFactor = 0.0,
MaxTotalReconnectTime = TimeSpan.FromSeconds(5)
};
@@ -1483,13 +1487,14 @@ namespace Opc.Ua.Client.Tests.ManagedSession
It.IsAny<IUserIdentity?>(),
It.IsAny<ArrayOf<string>>(),
It.IsAny<CancellationToken>()))
.ThrowsAsync(new ServiceResultException(StatusCodes.BadCertificateUntrusted));
.Returns(() => Task.FromException<ISession>(
new ServiceResultException(StatusCodes.BadCertificateUntrusted)));
var reconnectPolicy = new ReconnectPolicy
{
Strategy = BackoffStrategy.Constant,
InitialDelay = TimeSpan.FromMilliseconds(5),
MaxRetries = 0,
MaxRetries = 1,
JitterFactor = 0.0,
MaxTotalReconnectTime = TimeSpan.FromSeconds(10)
};