Commit Graph
1171 Commits
Author SHA1 Message Date
dependabot[bot] c4988f5dc2 Bump coverlet.msbuild from 2.9.0 to 3.0.1 (#1248)
Bumps [coverlet.msbuild](https://github.com/coverlet-coverage/coverlet) from 2.9.0 to 3.0.1.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](https://github.com/coverlet-coverage/coverlet/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-18 22:13:12 +01:00
dependabot[bot] e7e5834ca4 Bump NUnit.Console from 3.11.1 to 3.12.0 (#1250)
Bumps [NUnit.Console](https://github.com/nunit/nunit-console) from 3.11.1 to 3.12.0.
- [Release notes](https://github.com/nunit/nunit-console/releases)
- [Changelog](https://github.com/nunit/nunit-console/blob/master/CHANGES.txt)
- [Commits](https://github.com/nunit/nunit-console/compare/v3.11.1...v3.12)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-18 19:13:45 +01:00
dependabot[bot] 532ef934b9 Bump Moq from 4.10.1 to 4.16.0 (#1249)
Bumps [Moq](https://github.com/moq/moq4) from 4.10.1 to 4.16.0.
2021-01-18 16:46:18 +02:00
Alin Moldovean 97c22fdd25 Method calls validation for Executable and UserExecutable. Fixes #1190 (#1246) 2021-01-18 10:32:14 +02:00
dependabot[bot] a7b7aea2f8 Bump NUnit from 3.12.0 to 3.13.0 (#1231)
Bumps [NUnit](https://github.com/nunit/nunit) from 3.12.0 to 3.13.0.
- [Release notes](https://github.com/nunit/nunit/releases)
- [Changelog](https://github.com/nunit/nunit/blob/master/CHANGES.md)
- [Commits](https://github.com/nunit/nunit/compare/v3.12...v3.13)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-15 07:45:11 +01:00
Сергей 1102853812 Use monotonic timer for HiResClock and fix loss of monitored items when system time is changed (#1124)
Thanks @MyLastAngel for your contribution!

- Solves an issue when MonitoredItems are lost, when system time is changed.
- Use HiResClock.TickCount64  when update nextSamplingTime.
- Update HiResClock class with method of TickCount64 for use as monotonic timer
2021-01-15 07:44:32 +01:00
Alin Moldovean 2599a3edc2 Fix NuGet build (#1242) 2021-01-15 07:38:21 +01:00
Alin Moldovean 333aadc6f3 Compliance fixes in ReferenceServer (#1241)
Compliance fixes for certificate validation.
Add config flag in ReferenceServer to specify whether  Certificate dialog should be displayed.
2021-01-14 13:52:51 +02:00
Alin Moldovean 6a95638d15 Disable PubSub tests from build. (#1235)
* Disable PubSub tests from build.
* rename PubSub test project to .disabled
2021-01-12 16:13:36 +01:00
Alin Moldovean 16ff6511f2 PubSub Support for UADP (#1195)
* Add PubSub library and console samples. #1169
2021-01-08 17:48:09 +02:00
Martin Regen bfa117b7a7 Implement an AcceptAll flag in the cert validator callback (#1230)
- The AcceptAll flag can be used to accept all suppressible errors in one call back
- Behaviour unchanged when only Accept is set, callback is invoked for all errors and all must be approved
2021-01-07 10:16:07 +01:00
Martin Regen 4752a808df Validate server domains in Cert validator (#1226)
- Based on new handling of multiple suppressible errors, add also the domain check to the list
- Move domain check in validator and use cert validation callback to handle BadCertificateInvalidHostname.
- Allow to handle all suppressible errors including the domain check by the cert validator callback, approve all errors by new AcceptAll flag. Applications which only set Approve are called for each of the suppressible errors and must approve eah of them.
- Add approval of multiple errors to sample UI
- fix a few warnings
2021-01-07 09:26:14 +01:00
Martin Regen 2c1532edcb Tests for ECDsa certs (#1225)
* finalizing some work on API surface for ECDsa certs
* yet only nist/brainpool certs are supported specifically for OPC UA ECC errata 
* split tests for ECDsa and RSA certs
* skip brainpool tests on macos, no OS support on macos 10.15
2021-01-04 16:16:42 +01:00
Martin Regen ac8e358c2c Escape special characters in JSON fieldnames (#1224)
- Values were properly escaped, field names not.
- Fix fieldname encoding in various places
- Tests to verify strings are escaped in all codepaths.
- Fixes #1210
2021-01-04 14:49:17 +01:00
dependabot[bot]andMartin Regen 521d182d63 Bump Portable.BouncyCastle from 1.8.8 to 1.8.9 (#1222)
* Bump Portable.BouncyCastle from 1.8.8 to 1.8.9

Bumps [Portable.BouncyCastle](https://github.com/novotnyllc/bc-csharp) from 1.8.8 to 1.8.9.
- [Release notes](https://github.com/novotnyllc/bc-csharp/releases)
- [Commits](https://github.com/novotnyllc/bc-csharp/compare/pcl-v1.8.8...pcl-v1.8.9)

Signed-off-by: dependabot[bot] <support@github.com>

* Update Opc.Ua.Core.Tests.csproj

remove unnecessary dependency

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Martin Regen <mregen@microsoft.com>
2020-12-23 19:02:03 +01:00
Martin Regen 8c216e78f4 Replace CRLF in debug strings with AppendLine and improve cert validator tests (#1220)
- improve cross platform support, replace CRLF by AppendLine 
- replace $format trace messages with {} style
- fix warnings for comments and protected fields, null parameter checks
- replace cert factory calls with new API (obsolete warnings)
- allow to run cert validator tests in parallel using new temp cert validator class
- more test cases for cert validator, e.g wth cert validation callback
- improve cert validator for special cases
2020-12-23 00:17:09 +01:00
ThomasNehring d815cfb972 Improve handling of certificate validation (#1217)
The change ensures that all certificate validation failures (except those related to the hostname of a server) are stacked in the right order into a service result, which -- if not empty -- in the end is raised in a service result exception.
The single point where knowledge about suppressible changes is needed is the place in Validate, where that exception is caught.
2020-12-18 15:29:17 +01:00
dependabot[bot] 52754f4814 Bump System.ServiceModel.Primitives from 4.5.3 to 4.8.0 (#1182)
Bumps [System.ServiceModel.Primitives](https://github.com/dotnet/wcf) from 4.5.3 to 4.8.0.
- [Release notes](https://github.com/dotnet/wcf/releases)
- [Commits](https://github.com/dotnet/wcf/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-16 20:41:04 +01:00
Martin Regen f904139298 Refactor CertificateFactory, remove bouncy castle dependency in Opc.Ua.Core for .NET Core 3.1 (#1209)
- remove use of Bouncy Castle for .NET Core 3
- refactor CreateCertificate class to allow for an easier Create fluent model with respect to future extensions, e.g. ECC
- reimplement X509CRL and a couple of extension relevant for OPC UA based on the new System.Formats.Asn1 library
- use CertificateRequest on .NET Core 3.1
- refactor codebase to allow for a seperate library to handle all the ASN.1 encoding/decoding
- new package Opc.Ua.Security.Certificates with all ASN.1 encode/decode related code
breaking change: many  X509 related util functions were moved to X509Utils class
Note: .NET 4.6.2 and .NET Core 2.1 versions still use BouncyCastle for Cert creation
2020-12-13 18:17:54 +01:00
Alin Moldovean e53d97d9ae Set ParentNodeId of nodes at import from NodeSet2 files. (#1212) 2020-12-10 16:11:54 +02:00
Erich Barnstedt c171b14c7e Fix spelling in cert validation service results. (#1211) 2020-12-09 16:49:21 +01:00
dependabot[bot] 264cb2f08d Bump Microsoft.NET.Test.Sdk from 16.8.0 to 16.8.3 (#1203)
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.0 to 16.8.3.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.8.0...v16.8.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-04 12:52:33 +01:00
Alin Moldovean 31d1dff73c Merge pull request #1194 from AlinMoldovean/master
Fix for validation of endpoints from GetEndpoints and  CreateSession responses.
2020-12-02 10:53:55 +02:00
Alin Moldovean 7f19479b5a Closes #1145 - Fix for validation of endpoints from GetEndpoints and CreateSession responses. 2020-11-25 16:46:59 +02:00
Logan Komanetz 34d0af8dd6 Removes assigning a new instance of CertificateValidator in ApplicationConfiguration (#1161)
* Removes assigning a new instance of CertificateValidator in ApplicationConfiguration.Validate method by assigning it on construction.  
* Refactors the code to use 'using' statements for streams and LINQ expressions.
* Makes the CertificateValidator member readonly
* Removes read-only status of CertificateValidator and adds unit test to ensure it is assignable from outside the class.
2020-11-14 11:15:01 +01:00
dependabot[bot] e1e4f607e7 Bump Microsoft.NET.Test.Sdk from 16.7.1 to 16.8.0 (#1179)
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.7.1 to 16.8.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.7.1...v16.8.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-14 11:10:56 +01:00
Martin Regen ebe7e26a75 Allow to suppress zero nonce error (#1184)
- in addition to duplicate nonce this change allows to suppress zero nonce
2020-11-14 11:10:10 +01:00
Martin Regen 346c4e30c5 Fix codecov upload and Nuget builds (#1175)
- codecov couldn't resolve the source files when deterministic builds are enabled. Run codecoverage with det build option disabled.
- nuget preview build was broken, added ci build for packing libraries.
- add console client to ci build
- fixes #1173, fix dockerfile to use .NET Core 3.1 base image
2020-11-04 09:12:28 +01:00
Martin Regen d7f056ebde Fix codecoverage for coverlet with deterministic builds (#1171)
- with deterministic builds, coverlet needs a workaround
- apply workaround only added with cloud and codecoverage builds as described here:
https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/DeterministicBuild.md
2020-11-01 13:19:22 +01:00
Alin Moldovean 4be8c87903 Suppress server nonce validation errors in Client Session for encrypted channels (#1165)
* Implement the mitigation against weak nonce for CVE2019-19135.
* Suppress server nonce validation errors for user tokens in Client Session for encrypted channels.
* This change allows client interoperability with some legacy servers that do not comply with the specification for nonce usage of user token encryption. 
* The workaround for servers which can not connect due to a weak nonce is to use an encrypted channel, then the token is protected and the threat is mitigated.
2020-10-23 10:01:12 +02:00
Martin Regen f4891e626f Nuget build fix, part 2 (#1164)
* comment the SIGNASSEMBLY tags, InternalsVisibleTo can only be enabled when the test libraries become available
2020-10-21 12:11:18 +02:00
Shailesh Rasane 03eed2d9a5 Added tests for the Sessionlessmessage #1155 (#1159)
fixes #1155
2020-10-21 10:13:25 +02:00
Martin Regen d1b0e2f1df Add signassembly definition to fix nuget build (#1163) 2020-10-21 10:10:59 +02:00
Martin Regen 62eedc19be Reduce core dependencies, move https binding to optional assembly. (#1157)
* implement transport binding factory
* split https transport into seperate nuget package
* new Opc.Ua.Binding.Https assembly
* Https binding is loaded on demand, if available
* reduce core dependencies to kestrel and others
fixes #600
2020-10-21 00:03:37 +02:00
Alexander Köpke 3514e4d5fe Merge pull request #1154 from OPCFoundation/koepalex/write-encodeable
Avoid invalid Json while encode IEncodeables
2020-10-20 12:20:04 +02:00
Alexander Koepke 1c2d79d1fb fixed new LGTM issues - part 2 2020-10-20 11:48:12 +02:00
Alexander Koepke c3a4bc4500 fixed new LGTM issues 2020-10-20 11:12:50 +02:00
Martin Regen 488bc14caf improve JSON encoder 2020-10-20 10:25:09 +02:00
Martin Regen e1930fb4cd more tests 2020-10-17 12:27:57 +02:00
Alexander Koepke b27751ace8 Merge branch 'master' into koepalex/write-encodeable 2020-10-16 17:14:21 +02:00
Alexander Koepke f3d090aec4 Avoid invalid Json by using JsonEncoder for IEncodeables 2020-10-16 17:01:39 +02:00
Martin Regen bb3e456ef9 Add issue report template (#1151) 2020-10-15 19:17:14 +02:00
Martin Regen d0f5d9e51a Fix confusing async use of Utils.GetHostAddresses (#1148)
- due to the name change of the async version its a breaking change for the 364 release
- fixes #1132
2020-10-14 16:58:18 +02:00
Martin Regen 7f3f0dbbb4 Service update, fix many warnings for Xml comments (#1146)
- no bug fixes, just documentation and formatting
- fix all warnings for xml in core libraries, except
-- protected members
-- suppressed warnings in Opc.Ua.Gds libraries (tbd)
2020-10-14 12:00:01 +02:00
Martin Regen 52bee9f568 Fix the Nuget build debug assemblies signing step (#1147) 2020-10-14 11:58:15 +02:00
Martin Regen 9b8cf2eaf2 Push nuget as artifacts for release (#1143)
* upload pipelineartifacts for release pipeline and sign the symbol packages
* enable deterministic builds for snupkg source debugging
* allow release builds to be in release/x.y.z
* do not rename assemblies for debug builds, to allow for mixing of release and debug packages. Otherwise build issues may occure when packages are mixed.
2020-10-12 15:48:57 +02:00
dependabot[bot] 7fe666e9bb Bump Portable.BouncyCastle from 1.8.6.7 to 1.8.8 (#1131)
Bumps [Portable.BouncyCastle](https://github.com/novotnyllc/bc-csharp) from 1.8.6.7 to 1.8.8.
- [Release notes](https://github.com/novotnyllc/bc-csharp/releases)
- [Commits](https://github.com/novotnyllc/bc-csharp/compare/pcl-v1.8.6.7...pcl-v1.8.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-10-09 09:36:43 +02:00
Alin Moldovean c2c2801d3e Merge pull request #1138 from AlinMoldovean/master
Increase Nuget version
2020-10-08 12:20:31 +03:00
AlinMoldovean dd12288482 Increase Nuget version 2020-10-08 11:15:33 +03:00
Alin Moldovean eff62d573e Merge pull request #1135 from AlinMoldovean/master
Update NodeSet files and generated code for 1.04.7 Errata
2020-10-08 09:43:43 +03:00